From: Michael Ellerman <mpe@ellerman.id.au>
To: Andrew Murray <andrew.murray@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, linux-alpha@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
"paulus\@samba.org" <paulus@samba.org>
Subject: Re: [PATCH 10/10] perf/doc: update design.txt for exclude_{host|guest} flags
Date: Tue, 11 Dec 2018 22:06:53 +1100 [thread overview]
Message-ID: <87bm5sxqya.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20181120133202.GH35798@e119886-lin.cambridge.arm.com>
[ Reviving old thread. ]
Andrew Murray <andrew.murray@arm.com> writes:
> On Tue, Nov 20, 2018 at 10:31:36PM +1100, Michael Ellerman wrote:
>> Andrew Murray <andrew.murray@arm.com> writes:
>>
>> > Update design.txt to reflect the presence of the exclude_host
>> > and exclude_guest perf flags.
>> >
>> > Signed-off-by: Andrew Murray <andrew.murray@arm.com>
>> > ---
>> > tools/perf/design.txt | 4 ++++
>> > 1 file changed, 4 insertions(+)
>> >
>> > diff --git a/tools/perf/design.txt b/tools/perf/design.txt
>> > index a28dca2..7de7d83 100644
>> > --- a/tools/perf/design.txt
>> > +++ b/tools/perf/design.txt
>> > @@ -222,6 +222,10 @@ The 'exclude_user', 'exclude_kernel' and 'exclude_hv' bits provide a
>> > way to request that counting of events be restricted to times when the
>> > CPU is in user, kernel and/or hypervisor mode.
>> >
>> > +Furthermore the 'exclude_host' and 'exclude_guest' bits provide a way
>> > +to request counting of events restricted to guest and host contexts when
>> > +using virtualisation.
>>
>> How does exclude_host differ from exclude_hv ?
>
> I believe exclude_host / exclude_guest are intented to distinguish
> between host and guest in the hosted hypervisor context (KVM).
OK yeah, from the perf-list man page:
u - user-space counting
k - kernel counting
h - hypervisor counting
I - non idle counting
G - guest counting (in KVM guests)
H - host counting (not in KVM guests)
> Whereas exclude_hv allows to distinguish between guest and
> hypervisor in the bare-metal type hypervisors.
Except that's exactly not how we use them on powerpc :)
We use exclude_hv to exclude "the hypervisor", regardless of whether
it's KVM or PowerVM (which is a bare-metal hypervisor).
We don't use exclude_host / exclude_guest at all, which I guess is a
bug, except I didn't know they existed until this thread.
eg, in a KVM guest:
$ perf record -e cycles:G /bin/bash -c "for i in {0..100000}; do :;done"
$ perf report -D | grep -Fc "dso: [hypervisor]"
16
> In the case of arm64 - if VHE extensions are present then the host
> kernel will run at a higher privilege to the guest kernel, in which
> case there is no distinction between hypervisor and host so we ignore
> exclude_hv. But where VHE extensions are not present then the host
> kernel runs at the same privilege level as the guest and we use a
> higher privilege level to switch between them - in this case we can
> use exclude_hv to discount that hypervisor role of switching between
> guests.
I couldn't find any arm64 perf code using exclude_host/guest at all?
And I don't see any x86 code using exclude_hv.
But maybe that's OK, I just worry this is confusing for users.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Andrew Murray <andrew.murray@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
x86@kernel.org, Will Deacon <will.deacon@arm.com>,
linuxppc-dev@lists.ozlabs.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
linux-alpha@vger.kernel.org,
"paulus@samba.org" <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 10/10] perf/doc: update design.txt for exclude_{host|guest} flags
Date: Tue, 11 Dec 2018 22:06:53 +1100 [thread overview]
Message-ID: <87bm5sxqya.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20181120133202.GH35798@e119886-lin.cambridge.arm.com>
[ Reviving old thread. ]
Andrew Murray <andrew.murray@arm.com> writes:
> On Tue, Nov 20, 2018 at 10:31:36PM +1100, Michael Ellerman wrote:
>> Andrew Murray <andrew.murray@arm.com> writes:
>>
>> > Update design.txt to reflect the presence of the exclude_host
>> > and exclude_guest perf flags.
>> >
>> > Signed-off-by: Andrew Murray <andrew.murray@arm.com>
>> > ---
>> > tools/perf/design.txt | 4 ++++
>> > 1 file changed, 4 insertions(+)
>> >
>> > diff --git a/tools/perf/design.txt b/tools/perf/design.txt
>> > index a28dca2..7de7d83 100644
>> > --- a/tools/perf/design.txt
>> > +++ b/tools/perf/design.txt
>> > @@ -222,6 +222,10 @@ The 'exclude_user', 'exclude_kernel' and 'exclude_hv' bits provide a
>> > way to request that counting of events be restricted to times when the
>> > CPU is in user, kernel and/or hypervisor mode.
>> >
>> > +Furthermore the 'exclude_host' and 'exclude_guest' bits provide a way
>> > +to request counting of events restricted to guest and host contexts when
>> > +using virtualisation.
>>
>> How does exclude_host differ from exclude_hv ?
>
> I believe exclude_host / exclude_guest are intented to distinguish
> between host and guest in the hosted hypervisor context (KVM).
OK yeah, from the perf-list man page:
u - user-space counting
k - kernel counting
h - hypervisor counting
I - non idle counting
G - guest counting (in KVM guests)
H - host counting (not in KVM guests)
> Whereas exclude_hv allows to distinguish between guest and
> hypervisor in the bare-metal type hypervisors.
Except that's exactly not how we use them on powerpc :)
We use exclude_hv to exclude "the hypervisor", regardless of whether
it's KVM or PowerVM (which is a bare-metal hypervisor).
We don't use exclude_host / exclude_guest at all, which I guess is a
bug, except I didn't know they existed until this thread.
eg, in a KVM guest:
$ perf record -e cycles:G /bin/bash -c "for i in {0..100000}; do :;done"
$ perf report -D | grep -Fc "dso: [hypervisor]"
16
> In the case of arm64 - if VHE extensions are present then the host
> kernel will run at a higher privilege to the guest kernel, in which
> case there is no distinction between hypervisor and host so we ignore
> exclude_hv. But where VHE extensions are not present then the host
> kernel runs at the same privilege level as the guest and we use a
> higher privilege level to switch between them - in this case we can
> use exclude_hv to discount that hypervisor role of switching between
> guests.
I couldn't find any arm64 perf code using exclude_host/guest at all?
And I don't see any x86 code using exclude_hv.
But maybe that's OK, I just worry this is confusing for users.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Andrew Murray <andrew.murray@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
x86@kernel.org, Will Deacon <will.deacon@arm.com>,
linuxppc-dev@lists.ozlabs.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
linux-alpha@vger.kernel.org,
"paulus@samba.org" <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 10/10] perf/doc: update design.txt for exclude_{host|guest} flags
Date: Tue, 11 Dec 2018 22:06:53 +1100 [thread overview]
Message-ID: <87bm5sxqya.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20181120133202.GH35798@e119886-lin.cambridge.arm.com>
[ Reviving old thread. ]
Andrew Murray <andrew.murray@arm.com> writes:
> On Tue, Nov 20, 2018 at 10:31:36PM +1100, Michael Ellerman wrote:
>> Andrew Murray <andrew.murray@arm.com> writes:
>>
>> > Update design.txt to reflect the presence of the exclude_host
>> > and exclude_guest perf flags.
>> >
>> > Signed-off-by: Andrew Murray <andrew.murray@arm.com>
>> > ---
>> > tools/perf/design.txt | 4 ++++
>> > 1 file changed, 4 insertions(+)
>> >
>> > diff --git a/tools/perf/design.txt b/tools/perf/design.txt
>> > index a28dca2..7de7d83 100644
>> > --- a/tools/perf/design.txt
>> > +++ b/tools/perf/design.txt
>> > @@ -222,6 +222,10 @@ The 'exclude_user', 'exclude_kernel' and 'exclude_hv' bits provide a
>> > way to request that counting of events be restricted to times when the
>> > CPU is in user, kernel and/or hypervisor mode.
>> >
>> > +Furthermore the 'exclude_host' and 'exclude_guest' bits provide a way
>> > +to request counting of events restricted to guest and host contexts when
>> > +using virtualisation.
>>
>> How does exclude_host differ from exclude_hv ?
>
> I believe exclude_host / exclude_guest are intented to distinguish
> between host and guest in the hosted hypervisor context (KVM).
OK yeah, from the perf-list man page:
u - user-space counting
k - kernel counting
h - hypervisor counting
I - non idle counting
G - guest counting (in KVM guests)
H - host counting (not in KVM guests)
> Whereas exclude_hv allows to distinguish between guest and
> hypervisor in the bare-metal type hypervisors.
Except that's exactly not how we use them on powerpc :)
We use exclude_hv to exclude "the hypervisor", regardless of whether
it's KVM or PowerVM (which is a bare-metal hypervisor).
We don't use exclude_host / exclude_guest at all, which I guess is a
bug, except I didn't know they existed until this thread.
eg, in a KVM guest:
$ perf record -e cycles:G /bin/bash -c "for i in {0..100000}; do :;done"
$ perf report -D | grep -Fc "dso: [hypervisor]"
16
> In the case of arm64 - if VHE extensions are present then the host
> kernel will run at a higher privilege to the guest kernel, in which
> case there is no distinction between hypervisor and host so we ignore
> exclude_hv. But where VHE extensions are not present then the host
> kernel runs at the same privilege level as the guest and we use a
> higher privilege level to switch between them - in this case we can
> use exclude_hv to discount that hypervisor role of switching between
> guests.
I couldn't find any arm64 perf code using exclude_host/guest at all?
And I don't see any x86 code using exclude_hv.
But maybe that's OK, I just worry this is confusing for users.
cheers
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Andrew Murray <andrew.murray@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, linux-alpha@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
"paulus@samba.org" <paulus@samba.org>
Subject: Re: [PATCH 10/10] perf/doc: update design.txt for exclude_{host|guest} flags
Date: Tue, 11 Dec 2018 22:06:53 +1100 [thread overview]
Message-ID: <87bm5sxqya.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20181120133202.GH35798@e119886-lin.cambridge.arm.com>
[ Reviving old thread. ]
Andrew Murray <andrew.murray@arm.com> writes:
> On Tue, Nov 20, 2018 at 10:31:36PM +1100, Michael Ellerman wrote:
>> Andrew Murray <andrew.murray@arm.com> writes:
>>
>> > Update design.txt to reflect the presence of the exclude_host
>> > and exclude_guest perf flags.
>> >
>> > Signed-off-by: Andrew Murray <andrew.murray@arm.com>
>> > ---
>> > tools/perf/design.txt | 4 ++++
>> > 1 file changed, 4 insertions(+)
>> >
>> > diff --git a/tools/perf/design.txt b/tools/perf/design.txt
>> > index a28dca2..7de7d83 100644
>> > --- a/tools/perf/design.txt
>> > +++ b/tools/perf/design.txt
>> > @@ -222,6 +222,10 @@ The 'exclude_user', 'exclude_kernel' and 'exclude_hv' bits provide a
>> > way to request that counting of events be restricted to times when the
>> > CPU is in user, kernel and/or hypervisor mode.
>> >
>> > +Furthermore the 'exclude_host' and 'exclude_guest' bits provide a way
>> > +to request counting of events restricted to guest and host contexts when
>> > +using virtualisation.
>>
>> How does exclude_host differ from exclude_hv ?
>
> I believe exclude_host / exclude_guest are intented to distinguish
> between host and guest in the hosted hypervisor context (KVM).
OK yeah, from the perf-list man page:
u - user-space counting
k - kernel counting
h - hypervisor counting
I - non idle counting
G - guest counting (in KVM guests)
H - host counting (not in KVM guests)
> Whereas exclude_hv allows to distinguish between guest and
> hypervisor in the bare-metal type hypervisors.
Except that's exactly not how we use them on powerpc :)
We use exclude_hv to exclude "the hypervisor", regardless of whether
it's KVM or PowerVM (which is a bare-metal hypervisor).
We don't use exclude_host / exclude_guest at all, which I guess is a
bug, except I didn't know they existed until this thread.
eg, in a KVM guest:
$ perf record -e cycles:G /bin/bash -c "for i in {0..100000}; do :;done"
$ perf report -D | grep -Fc "dso: [hypervisor]"
16
> In the case of arm64 - if VHE extensions are present then the host
> kernel will run at a higher privilege to the guest kernel, in which
> case there is no distinction between hypervisor and host so we ignore
> exclude_hv. But where VHE extensions are not present then the host
> kernel runs at the same privilege level as the guest and we use a
> higher privilege level to switch between them - in this case we can
> use exclude_hv to discount that hypervisor role of switching between
> guests.
I couldn't find any arm64 perf code using exclude_host/guest at all?
And I don't see any x86 code using exclude_hv.
But maybe that's OK, I just worry this is confusing for users.
cheers
next prev parent reply other threads:[~2018-12-11 11:06 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 10:24 [PATCH 00/10] perf/core: Generalise event exclusion checking Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 01/10] perf/core: Add macro to test for event exclusion flags Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-19 12:58 ` Peter Zijlstra
2018-11-19 12:58 ` Peter Zijlstra
2018-11-19 12:58 ` Peter Zijlstra
2018-11-19 12:58 ` Peter Zijlstra
2018-11-19 16:01 ` Mark Rutland
2018-11-19 16:01 ` Mark Rutland
2018-11-19 16:01 ` Mark Rutland
2018-11-20 11:28 ` Michael Ellerman
2018-11-20 11:28 ` Michael Ellerman
2018-11-20 11:28 ` Michael Ellerman
2018-11-23 14:32 ` Andrew Murray
2018-11-23 14:32 ` Andrew Murray
2018-11-23 14:32 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 02/10] arm: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 03/10] arm: perf: add additional validation to set_event_filter Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 04/10] powerpc: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-20 11:21 ` Michael Ellerman
2018-11-20 11:21 ` Michael Ellerman
2018-11-20 11:21 ` Michael Ellerman
2018-11-16 10:24 ` [PATCH 05/10] powerpc/pmu/fsl: add additional validation to event_init Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 06/10] alpha: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 07/10] x86: " Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 08/10] perf/core: Remove unused perf_flags Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 09/10] drivers/perf: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-19 16:03 ` Mark Rutland
2018-11-19 16:03 ` Mark Rutland
2018-11-19 16:03 ` Mark Rutland
2018-11-23 14:31 ` Andrew Murray
2018-11-23 14:31 ` Andrew Murray
2018-11-23 14:31 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 10/10] perf/doc: update design.txt for exclude_{host|guest} flags Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-20 11:31 ` Michael Ellerman
2018-11-20 11:31 ` Michael Ellerman
2018-11-20 11:31 ` Michael Ellerman
2018-11-20 13:32 ` Andrew Murray
2018-11-20 13:32 ` Andrew Murray
2018-11-20 13:32 ` Andrew Murray
2018-12-11 11:06 ` Michael Ellerman [this message]
2018-12-11 11:06 ` Michael Ellerman
2018-12-11 11:06 ` Michael Ellerman
2018-12-11 11:06 ` Michael Ellerman
2018-12-11 13:59 ` Andrew Murray
2018-12-11 13:59 ` Andrew Murray
2018-12-11 13:59 ` Andrew Murray
2018-12-12 4:48 ` Michael Ellerman
2018-12-12 4:48 ` Michael Ellerman
2018-12-12 4:48 ` Michael Ellerman
2018-12-12 4:48 ` Michael Ellerman
2018-12-12 8:07 ` Christoffer Dall
2018-12-12 8:07 ` Christoffer Dall
2018-12-12 8:07 ` Christoffer Dall
2018-12-12 17:08 ` Andrew Murray
2018-12-12 17:08 ` Andrew Murray
2018-12-12 17:08 ` Andrew Murray
2018-11-19 13:08 ` [PATCH 00/10] perf/core: Generalise event exclusion checking Peter Zijlstra
2018-11-19 13:08 ` Peter Zijlstra
2018-11-19 13:08 ` Peter Zijlstra
2018-11-19 13:08 ` Peter Zijlstra
2018-11-22 12:21 ` Andrew Murray
2018-11-22 12:21 ` Andrew Murray
2018-11-22 12:21 ` Andrew Murray
2018-11-22 12:26 ` Peter Zijlstra
2018-11-22 12:26 ` Peter Zijlstra
2018-11-22 12:26 ` Peter Zijlstra
2018-11-22 12:26 ` Peter Zijlstra
2018-11-22 12:59 ` Andrew Murray
2018-11-22 12:59 ` Andrew Murray
2018-11-22 12:59 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm5sxqya.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=acme@kernel.org \
--cc=andrew.murray@arm.com \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=joro@8bytes.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.