From: Andrew Murray <andrew.murray@arm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, linux-alpha@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/10] perf/core: Add macro to test for event exclusion flags
Date: Fri, 23 Nov 2018 14:32:13 +0000 [thread overview]
Message-ID: <20181123143213.GB1617@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <87sgzw0yzh.fsf@concordia.ellerman.id.au>
On Tue, Nov 20, 2018 at 10:28:34PM +1100, Michael Ellerman wrote:
> Andrew Murray <andrew.murray@arm.com> writes:
>
> > Add a macro that tests if any of the perf event exclusion flags
> > are set on a given event.
> >
> > Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> > ---
> > include/linux/perf_event.h | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> > index 53c500f..89ee7fa 100644
> > --- a/include/linux/perf_event.h
> > +++ b/include/linux/perf_event.h
> > @@ -1004,6 +1004,15 @@ perf_event__output_id_sample(struct perf_event *event,
> > extern void
> > perf_log_lost_samples(struct perf_event *event, u64 lost);
> >
> > +static inline bool event_has_exclude_flags(struct perf_event *event)
> > +{
> > + struct perf_event_attr *attr = &event->attr;
> > +
> > + return attr->exclude_idle || attr->exclude_user ||
> > + attr->exclude_kernel || attr->exclude_hv ||
> > + attr->exclude_guest || attr->exclude_host;
> > +}
>
> Sorry to be a total PITA, but using "flags" plural suggests that it only
> returns true if there is more than one exclude flag set.
>
> A better name would be event_has_exclude_flag() or maybe
> event_has_any_exclude_flag().
>
> If you're doing a respin anyway it'd be nice to fix the name, but
> obviously it's not high priority.
No problem - I'll go with event_has_any_exclude_flag.
Thanks,
Andrew Murray
>
> cheers
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Murray <andrew.murray@arm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
x86@kernel.org, Will Deacon <will.deacon@arm.com>,
linuxppc-dev@lists.ozlabs.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
linux-alpha@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/10] perf/core: Add macro to test for event exclusion flags
Date: Fri, 23 Nov 2018 14:32:13 +0000 [thread overview]
Message-ID: <20181123143213.GB1617@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <87sgzw0yzh.fsf@concordia.ellerman.id.au>
On Tue, Nov 20, 2018 at 10:28:34PM +1100, Michael Ellerman wrote:
> Andrew Murray <andrew.murray@arm.com> writes:
>
> > Add a macro that tests if any of the perf event exclusion flags
> > are set on a given event.
> >
> > Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> > ---
> > include/linux/perf_event.h | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> > index 53c500f..89ee7fa 100644
> > --- a/include/linux/perf_event.h
> > +++ b/include/linux/perf_event.h
> > @@ -1004,6 +1004,15 @@ perf_event__output_id_sample(struct perf_event *event,
> > extern void
> > perf_log_lost_samples(struct perf_event *event, u64 lost);
> >
> > +static inline bool event_has_exclude_flags(struct perf_event *event)
> > +{
> > + struct perf_event_attr *attr = &event->attr;
> > +
> > + return attr->exclude_idle || attr->exclude_user ||
> > + attr->exclude_kernel || attr->exclude_hv ||
> > + attr->exclude_guest || attr->exclude_host;
> > +}
>
> Sorry to be a total PITA, but using "flags" plural suggests that it only
> returns true if there is more than one exclude flag set.
>
> A better name would be event_has_exclude_flag() or maybe
> event_has_any_exclude_flag().
>
> If you're doing a respin anyway it'd be nice to fix the name, but
> obviously it's not high priority.
No problem - I'll go with event_has_any_exclude_flag.
Thanks,
Andrew Murray
>
> cheers
WARNING: multiple messages have this Message-ID (diff)
From: andrew.murray@arm.com (Andrew Murray)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/10] perf/core: Add macro to test for event exclusion flags
Date: Fri, 23 Nov 2018 14:32:13 +0000 [thread overview]
Message-ID: <20181123143213.GB1617@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <87sgzw0yzh.fsf@concordia.ellerman.id.au>
On Tue, Nov 20, 2018 at 10:28:34PM +1100, Michael Ellerman wrote:
> Andrew Murray <andrew.murray@arm.com> writes:
>
> > Add a macro that tests if any of the perf event exclusion flags
> > are set on a given event.
> >
> > Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> > ---
> > include/linux/perf_event.h | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> > index 53c500f..89ee7fa 100644
> > --- a/include/linux/perf_event.h
> > +++ b/include/linux/perf_event.h
> > @@ -1004,6 +1004,15 @@ perf_event__output_id_sample(struct perf_event *event,
> > extern void
> > perf_log_lost_samples(struct perf_event *event, u64 lost);
> >
> > +static inline bool event_has_exclude_flags(struct perf_event *event)
> > +{
> > + struct perf_event_attr *attr = &event->attr;
> > +
> > + return attr->exclude_idle || attr->exclude_user ||
> > + attr->exclude_kernel || attr->exclude_hv ||
> > + attr->exclude_guest || attr->exclude_host;
> > +}
>
> Sorry to be a total PITA, but using "flags" plural suggests that it only
> returns true if there is more than one exclude flag set.
>
> A better name would be event_has_exclude_flag() or maybe
> event_has_any_exclude_flag().
>
> If you're doing a respin anyway it'd be nice to fix the name, but
> obviously it's not high priority.
No problem - I'll go with event_has_any_exclude_flag.
Thanks,
Andrew Murray
>
> cheers
next prev parent reply other threads:[~2018-11-23 14:32 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 10:24 [PATCH 00/10] perf/core: Generalise event exclusion checking Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 01/10] perf/core: Add macro to test for event exclusion flags Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-19 12:58 ` Peter Zijlstra
2018-11-19 12:58 ` Peter Zijlstra
2018-11-19 12:58 ` Peter Zijlstra
2018-11-19 12:58 ` Peter Zijlstra
2018-11-19 16:01 ` Mark Rutland
2018-11-19 16:01 ` Mark Rutland
2018-11-19 16:01 ` Mark Rutland
2018-11-20 11:28 ` Michael Ellerman
2018-11-20 11:28 ` Michael Ellerman
2018-11-20 11:28 ` Michael Ellerman
2018-11-23 14:32 ` Andrew Murray [this message]
2018-11-23 14:32 ` Andrew Murray
2018-11-23 14:32 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 02/10] arm: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 03/10] arm: perf: add additional validation to set_event_filter Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 04/10] powerpc: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-20 11:21 ` Michael Ellerman
2018-11-20 11:21 ` Michael Ellerman
2018-11-20 11:21 ` Michael Ellerman
2018-11-16 10:24 ` [PATCH 05/10] powerpc/pmu/fsl: add additional validation to event_init Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 06/10] alpha: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 07/10] x86: " Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 08/10] perf/core: Remove unused perf_flags Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 09/10] drivers/perf: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-19 16:03 ` Mark Rutland
2018-11-19 16:03 ` Mark Rutland
2018-11-19 16:03 ` Mark Rutland
2018-11-23 14:31 ` Andrew Murray
2018-11-23 14:31 ` Andrew Murray
2018-11-23 14:31 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 10/10] perf/doc: update design.txt for exclude_{host|guest} flags Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-20 11:31 ` Michael Ellerman
2018-11-20 11:31 ` Michael Ellerman
2018-11-20 11:31 ` Michael Ellerman
2018-11-20 13:32 ` Andrew Murray
2018-11-20 13:32 ` Andrew Murray
2018-11-20 13:32 ` Andrew Murray
2018-12-11 11:06 ` Michael Ellerman
2018-12-11 11:06 ` Michael Ellerman
2018-12-11 11:06 ` Michael Ellerman
2018-12-11 11:06 ` Michael Ellerman
2018-12-11 13:59 ` Andrew Murray
2018-12-11 13:59 ` Andrew Murray
2018-12-11 13:59 ` Andrew Murray
2018-12-12 4:48 ` Michael Ellerman
2018-12-12 4:48 ` Michael Ellerman
2018-12-12 4:48 ` Michael Ellerman
2018-12-12 4:48 ` Michael Ellerman
2018-12-12 8:07 ` Christoffer Dall
2018-12-12 8:07 ` Christoffer Dall
2018-12-12 8:07 ` Christoffer Dall
2018-12-12 17:08 ` Andrew Murray
2018-12-12 17:08 ` Andrew Murray
2018-12-12 17:08 ` Andrew Murray
2018-11-19 13:08 ` [PATCH 00/10] perf/core: Generalise event exclusion checking Peter Zijlstra
2018-11-19 13:08 ` Peter Zijlstra
2018-11-19 13:08 ` Peter Zijlstra
2018-11-19 13:08 ` Peter Zijlstra
2018-11-22 12:21 ` Andrew Murray
2018-11-22 12:21 ` Andrew Murray
2018-11-22 12:21 ` Andrew Murray
2018-11-22 12:26 ` Peter Zijlstra
2018-11-22 12:26 ` Peter Zijlstra
2018-11-22 12:26 ` Peter Zijlstra
2018-11-22 12:26 ` Peter Zijlstra
2018-11-22 12:59 ` Andrew Murray
2018-11-22 12:59 ` Andrew Murray
2018-11-22 12:59 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123143213.GB1617@e119886-lin.cambridge.arm.com \
--to=andrew.murray@arm.com \
--cc=acme@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.