From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
LKML <linux-kernel@vger.kernel.org>
Cc: "Michal Hocko" <mhocko@suse.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"DRI Development" <dri-devel@lists.freedesktop.org>,
"Linux MM" <linux-mm@kvack.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"David Rientjes" <rientjes@google.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [Intel-gfx] [PATCH 1/3] mm: Check if mmu notifier callbacks are allowed to fail
Date: Thu, 22 Nov 2018 16:53:34 +0000 [thread overview]
Message-ID: <154290561362.11623.15299444358726283678@skylake-alporthouse-com> (raw)
In-Reply-To: <20181122165106.18238-2-daniel.vetter@ffwll.ch>
Quoting Daniel Vetter (2018-11-22 16:51:04)
> Just a bit of paranoia, since if we start pushing this deep into
> callchains it's hard to spot all places where an mmu notifier
> implementation might fail when it's not allowed to.
Most callers could handle the failure correctly. It looks like the
failure was not propagated for convenience.
-Chris
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
LKML <linux-kernel@vger.kernel.org>
Cc: "Michal Hocko" <mhocko@suse.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"DRI Development" <dri-devel@lists.freedesktop.org>,
"Linux MM" <linux-mm@kvack.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"David Rientjes" <rientjes@google.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [Intel-gfx] [PATCH 1/3] mm: Check if mmu notifier callbacks are allowed to fail
Date: Thu, 22 Nov 2018 16:53:34 +0000 [thread overview]
Message-ID: <154290561362.11623.15299444358726283678@skylake-alporthouse-com> (raw)
In-Reply-To: <20181122165106.18238-2-daniel.vetter@ffwll.ch>
Quoting Daniel Vetter (2018-11-22 16:51:04)
> Just a bit of paranoia, since if we start pushing this deep into
> callchains it's hard to spot all places where an mmu notifier
> implementation might fail when it's not allowed to.
Most callers could handle the failure correctly. It looks like the
failure was not propagated for convenience.
-Chris
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: LKML <linux-kernel@vger.kernel.org>
Cc: "Michal Hocko" <mhocko@suse.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"DRI Development" <dri-devel@lists.freedesktop.org>,
"Linux MM" <linux-mm@kvack.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Rientjes" <rientjes@google.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 1/3] mm: Check if mmu notifier callbacks are allowed to fail
Date: Thu, 22 Nov 2018 16:53:34 +0000 [thread overview]
Message-ID: <154290561362.11623.15299444358726283678@skylake-alporthouse-com> (raw)
In-Reply-To: <20181122165106.18238-2-daniel.vetter@ffwll.ch>
Quoting Daniel Vetter (2018-11-22 16:51:04)
> Just a bit of paranoia, since if we start pushing this deep into
> callchains it's hard to spot all places where an mmu notifier
> implementation might fail when it's not allowed to.
Most callers could handle the failure correctly. It looks like the
failure was not propagated for convenience.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-22 16:54 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 16:51 [PATCH 0/3] RFC: mmu notifier debug checks Daniel Vetter
2018-11-22 16:51 ` [PATCH 1/3] mm: Check if mmu notifier callbacks are allowed to fail Daniel Vetter
2018-11-22 16:53 ` Chris Wilson [this message]
2018-11-22 16:53 ` Chris Wilson
2018-11-22 16:53 ` [Intel-gfx] " Chris Wilson
2018-11-23 8:49 ` Daniel Vetter
2018-11-23 11:14 ` Michal Hocko
2018-11-22 18:50 ` Koenig, Christian
2018-11-22 18:50 ` Koenig, Christian
2018-11-23 11:15 ` Michal Hocko
2018-11-23 11:15 ` Michal Hocko
2018-11-23 11:15 ` Michal Hocko
2018-11-23 12:30 ` Daniel Vetter
2018-11-23 12:30 ` Daniel Vetter
2018-11-23 12:30 ` Daniel Vetter
2018-11-23 12:43 ` Michal Hocko
2018-11-23 13:15 ` Daniel Vetter
2018-11-23 13:15 ` Daniel Vetter
2018-11-23 13:30 ` Michal Hocko
2018-11-22 16:51 ` [PATCH 2/3] mm, notifier: Catch sleeping/blocking for !blockable Daniel Vetter
2018-11-22 18:55 ` Koenig, Christian
2018-11-22 18:55 ` Koenig, Christian
2018-11-23 8:46 ` Daniel Vetter
2018-11-23 8:46 ` Daniel Vetter
2018-11-23 8:46 ` Daniel Vetter
2018-11-23 10:14 ` Christian König
2018-11-23 11:12 ` Michal Hocko
2018-11-23 11:12 ` Michal Hocko
2018-11-23 12:38 ` Daniel Vetter
2018-11-23 12:38 ` Daniel Vetter
2018-11-23 12:46 ` Michal Hocko
2018-11-23 13:12 ` Daniel Vetter
2018-11-23 13:12 ` Daniel Vetter
2018-11-23 13:23 ` [Intel-gfx] " Tvrtko Ursulin
2018-11-22 16:51 ` [PATCH 3/3] mm, notifier: Add a lockdep map for invalidate_range_start Daniel Vetter
2018-11-22 16:51 ` Daniel Vetter
2018-11-27 7:49 ` Daniel Vetter
2018-11-27 7:49 ` Daniel Vetter
2018-11-27 7:49 ` Daniel Vetter
2018-11-27 16:49 ` [Intel-gfx] " Chris Wilson
2018-11-27 16:49 ` Chris Wilson
2018-11-27 17:28 ` Daniel Vetter
2018-11-27 17:28 ` Daniel Vetter
2018-11-27 17:33 ` [Intel-gfx] " Chris Wilson
2018-11-27 17:33 ` Chris Wilson
2018-11-27 17:39 ` [Intel-gfx] " Daniel Vetter
2018-11-27 17:39 ` Daniel Vetter
2018-11-27 17:39 ` Daniel Vetter
2018-11-22 18:09 ` ✗ Fi.CI.CHECKPATCH: warning for RFC: mmu notifier debug checks Patchwork
2018-11-22 18:26 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-23 0:27 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154290561362.11623.15299444358726283678@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=akpm@linux-foundation.org \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.