From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
darrick.wong@oracle.com, shaggy@kernel.org,
ard.biesheuvel@linaro.org, josef@toxicpanda.com,
hch@infradead.org, clm@fb.com, adilger.kernel@dilger.ca,
jk@ozlabs.org, jack@suse.com, dsterba@suse.com,
jaegeuk@kernel.org, viro@zeniv.linux.org.uk
Cc: cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
linux-efi@vger.kernel.org, reiserfs-devel@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-nilfs@vger.kernel.org,
linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: [PATCH 5/5] vfs: only allow FSSETXATTR to set DAX flag on files and dirs
Date: Tue, 25 Jun 2019 19:32:47 -0700 [thread overview]
Message-ID: <156151636789.2283456.3835262849301472968.stgit@magnolia> (raw)
In-Reply-To: <156151632209.2283456.3592379873620132456.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
The DAX flag only applies to files and directories, so don't let it get
set for other types of files.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/inode.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/inode.c b/fs/inode.c
index 670d5408d022..f08711b34341 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2259,6 +2259,14 @@ int vfs_ioc_fssetxattr_check(struct inode *inode, const struct fsxattr *old_fa,
!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode))
return -EINVAL;
+ /*
+ * It is only valid to set the DAX flag on regular files and
+ * directories on filesystems.
+ */
+ if ((fa->fsx_xflags & FS_XFLAG_DAX) &&
+ !(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode)))
+ return -EINVAL;
+
/* Extent size hints of zero turn off the flags. */
if (fa->fsx_extsize == 0)
fa->fsx_xflags &= ~(FS_XFLAG_EXTSIZE | FS_XFLAG_EXTSZINHERIT);
WARNING: multiple messages have this Message-ID (diff)
From: Darrick J. Wong <darrick.wong@oracle.com>
To: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
darrick.wong@oracle.com, shaggy@kernel.org,
ard.biesheuvel@linaro.org, josef@toxicpanda.com,
hch@infradead.org, clm@fb.com, adilger.kernel@dilger.ca,
jk@ozlabs.org, jack@suse.com, dsterba@suse.com,
jaegeuk@kernel.org, viro@zeniv.linux.org.uk
Cc: cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net,
linux-efi@vger.kernel.org, reiserfs-devel@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-nilfs@vger.kernel.org,
linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: [Ocfs2-devel] [PATCH 5/5] vfs: only allow FSSETXATTR to set DAX flag on files and dirs
Date: Tue, 25 Jun 2019 19:32:47 -0700 [thread overview]
Message-ID: <156151636789.2283456.3835262849301472968.stgit@magnolia> (raw)
In-Reply-To: <156151632209.2283456.3592379873620132456.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
The DAX flag only applies to files and directories, so don't let it get
set for other types of files.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/inode.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/inode.c b/fs/inode.c
index 670d5408d022..f08711b34341 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2259,6 +2259,14 @@ int vfs_ioc_fssetxattr_check(struct inode *inode, const struct fsxattr *old_fa,
!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode))
return -EINVAL;
+ /*
+ * It is only valid to set the DAX flag on regular files and
+ * directories on filesystems.
+ */
+ if ((fa->fsx_xflags & FS_XFLAG_DAX) &&
+ !(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode)))
+ return -EINVAL;
+
/* Extent size hints of zero turn off the flags. */
if (fa->fsx_extsize == 0)
fa->fsx_xflags &= ~(FS_XFLAG_EXTSIZE | FS_XFLAG_EXTSZINHERIT);
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
darrick.wong@oracle.com, shaggy@kernel.org,
ard.biesheuvel@linaro.org, josef@toxicpanda.com,
hch@infradead.org, clm@fb.com, adilger.kernel@dilger.ca,
jk@ozlabs.org, jack@suse.com, dsterba@suse.com,
jaegeuk@kernel.org, viro@zeniv.linux.org.uk
Cc: linux-xfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
reiserfs-devel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-nilfs@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [f2fs-dev] [PATCH 5/5] vfs: only allow FSSETXATTR to set DAX flag on files and dirs
Date: Tue, 25 Jun 2019 19:32:47 -0700 [thread overview]
Message-ID: <156151636789.2283456.3835262849301472968.stgit@magnolia> (raw)
In-Reply-To: <156151632209.2283456.3592379873620132456.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
The DAX flag only applies to files and directories, so don't let it get
set for other types of files.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/inode.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/inode.c b/fs/inode.c
index 670d5408d022..f08711b34341 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2259,6 +2259,14 @@ int vfs_ioc_fssetxattr_check(struct inode *inode, const struct fsxattr *old_fa,
!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode))
return -EINVAL;
+ /*
+ * It is only valid to set the DAX flag on regular files and
+ * directories on filesystems.
+ */
+ if ((fa->fsx_xflags & FS_XFLAG_DAX) &&
+ !(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode)))
+ return -EINVAL;
+
/* Extent size hints of zero turn off the flags. */
if (fa->fsx_extsize == 0)
fa->fsx_xflags &= ~(FS_XFLAG_EXTSIZE | FS_XFLAG_EXTSZINHERIT);
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
darrick.wong@oracle.com, shaggy@kernel.org,
ard.biesheuvel@linaro.org, josef@toxicpanda.com,
hch@infradead.org, clm@fb.com, adilger.kernel@dilger.ca,
jk@ozlabs.org, jack@suse.com, dsterba@suse.com,
jaegeuk@kernel.org, viro@zeniv.linux.org.uk
Cc: linux-xfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
reiserfs-devel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-nilfs@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [PATCH 5/5] vfs: only allow FSSETXATTR to set DAX flag on files and dirs
Date: Tue, 25 Jun 2019 19:32:47 -0700 [thread overview]
Message-ID: <156151636789.2283456.3835262849301472968.stgit@magnolia> (raw)
In-Reply-To: <156151632209.2283456.3592379873620132456.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
The DAX flag only applies to files and directories, so don't let it get
set for other types of files.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/inode.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/inode.c b/fs/inode.c
index 670d5408d022..f08711b34341 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2259,6 +2259,14 @@ int vfs_ioc_fssetxattr_check(struct inode *inode, const struct fsxattr *old_fa,
!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode))
return -EINVAL;
+ /*
+ * It is only valid to set the DAX flag on regular files and
+ * directories on filesystems.
+ */
+ if ((fa->fsx_xflags & FS_XFLAG_DAX) &&
+ !(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode)))
+ return -EINVAL;
+
/* Extent size hints of zero turn off the flags. */
if (fa->fsx_extsize == 0)
fa->fsx_xflags &= ~(FS_XFLAG_EXTSIZE | FS_XFLAG_EXTSZINHERIT);
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Darrick J. Wong <darrick.wong@oracle.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 5/5] vfs: only allow FSSETXATTR to set DAX flag on files and dirs
Date: Tue, 25 Jun 2019 19:32:47 -0700 [thread overview]
Message-ID: <156151636789.2283456.3835262849301472968.stgit@magnolia> (raw)
In-Reply-To: <156151632209.2283456.3592379873620132456.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
The DAX flag only applies to files and directories, so don't let it get
set for other types of files.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/inode.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/inode.c b/fs/inode.c
index 670d5408d022..f08711b34341 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2259,6 +2259,14 @@ int vfs_ioc_fssetxattr_check(struct inode *inode, const struct fsxattr *old_fa,
!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode))
return -EINVAL;
+ /*
+ * It is only valid to set the DAX flag on regular files and
+ * directories on filesystems.
+ */
+ if ((fa->fsx_xflags & FS_XFLAG_DAX) &&
+ !(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode)))
+ return -EINVAL;
+
/* Extent size hints of zero turn off the flags. */
if (fa->fsx_extsize == 0)
fa->fsx_xflags &= ~(FS_XFLAG_EXTSIZE | FS_XFLAG_EXTSZINHERIT);
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
darrick.wong@oracle.com, shaggy@kernel.org,
ard.biesheuvel@linaro.org, josef@toxicpanda.com,
hch@infradead.org, clm@fb.com, adilger.kernel@dilger.ca,
jk@ozlabs.org, jack@suse.com, dsterba@suse.com,
jaegeuk@kernel.org, viro@zeniv.linux.org.uk
Cc: linux-xfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
reiserfs-devel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-nilfs@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [PATCH 5/5] vfs: only allow FSSETXATTR to set DAX flag on files and dirs
Date: Tue, 25 Jun 2019 19:32:47 -0700 [thread overview]
Message-ID: <156151636789.2283456.3835262849301472968.stgit@magnolia> (raw)
In-Reply-To: <156151632209.2283456.3592379873620132456.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
The DAX flag only applies to files and directories, so don't let it get
set for other types of files.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/inode.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/inode.c b/fs/inode.c
index 670d5408d022..f08711b34341 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2259,6 +2259,14 @@ int vfs_ioc_fssetxattr_check(struct inode *inode, const struct fsxattr *old_fa,
!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode))
return -EINVAL;
+ /*
+ * It is only valid to set the DAX flag on regular files and
+ * directories on filesystems.
+ */
+ if ((fa->fsx_xflags & FS_XFLAG_DAX) &&
+ !(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode)))
+ return -EINVAL;
+
/* Extent size hints of zero turn off the flags. */
if (fa->fsx_extsize == 0)
fa->fsx_xflags &= ~(FS_XFLAG_EXTSIZE | FS_XFLAG_EXTSZINHERIT);
next prev parent reply other threads:[~2019-06-26 2:34 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 2:32 [PATCH v3 0/5] vfs: clean up SETFLAGS and FSSETXATTR option processing Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 2:32 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 2:32 ` [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 4:02 ` Al Viro
2019-06-26 4:02 ` [Cluster-devel] " Al Viro
2019-06-26 4:02 ` Al Viro
2019-06-26 4:02 ` [f2fs-dev] " Al Viro
2019-06-26 4:02 ` [Ocfs2-devel] " Al Viro
2019-06-26 15:30 ` Darrick J. Wong
2019-06-26 15:30 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 15:30 ` Darrick J. Wong
2019-06-26 15:30 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 15:30 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 12:20 ` [Cluster-devel] " Bob Peterson
2019-06-26 12:20 ` Bob Peterson
2019-06-26 12:20 ` Bob Peterson
2019-06-26 12:20 ` [f2fs-dev] " Bob Peterson
2019-06-26 2:32 ` [PATCH 2/5] vfs: create a generic checking function for FS_IOC_FSSETXATTR Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 2:32 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 4:11 ` Al Viro
2019-06-26 4:11 ` Al Viro
2019-06-26 4:11 ` [Cluster-devel] " Al Viro
2019-06-26 4:11 ` Al Viro
2019-06-26 4:11 ` [f2fs-dev] " Al Viro
2019-06-26 4:11 ` [Ocfs2-devel] " Al Viro
2019-06-26 15:35 ` Darrick J. Wong
2019-06-26 15:35 ` Darrick J. Wong
2019-06-26 15:35 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 15:35 ` Darrick J. Wong
2019-06-26 15:35 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 15:35 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 15:43 ` Christoph Hellwig
2019-06-26 15:43 ` [Cluster-devel] " Christoph Hellwig
2019-06-26 15:43 ` Christoph Hellwig
2019-06-26 15:43 ` [f2fs-dev] " Christoph Hellwig
2019-06-26 15:43 ` [Ocfs2-devel] " Christoph Hellwig
2019-06-27 0:19 ` Darrick J. Wong
2019-06-27 0:19 ` Darrick J. Wong
2019-06-27 0:19 ` [Cluster-devel] " Darrick J. Wong
2019-06-27 0:19 ` Darrick J. Wong
2019-06-27 0:19 ` [f2fs-dev] " Darrick J. Wong
2019-06-27 0:19 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 2:32 ` [PATCH 3/5] vfs: teach vfs_ioc_fssetxattr_check to check project id info Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 2:32 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 2:32 ` [PATCH 4/5] vfs: teach vfs_ioc_fssetxattr_check to check extent size hints Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 2:32 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong [this message]
2019-06-26 2:32 ` [PATCH 5/5] vfs: only allow FSSETXATTR to set DAX flag on files and dirs Darrick J. Wong
2019-06-26 2:32 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 2:32 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-28 18:33 [PATCH v4 0/5] vfs: clean up SETFLAGS and FSSETXATTR option processing Darrick J. Wong
2019-06-28 18:34 ` [PATCH 5/5] vfs: only allow FSSETXATTR to set DAX flag on files and dirs Darrick J. Wong
2019-06-28 18:34 ` Darrick J. Wong
2019-06-28 18:34 ` Darrick J. Wong
2019-06-29 20:09 ` Jan Kara
2019-06-29 20:09 ` Jan Kara
2019-06-29 20:09 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156151636789.2283456.3835262849301472968.stgit@magnolia \
--to=darrick.wong@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=ard.biesheuvel@linaro.org \
--cc=clm@fb.com \
--cc=cluster-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=hch@infradead.org \
--cc=jack@suse.com \
--cc=jaegeuk@kernel.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jk@ozlabs.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=shaggy@kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.