All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: matthew garrett <matthew.garrett@nebula.com>,
	yuchao0@huawei.com, tytso@mit.edu, shaggy@kernel.org,
	ard biesheuvel <ard.biesheuvel@linaro.org>,
	josef@toxicpanda.com, hch@infradead.org, clm@fb.com,
	adilger kernel <adilger.kernel@dilger.ca>,
	jk@ozlabs.org, jack@suse.com, dsterba@suse.com,
	jaegeuk@kernel.org, viro@zeniv.linux.org.uk,
	linux-xfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net,
	linux-efi@vger.kernel.org, Jan Kara <jack@suse.cz>,
	linux-ext4@vger.kernel.org, reiserfs-devel@vger.kernel.org,
	linux-kernel@vger.kernel.org, cluster-devel@redhat.com,
	linux-nilfs@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	Christoph Hellwig <hch@lst.de>,
	ocfs2-devel@oss.oracle.com
Subject: Re: [Cluster-devel] [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS
Date: Wed, 26 Jun 2019 08:20:42 -0400 (EDT)	[thread overview]
Message-ID: <868182386.37358699.1561551642881.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <156151633004.2283456.4175543089138173586.stgit@magnolia>

----- Original Message -----
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Create a generic function to check incoming FS_IOC_SETFLAGS flag values
> and later prepare the inode for updates so that we can standardize the
> implementations that follow ext4's flag values.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Acked-by: David Sterba <dsterba@suse.com>
> ---
>  fs/btrfs/ioctl.c    |   13 +++++--------
>  fs/efivarfs/file.c  |   26 +++++++++++++++++---------
>  fs/ext2/ioctl.c     |   16 ++++------------
>  fs/ext4/ioctl.c     |   13 +++----------
>  fs/f2fs/file.c      |    7 ++++---
>  fs/gfs2/file.c      |   42 +++++++++++++++++++++++++++++-------------
>  fs/hfsplus/ioctl.c  |   21 ++++++++++++---------
>  fs/inode.c          |   24 ++++++++++++++++++++++++
>  fs/jfs/ioctl.c      |   22 +++++++---------------
>  fs/nilfs2/ioctl.c   |    9 ++-------
>  fs/ocfs2/ioctl.c    |   13 +++----------
>  fs/orangefs/file.c  |   35 ++++++++++++++++++++++++++---------
>  fs/reiserfs/ioctl.c |   10 ++++------
>  fs/ubifs/ioctl.c    |   13 +++----------
>  include/linux/fs.h  |    3 +++
>  15 files changed, 146 insertions(+), 121 deletions(-)

The gfs2 portion looks correct.

Reviewed-by: Bob Peterson <rpeterso@redhat.com>

Regards,

Bob Peterson

WARNING: multiple messages have this Message-ID (diff)
From: Bob Peterson <rpeterso@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net,
	linux-efi@vger.kernel.org, Jan Kara <jack@suse.cz>,
	clm@fb.com, adilger kernel <adilger.kernel@dilger.ca>,
	ocfs2-devel@oss.oracle.com, Christoph Hellwig <hch@lst.de>,
	matthew garrett <matthew.garrett@nebula.com>,
	cluster-devel@redhat.com, hch@infradead.org,
	linux-ext4@vger.kernel.org, josef@toxicpanda.com,
	reiserfs-devel@vger.kernel.org, linux-nilfs@vger.kernel.org,
	viro@zeniv.linux.org.uk, dsterba@suse.com, jaegeuk@kernel.org,
	tytso@mit.edu, ard biesheuvel <ard.biesheuvel@linaro.org>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-xfs@vger.kernel.org, jk@ozlabs.org, jack@suse.com,
	linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [Cluster-devel] [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS
Date: Wed, 26 Jun 2019 08:20:42 -0400 (EDT)	[thread overview]
Message-ID: <868182386.37358699.1561551642881.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <156151633004.2283456.4175543089138173586.stgit@magnolia>

----- Original Message -----
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Create a generic function to check incoming FS_IOC_SETFLAGS flag values
> and later prepare the inode for updates so that we can standardize the
> implementations that follow ext4's flag values.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Acked-by: David Sterba <dsterba@suse.com>
> ---
>  fs/btrfs/ioctl.c    |   13 +++++--------
>  fs/efivarfs/file.c  |   26 +++++++++++++++++---------
>  fs/ext2/ioctl.c     |   16 ++++------------
>  fs/ext4/ioctl.c     |   13 +++----------
>  fs/f2fs/file.c      |    7 ++++---
>  fs/gfs2/file.c      |   42 +++++++++++++++++++++++++++++-------------
>  fs/hfsplus/ioctl.c  |   21 ++++++++++++---------
>  fs/inode.c          |   24 ++++++++++++++++++++++++
>  fs/jfs/ioctl.c      |   22 +++++++---------------
>  fs/nilfs2/ioctl.c   |    9 ++-------
>  fs/ocfs2/ioctl.c    |   13 +++----------
>  fs/orangefs/file.c  |   35 ++++++++++++++++++++++++++---------
>  fs/reiserfs/ioctl.c |   10 ++++------
>  fs/ubifs/ioctl.c    |   13 +++----------
>  include/linux/fs.h  |    3 +++
>  15 files changed, 146 insertions(+), 121 deletions(-)

The gfs2 portion looks correct.

Reviewed-by: Bob Peterson <rpeterso@redhat.com>

Regards,

Bob Peterson


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Bob Peterson <rpeterso@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net,
	linux-efi@vger.kernel.org, Jan Kara <jack@suse.cz>,
	yuchao0@huawei.com, clm@fb.com,
	adilger kernel <adilger.kernel@dilger.ca>,
	ocfs2-devel@oss.oracle.com, Christoph Hellwig <hch@lst.de>,
	matthew garrett <matthew.garrett@nebula.com>,
	cluster-devel@redhat.com, hch@infradead.org,
	linux-ext4@vger.kernel.org, josef@toxicpanda.com,
	reiserfs-devel@vger.kernel.org, linux-nilfs@vger.kernel.org,
	viro@zeniv.linux.org.uk, dsterba@suse.com, jaegeuk@kernel.org,
	tytso@mit.edu, ard biesheuvel <ard.biesheuvel@linaro.org>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-xfs@vger.kernel.org, jk@ozlabs.org, jack@suse.com,
	linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-btrfs@vger.kernel.org
Subject: Re: [Cluster-devel] [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS
Date: Wed, 26 Jun 2019 08:20:42 -0400 (EDT)	[thread overview]
Message-ID: <868182386.37358699.1561551642881.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <156151633004.2283456.4175543089138173586.stgit@magnolia>

----- Original Message -----
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Create a generic function to check incoming FS_IOC_SETFLAGS flag values
> and later prepare the inode for updates so that we can standardize the
> implementations that follow ext4's flag values.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Acked-by: David Sterba <dsterba@suse.com>
> ---
>  fs/btrfs/ioctl.c    |   13 +++++--------
>  fs/efivarfs/file.c  |   26 +++++++++++++++++---------
>  fs/ext2/ioctl.c     |   16 ++++------------
>  fs/ext4/ioctl.c     |   13 +++----------
>  fs/f2fs/file.c      |    7 ++++---
>  fs/gfs2/file.c      |   42 +++++++++++++++++++++++++++++-------------
>  fs/hfsplus/ioctl.c  |   21 ++++++++++++---------
>  fs/inode.c          |   24 ++++++++++++++++++++++++
>  fs/jfs/ioctl.c      |   22 +++++++---------------
>  fs/nilfs2/ioctl.c   |    9 ++-------
>  fs/ocfs2/ioctl.c    |   13 +++----------
>  fs/orangefs/file.c  |   35 ++++++++++++++++++++++++++---------
>  fs/reiserfs/ioctl.c |   10 ++++------
>  fs/ubifs/ioctl.c    |   13 +++----------
>  include/linux/fs.h  |    3 +++
>  15 files changed, 146 insertions(+), 121 deletions(-)

The gfs2 portion looks correct.

Reviewed-by: Bob Peterson <rpeterso@redhat.com>

Regards,

Bob Peterson

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS
Date: Wed, 26 Jun 2019 08:20:42 -0400 (EDT)	[thread overview]
Message-ID: <868182386.37358699.1561551642881.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <156151633004.2283456.4175543089138173586.stgit@magnolia>

----- Original Message -----
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Create a generic function to check incoming FS_IOC_SETFLAGS flag values
> and later prepare the inode for updates so that we can standardize the
> implementations that follow ext4's flag values.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Acked-by: David Sterba <dsterba@suse.com>
> ---
>  fs/btrfs/ioctl.c    |   13 +++++--------
>  fs/efivarfs/file.c  |   26 +++++++++++++++++---------
>  fs/ext2/ioctl.c     |   16 ++++------------
>  fs/ext4/ioctl.c     |   13 +++----------
>  fs/f2fs/file.c      |    7 ++++---
>  fs/gfs2/file.c      |   42 +++++++++++++++++++++++++++++-------------
>  fs/hfsplus/ioctl.c  |   21 ++++++++++++---------
>  fs/inode.c          |   24 ++++++++++++++++++++++++
>  fs/jfs/ioctl.c      |   22 +++++++---------------
>  fs/nilfs2/ioctl.c   |    9 ++-------
>  fs/ocfs2/ioctl.c    |   13 +++----------
>  fs/orangefs/file.c  |   35 ++++++++++++++++++++++++++---------
>  fs/reiserfs/ioctl.c |   10 ++++------
>  fs/ubifs/ioctl.c    |   13 +++----------
>  include/linux/fs.h  |    3 +++
>  15 files changed, 146 insertions(+), 121 deletions(-)

The gfs2 portion looks correct.

Reviewed-by: Bob Peterson <rpeterso@redhat.com>

Regards,

Bob Peterson



  parent reply	other threads:[~2019-06-26 12:21 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26  2:32 [PATCH v3 0/5] vfs: clean up SETFLAGS and FSSETXATTR option processing Darrick J. Wong
2019-06-26  2:32 ` Darrick J. Wong
2019-06-26  2:32 ` [Cluster-devel] " Darrick J. Wong
2019-06-26  2:32 ` Darrick J. Wong
2019-06-26  2:32 ` [f2fs-dev] " Darrick J. Wong
2019-06-26  2:32 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26  2:32 ` [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS Darrick J. Wong
2019-06-26  2:32   ` Darrick J. Wong
2019-06-26  2:32   ` [Cluster-devel] " Darrick J. Wong
2019-06-26  2:32   ` Darrick J. Wong
2019-06-26  2:32   ` [f2fs-dev] " Darrick J. Wong
2019-06-26  4:02   ` Al Viro
2019-06-26  4:02     ` [Cluster-devel] " Al Viro
2019-06-26  4:02     ` Al Viro
2019-06-26  4:02     ` [f2fs-dev] " Al Viro
2019-06-26  4:02     ` [Ocfs2-devel] " Al Viro
2019-06-26 15:30     ` Darrick J. Wong
2019-06-26 15:30       ` [Cluster-devel] " Darrick J. Wong
2019-06-26 15:30       ` Darrick J. Wong
2019-06-26 15:30       ` [f2fs-dev] " Darrick J. Wong
2019-06-26 15:30       ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 12:20   ` Bob Peterson [this message]
2019-06-26 12:20     ` [Cluster-devel] " Bob Peterson
2019-06-26 12:20     ` Bob Peterson
2019-06-26 12:20     ` [f2fs-dev] " Bob Peterson
2019-06-26  2:32 ` [PATCH 2/5] vfs: create a generic checking function for FS_IOC_FSSETXATTR Darrick J. Wong
2019-06-26  2:32   ` Darrick J. Wong
2019-06-26  2:32   ` [Cluster-devel] " Darrick J. Wong
2019-06-26  2:32   ` Darrick J. Wong
2019-06-26  2:32   ` [f2fs-dev] " Darrick J. Wong
2019-06-26  2:32   ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26  4:11   ` Al Viro
2019-06-26  4:11     ` Al Viro
2019-06-26  4:11     ` [Cluster-devel] " Al Viro
2019-06-26  4:11     ` Al Viro
2019-06-26  4:11     ` [f2fs-dev] " Al Viro
2019-06-26  4:11     ` [Ocfs2-devel] " Al Viro
2019-06-26 15:35     ` Darrick J. Wong
2019-06-26 15:35       ` Darrick J. Wong
2019-06-26 15:35       ` [Cluster-devel] " Darrick J. Wong
2019-06-26 15:35       ` Darrick J. Wong
2019-06-26 15:35       ` [f2fs-dev] " Darrick J. Wong
2019-06-26 15:35       ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 15:43       ` Christoph Hellwig
2019-06-26 15:43         ` [Cluster-devel] " Christoph Hellwig
2019-06-26 15:43         ` Christoph Hellwig
2019-06-26 15:43         ` [f2fs-dev] " Christoph Hellwig
2019-06-26 15:43         ` [Ocfs2-devel] " Christoph Hellwig
2019-06-27  0:19         ` Darrick J. Wong
2019-06-27  0:19           ` Darrick J. Wong
2019-06-27  0:19           ` [Cluster-devel] " Darrick J. Wong
2019-06-27  0:19           ` Darrick J. Wong
2019-06-27  0:19           ` [f2fs-dev] " Darrick J. Wong
2019-06-27  0:19           ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26  2:32 ` [PATCH 3/5] vfs: teach vfs_ioc_fssetxattr_check to check project id info Darrick J. Wong
2019-06-26  2:32   ` Darrick J. Wong
2019-06-26  2:32   ` [Cluster-devel] " Darrick J. Wong
2019-06-26  2:32   ` Darrick J. Wong
2019-06-26  2:32   ` [f2fs-dev] " Darrick J. Wong
2019-06-26  2:32   ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26  2:32 ` [PATCH 4/5] vfs: teach vfs_ioc_fssetxattr_check to check extent size hints Darrick J. Wong
2019-06-26  2:32   ` Darrick J. Wong
2019-06-26  2:32   ` [Cluster-devel] " Darrick J. Wong
2019-06-26  2:32   ` Darrick J. Wong
2019-06-26  2:32   ` [f2fs-dev] " Darrick J. Wong
2019-06-26  2:32   ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26  2:32 ` [PATCH 5/5] vfs: only allow FSSETXATTR to set DAX flag on files and dirs Darrick J. Wong
2019-06-26  2:32   ` Darrick J. Wong
2019-06-26  2:32   ` [Cluster-devel] " Darrick J. Wong
2019-06-26  2:32   ` Darrick J. Wong
2019-06-26  2:32   ` [f2fs-dev] " Darrick J. Wong
2019-06-26  2:32   ` [Ocfs2-devel] " Darrick J. Wong
2019-06-28 18:33 [PATCH v4 0/5] vfs: clean up SETFLAGS and FSSETXATTR option processing Darrick J. Wong
2019-06-28 18:33 ` [Cluster-devel] [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868182386.37358699.1561551642881.JavaMail.zimbra@redhat.com \
    --to=rpeterso@redhat.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=ard.biesheuvel@linaro.org \
    --cc=clm@fb.com \
    --cc=cluster-devel@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=dsterba@suse.com \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=jack@suse.com \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=jk@ozlabs.org \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nilfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=reiserfs-devel@vger.kernel.org \
    --cc=shaggy@kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.