From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
shaggy@kernel.org, ard.biesheuvel@linaro.org,
josef@toxicpanda.com, hch@infradead.org, clm@fb.com,
adilger.kernel@dilger.ca, jk@ozlabs.org, jack@suse.com,
dsterba@suse.com, jaegeuk@kernel.org, cluster-devel@redhat.com,
jfs-discussion@lists.sourceforge.net, linux-efi@vger.kernel.org,
Jan Kara <jack@suse.cz>,
reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-nilfs@vger.kernel.org,
linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS
Date: Wed, 26 Jun 2019 08:30:36 -0700 [thread overview]
Message-ID: <20190626153036.GD5171@magnolia> (raw)
In-Reply-To: <20190626040202.GA32272@ZenIV.linux.org.uk>
On Wed, Jun 26, 2019 at 05:02:02AM +0100, Al Viro wrote:
> On Tue, Jun 25, 2019 at 07:32:10PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Create a generic function to check incoming FS_IOC_SETFLAGS flag values
> > and later prepare the inode for updates so that we can standardize the
> > implementations that follow ext4's flag values.
>
> Change in efivarfs behaviour deserves a note. I'm not saying it's wrong,
> but behaviour is changed there - no-op FS_IOC_SETFLAGS used to fail
> without CAP_LINUX_IMMUTABLE...
Ok, will do. FWIW I wondered about fixing the orangefs usage too (using
an unsigned long uval to hold the contents of an unsigned int coming
from userspace) but ... that's their decision.
--D
WARNING: multiple messages have this Message-ID (diff)
From: Darrick J. Wong <darrick.wong@oracle.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
shaggy@kernel.org, ard.biesheuvel@linaro.org,
josef@toxicpanda.com, hch@infradead.org, clm@fb.com,
adilger.kernel@dilger.ca, jk@ozlabs.org, jack@suse.com,
dsterba@suse.com, jaegeuk@kernel.org, cluster-devel@redhat.com,
jfs-discussion@lists.sourceforge.net, linux-efi@vger.kernel.org,
Jan Kara <jack@suse.cz>,
reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-nilfs@vger.kernel.org,
linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
linux-btrfs@vger.kernel.org
Subject: [Ocfs2-devel] [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS
Date: Wed, 26 Jun 2019 08:30:36 -0700 [thread overview]
Message-ID: <20190626153036.GD5171@magnolia> (raw)
In-Reply-To: <20190626040202.GA32272@ZenIV.linux.org.uk>
On Wed, Jun 26, 2019 at 05:02:02AM +0100, Al Viro wrote:
> On Tue, Jun 25, 2019 at 07:32:10PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Create a generic function to check incoming FS_IOC_SETFLAGS flag values
> > and later prepare the inode for updates so that we can standardize the
> > implementations that follow ext4's flag values.
>
> Change in efivarfs behaviour deserves a note. I'm not saying it's wrong,
> but behaviour is changed there - no-op FS_IOC_SETFLAGS used to fail
> without CAP_LINUX_IMMUTABLE...
Ok, will do. FWIW I wondered about fixing the orangefs usage too (using
an unsigned long uval to hold the contents of an unsigned int coming
from userspace) but ... that's their decision.
--D
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net,
linux-efi@vger.kernel.org, Jan Kara <jack@suse.cz>,
hch@infradead.org, linux-btrfs@vger.kernel.org, clm@fb.com,
adilger.kernel@dilger.ca, Christoph Hellwig <hch@lst.de>,
matthew.garrett@nebula.com, linux-nilfs@vger.kernel.org,
cluster-devel@redhat.com, linux-ext4@vger.kernel.org,
josef@toxicpanda.com, reiserfs-devel@vger.kernel.org,
dsterba@suse.com, jaegeuk@kernel.org, tytso@mit.edu,
ard.biesheuvel@linaro.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, jk@ozlabs.org, jack@suse.com,
linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
ocfs2-devel@oss.oracle.com
Subject: Re: [f2fs-dev] [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS
Date: Wed, 26 Jun 2019 08:30:36 -0700 [thread overview]
Message-ID: <20190626153036.GD5171@magnolia> (raw)
In-Reply-To: <20190626040202.GA32272@ZenIV.linux.org.uk>
On Wed, Jun 26, 2019 at 05:02:02AM +0100, Al Viro wrote:
> On Tue, Jun 25, 2019 at 07:32:10PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Create a generic function to check incoming FS_IOC_SETFLAGS flag values
> > and later prepare the inode for updates so that we can standardize the
> > implementations that follow ext4's flag values.
>
> Change in efivarfs behaviour deserves a note. I'm not saying it's wrong,
> but behaviour is changed there - no-op FS_IOC_SETFLAGS used to fail
> without CAP_LINUX_IMMUTABLE...
Ok, will do. FWIW I wondered about fixing the orangefs usage too (using
an unsigned long uval to hold the contents of an unsigned int coming
from userspace) but ... that's their decision.
--D
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net,
linux-efi@vger.kernel.org, Jan Kara <jack@suse.cz>,
hch@infradead.org, linux-btrfs@vger.kernel.org,
yuchao0@huawei.com, clm@fb.com, adilger.kernel@dilger.ca,
Christoph Hellwig <hch@lst.de>,
matthew.garrett@nebula.com, linux-nilfs@vger.kernel.org,
cluster-devel@redhat.com, linux-ext4@vger.kernel.org,
josef@toxicpanda.com, reiserfs-devel@vger.kernel.org,
dsterba@suse.com, jaegeuk@kernel.org, tytso@mit.edu,
ard.biesheuvel@linaro.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, jk@ozlabs.org, jack@suse.com,
linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS
Date: Wed, 26 Jun 2019 08:30:36 -0700 [thread overview]
Message-ID: <20190626153036.GD5171@magnolia> (raw)
In-Reply-To: <20190626040202.GA32272@ZenIV.linux.org.uk>
On Wed, Jun 26, 2019 at 05:02:02AM +0100, Al Viro wrote:
> On Tue, Jun 25, 2019 at 07:32:10PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Create a generic function to check incoming FS_IOC_SETFLAGS flag values
> > and later prepare the inode for updates so that we can standardize the
> > implementations that follow ext4's flag values.
>
> Change in efivarfs behaviour deserves a note. I'm not saying it's wrong,
> but behaviour is changed there - no-op FS_IOC_SETFLAGS used to fail
> without CAP_LINUX_IMMUTABLE...
Ok, will do. FWIW I wondered about fixing the orangefs usage too (using
an unsigned long uval to hold the contents of an unsigned int coming
from userspace) but ... that's their decision.
--D
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Darrick J. Wong <darrick.wong@oracle.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS
Date: Wed, 26 Jun 2019 08:30:36 -0700 [thread overview]
Message-ID: <20190626153036.GD5171@magnolia> (raw)
In-Reply-To: <20190626040202.GA32272@ZenIV.linux.org.uk>
On Wed, Jun 26, 2019 at 05:02:02AM +0100, Al Viro wrote:
> On Tue, Jun 25, 2019 at 07:32:10PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Create a generic function to check incoming FS_IOC_SETFLAGS flag values
> > and later prepare the inode for updates so that we can standardize the
> > implementations that follow ext4's flag values.
>
> Change in efivarfs behaviour deserves a note. I'm not saying it's wrong,
> but behaviour is changed there - no-op FS_IOC_SETFLAGS used to fail
> without CAP_LINUX_IMMUTABLE...
Ok, will do. FWIW I wondered about fixing the orangefs usage too (using
an unsigned long uval to hold the contents of an unsigned int coming
from userspace) but ... that's their decision.
--D
next prev parent reply other threads:[~2019-06-26 15:32 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 2:32 [PATCH v3 0/5] vfs: clean up SETFLAGS and FSSETXATTR option processing Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 2:32 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 2:32 ` [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 4:02 ` Al Viro
2019-06-26 4:02 ` [Cluster-devel] " Al Viro
2019-06-26 4:02 ` Al Viro
2019-06-26 4:02 ` [f2fs-dev] " Al Viro
2019-06-26 4:02 ` [Ocfs2-devel] " Al Viro
2019-06-26 15:30 ` Darrick J. Wong [this message]
2019-06-26 15:30 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 15:30 ` Darrick J. Wong
2019-06-26 15:30 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 15:30 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 12:20 ` [Cluster-devel] " Bob Peterson
2019-06-26 12:20 ` Bob Peterson
2019-06-26 12:20 ` Bob Peterson
2019-06-26 12:20 ` [f2fs-dev] " Bob Peterson
2019-06-26 2:32 ` [PATCH 2/5] vfs: create a generic checking function for FS_IOC_FSSETXATTR Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 2:32 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 4:11 ` Al Viro
2019-06-26 4:11 ` Al Viro
2019-06-26 4:11 ` [Cluster-devel] " Al Viro
2019-06-26 4:11 ` Al Viro
2019-06-26 4:11 ` [f2fs-dev] " Al Viro
2019-06-26 4:11 ` [Ocfs2-devel] " Al Viro
2019-06-26 15:35 ` Darrick J. Wong
2019-06-26 15:35 ` Darrick J. Wong
2019-06-26 15:35 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 15:35 ` Darrick J. Wong
2019-06-26 15:35 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 15:35 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 15:43 ` Christoph Hellwig
2019-06-26 15:43 ` [Cluster-devel] " Christoph Hellwig
2019-06-26 15:43 ` Christoph Hellwig
2019-06-26 15:43 ` [f2fs-dev] " Christoph Hellwig
2019-06-26 15:43 ` [Ocfs2-devel] " Christoph Hellwig
2019-06-27 0:19 ` Darrick J. Wong
2019-06-27 0:19 ` Darrick J. Wong
2019-06-27 0:19 ` [Cluster-devel] " Darrick J. Wong
2019-06-27 0:19 ` Darrick J. Wong
2019-06-27 0:19 ` [f2fs-dev] " Darrick J. Wong
2019-06-27 0:19 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 2:32 ` [PATCH 3/5] vfs: teach vfs_ioc_fssetxattr_check to check project id info Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 2:32 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 2:32 ` [PATCH 4/5] vfs: teach vfs_ioc_fssetxattr_check to check extent size hints Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 2:32 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-26 2:32 ` [PATCH 5/5] vfs: only allow FSSETXATTR to set DAX flag on files and dirs Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [Cluster-devel] " Darrick J. Wong
2019-06-26 2:32 ` Darrick J. Wong
2019-06-26 2:32 ` [f2fs-dev] " Darrick J. Wong
2019-06-26 2:32 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-28 18:33 [PATCH v4 0/5] vfs: clean up SETFLAGS and FSSETXATTR option processing Darrick J. Wong
2019-06-28 18:33 ` [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS Darrick J. Wong
2019-06-28 18:33 ` Darrick J. Wong
2019-06-28 18:33 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626153036.GD5171@magnolia \
--to=darrick.wong@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=ard.biesheuvel@linaro.org \
--cc=clm@fb.com \
--cc=cluster-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jk@ozlabs.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=shaggy@kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.