Re: [PATCH v2 5/5] platform/x86: intel-vbtn: support panel front button

From: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
To: Bastien Nocera <hadess@hadess.net>
Cc: <platform-driver-x86@vger.kernel.org>,
	<linux-input@vger.kernel.org>,
	AceLan Kao <acelan.kao@canonical.com>,
	Andy Shevchenko <andy@infradead.org>,
	Darren Hart <dvhart@infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] platform/x86: intel-vbtn: support panel front button
Date: Fri, 10 Nov 2017 01:21:51 +0100	[thread overview]
Message-ID: <1625791.nSucaqoEJ0@pebbles> (raw)
In-Reply-To: <1510270833.2624.52.camel@hadess.net>

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]

On Friday, November 10, 2017 12:40:33 AM CET Bastien Nocera wrote:
> On Thu, 2017-11-09 at 23:44 +0100, Stefan Brüns wrote:
> > The Lenovo Helix 2 and Dell XPS 12 (9Q33) have an extra button on the
> > front showing a 'Windows' logo, both reporting event codes 0xC2/0xC3
> > on press/release. On the Dell, both press/release are distinct events
> > while on the Helix 2 both events are generated on release.
> > 
> > Tested on XPS 12, for info on the Helix 2 see:
> > https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html
> > 
> > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
> 
> Same problem as mentioned in patch 3. Pretty sure you need to set the
> Windows key release to KEY_IGNORE.
> 
> Or better, teach the intel-vbtn driver which buttons should be
> autoreleased, and which ones should send key presses and key releases
> separately. This would allow handling long presses in the upper layers.

First, I explicitly mentioned on the XPS 12, press/release are distinct 
events. Care to read?

Second, if you read patch 2/5, you see support for press/release vs 
autorelease.

Regards,

Stefan

-- 
Stefan Brüns  /  Bergstraße 21  /  52062 Aachen
home: +49 241 53809034     mobile: +49 151 50412019

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]