From: "Stefan Brüns" <stefan.bruens@rwth-aachen.de> To: <platform-driver-x86@vger.kernel.org> Cc: linux-input@vger.kernel.org, "Stefan Brüns" <stefan.bruens@rwth-aachen.de>, "AceLan Kao" <acelan.kao@canonical.com>, "Andy Shevchenko" <andy@infradead.org>, "Darren Hart" <dvhart@infradead.org>, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/5] platform/x86: intel-vbtn: support SW_TABLET_MODE Date: Thu, 9 Nov 2017 23:44:32 +0100 [thread overview] Message-ID: <fb108f3b-7774-4caa-a5fb-daa50399163a@rwthex-w2-a.rwth-ad.de> (raw) In-Reply-To: <20171109224436.16472-1-stefan.bruens@rwth-aachen.de> Event code 0xcc is emitted by several convertibles (Dell XPS 12 9Q33 BIOS A8, Dell XPS 13 2in1 9365, HP Spectre x360, Lenovo Thinkpad Helix) when entering tablet mode, and 0xcd on return to laptop mode. Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> --- Changes in v2: - Correct whitespace in key_entry struct The changes where tested on an XPS 12 with BIOS version A8 (2015-03-03). An earlier BIOS version (A2, ~2013) did not report event, at least not using the INT33D6 plattform device. There are other convertible laptops apparenly using the same event codes: https://wiki.gentoo.org/wiki/HP_Spectre_x360_(2015) https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1678200 https://forums.opensuse.org/showthread.php/526850-Touchpad-and-trackpoint-no-longer-working-after-reattaching-convertible-keyboard --- drivers/platform/x86/intel-vbtn.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c index 58c5ff36523a..ae55be91a64b 100644 --- a/drivers/platform/x86/intel-vbtn.c +++ b/drivers/platform/x86/intel-vbtn.c @@ -42,6 +42,8 @@ static const struct key_entry intel_vbtn_keymap[] = { { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key release */ { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } }, /* volume-down key press */ { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */ + { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet */ + { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Laptop */ { KE_END }, }; -- 2.15.0
WARNING: multiple messages have this Message-ID (diff)
From: "Stefan Brüns" <stefan.bruens@rwth-aachen.de> To: platform-driver-x86@vger.kernel.org Cc: linux-input@vger.kernel.org, "Stefan Brüns" <stefan.bruens@rwth-aachen.de>, "AceLan Kao" <acelan.kao@canonical.com>, "Andy Shevchenko" <andy@infradead.org>, "Darren Hart" <dvhart@infradead.org>, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/5] platform/x86: intel-vbtn: support SW_TABLET_MODE Date: Thu, 9 Nov 2017 23:44:32 +0100 [thread overview] Message-ID: <fb108f3b-7774-4caa-a5fb-daa50399163a@rwthex-w2-a.rwth-ad.de> (raw) In-Reply-To: <20171109224436.16472-1-stefan.bruens@rwth-aachen.de> Event code 0xcc is emitted by several convertibles (Dell XPS 12 9Q33 BIOS A8, Dell XPS 13 2in1 9365, HP Spectre x360, Lenovo Thinkpad Helix) when entering tablet mode, and 0xcd on return to laptop mode. Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> --- Changes in v2: - Correct whitespace in key_entry struct The changes where tested on an XPS 12 with BIOS version A8 (2015-03-03). An earlier BIOS version (A2, ~2013) did not report event, at least not using the INT33D6 plattform device. There are other convertible laptops apparenly using the same event codes: https://wiki.gentoo.org/wiki/HP_Spectre_x360_(2015) https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1678200 https://forums.opensuse.org/showthread.php/526850-Touchpad-and-trackpoint-no-longer-working-after-reattaching-convertible-keyboard --- drivers/platform/x86/intel-vbtn.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c index 58c5ff36523a..ae55be91a64b 100644 --- a/drivers/platform/x86/intel-vbtn.c +++ b/drivers/platform/x86/intel-vbtn.c @@ -42,6 +42,8 @@ static const struct key_entry intel_vbtn_keymap[] = { { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key release */ { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } }, /* volume-down key press */ { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */ + { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet */ + { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Laptop */ { KE_END }, }; -- 2.15.0
next parent reply other threads:[~2017-11-09 22:46 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20171109224436.16472-1-stefan.bruens@rwth-aachen.de> 2017-11-09 22:44 ` Stefan Brüns [this message] 2017-11-09 22:44 ` [PATCH v2 1/5] platform/x86: intel-vbtn: support SW_TABLET_MODE Stefan Brüns 2017-11-09 22:44 ` [PATCH v2 2/5] platform/x86: intel-vbtn: Support separate press/release events Stefan Brüns 2017-11-09 22:44 ` Stefan Brüns 2017-11-10 1:34 ` Darren Hart 2017-11-10 1:58 ` Stefan Brüns 2017-11-10 1:58 ` Stefan Brüns 2017-11-10 2:11 ` Darren Hart 2017-11-10 2:44 ` Stefan Brüns 2017-11-10 2:44 ` Stefan Brüns 2017-11-10 2:15 ` Darren Hart 2017-12-08 20:33 ` Stefan Brüns 2017-12-08 20:33 ` Stefan Brüns 2017-11-09 22:44 ` [PATCH v2 3/5] Input: add KEY_ROTATE_LOCK_TOGGLE Stefan Brüns 2017-11-09 22:44 ` Stefan Brüns 2017-11-09 23:34 ` Bastien Nocera 2017-11-30 17:51 ` Brüns, Stefan 2017-11-30 17:51 ` Brüns, Stefan 2017-12-05 18:50 ` Jason Gerecke 2017-12-05 18:50 ` Jason Gerecke 2018-01-25 16:23 ` Jason Gerecke 2017-11-10 1:41 ` Darren Hart 2017-11-09 22:44 ` [PATCH v2 4/5] platform/x86: intel-vbtn: support KEY_ROTATE_LOCK_TOGGLE Stefan Brüns 2017-11-09 22:44 ` Stefan Brüns 2017-11-09 23:30 ` Bastien Nocera 2017-11-09 23:46 ` Darren Hart 2017-11-10 0:23 ` Stefan Brüns 2017-11-10 0:23 ` Stefan Brüns 2017-11-10 0:15 ` Stefan Brüns 2017-11-10 0:15 ` Stefan Brüns 2017-11-10 0:39 ` Bastien Nocera 2017-11-10 0:39 ` Bastien Nocera 2017-11-10 0:53 ` Darren Hart 2017-11-10 1:54 ` Darren Hart 2017-11-10 2:20 ` Stefan Brüns 2017-11-10 2:20 ` Stefan Brüns 2017-11-09 22:44 ` [PATCH v2 5/5] platform/x86: intel-vbtn: support panel front button Stefan Brüns 2017-11-09 22:44 ` Stefan Brüns 2017-11-09 23:40 ` Bastien Nocera 2017-11-10 0:21 ` Stefan Brüns 2017-11-10 0:21 ` Stefan Brüns
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fb108f3b-7774-4caa-a5fb-daa50399163a@rwthex-w2-a.rwth-ad.de \ --to=stefan.bruens@rwth-aachen.de \ --cc=acelan.kao@canonical.com \ --cc=andy@infradead.org \ --cc=dvhart@infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=platform-driver-x86@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.