From: "Stefan Brüns" <stefan.bruens@rwth-aachen.de> To: Darren Hart <dvhart@infradead.org> Cc: Bastien Nocera <hadess@hadess.net>, <platform-driver-x86@vger.kernel.org>, <linux-input@vger.kernel.org>, AceLan Kao <acelan.kao@canonical.com>, "Andy Shevchenko" <andy@infradead.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2 4/5] platform/x86: intel-vbtn: support KEY_ROTATE_LOCK_TOGGLE Date: Fri, 10 Nov 2017 01:23:13 +0100 [thread overview] Message-ID: <1643367.Hfkyk2hqTC@pebbles> (raw) In-Reply-To: <20171109234630.GG21449@fury> [-- Attachment #1: Type: text/plain, Size: 2091 bytes --] On Friday, November 10, 2017 12:46:30 AM CET Darren Hart wrote: > On Fri, Nov 10, 2017 at 12:30:46AM +0100, Bastien Nocera wrote: > > On Thu, 2017-11-09 at 23:44 +0100, Stefan Brüns wrote: > > > The Rotate Lock button event is emitted on the XPS 12 (BIOS A8, but > > > not > > > on BIOS A2). > > > > > > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> > > > --- > > > > > > Changes in v2: > > > - Emit KEY_ROTATE_LOCK_TOGGLE instead of KEY_ROTATE_DISPLAY > > > - Use separate up/down events > > > > > > drivers/platform/x86/intel-vbtn.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/platform/x86/intel-vbtn.c > > > b/drivers/platform/x86/intel-vbtn.c index e3f6375af85c..a484bcc6393b > > > 100644 > > > --- a/drivers/platform/x86/intel-vbtn.c > > > +++ b/drivers/platform/x86/intel-vbtn.c > > > @@ -42,6 +42,8 @@ static const struct key_entry intel_vbtn_keymap[] = { > > > > > > { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key release */ > > > { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } }, /* volume-down key press */ > > > { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */ > > > > > > + { KE_KEY, 0xC8, { KEY_ROTATE_LOCK_TOGGLE } }, /* rotate-lock key > > > press */ + { KE_KEY, 0xC9, { KEY_ROTATE_LOCK_TOGGLE } }, /* > > > rotate-lock key release */> > > How are those events sent? When pressing and releasing the key, do you > > receive 0xC8 followed by 0xC9? Or do you receive 0xC8 when pressing and > > releasing the first time, and 0xC9 when pressing and releasing a second > > time? > > > > If the former, then it's not going to work. The release is supposed to > > be ignored, as you send the event with sparse_keymap_report_event(). > > I expect the former, which is consistent with the volume keys preceding it > (also ignoring the release). Read the whole series and the cover letter, and stop making assumptions. Regards, Stefan -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019 [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 195 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Stefan Brüns" <stefan.bruens@rwth-aachen.de> To: Darren Hart <dvhart@infradead.org> Cc: Bastien Nocera <hadess@hadess.net>, platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org, AceLan Kao <acelan.kao@canonical.com>, Andy Shevchenko <andy@infradead.org>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] platform/x86: intel-vbtn: support KEY_ROTATE_LOCK_TOGGLE Date: Fri, 10 Nov 2017 01:23:13 +0100 [thread overview] Message-ID: <1643367.Hfkyk2hqTC@pebbles> (raw) In-Reply-To: <20171109234630.GG21449@fury> [-- Attachment #1: Type: text/plain, Size: 2091 bytes --] On Friday, November 10, 2017 12:46:30 AM CET Darren Hart wrote: > On Fri, Nov 10, 2017 at 12:30:46AM +0100, Bastien Nocera wrote: > > On Thu, 2017-11-09 at 23:44 +0100, Stefan Brüns wrote: > > > The Rotate Lock button event is emitted on the XPS 12 (BIOS A8, but > > > not > > > on BIOS A2). > > > > > > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> > > > --- > > > > > > Changes in v2: > > > - Emit KEY_ROTATE_LOCK_TOGGLE instead of KEY_ROTATE_DISPLAY > > > - Use separate up/down events > > > > > > drivers/platform/x86/intel-vbtn.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/platform/x86/intel-vbtn.c > > > b/drivers/platform/x86/intel-vbtn.c index e3f6375af85c..a484bcc6393b > > > 100644 > > > --- a/drivers/platform/x86/intel-vbtn.c > > > +++ b/drivers/platform/x86/intel-vbtn.c > > > @@ -42,6 +42,8 @@ static const struct key_entry intel_vbtn_keymap[] = { > > > > > > { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key release */ > > > { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } }, /* volume-down key press */ > > > { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */ > > > > > > + { KE_KEY, 0xC8, { KEY_ROTATE_LOCK_TOGGLE } }, /* rotate-lock key > > > press */ + { KE_KEY, 0xC9, { KEY_ROTATE_LOCK_TOGGLE } }, /* > > > rotate-lock key release */> > > How are those events sent? When pressing and releasing the key, do you > > receive 0xC8 followed by 0xC9? Or do you receive 0xC8 when pressing and > > releasing the first time, and 0xC9 when pressing and releasing a second > > time? > > > > If the former, then it's not going to work. The release is supposed to > > be ignored, as you send the event with sparse_keymap_report_event(). > > I expect the former, which is consistent with the volume keys preceding it > (also ignoring the release). Read the whole series and the cover letter, and stop making assumptions. Regards, Stefan -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019 [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2017-11-10 0:23 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20171109224436.16472-1-stefan.bruens@rwth-aachen.de> 2017-11-09 22:44 ` [PATCH v2 1/5] platform/x86: intel-vbtn: support SW_TABLET_MODE Stefan Brüns 2017-11-09 22:44 ` Stefan Brüns 2017-11-09 22:44 ` [PATCH v2 2/5] platform/x86: intel-vbtn: Support separate press/release events Stefan Brüns 2017-11-09 22:44 ` Stefan Brüns 2017-11-10 1:34 ` Darren Hart 2017-11-10 1:58 ` Stefan Brüns 2017-11-10 1:58 ` Stefan Brüns 2017-11-10 2:11 ` Darren Hart 2017-11-10 2:44 ` Stefan Brüns 2017-11-10 2:44 ` Stefan Brüns 2017-11-10 2:15 ` Darren Hart 2017-12-08 20:33 ` Stefan Brüns 2017-12-08 20:33 ` Stefan Brüns 2017-11-09 22:44 ` [PATCH v2 3/5] Input: add KEY_ROTATE_LOCK_TOGGLE Stefan Brüns 2017-11-09 22:44 ` Stefan Brüns 2017-11-09 23:34 ` Bastien Nocera 2017-11-30 17:51 ` Brüns, Stefan 2017-11-30 17:51 ` Brüns, Stefan 2017-12-05 18:50 ` Jason Gerecke 2017-12-05 18:50 ` Jason Gerecke 2018-01-25 16:23 ` Jason Gerecke 2017-11-10 1:41 ` Darren Hart 2017-11-09 22:44 ` [PATCH v2 4/5] platform/x86: intel-vbtn: support KEY_ROTATE_LOCK_TOGGLE Stefan Brüns 2017-11-09 22:44 ` Stefan Brüns 2017-11-09 23:30 ` Bastien Nocera 2017-11-09 23:46 ` Darren Hart 2017-11-10 0:23 ` Stefan Brüns [this message] 2017-11-10 0:23 ` Stefan Brüns 2017-11-10 0:15 ` Stefan Brüns 2017-11-10 0:15 ` Stefan Brüns 2017-11-10 0:39 ` Bastien Nocera 2017-11-10 0:39 ` Bastien Nocera 2017-11-10 0:53 ` Darren Hart 2017-11-10 1:54 ` Darren Hart 2017-11-10 2:20 ` Stefan Brüns 2017-11-10 2:20 ` Stefan Brüns 2017-11-09 22:44 ` [PATCH v2 5/5] platform/x86: intel-vbtn: support panel front button Stefan Brüns 2017-11-09 22:44 ` Stefan Brüns 2017-11-09 23:40 ` Bastien Nocera 2017-11-10 0:21 ` Stefan Brüns 2017-11-10 0:21 ` Stefan Brüns
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1643367.Hfkyk2hqTC@pebbles \ --to=stefan.bruens@rwth-aachen.de \ --cc=acelan.kao@canonical.com \ --cc=andy@infradead.org \ --cc=dvhart@infradead.org \ --cc=hadess@hadess.net \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=platform-driver-x86@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.