From: Marc Zyngier <maz@kernel.org> To: Leo Li <leoyang.li@nxp.com> Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>, "Biwen Li (OSS)" <biwen.li@oss.nxp.com>, shawnguo@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, "Z.q. Hou" <zhiqiang.hou@nxp.com>, tglx@linutronix.de, jason@lakedaemon.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jiafei Pan <jiafei.pan@nxp.com>, Xiaobo Xie <xiaobo.xie@nxp.com>, linux-arm-kernel@lists.infradead.org, Biwen Li <biwen.li@nxp.com> Subject: Re: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt Date: Mon, 26 Oct 2020 15:42:34 +0000 [thread overview] Message-ID: <19b5f5e7bd5e7a41621ecad2239e4bd6@kernel.org> (raw) In-Reply-To: <VE1PR04MB668737DF1DDA6E1007BCA24C8F190@VE1PR04MB6687.eurprd04.prod.outlook.com> On 2020-10-26 15:06, Leo Li wrote: >> -----Original Message----- >> From: Marc Zyngier <maz@kernel.org> >> Sent: Monday, October 26, 2020 4:23 AM >> To: Rasmus Villemoes <linux@rasmusvillemoes.dk> >> Cc: Biwen Li (OSS) <biwen.li@oss.nxp.com>; shawnguo@kernel.org; >> robh+dt@kernel.org; mark.rutland@arm.com; Leo Li <leoyang.li@nxp.com>; >> Z.q. Hou <zhiqiang.hou@nxp.com>; tglx@linutronix.de; >> jason@lakedaemon.net; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; Jiafei Pan <jiafei.pan@nxp.com>; Xiaobo Xie >> <xiaobo.xie@nxp.com>; linux-arm-kernel@lists.infradead.org; Biwen Li >> <biwen.li@nxp.com> >> Subject: Re: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A >> external >> interrupt >> >> On 2020-10-26 09:06, Rasmus Villemoes wrote: >> > On 26/10/2020 09.44, Marc Zyngier wrote: >> >> On 2020-10-26 08:01, Biwen Li wrote: >> >>> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> >> >>> >> >>> Add an new IRQ chip declaration for LS1043A and LS1088A >> >>> - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A >> >>> - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA >> >> >> >> Three things: >> >> - This commit message doesn't describe the bit_reverse change >> > >> > Yeah, please elaborate on that, as the RM for 1043 or 1046 doesn't >> > mention anything about bit reversal for the scfg registers - they >> > don't seem to have the utter nonsense that is SCFG_SCFGREVCR, but >> > perhaps, instead of removing it, that has just become a hard-coded >> > part of the IP. >> > >> > Also, IANAL etc., but >> > >> >>> +// Copyright 2019-2020 NXP >> > >> > really? Seems to be a bit of a stretch. >> > >> > At the very least, cc'ing the original author and only person to ever >> > touch that file would have been appreciated. >> >> Huh. Well spotted. That's definitely not on. >> NXP people, please talk to your legal department. > > We do have an internal policy to require developer adding/updating NXP > copyright on non-trivial changes. I'm not sure if this change should > be considered trivial, but adding copyright claim on a file without > prior copyright claims could causing confusion like in this case. The copyright exists implicitly, and doesn't require a copyright claim in the file itself. Please talk to your legal department. > One > potential solution is to add a more specific description on the NXP > change together with the copyright claim. But maybe an easier > solution is to add Rasmus your Copyright claim first if you are ok > with it. That's for Rasmus to decide whether he wants to add such a claim, given that it exists implicitly. Adding copyright claims for any odd change you make isn't acceptable either (your changes are already unambiguously identified in git). For the time being, I'm not taking any NXP patch carrying additional copyright update until this is clarified. M. -- Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org> To: Leo Li <leoyang.li@nxp.com> Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, jason@lakedaemon.net, Biwen Li <biwen.li@nxp.com>, "Z.q. Hou" <zhiqiang.hou@nxp.com>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-kernel@vger.kernel.org, "Biwen Li \(OSS\)" <biwen.li@oss.nxp.com>, Xiaobo Xie <xiaobo.xie@nxp.com>, robh+dt@kernel.org, tglx@linutronix.de, shawnguo@kernel.org, Jiafei Pan <jiafei.pan@nxp.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt Date: Mon, 26 Oct 2020 15:42:34 +0000 [thread overview] Message-ID: <19b5f5e7bd5e7a41621ecad2239e4bd6@kernel.org> (raw) In-Reply-To: <VE1PR04MB668737DF1DDA6E1007BCA24C8F190@VE1PR04MB6687.eurprd04.prod.outlook.com> On 2020-10-26 15:06, Leo Li wrote: >> -----Original Message----- >> From: Marc Zyngier <maz@kernel.org> >> Sent: Monday, October 26, 2020 4:23 AM >> To: Rasmus Villemoes <linux@rasmusvillemoes.dk> >> Cc: Biwen Li (OSS) <biwen.li@oss.nxp.com>; shawnguo@kernel.org; >> robh+dt@kernel.org; mark.rutland@arm.com; Leo Li <leoyang.li@nxp.com>; >> Z.q. Hou <zhiqiang.hou@nxp.com>; tglx@linutronix.de; >> jason@lakedaemon.net; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; Jiafei Pan <jiafei.pan@nxp.com>; Xiaobo Xie >> <xiaobo.xie@nxp.com>; linux-arm-kernel@lists.infradead.org; Biwen Li >> <biwen.li@nxp.com> >> Subject: Re: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A >> external >> interrupt >> >> On 2020-10-26 09:06, Rasmus Villemoes wrote: >> > On 26/10/2020 09.44, Marc Zyngier wrote: >> >> On 2020-10-26 08:01, Biwen Li wrote: >> >>> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> >> >>> >> >>> Add an new IRQ chip declaration for LS1043A and LS1088A >> >>> - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A >> >>> - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA >> >> >> >> Three things: >> >> - This commit message doesn't describe the bit_reverse change >> > >> > Yeah, please elaborate on that, as the RM for 1043 or 1046 doesn't >> > mention anything about bit reversal for the scfg registers - they >> > don't seem to have the utter nonsense that is SCFG_SCFGREVCR, but >> > perhaps, instead of removing it, that has just become a hard-coded >> > part of the IP. >> > >> > Also, IANAL etc., but >> > >> >>> +// Copyright 2019-2020 NXP >> > >> > really? Seems to be a bit of a stretch. >> > >> > At the very least, cc'ing the original author and only person to ever >> > touch that file would have been appreciated. >> >> Huh. Well spotted. That's definitely not on. >> NXP people, please talk to your legal department. > > We do have an internal policy to require developer adding/updating NXP > copyright on non-trivial changes. I'm not sure if this change should > be considered trivial, but adding copyright claim on a file without > prior copyright claims could causing confusion like in this case. The copyright exists implicitly, and doesn't require a copyright claim in the file itself. Please talk to your legal department. > One > potential solution is to add a more specific description on the NXP > change together with the copyright claim. But maybe an easier > solution is to add Rasmus your Copyright claim first if you are ok > with it. That's for Rasmus to decide whether he wants to add such a claim, given that it exists implicitly. Adding copyright claims for any odd change you make isn't acceptable either (your changes are already unambiguously identified in git). For the time being, I'm not taking any NXP patch carrying additional copyright update until this is clarified. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-26 15:42 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-26 8:01 [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt Biwen Li 2020-10-26 8:01 ` Biwen Li 2020-10-26 8:01 ` [RESEND 02/11] arm64: dts: ls1043a: add DT node for external interrupt lines Biwen Li 2020-10-26 8:01 ` Biwen Li 2020-10-26 8:01 ` [RESEND 03/11] arm64: dts: ls1046a: " Biwen Li 2020-10-26 8:01 ` Biwen Li 2020-10-26 8:01 ` [RESEND 04/11] arm64: dts: ls1046ardb: Add interrupt line for RTC node Biwen Li 2020-10-26 8:01 ` Biwen Li 2020-10-26 8:01 ` [RESEND 05/11] arm64: dts: ls1088a: add DT node for external interrupt lines Biwen Li 2020-10-26 8:01 ` Biwen Li 2020-10-26 8:01 ` [RESEND 06/11] arm64: dts: ls1088ardb: fix interrupt line for RTC node Biwen Li 2020-10-26 8:01 ` Biwen Li 2020-10-26 8:01 ` [RESEND 07/11] arm64: dts: ls208xa: add DT node for external interrupt lines Biwen Li 2020-10-26 8:01 ` Biwen Li 2020-10-26 8:01 ` [RESEND 08/11] arm64: dts: ls208xa-rdb: add interrupt line for RTC node Biwen Li 2020-10-26 8:01 ` Biwen Li 2020-10-26 8:01 ` [RESEND 09/11] arm64: dts: lx2160a: add DT node for external interrupt lines Biwen Li 2020-10-26 8:01 ` Biwen Li 2020-10-26 8:01 ` [RESEND 10/11] arm64: dts: lx2160ardb: fix interrupt line for RTC node Biwen Li 2020-10-26 8:01 ` Biwen Li 2020-10-26 8:01 ` [RESEND 11/11] dt-bindings: interrupt-controller: update bindings for supporting more SoCs Biwen Li 2020-10-26 8:01 ` Biwen Li 2020-10-26 8:44 ` [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt Marc Zyngier 2020-10-26 8:44 ` Marc Zyngier 2020-10-26 9:06 ` Rasmus Villemoes 2020-10-26 9:06 ` Rasmus Villemoes 2020-10-26 9:22 ` Marc Zyngier 2020-10-26 9:22 ` Marc Zyngier 2020-10-26 15:06 ` Leo Li 2020-10-26 15:06 ` Leo Li 2020-10-26 15:42 ` Marc Zyngier [this message] 2020-10-26 15:42 ` Marc Zyngier 2020-10-27 3:14 ` Biwen Li 2020-10-27 3:14 ` Biwen Li 2020-10-27 3:25 ` Biwen Li (OSS) 2020-10-27 3:25 ` Biwen Li (OSS)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=19b5f5e7bd5e7a41621ecad2239e4bd6@kernel.org \ --to=maz@kernel.org \ --cc=biwen.li@nxp.com \ --cc=biwen.li@oss.nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=jason@lakedaemon.net \ --cc=jiafei.pan@nxp.com \ --cc=leoyang.li@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@rasmusvillemoes.dk \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=shawnguo@kernel.org \ --cc=tglx@linutronix.de \ --cc=xiaobo.xie@nxp.com \ --cc=zhiqiang.hou@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.