From: Greg Ungerer <gregungerer00@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: uclinux-h8-devel@lists.sourceforge.jp,
linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 04/15] binfmt_flat: remove flat_old_ram_flag
Date: Tue, 11 Jun 2019 13:07:36 +0000 [thread overview]
Message-ID: <1aaf5ce2-1e7a-e818-fbeb-42fbe551a108@linux-m68k.org> (raw)
In-Reply-To: <20190611073648.GA21522@lst.de>
On 11/6/19 5:36 pm, Christoph Hellwig wrote:
> On Tue, Jun 11, 2019 at 04:04:39PM +1000, Greg Ungerer wrote:
>>> index c0e4535dc1ec..18d82fd5f57c 100644
>>> --- a/fs/binfmt_flat.c
>>> +++ b/fs/binfmt_flat.c
>>> @@ -488,7 +488,8 @@ static int load_flat_file(struct linux_binprm *bprm,
>>> * fix up the flags for the older format, there were all kinds
>>> * of endian hacks, this only works for the simple cases
>>> */
>>> - if (rev = OLD_FLAT_VERSION && flat_old_ram_flag(flags))
>>> + if (IS_ENABLED(CONFIG_BINFMT_FLAT_OLD_ALWAYS_RAM) &&
>>> + rev = OLD_FLAT_VERSION)
>>
>> The flags are from the binary file header here, so this is going to lose
>> that check for most platforms (except h8300 where it would always have
>> been true).
>
> Indeed. The old code is:
>
> if (rev = OLD_FLAT_VERSION && flat_old_ram_flag(flags))
> flags = FLAT_FLAG_RAM;
>
> which for !h8300 evaluates to:
>
> if (rev = OLD_FLAT_VERSION && flags)
> flags = FLAT_FLAG_RAM;
>
> so basically if any flag was set it was turned into FLAT_FLAG_RAM.
> Was that really intentional?
Probably not, looking at the flags. For the compressed flag it
makes some sense. But I don't think many of the others need load
to RAM behavior.
> I guess even if it wasn't the is no
> point in changing this historic behavior now.
>
> So I guess what we could do it something like:
>
> if (rev = OLD_FLAT_VERSION &&
> (flags || IS_ENABLED(CONFIG_BINFMT_FLAT_OLD_ALWAYS_RAM)))
> flags = FLAT_FLAG_RAM;
Yeah, that to looks to preserve the old behavior.
Regards
Greg
WARNING: multiple messages have this Message-ID (diff)
From: Greg Ungerer <gregungerer00@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Michal Simek <monstr@monstr.eu>,
linux-arm-kernel@lists.infradead.org,
linux-c6x-dev@linux-c6x.org,
uclinux-h8-devel@lists.sourceforge.jp,
linux-m68k@lists.linux-m68k.org, linux-riscv@lists.infradead.org,
linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/15] binfmt_flat: remove flat_old_ram_flag
Date: Tue, 11 Jun 2019 23:07:36 +1000 [thread overview]
Message-ID: <1aaf5ce2-1e7a-e818-fbeb-42fbe551a108@linux-m68k.org> (raw)
In-Reply-To: <20190611073648.GA21522@lst.de>
On 11/6/19 5:36 pm, Christoph Hellwig wrote:
> On Tue, Jun 11, 2019 at 04:04:39PM +1000, Greg Ungerer wrote:
>>> index c0e4535dc1ec..18d82fd5f57c 100644
>>> --- a/fs/binfmt_flat.c
>>> +++ b/fs/binfmt_flat.c
>>> @@ -488,7 +488,8 @@ static int load_flat_file(struct linux_binprm *bprm,
>>> * fix up the flags for the older format, there were all kinds
>>> * of endian hacks, this only works for the simple cases
>>> */
>>> - if (rev == OLD_FLAT_VERSION && flat_old_ram_flag(flags))
>>> + if (IS_ENABLED(CONFIG_BINFMT_FLAT_OLD_ALWAYS_RAM) &&
>>> + rev == OLD_FLAT_VERSION)
>>
>> The flags are from the binary file header here, so this is going to lose
>> that check for most platforms (except h8300 where it would always have
>> been true).
>
> Indeed. The old code is:
>
> if (rev == OLD_FLAT_VERSION && flat_old_ram_flag(flags))
> flags = FLAT_FLAG_RAM;
>
> which for !h8300 evaluates to:
>
> if (rev == OLD_FLAT_VERSION && flags)
> flags = FLAT_FLAG_RAM;
>
> so basically if any flag was set it was turned into FLAT_FLAG_RAM.
> Was that really intentional?
Probably not, looking at the flags. For the compressed flag it
makes some sense. But I don't think many of the others need load
to RAM behavior.
> I guess even if it wasn't the is no
> point in changing this historic behavior now.
>
> So I guess what we could do it something like:
>
> if (rev == OLD_FLAT_VERSION &&
> (flags || IS_ENABLED(CONFIG_BINFMT_FLAT_OLD_ALWAYS_RAM)))
> flags = FLAT_FLAG_RAM;
Yeah, that to looks to preserve the old behavior.
Regards
Greg
WARNING: multiple messages have this Message-ID (diff)
From: Greg Ungerer <gregungerer00@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: uclinux-h8-devel@lists.sourceforge.jp,
linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 04/15] binfmt_flat: remove flat_old_ram_flag
Date: Tue, 11 Jun 2019 23:07:36 +1000 [thread overview]
Message-ID: <1aaf5ce2-1e7a-e818-fbeb-42fbe551a108@linux-m68k.org> (raw)
In-Reply-To: <20190611073648.GA21522@lst.de>
On 11/6/19 5:36 pm, Christoph Hellwig wrote:
> On Tue, Jun 11, 2019 at 04:04:39PM +1000, Greg Ungerer wrote:
>>> index c0e4535dc1ec..18d82fd5f57c 100644
>>> --- a/fs/binfmt_flat.c
>>> +++ b/fs/binfmt_flat.c
>>> @@ -488,7 +488,8 @@ static int load_flat_file(struct linux_binprm *bprm,
>>> * fix up the flags for the older format, there were all kinds
>>> * of endian hacks, this only works for the simple cases
>>> */
>>> - if (rev == OLD_FLAT_VERSION && flat_old_ram_flag(flags))
>>> + if (IS_ENABLED(CONFIG_BINFMT_FLAT_OLD_ALWAYS_RAM) &&
>>> + rev == OLD_FLAT_VERSION)
>>
>> The flags are from the binary file header here, so this is going to lose
>> that check for most platforms (except h8300 where it would always have
>> been true).
>
> Indeed. The old code is:
>
> if (rev == OLD_FLAT_VERSION && flat_old_ram_flag(flags))
> flags = FLAT_FLAG_RAM;
>
> which for !h8300 evaluates to:
>
> if (rev == OLD_FLAT_VERSION && flags)
> flags = FLAT_FLAG_RAM;
>
> so basically if any flag was set it was turned into FLAT_FLAG_RAM.
> Was that really intentional?
Probably not, looking at the flags. For the compressed flag it
makes some sense. But I don't think many of the others need load
to RAM behavior.
> I guess even if it wasn't the is no
> point in changing this historic behavior now.
>
> So I guess what we could do it something like:
>
> if (rev == OLD_FLAT_VERSION &&
> (flags || IS_ENABLED(CONFIG_BINFMT_FLAT_OLD_ALWAYS_RAM)))
> flags = FLAT_FLAG_RAM;
Yeah, that to looks to preserve the old behavior.
Regards
Greg
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Greg Ungerer <gregungerer00@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: uclinux-h8-devel@lists.sourceforge.jp,
linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 04/15] binfmt_flat: remove flat_old_ram_flag
Date: Tue, 11 Jun 2019 23:07:36 +1000 [thread overview]
Message-ID: <1aaf5ce2-1e7a-e818-fbeb-42fbe551a108@linux-m68k.org> (raw)
In-Reply-To: <20190611073648.GA21522@lst.de>
On 11/6/19 5:36 pm, Christoph Hellwig wrote:
> On Tue, Jun 11, 2019 at 04:04:39PM +1000, Greg Ungerer wrote:
>>> index c0e4535dc1ec..18d82fd5f57c 100644
>>> --- a/fs/binfmt_flat.c
>>> +++ b/fs/binfmt_flat.c
>>> @@ -488,7 +488,8 @@ static int load_flat_file(struct linux_binprm *bprm,
>>> * fix up the flags for the older format, there were all kinds
>>> * of endian hacks, this only works for the simple cases
>>> */
>>> - if (rev == OLD_FLAT_VERSION && flat_old_ram_flag(flags))
>>> + if (IS_ENABLED(CONFIG_BINFMT_FLAT_OLD_ALWAYS_RAM) &&
>>> + rev == OLD_FLAT_VERSION)
>>
>> The flags are from the binary file header here, so this is going to lose
>> that check for most platforms (except h8300 where it would always have
>> been true).
>
> Indeed. The old code is:
>
> if (rev == OLD_FLAT_VERSION && flat_old_ram_flag(flags))
> flags = FLAT_FLAG_RAM;
>
> which for !h8300 evaluates to:
>
> if (rev == OLD_FLAT_VERSION && flags)
> flags = FLAT_FLAG_RAM;
>
> so basically if any flag was set it was turned into FLAT_FLAG_RAM.
> Was that really intentional?
Probably not, looking at the flags. For the compressed flag it
makes some sense. But I don't think many of the others need load
to RAM behavior.
> I guess even if it wasn't the is no
> point in changing this historic behavior now.
>
> So I guess what we could do it something like:
>
> if (rev == OLD_FLAT_VERSION &&
> (flags || IS_ENABLED(CONFIG_BINFMT_FLAT_OLD_ALWAYS_RAM)))
> flags = FLAT_FLAG_RAM;
Yeah, that to looks to preserve the old behavior.
Regards
Greg
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-11 13:07 UTC|newest]
Thread overview: 152+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 21:20 binfmt_flat cleanups and RISC-V support Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` [PATCH 01/15] binfmt_flat: remove flat_reloc_valid Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:44 ` Vladimir Murzin
2019-06-11 9:44 ` Vladimir Murzin
2019-06-11 9:44 ` Vladimir Murzin
2019-06-11 9:44 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 02/15] binfmt_flat: remove flat_set_persistent Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:45 ` Vladimir Murzin
2019-06-11 9:45 ` Vladimir Murzin
2019-06-11 9:45 ` Vladimir Murzin
2019-06-11 9:45 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 03/15] binfmt_flat: provide a default version of flat_get_relocate_addr Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:46 ` Vladimir Murzin
2019-06-11 9:46 ` Vladimir Murzin
2019-06-11 9:46 ` Vladimir Murzin
2019-06-11 9:46 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 04/15] binfmt_flat: remove flat_old_ram_flag Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 6:04 ` Greg Ungerer
2019-06-11 6:04 ` Greg Ungerer
2019-06-11 6:04 ` Greg Ungerer
2019-06-11 6:04 ` Greg Ungerer
2019-06-11 7:36 ` Christoph Hellwig
2019-06-11 7:36 ` Christoph Hellwig
2019-06-11 7:36 ` Christoph Hellwig
2019-06-11 7:36 ` Christoph Hellwig
2019-06-11 13:07 ` Greg Ungerer [this message]
2019-06-11 13:07 ` Greg Ungerer
2019-06-11 13:07 ` Greg Ungerer
2019-06-11 13:07 ` Greg Ungerer
2019-06-11 9:47 ` Vladimir Murzin
2019-06-11 9:47 ` Vladimir Murzin
2019-06-11 9:47 ` Vladimir Murzin
2019-06-11 9:47 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 05/15] binfmt_flat: replace flat_argvp_envp_on_stack with a Kconfig variable Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:49 ` Vladimir Murzin
2019-06-11 9:49 ` Vladimir Murzin
2019-06-11 9:49 ` Vladimir Murzin
2019-06-11 9:49 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 06/15] binfmt_flat: remove the uapi <linux/flat.h> header Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:51 ` Vladimir Murzin
2019-06-11 9:51 ` Vladimir Murzin
2019-06-11 9:51 ` Vladimir Murzin
2019-06-11 9:51 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 07/15] binfmt_flat: use __be32 for the on-disk format Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 8:25 ` Geert Uytterhoeven
2019-06-11 8:25 ` Geert Uytterhoeven
2019-06-11 8:25 ` Geert Uytterhoeven
2019-06-11 8:25 ` Geert Uytterhoeven
2019-06-11 9:57 ` Vladimir Murzin
2019-06-11 9:57 ` Vladimir Murzin
2019-06-11 9:57 ` Vladimir Murzin
2019-06-11 9:57 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 08/15] binfmt_flat: add endianess annotations Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:58 ` Vladimir Murzin
2019-06-11 9:58 ` Vladimir Murzin
2019-06-11 9:58 ` Vladimir Murzin
2019-06-11 9:58 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 09/15] binfmt_flat: add a ARCH_HAS_BINFMT_FLAT option Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:59 ` Vladimir Murzin
2019-06-11 9:59 ` Vladimir Murzin
2019-06-11 9:59 ` Vladimir Murzin
2019-06-11 9:59 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 10/15] binfmt_flat: make support for old format binaries optional Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` [PATCH 11/15] binfmt_flat: provide an asm-generic/flat.h Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 10:01 ` Vladimir Murzin
2019-06-11 10:01 ` Vladimir Murzin
2019-06-11 10:01 ` Vladimir Murzin
2019-06-11 10:01 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 12/15] binfmt_flat: remove the persistent argument from flat_get_addr_from_rp Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` [PATCH 13/15] binfmt_flat: move the MAX_SHARED_LIBS definition to binfmt_flat.c Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` [PATCH 14/15] binfmt_flat: don't offset the data start Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` [PATCH 15/15] riscv: add binfmt_flat support Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 8:16 ` Vladimir Murzin
2019-06-11 8:16 ` Vladimir Murzin
2019-06-11 8:16 ` Vladimir Murzin
2019-06-11 8:16 ` Vladimir Murzin
2019-06-11 9:20 ` Christoph Hellwig
2019-06-11 9:20 ` Christoph Hellwig
2019-06-11 9:20 ` Christoph Hellwig
2019-06-11 9:20 ` Christoph Hellwig
2019-06-11 6:51 ` binfmt_flat cleanups and RISC-V support Greg Ungerer
2019-06-11 6:51 ` Greg Ungerer
2019-06-11 6:51 ` Greg Ungerer
2019-06-11 6:51 ` Greg Ungerer
2019-06-11 7:38 ` Christoph Hellwig
2019-06-11 7:38 ` Christoph Hellwig
2019-06-11 7:38 ` Christoph Hellwig
2019-06-11 7:38 ` Christoph Hellwig
2019-06-11 13:02 ` Greg Ungerer
2019-06-11 13:02 ` Greg Ungerer
2019-06-11 13:02 ` Greg Ungerer
2019-06-11 13:02 ` Greg Ungerer
2019-06-11 8:05 ` Vladimir Murzin
2019-06-11 8:05 ` Vladimir Murzin
2019-06-11 8:05 ` Vladimir Murzin
2019-06-11 8:05 ` Vladimir Murzin
2019-06-11 8:11 ` Christoph Hellwig
2019-06-11 8:11 ` Christoph Hellwig
2019-06-11 8:11 ` Christoph Hellwig
2019-06-11 8:11 ` Christoph Hellwig
2019-06-11 10:08 ` Vladimir Murzin
2019-06-11 10:08 ` Vladimir Murzin
2019-06-11 10:08 ` Vladimir Murzin
2019-06-11 10:08 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aaf5ce2-1e7a-e818-fbeb-42fbe551a108@linux-m68k.org \
--to=gregungerer00@gmail.com \
--cc=hch@lst.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=monstr@monstr.eu \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.