From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Christoph Hellwig <hch@lst.de>, Greg Ungerer <gerg@linux-m68k.org>
Cc: uclinux-h8-devel@lists.sourceforge.jp,
linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 15/15] riscv: add binfmt_flat support
Date: Tue, 11 Jun 2019 08:16:43 +0000 [thread overview]
Message-ID: <d8d81820-8f0d-d5d0-fa3d-3376ddcc5358@arm.com> (raw)
In-Reply-To: <20190610212015.9157-16-hch@lst.de>
On 6/10/19 10:20 PM, Christoph Hellwig wrote:
> Use the generic support with arguments are on the stack. Same as arm
> and m68k.
Out of curiosity, what is reason for keeping arguments on the stack?
ARM port of uClibc has following comment around manipulating of argv/argc:
/*
* uClinux/arm stacks look a little different from normal
* MMU-full Linux/arm stacks (for no good reason)
*/
So I though it is kind of legacy.
Thanks
Vladimir
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/riscv/Kconfig | 2 ++
> arch/riscv/include/asm/Kbuild | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 0c4b12205632..2e3b60cdeef4 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -17,7 +17,9 @@ config RISCV
> select OF
> select OF_EARLY_FLATTREE
> select OF_IRQ
> + select ARCH_HAS_BINFMT_FLAT
> select ARCH_WANT_FRAME_POINTERS
> + select BINFMT_FLAT_ARGVP_ENVP_ON_STACK
> select CLONE_BACKWARDS
> select COMMON_CLK
> select GENERIC_CLOCKEVENTS
> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> index 5ee646619cc3..1efaeddf1e4b 100644
> --- a/arch/riscv/include/asm/Kbuild
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -5,6 +5,7 @@ generic-y += compat.h
> generic-y += device.h
> generic-y += div64.h
> generic-y += extable.h
> +generic-y += flat.h
> generic-y += dma.h
> generic-y += dma-contiguous.h
> generic-y += dma-mapping.h
>
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Christoph Hellwig <hch@lst.de>, Greg Ungerer <gerg@linux-m68k.org>
Cc: uclinux-h8-devel@lists.sourceforge.jp,
linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 15/15] riscv: add binfmt_flat support
Date: Tue, 11 Jun 2019 09:16:43 +0100 [thread overview]
Message-ID: <d8d81820-8f0d-d5d0-fa3d-3376ddcc5358@arm.com> (raw)
In-Reply-To: <20190610212015.9157-16-hch@lst.de>
On 6/10/19 10:20 PM, Christoph Hellwig wrote:
> Use the generic support with arguments are on the stack. Same as arm
> and m68k.
Out of curiosity, what is reason for keeping arguments on the stack?
ARM port of uClibc has following comment around manipulating of argv/argc:
/*
* uClinux/arm stacks look a little different from normal
* MMU-full Linux/arm stacks (for no good reason)
*/
So I though it is kind of legacy.
Thanks
Vladimir
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/riscv/Kconfig | 2 ++
> arch/riscv/include/asm/Kbuild | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 0c4b12205632..2e3b60cdeef4 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -17,7 +17,9 @@ config RISCV
> select OF
> select OF_EARLY_FLATTREE
> select OF_IRQ
> + select ARCH_HAS_BINFMT_FLAT
> select ARCH_WANT_FRAME_POINTERS
> + select BINFMT_FLAT_ARGVP_ENVP_ON_STACK
> select CLONE_BACKWARDS
> select COMMON_CLK
> select GENERIC_CLOCKEVENTS
> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> index 5ee646619cc3..1efaeddf1e4b 100644
> --- a/arch/riscv/include/asm/Kbuild
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -5,6 +5,7 @@ generic-y += compat.h
> generic-y += device.h
> generic-y += div64.h
> generic-y += extable.h
> +generic-y += flat.h
> generic-y += dma.h
> generic-y += dma-contiguous.h
> generic-y += dma-mapping.h
>
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Christoph Hellwig <hch@lst.de>, Greg Ungerer <gerg@linux-m68k.org>
Cc: uclinux-h8-devel@lists.sourceforge.jp,
linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 15/15] riscv: add binfmt_flat support
Date: Tue, 11 Jun 2019 09:16:43 +0100 [thread overview]
Message-ID: <d8d81820-8f0d-d5d0-fa3d-3376ddcc5358@arm.com> (raw)
In-Reply-To: <20190610212015.9157-16-hch@lst.de>
On 6/10/19 10:20 PM, Christoph Hellwig wrote:
> Use the generic support with arguments are on the stack. Same as arm
> and m68k.
Out of curiosity, what is reason for keeping arguments on the stack?
ARM port of uClibc has following comment around manipulating of argv/argc:
/*
* uClinux/arm stacks look a little different from normal
* MMU-full Linux/arm stacks (for no good reason)
*/
So I though it is kind of legacy.
Thanks
Vladimir
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/riscv/Kconfig | 2 ++
> arch/riscv/include/asm/Kbuild | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 0c4b12205632..2e3b60cdeef4 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -17,7 +17,9 @@ config RISCV
> select OF
> select OF_EARLY_FLATTREE
> select OF_IRQ
> + select ARCH_HAS_BINFMT_FLAT
> select ARCH_WANT_FRAME_POINTERS
> + select BINFMT_FLAT_ARGVP_ENVP_ON_STACK
> select CLONE_BACKWARDS
> select COMMON_CLK
> select GENERIC_CLOCKEVENTS
> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> index 5ee646619cc3..1efaeddf1e4b 100644
> --- a/arch/riscv/include/asm/Kbuild
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -5,6 +5,7 @@ generic-y += compat.h
> generic-y += device.h
> generic-y += div64.h
> generic-y += extable.h
> +generic-y += flat.h
> generic-y += dma.h
> generic-y += dma-contiguous.h
> generic-y += dma-mapping.h
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Christoph Hellwig <hch@lst.de>, Greg Ungerer <gerg@linux-m68k.org>
Cc: uclinux-h8-devel@lists.sourceforge.jp,
linux-xtensa@linux-xtensa.org, Michal Simek <monstr@monstr.eu>,
linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 15/15] riscv: add binfmt_flat support
Date: Tue, 11 Jun 2019 09:16:43 +0100 [thread overview]
Message-ID: <d8d81820-8f0d-d5d0-fa3d-3376ddcc5358@arm.com> (raw)
In-Reply-To: <20190610212015.9157-16-hch@lst.de>
On 6/10/19 10:20 PM, Christoph Hellwig wrote:
> Use the generic support with arguments are on the stack. Same as arm
> and m68k.
Out of curiosity, what is reason for keeping arguments on the stack?
ARM port of uClibc has following comment around manipulating of argv/argc:
/*
* uClinux/arm stacks look a little different from normal
* MMU-full Linux/arm stacks (for no good reason)
*/
So I though it is kind of legacy.
Thanks
Vladimir
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/riscv/Kconfig | 2 ++
> arch/riscv/include/asm/Kbuild | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 0c4b12205632..2e3b60cdeef4 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -17,7 +17,9 @@ config RISCV
> select OF
> select OF_EARLY_FLATTREE
> select OF_IRQ
> + select ARCH_HAS_BINFMT_FLAT
> select ARCH_WANT_FRAME_POINTERS
> + select BINFMT_FLAT_ARGVP_ENVP_ON_STACK
> select CLONE_BACKWARDS
> select COMMON_CLK
> select GENERIC_CLOCKEVENTS
> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> index 5ee646619cc3..1efaeddf1e4b 100644
> --- a/arch/riscv/include/asm/Kbuild
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -5,6 +5,7 @@ generic-y += compat.h
> generic-y += device.h
> generic-y += div64.h
> generic-y += extable.h
> +generic-y += flat.h
> generic-y += dma.h
> generic-y += dma-contiguous.h
> generic-y += dma-mapping.h
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-11 8:16 UTC|newest]
Thread overview: 152+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 21:20 binfmt_flat cleanups and RISC-V support Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` [PATCH 01/15] binfmt_flat: remove flat_reloc_valid Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:44 ` Vladimir Murzin
2019-06-11 9:44 ` Vladimir Murzin
2019-06-11 9:44 ` Vladimir Murzin
2019-06-11 9:44 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 02/15] binfmt_flat: remove flat_set_persistent Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:45 ` Vladimir Murzin
2019-06-11 9:45 ` Vladimir Murzin
2019-06-11 9:45 ` Vladimir Murzin
2019-06-11 9:45 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 03/15] binfmt_flat: provide a default version of flat_get_relocate_addr Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:46 ` Vladimir Murzin
2019-06-11 9:46 ` Vladimir Murzin
2019-06-11 9:46 ` Vladimir Murzin
2019-06-11 9:46 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 04/15] binfmt_flat: remove flat_old_ram_flag Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 6:04 ` Greg Ungerer
2019-06-11 6:04 ` Greg Ungerer
2019-06-11 6:04 ` Greg Ungerer
2019-06-11 6:04 ` Greg Ungerer
2019-06-11 7:36 ` Christoph Hellwig
2019-06-11 7:36 ` Christoph Hellwig
2019-06-11 7:36 ` Christoph Hellwig
2019-06-11 7:36 ` Christoph Hellwig
2019-06-11 13:07 ` Greg Ungerer
2019-06-11 13:07 ` Greg Ungerer
2019-06-11 13:07 ` Greg Ungerer
2019-06-11 13:07 ` Greg Ungerer
2019-06-11 9:47 ` Vladimir Murzin
2019-06-11 9:47 ` Vladimir Murzin
2019-06-11 9:47 ` Vladimir Murzin
2019-06-11 9:47 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 05/15] binfmt_flat: replace flat_argvp_envp_on_stack with a Kconfig variable Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:49 ` Vladimir Murzin
2019-06-11 9:49 ` Vladimir Murzin
2019-06-11 9:49 ` Vladimir Murzin
2019-06-11 9:49 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 06/15] binfmt_flat: remove the uapi <linux/flat.h> header Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:51 ` Vladimir Murzin
2019-06-11 9:51 ` Vladimir Murzin
2019-06-11 9:51 ` Vladimir Murzin
2019-06-11 9:51 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 07/15] binfmt_flat: use __be32 for the on-disk format Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 8:25 ` Geert Uytterhoeven
2019-06-11 8:25 ` Geert Uytterhoeven
2019-06-11 8:25 ` Geert Uytterhoeven
2019-06-11 8:25 ` Geert Uytterhoeven
2019-06-11 9:57 ` Vladimir Murzin
2019-06-11 9:57 ` Vladimir Murzin
2019-06-11 9:57 ` Vladimir Murzin
2019-06-11 9:57 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 08/15] binfmt_flat: add endianess annotations Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:58 ` Vladimir Murzin
2019-06-11 9:58 ` Vladimir Murzin
2019-06-11 9:58 ` Vladimir Murzin
2019-06-11 9:58 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 09/15] binfmt_flat: add a ARCH_HAS_BINFMT_FLAT option Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 9:59 ` Vladimir Murzin
2019-06-11 9:59 ` Vladimir Murzin
2019-06-11 9:59 ` Vladimir Murzin
2019-06-11 9:59 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 10/15] binfmt_flat: make support for old format binaries optional Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` [PATCH 11/15] binfmt_flat: provide an asm-generic/flat.h Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 10:01 ` Vladimir Murzin
2019-06-11 10:01 ` Vladimir Murzin
2019-06-11 10:01 ` Vladimir Murzin
2019-06-11 10:01 ` Vladimir Murzin
2019-06-10 21:20 ` [PATCH 12/15] binfmt_flat: remove the persistent argument from flat_get_addr_from_rp Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` [PATCH 13/15] binfmt_flat: move the MAX_SHARED_LIBS definition to binfmt_flat.c Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` [PATCH 14/15] binfmt_flat: don't offset the data start Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` [PATCH 15/15] riscv: add binfmt_flat support Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-10 21:20 ` Christoph Hellwig
2019-06-11 8:16 ` Vladimir Murzin [this message]
2019-06-11 8:16 ` Vladimir Murzin
2019-06-11 8:16 ` Vladimir Murzin
2019-06-11 8:16 ` Vladimir Murzin
2019-06-11 9:20 ` Christoph Hellwig
2019-06-11 9:20 ` Christoph Hellwig
2019-06-11 9:20 ` Christoph Hellwig
2019-06-11 9:20 ` Christoph Hellwig
2019-06-11 6:51 ` binfmt_flat cleanups and RISC-V support Greg Ungerer
2019-06-11 6:51 ` Greg Ungerer
2019-06-11 6:51 ` Greg Ungerer
2019-06-11 6:51 ` Greg Ungerer
2019-06-11 7:38 ` Christoph Hellwig
2019-06-11 7:38 ` Christoph Hellwig
2019-06-11 7:38 ` Christoph Hellwig
2019-06-11 7:38 ` Christoph Hellwig
2019-06-11 13:02 ` Greg Ungerer
2019-06-11 13:02 ` Greg Ungerer
2019-06-11 13:02 ` Greg Ungerer
2019-06-11 13:02 ` Greg Ungerer
2019-06-11 8:05 ` Vladimir Murzin
2019-06-11 8:05 ` Vladimir Murzin
2019-06-11 8:05 ` Vladimir Murzin
2019-06-11 8:05 ` Vladimir Murzin
2019-06-11 8:11 ` Christoph Hellwig
2019-06-11 8:11 ` Christoph Hellwig
2019-06-11 8:11 ` Christoph Hellwig
2019-06-11 8:11 ` Christoph Hellwig
2019-06-11 10:08 ` Vladimir Murzin
2019-06-11 10:08 ` Vladimir Murzin
2019-06-11 10:08 ` Vladimir Murzin
2019-06-11 10:08 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8d81820-8f0d-d5d0-fa3d-3376ddcc5358@arm.com \
--to=vladimir.murzin@arm.com \
--cc=gerg@linux-m68k.org \
--cc=hch@lst.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=monstr@monstr.eu \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.