Re: [LKML] Re: [PATCH v3] ad7877: keep dma rx buffers in seperate cache lines

From: Johannes Weiner <jw@emlix.com>
To: Nick Piggin <npiggin@suse.de>
Cc: "David Woodhouse" <dwmw2@infradead.org>,
	"Marc Gauthier" <marc@tensilica.com>,
	"Mike Frysinger" <vapier.adi@gmail.com>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Christoph Lameter" <cl@linux.com>,
	"Pekka Enberg" <penberg@cs.helsinki.fi>,
	"Matt Mackall" <mpm@selenic.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Oskar Schirmer" <os@emlix.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Daniel Glöckner" <dg@emlix.com>,
	"Oliver Schneidewind" <osw@emlix.com>,
	"David Rientjes" <rientjes@google.com>,
	"David Brownell" <dbrownell@users.sourceforge.net>,
	"Grant Likely" <grant.likely@secretlab.ca>,
	"Chris Zankel" <chris@zankel.net>,
	"Piet Delaney" <Piet.Delaney@tensilica.com>
Subject: Re: [LKML] Re: [PATCH v3] ad7877: keep dma rx buffers in seperate cache lines
Date: Wed, 19 May 2010 17:00:03 +0200	[thread overview]
Message-ID: <20100519150003.GK26131@emlix.com> (raw)
In-Reply-To: <20100519135226.GZ2516@laptop>

On Wed, May 19, 2010 at 11:52:26PM +1000, Nick Piggin wrote:
> On Wed, May 19, 2010 at 03:44:30PM +0200, Johannes Weiner wrote:
> > On Wed, May 19, 2010 at 11:36:56PM +1000, Nick Piggin wrote:
> > > On Wed, May 19, 2010 at 02:17:47PM +0100, David Woodhouse wrote:
> > > >
> > > > The 'cacheline aligned' misconception did manage to get into the ad7877
> > > > driver in commit 3843384a though -- it now uses ____cacheline_aligned
> > > > instead of __attribute__((__aligned__(ARCH_KMALLOC_MINALIGN))) as it
> > > > should.
> > > 
> > > OK so long as there is not a "must be cacheline aligned" requirement.
> > > Your proposal for a __dma_aligned attribute in an arch header looks
> > > like a good idea there.
> > 
> > Would you happen to know of other potential users?  At this point I'd
> > much rather just allocate the buffers dynamically and hide the issue
> > nicely behind kmalloc().
> 
> I don't think we need to hide the fact that some platforms have
> specific alignment restrictions for DMA. So if any drivers make use
> of the alignment, I see no problem with __dma_aligned.

In this case, the slave driver does not know whether the master driver
is even using DMA.  That's the reason we do not use dma_alloc_* for
the buffers in the first place.  And that's why I'd prefer to leave
the slave agnostic about it.  Use kmalloc(), don't worry about the
details.

Of course, there may still be more appropriate users for the macro,
that's why I asked.