From: Wolfram Sang <w.sang@pengutronix.de>
To: Dong Aisheng-B29396 <B29396@freescale.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"lrg@ti.com" <lrg@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/3] ARM: mx28evk: add platform data for saif
Date: Fri, 9 Sep 2011 15:41:05 +0200 [thread overview]
Message-ID: <20110909134105.GT1912@pengutronix.de> (raw)
In-Reply-To: <65EE16ACC360FA4D99C96DC085B3F77223C8CB@039-SN1MPN1-003.039d.mgd.msft.net>
[-- Attachment #1.1: Type: text/plain, Size: 1156 bytes --]
> > > +static unsigned int saif_clkmux;
Can't we just read the register in get_master and spare the static
variable?
> > and is it intended that if you do:
> >
> > mxs_saif_clkmux_select(1);
> > mxs_saif_clkmux_select(2);
> >
> > the SAIF_CLKMUX_SEL bitfield ends up being 3?
> Yes, it ends up being 3.
Needs to be fixed, of course. The function will need locking then.
> > > extern const struct mxs_saif_data mx28_saif_data[] __initconst;
> > > -#define mx28_add_saif(id)
> > mxs_add_saif(&mx28_saif_data[id])
> > > +#define mx28_add_saif(id, pdata) \
> > > + mxs_add_saif(&mx28_saif_data[id], pdata)
> > should it be a seperate patch to add pdata for saif devices?
> How do you suggest to separate?
> All changes are mainly to add saif pdata.
> You mean to move DIGCTL related saif pdata function to another patch?
I think he meant one patch for adding the functions in clock-mx28.c and
one patch to use the stuff when adding the pdata. Uwe?
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ARM: mx28evk: add platform data for saif
Date: Fri, 9 Sep 2011 15:41:05 +0200 [thread overview]
Message-ID: <20110909134105.GT1912@pengutronix.de> (raw)
In-Reply-To: <65EE16ACC360FA4D99C96DC085B3F77223C8CB@039-SN1MPN1-003.039d.mgd.msft.net>
> > > +static unsigned int saif_clkmux;
Can't we just read the register in get_master and spare the static
variable?
> > and is it intended that if you do:
> >
> > mxs_saif_clkmux_select(1);
> > mxs_saif_clkmux_select(2);
> >
> > the SAIF_CLKMUX_SEL bitfield ends up being 3?
> Yes, it ends up being 3.
Needs to be fixed, of course. The function will need locking then.
> > > extern const struct mxs_saif_data mx28_saif_data[] __initconst;
> > > -#define mx28_add_saif(id)
> > mxs_add_saif(&mx28_saif_data[id])
> > > +#define mx28_add_saif(id, pdata) \
> > > + mxs_add_saif(&mx28_saif_data[id], pdata)
> > should it be a seperate patch to add pdata for saif devices?
> How do you suggest to separate?
> All changes are mainly to add saif pdata.
> You mean to move DIGCTL related saif pdata function to another patch?
I think he meant one patch for adding the functions in clock-mx28.c and
one patch to use the stuff when adding the pdata. Uwe?
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110909/76649b9c/attachment.sig>
next prev parent reply other threads:[~2011-09-09 13:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 13:57 [PATCH v2 0/3] ARM: mxs: add recording support for saif Dong Aisheng
2011-09-07 13:57 ` Dong Aisheng
2011-09-07 13:57 ` [PATCH v2 1/3] ARM: mx28evk: add platform data " Dong Aisheng
2011-09-07 13:57 ` Dong Aisheng
2011-09-07 18:18 ` Uwe Kleine-König
2011-09-07 18:18 ` Uwe Kleine-König
2011-09-08 7:52 ` Dong Aisheng-B29396
2011-09-08 7:52 ` Dong Aisheng-B29396
2011-09-09 13:41 ` Wolfram Sang [this message]
2011-09-09 13:41 ` Wolfram Sang
2011-09-10 14:08 ` Uwe Kleine-König
2011-09-10 14:08 ` Uwe Kleine-König
2011-09-07 13:57 ` [PATCH v2 2/3] ARM: mx28evk: set a initial clock rate " Dong Aisheng
2011-09-07 13:57 ` Dong Aisheng
2011-09-07 18:21 ` Uwe Kleine-König
2011-09-07 18:21 ` Uwe Kleine-König
2011-09-08 8:03 ` Dong Aisheng-B29396
2011-09-08 8:03 ` Dong Aisheng-B29396
2011-09-08 8:56 ` Uwe Kleine-König
2011-09-08 8:56 ` Uwe Kleine-König
2011-09-08 9:06 ` Dong Aisheng-B29396
2011-09-08 9:06 ` Dong Aisheng-B29396
2011-09-07 13:57 ` [PATCH v2 3/3] arm: mxs: disable clock-gates when setting saif-clocks Dong Aisheng
2011-09-07 13:57 ` Dong Aisheng
2011-09-07 18:24 ` Uwe Kleine-König
2011-09-07 18:24 ` Uwe Kleine-König
2011-09-08 8:24 ` Dong Aisheng-B29396
2011-09-08 8:24 ` Dong Aisheng-B29396
2011-09-09 13:42 ` Wolfram Sang
2011-09-09 13:42 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909134105.GT1912@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=B29396@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.