From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Dong Aisheng-B29396 <B29396@freescale.com>,
"lrg@ti.com" <lrg@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/3] ARM: mx28evk: add platform data for saif
Date: Sat, 10 Sep 2011 16:08:52 +0200 [thread overview]
Message-ID: <20110910140852.GP28816@pengutronix.de> (raw)
In-Reply-To: <20110909134105.GT1912@pengutronix.de>
Hello,
On Fri, Sep 09, 2011 at 03:41:05PM +0200, Wolfram Sang wrote:
> > > > extern const struct mxs_saif_data mx28_saif_data[] __initconst;
> > > > -#define mx28_add_saif(id)
> > > mxs_add_saif(&mx28_saif_data[id])
> > > > +#define mx28_add_saif(id, pdata) \
> > > > + mxs_add_saif(&mx28_saif_data[id], pdata)
> > > should it be a seperate patch to add pdata for saif devices?
> > How do you suggest to separate?
> > All changes are mainly to add saif pdata.
> > You mean to move DIGCTL related saif pdata function to another patch?
>
> I think he meant one patch for adding the functions in clock-mx28.c and
> one patch to use the stuff when adding the pdata. Uwe?
yeah.
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ARM: mx28evk: add platform data for saif
Date: Sat, 10 Sep 2011 16:08:52 +0200 [thread overview]
Message-ID: <20110910140852.GP28816@pengutronix.de> (raw)
In-Reply-To: <20110909134105.GT1912@pengutronix.de>
Hello,
On Fri, Sep 09, 2011 at 03:41:05PM +0200, Wolfram Sang wrote:
> > > > extern const struct mxs_saif_data mx28_saif_data[] __initconst;
> > > > -#define mx28_add_saif(id)
> > > mxs_add_saif(&mx28_saif_data[id])
> > > > +#define mx28_add_saif(id, pdata) \
> > > > + mxs_add_saif(&mx28_saif_data[id], pdata)
> > > should it be a seperate patch to add pdata for saif devices?
> > How do you suggest to separate?
> > All changes are mainly to add saif pdata.
> > You mean to move DIGCTL related saif pdata function to another patch?
>
> I think he meant one patch for adding the functions in clock-mx28.c and
> one patch to use the stuff when adding the pdata. Uwe?
yeah.
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-09-10 14:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 13:57 [PATCH v2 0/3] ARM: mxs: add recording support for saif Dong Aisheng
2011-09-07 13:57 ` Dong Aisheng
2011-09-07 13:57 ` [PATCH v2 1/3] ARM: mx28evk: add platform data " Dong Aisheng
2011-09-07 13:57 ` Dong Aisheng
2011-09-07 18:18 ` Uwe Kleine-König
2011-09-07 18:18 ` Uwe Kleine-König
2011-09-08 7:52 ` Dong Aisheng-B29396
2011-09-08 7:52 ` Dong Aisheng-B29396
2011-09-09 13:41 ` Wolfram Sang
2011-09-09 13:41 ` Wolfram Sang
2011-09-10 14:08 ` Uwe Kleine-König [this message]
2011-09-10 14:08 ` Uwe Kleine-König
2011-09-07 13:57 ` [PATCH v2 2/3] ARM: mx28evk: set a initial clock rate " Dong Aisheng
2011-09-07 13:57 ` Dong Aisheng
2011-09-07 18:21 ` Uwe Kleine-König
2011-09-07 18:21 ` Uwe Kleine-König
2011-09-08 8:03 ` Dong Aisheng-B29396
2011-09-08 8:03 ` Dong Aisheng-B29396
2011-09-08 8:56 ` Uwe Kleine-König
2011-09-08 8:56 ` Uwe Kleine-König
2011-09-08 9:06 ` Dong Aisheng-B29396
2011-09-08 9:06 ` Dong Aisheng-B29396
2011-09-07 13:57 ` [PATCH v2 3/3] arm: mxs: disable clock-gates when setting saif-clocks Dong Aisheng
2011-09-07 13:57 ` Dong Aisheng
2011-09-07 18:24 ` Uwe Kleine-König
2011-09-07 18:24 ` Uwe Kleine-König
2011-09-08 8:24 ` Dong Aisheng-B29396
2011-09-08 8:24 ` Dong Aisheng-B29396
2011-09-09 13:42 ` Wolfram Sang
2011-09-09 13:42 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110910140852.GP28816@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=B29396@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.