From: Mark Rutland <mark.rutland@arm.com>
To: Chander Kashyap <chander.kashyap@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
"t.figa@samsung.com" <t.figa@samsung.com>,
"s.nawrocki@samsung.com" <s.nawrocki@samsung.com>,
"thomas.ab@samsung.com" <thomas.ab@samsung.com>
Subject: Re: [PATCH v2 07/10] ARM: dts: Add initial device tree support for Exynos5420
Date: Mon, 17 Jun 2013 09:46:48 +0100 [thread overview]
Message-ID: <20130617084648.GA6809@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1371218572-8993-8-git-send-email-chander.kashyap@linaro.org>
Hi,
> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> new file mode 100644
> index 0000000..43f0eb8
> --- /dev/null
> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> @@ -0,0 +1,40 @@
> +/*
> + * SAMSUNG SMDK5420 board device tree source
> + *
> + * Copyright (c) 2013 Samsung Electronics Co., Ltd.
> + * http://www.samsung.com
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +/dts-v1/;
> +#include "exynos5420.dtsi"
> +
> +/ {
> + model = "Samsung SMDK5420 board based on EXYNOS5420";
> + compatible = "samsung,smdk5420", "samsung,exynos5420";
> +
> + memory {
> + reg = <0x20000000 0x10000000
> + 0x30000000 0x10000000
> + 0x40000000 0x10000000
> + 0x50000000 0x10000000
> + 0x60000000 0x10000000
> + 0x70000000 0x10000000
> + 0x80000000 0x10000000
> + 0x90000000 0x10000000>;
> + };
As splitting these into 256MB banks is a workaround for an implementation
issue, there should at least be a comment to that effect.
It would be far nicer if this were described as one bank and the kernel could
split it up as necessary when using sparsemem.
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 07/10] ARM: dts: Add initial device tree support for Exynos5420
Date: Mon, 17 Jun 2013 09:46:48 +0100 [thread overview]
Message-ID: <20130617084648.GA6809@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1371218572-8993-8-git-send-email-chander.kashyap@linaro.org>
Hi,
> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> new file mode 100644
> index 0000000..43f0eb8
> --- /dev/null
> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> @@ -0,0 +1,40 @@
> +/*
> + * SAMSUNG SMDK5420 board device tree source
> + *
> + * Copyright (c) 2013 Samsung Electronics Co., Ltd.
> + * http://www.samsung.com
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +/dts-v1/;
> +#include "exynos5420.dtsi"
> +
> +/ {
> + model = "Samsung SMDK5420 board based on EXYNOS5420";
> + compatible = "samsung,smdk5420", "samsung,exynos5420";
> +
> + memory {
> + reg = <0x20000000 0x10000000
> + 0x30000000 0x10000000
> + 0x40000000 0x10000000
> + 0x50000000 0x10000000
> + 0x60000000 0x10000000
> + 0x70000000 0x10000000
> + 0x80000000 0x10000000
> + 0x90000000 0x10000000>;
> + };
As splitting these into 256MB banks is a workaround for an implementation
issue, there should at least be a comment to that effect.
It would be far nicer if this were described as one bank and the kernel could
split it up as necessary when using sparsemem.
Thanks,
Mark.
next prev parent reply other threads:[~2013-06-17 8:46 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 11:01 [PATCH 01/13] ARM: Exynos: initialize l2x0 cache controller only for cortex-a9 based SoCs Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 02/13] ARM: Exynos: fix secondary cpu power control register address calculation Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-08 11:05 ` Tomasz Figa
2013-06-08 11:05 ` Tomasz Figa
2013-06-11 13:46 ` Chander Kashyap
2013-06-11 13:46 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 03/13] ARM: dts: fork out common Exynos5 nodes Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:14 ` Sachin Kamat
2013-06-06 11:14 ` Sachin Kamat
2013-06-08 11:12 ` Tomasz Figa
2013-06-08 11:12 ` Tomasz Figa
2013-06-11 13:49 ` Chander Kashyap
2013-06-11 13:49 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 04/13] ARM: dts: list the CPU nodes for Exynos5250 Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 16:54 ` Mark Rutland
2013-06-06 16:54 ` Mark Rutland
2013-06-10 9:18 ` Chander Kashyap
2013-06-10 9:18 ` Chander Kashyap
2013-06-08 11:16 ` Tomasz Figa
2013-06-08 11:16 ` Tomasz Figa
2013-06-10 9:18 ` Chander Kashyap
2013-06-10 9:18 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 05/13] ARM: Exynos: Add support for Exynos5420 SoC Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 06/13] serial: samsung: add support for Exynos5420 Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:35 ` Girish KS
2013-06-06 11:35 ` Girish KS
2013-06-10 9:05 ` Chander Kashyap
2013-06-10 9:05 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 07/13] ARM: Exynos: use four additional chipid bits to identify Exynos family Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 08/13] irqchip: exynos-combiner: set irq base as 256 for Exynos5420 Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-08 11:24 ` Tomasz Figa
2013-06-08 11:24 ` Tomasz Figa
2013-06-06 11:01 ` [PATCH 09/13] clk: exynos5420: register clocks using common clock framework Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-08 11:25 ` Tomasz Figa
2013-06-08 11:25 ` Tomasz Figa
2013-06-11 13:22 ` Chander Kashyap
2013-06-11 13:22 ` Chander Kashyap
2013-06-10 11:12 ` sunil joshi
2013-06-10 11:12 ` sunil joshi
2013-06-11 13:23 ` Chander Kashyap
2013-06-11 13:23 ` Chander Kashyap
2013-06-12 21:17 ` Tomasz Figa
2013-06-12 21:17 ` Tomasz Figa
2013-06-12 21:32 ` Andrew Bresticker
2013-06-12 21:32 ` Andrew Bresticker
2013-06-13 5:18 ` Chander Kashyap
2013-06-13 5:18 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 10/13] ARM: dts: Add initial device tree support for Exynos5420 Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 16:34 ` Mark Rutland
2013-06-06 16:34 ` Mark Rutland
2013-06-11 13:35 ` Chander Kashyap
2013-06-11 13:35 ` Chander Kashyap
2013-06-11 14:11 ` Mark Rutland
2013-06-11 14:11 ` Mark Rutland
2013-06-12 5:35 ` Subash Patel
2013-06-12 5:35 ` Subash Patel
2013-06-08 11:38 ` Tomasz Figa
2013-06-08 11:38 ` Tomasz Figa
2013-06-14 13:54 ` Chander Kashyap
2013-06-14 13:54 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 00/10] ARM: Exynos: Add Exynos5420 SoC support Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 01/10] ARM: dts: fork out common Exynos5 nodes Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 02/10] ARM: dts: list the CPU nodes for Exynos5250 Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 03/10] ARM: Exynos: Add support for Exynos5420 SoC Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 04/10] serial: samsung: select Exynos specific driver data if ARCH_EXYNOS is defined Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 05/10] ARM: Exynos: use four additional chipid bits to identify Exynos family Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 06/10] clk: exynos5420: register clocks using common clock framework Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 17:26 ` Andrew Bresticker
2013-06-14 17:26 ` Andrew Bresticker
2013-06-17 8:46 ` Chander Kashyap
2013-06-17 8:46 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 07/10] ARM: dts: Add initial device tree support for Exynos5420 Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-17 8:46 ` Mark Rutland [this message]
2013-06-17 8:46 ` Mark Rutland
[not found] ` <CAGOxZ51H_dtZN3Nx-=qU+gjHAEwgPA--SZrdiu-sBCANhdKtAw@mail.gmail.com>
2013-06-17 11:08 ` Chander Kashyap
2013-06-17 11:08 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 08/10] clocksource: exynos_mct: use (request/free)_irq calls for local timer registration Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-17 10:01 ` Mark Rutland
2013-06-17 10:01 ` Mark Rutland
2013-06-17 10:29 ` Chander Kashyap
2013-06-17 10:29 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 09/10] ARM: Exynos: add secondary CPU boot base location for Exynos5420 Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 10/10] ARM: Exynos: extend soft-reset support " Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 11/13] clocksource: exynos_mct: extend local timer support for four cores Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 16:50 ` Mark Rutland
2013-06-06 16:50 ` Mark Rutland
2013-06-08 11:39 ` Tomasz Figa
2013-06-08 11:39 ` Tomasz Figa
2013-06-11 13:26 ` Chander Kashyap
2013-06-11 13:26 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 12/13] ARM: Exynos: add secondary CPU boot base location for Exynos5420 Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 13/13] ARM: Exynos: extend soft-reset support " Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:44 ` Tushar Behera
2013-06-06 11:44 ` Tushar Behera
2013-06-10 8:54 ` Kukjin Kim
2013-06-10 8:54 ` Kukjin Kim
2013-06-11 13:24 ` Chander Kashyap
2013-06-11 13:24 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 00/13] add exynos5420 support Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-08 10:57 ` [PATCH 01/13] ARM: Exynos: initialize l2x0 cache controller only for cortex-a9 based SoCs Tomasz Figa
2013-06-08 10:57 ` Tomasz Figa
2013-06-11 23:58 ` Olof Johansson
2013-06-11 23:58 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617084648.GA6809@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=chander.kashyap@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.