From: Tushar Behera <tushar.behera@linaro.org>
To: Chander Kashyap <chander.kashyap@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
kgene.kim@samsung.com, t.figa@samsung.com,
s.nawrocki@samsung.com, thomas.ab@samsung.com
Subject: Re: [PATCH 13/13] ARM: Exynos: extend soft-reset support for Exynos5420
Date: Thu, 06 Jun 2013 17:14:49 +0530 [thread overview]
Message-ID: <51B07631.2010802@linaro.org> (raw)
In-Reply-To: <1370516488-25860-13-git-send-email-chander.kashyap@linaro.org>
On 06/06/2013 04:31 PM, Chander Kashyap wrote:
> Extend the soft reset support for Exynos5420 SoC.
>
> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> ---
> arch/arm/mach-exynos/common.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index fbe1aa7..dc7c134 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -321,7 +321,8 @@ void exynos5_restart(char mode, const char *cmd)
> u32 val;
> void __iomem *addr;
>
> - if (of_machine_is_compatible("samsung,exynos5250")) {
> + if (of_machine_is_compatible("samsung,exynos5250") ||
> + (of_machine_is_compatible("samsung,exynos5420"))) {
> val = 0x1;
> addr = EXYNOS_SWRESET;
> } else if (of_machine_is_compatible("samsung,exynos5440")) {
>
How about making 0x1 and EXYNOS_SWRESET as default values of val and
addr. That way we can remove this check for exynos5250 and exynos5420.
Also we can remove the trailing else statement as there are no non-DT
boards for EXYNOS5.
void exynos5_restart(char mode, const char *cmd)
{
struct device_node *np;
- u32 val;
- void __iomem *addr;
+ u32 val = 0x1;
+ void __iomem *addr = EXYNOS_SWRESET;
- if (of_machine_is_compatible("samsung,exynos5250")) {
- val = 0x1;
- addr = EXYNOS_SWRESET;
- } else if (of_machine_is_compatible("samsung,exynos5440")) {
+ if (of_machine_is_compatible("samsung,exynos5440")) {
u32 status;
np = of_find_compatible_node(NULL, NULL,
"samsung,exynos5440-clock");
@@ -336,9 +333,6 @@ void exynos5_restart(char mode, const char *cmd)
val = __raw_readl(addr);
val = (val & 0xffff0000) | (status & 0xffff);
- } else {
- pr_err("%s: cannot support non-DT\n", __func__);
- return;
}
--
Tushar Behera
WARNING: multiple messages have this Message-ID (diff)
From: tushar.behera@linaro.org (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/13] ARM: Exynos: extend soft-reset support for Exynos5420
Date: Thu, 06 Jun 2013 17:14:49 +0530 [thread overview]
Message-ID: <51B07631.2010802@linaro.org> (raw)
In-Reply-To: <1370516488-25860-13-git-send-email-chander.kashyap@linaro.org>
On 06/06/2013 04:31 PM, Chander Kashyap wrote:
> Extend the soft reset support for Exynos5420 SoC.
>
> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> ---
> arch/arm/mach-exynos/common.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index fbe1aa7..dc7c134 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -321,7 +321,8 @@ void exynos5_restart(char mode, const char *cmd)
> u32 val;
> void __iomem *addr;
>
> - if (of_machine_is_compatible("samsung,exynos5250")) {
> + if (of_machine_is_compatible("samsung,exynos5250") ||
> + (of_machine_is_compatible("samsung,exynos5420"))) {
> val = 0x1;
> addr = EXYNOS_SWRESET;
> } else if (of_machine_is_compatible("samsung,exynos5440")) {
>
How about making 0x1 and EXYNOS_SWRESET as default values of val and
addr. That way we can remove this check for exynos5250 and exynos5420.
Also we can remove the trailing else statement as there are no non-DT
boards for EXYNOS5.
void exynos5_restart(char mode, const char *cmd)
{
struct device_node *np;
- u32 val;
- void __iomem *addr;
+ u32 val = 0x1;
+ void __iomem *addr = EXYNOS_SWRESET;
- if (of_machine_is_compatible("samsung,exynos5250")) {
- val = 0x1;
- addr = EXYNOS_SWRESET;
- } else if (of_machine_is_compatible("samsung,exynos5440")) {
+ if (of_machine_is_compatible("samsung,exynos5440")) {
u32 status;
np = of_find_compatible_node(NULL, NULL,
"samsung,exynos5440-clock");
@@ -336,9 +333,6 @@ void exynos5_restart(char mode, const char *cmd)
val = __raw_readl(addr);
val = (val & 0xffff0000) | (status & 0xffff);
- } else {
- pr_err("%s: cannot support non-DT\n", __func__);
- return;
}
--
Tushar Behera
next prev parent reply other threads:[~2013-06-06 11:44 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 11:01 [PATCH 01/13] ARM: Exynos: initialize l2x0 cache controller only for cortex-a9 based SoCs Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 02/13] ARM: Exynos: fix secondary cpu power control register address calculation Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-08 11:05 ` Tomasz Figa
2013-06-08 11:05 ` Tomasz Figa
2013-06-11 13:46 ` Chander Kashyap
2013-06-11 13:46 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 03/13] ARM: dts: fork out common Exynos5 nodes Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:14 ` Sachin Kamat
2013-06-06 11:14 ` Sachin Kamat
2013-06-08 11:12 ` Tomasz Figa
2013-06-08 11:12 ` Tomasz Figa
2013-06-11 13:49 ` Chander Kashyap
2013-06-11 13:49 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 04/13] ARM: dts: list the CPU nodes for Exynos5250 Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 16:54 ` Mark Rutland
2013-06-06 16:54 ` Mark Rutland
2013-06-10 9:18 ` Chander Kashyap
2013-06-10 9:18 ` Chander Kashyap
2013-06-08 11:16 ` Tomasz Figa
2013-06-08 11:16 ` Tomasz Figa
2013-06-10 9:18 ` Chander Kashyap
2013-06-10 9:18 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 05/13] ARM: Exynos: Add support for Exynos5420 SoC Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 06/13] serial: samsung: add support for Exynos5420 Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:35 ` Girish KS
2013-06-06 11:35 ` Girish KS
2013-06-10 9:05 ` Chander Kashyap
2013-06-10 9:05 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 07/13] ARM: Exynos: use four additional chipid bits to identify Exynos family Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 08/13] irqchip: exynos-combiner: set irq base as 256 for Exynos5420 Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-08 11:24 ` Tomasz Figa
2013-06-08 11:24 ` Tomasz Figa
2013-06-06 11:01 ` [PATCH 09/13] clk: exynos5420: register clocks using common clock framework Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-08 11:25 ` Tomasz Figa
2013-06-08 11:25 ` Tomasz Figa
2013-06-11 13:22 ` Chander Kashyap
2013-06-11 13:22 ` Chander Kashyap
2013-06-10 11:12 ` sunil joshi
2013-06-10 11:12 ` sunil joshi
2013-06-11 13:23 ` Chander Kashyap
2013-06-11 13:23 ` Chander Kashyap
2013-06-12 21:17 ` Tomasz Figa
2013-06-12 21:17 ` Tomasz Figa
2013-06-12 21:32 ` Andrew Bresticker
2013-06-12 21:32 ` Andrew Bresticker
2013-06-13 5:18 ` Chander Kashyap
2013-06-13 5:18 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 10/13] ARM: dts: Add initial device tree support for Exynos5420 Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 16:34 ` Mark Rutland
2013-06-06 16:34 ` Mark Rutland
2013-06-11 13:35 ` Chander Kashyap
2013-06-11 13:35 ` Chander Kashyap
2013-06-11 14:11 ` Mark Rutland
2013-06-11 14:11 ` Mark Rutland
2013-06-12 5:35 ` Subash Patel
2013-06-12 5:35 ` Subash Patel
2013-06-08 11:38 ` Tomasz Figa
2013-06-08 11:38 ` Tomasz Figa
2013-06-14 13:54 ` Chander Kashyap
2013-06-14 13:54 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 00/10] ARM: Exynos: Add Exynos5420 SoC support Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 01/10] ARM: dts: fork out common Exynos5 nodes Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 02/10] ARM: dts: list the CPU nodes for Exynos5250 Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 03/10] ARM: Exynos: Add support for Exynos5420 SoC Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 04/10] serial: samsung: select Exynos specific driver data if ARCH_EXYNOS is defined Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 05/10] ARM: Exynos: use four additional chipid bits to identify Exynos family Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 06/10] clk: exynos5420: register clocks using common clock framework Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 17:26 ` Andrew Bresticker
2013-06-14 17:26 ` Andrew Bresticker
2013-06-17 8:46 ` Chander Kashyap
2013-06-17 8:46 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 07/10] ARM: dts: Add initial device tree support for Exynos5420 Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-17 8:46 ` Mark Rutland
2013-06-17 8:46 ` Mark Rutland
[not found] ` <CAGOxZ51H_dtZN3Nx-=qU+gjHAEwgPA--SZrdiu-sBCANhdKtAw@mail.gmail.com>
2013-06-17 11:08 ` Chander Kashyap
2013-06-17 11:08 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 08/10] clocksource: exynos_mct: use (request/free)_irq calls for local timer registration Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-17 10:01 ` Mark Rutland
2013-06-17 10:01 ` Mark Rutland
2013-06-17 10:29 ` Chander Kashyap
2013-06-17 10:29 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 09/10] ARM: Exynos: add secondary CPU boot base location for Exynos5420 Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-14 14:02 ` [PATCH v2 10/10] ARM: Exynos: extend soft-reset support " Chander Kashyap
2013-06-14 14:02 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 11/13] clocksource: exynos_mct: extend local timer support for four cores Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 16:50 ` Mark Rutland
2013-06-06 16:50 ` Mark Rutland
2013-06-08 11:39 ` Tomasz Figa
2013-06-08 11:39 ` Tomasz Figa
2013-06-11 13:26 ` Chander Kashyap
2013-06-11 13:26 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 12/13] ARM: Exynos: add secondary CPU boot base location for Exynos5420 Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 13/13] ARM: Exynos: extend soft-reset support " Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-06 11:44 ` Tushar Behera [this message]
2013-06-06 11:44 ` Tushar Behera
2013-06-10 8:54 ` Kukjin Kim
2013-06-10 8:54 ` Kukjin Kim
2013-06-11 13:24 ` Chander Kashyap
2013-06-11 13:24 ` Chander Kashyap
2013-06-06 11:01 ` [PATCH 00/13] add exynos5420 support Chander Kashyap
2013-06-06 11:01 ` Chander Kashyap
2013-06-08 10:57 ` [PATCH 01/13] ARM: Exynos: initialize l2x0 cache controller only for cortex-a9 based SoCs Tomasz Figa
2013-06-08 10:57 ` Tomasz Figa
2013-06-11 23:58 ` Olof Johansson
2013-06-11 23:58 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B07631.2010802@linaro.org \
--to=tushar.behera@linaro.org \
--cc=chander.kashyap@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.