From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jyri Sarha <jyri.sarha@iki.fi>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org,
Mark Brown <broonie@kernel.org>,
jsarha@ti.com, Yakir Yang <ykk@rock-chips.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH RFC v2 10/13] sound/core: add DRM ELD helper
Date: Fri, 8 May 2015 14:27:01 +0100 [thread overview]
Message-ID: <20150508132701.GJ2067@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <34627ba55428fd0dd821d99a5326e451@kapsi.fi>
On Fri, May 08, 2015 at 04:16:08PM +0300, Jyri Sarha wrote:
> On 2015-04-02 12:22, Russell King wrote:
> >+static const unsigned int eld_rates[] = {
> >+ 32000,
> >+ 44100,
> >+ 48000,
> >+ 88200,
> >+ 96000,
> >+ 176400,
> >+ 192000,
> >+};
> >+
>
> For what I can see, you are setting the cross dependency between
> the sample rate and channels incorrectly.
There is a dependency between sample rate and channels.
> You should look for the
> currently tested channel count directly from hw params.
I'm not so sure that's right after looking at snd_ac97_pcm_double_rate_rules().
That's pretty much the same problem - AC'97 codecs can operate at a
sample rate of either the bus frame frequency or twice the bus frame
frequency.
They achieve twice the bus frame frequency by reallocating a couple
of the PCM data slots which would otherwise be used for >2 channels
to the first two channels, thus allowing two front channel samples
per frame.
AC'97 limits the number of channels to two if:
if (rate->min > 48000) {
and limits the sample rate to 1-48kHz if:
if (channels->min > 2) {
> From this side the dependency is missing all together.
Yes, it I initially couldn't work out how to do that bit... but I have
a solution now which seems to sort-of work.
Testing with aplay, I find that it seems to mostly work, and I guess
that:
aplay -D hw:0,0 -v -f S24_LE -c 6 -r 192000 /dev/zero
resulting in:
Playing raw data '/dev/zero' : Signed 24 bit Little Endian, Rate 192000 Hz, Channels 6
Warning: rate is not accurate (requested = 192000Hz, got = 48000Hz)
please, try the plug plugin
Hardware PCM card 0 'DW-HDMI' device 0 subdevice 0
Its setup is:
stream : PLAYBACK
access : RW_INTERLEAVED
format : S24_LE
subformat : STD
channels : 6
rate : 48000
exact rate : 48000 (48000/1)
is acceptable.
Also looking at AC'97, I don't need to list the same parameter as a
dependent of the rule... something I'll try when I'm back from the
hospital later this afternoon...
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH RFC v2 10/13] sound/core: add DRM ELD helper
Date: Fri, 8 May 2015 14:27:01 +0100 [thread overview]
Message-ID: <20150508132701.GJ2067@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <34627ba55428fd0dd821d99a5326e451@kapsi.fi>
On Fri, May 08, 2015 at 04:16:08PM +0300, Jyri Sarha wrote:
> On 2015-04-02 12:22, Russell King wrote:
> >+static const unsigned int eld_rates[] = {
> >+ 32000,
> >+ 44100,
> >+ 48000,
> >+ 88200,
> >+ 96000,
> >+ 176400,
> >+ 192000,
> >+};
> >+
>
> For what I can see, you are setting the cross dependency between
> the sample rate and channels incorrectly.
There is a dependency between sample rate and channels.
> You should look for the
> currently tested channel count directly from hw params.
I'm not so sure that's right after looking at snd_ac97_pcm_double_rate_rules().
That's pretty much the same problem - AC'97 codecs can operate at a
sample rate of either the bus frame frequency or twice the bus frame
frequency.
They achieve twice the bus frame frequency by reallocating a couple
of the PCM data slots which would otherwise be used for >2 channels
to the first two channels, thus allowing two front channel samples
per frame.
AC'97 limits the number of channels to two if:
if (rate->min > 48000) {
and limits the sample rate to 1-48kHz if:
if (channels->min > 2) {
> From this side the dependency is missing all together.
Yes, it I initially couldn't work out how to do that bit... but I have
a solution now which seems to sort-of work.
Testing with aplay, I find that it seems to mostly work, and I guess
that:
aplay -D hw:0,0 -v -f S24_LE -c 6 -r 192000 /dev/zero
resulting in:
Playing raw data '/dev/zero' : Signed 24 bit Little Endian, Rate 192000 Hz, Channels 6
Warning: rate is not accurate (requested = 192000Hz, got = 48000Hz)
please, try the plug plugin
Hardware PCM card 0 'DW-HDMI' device 0 subdevice 0
Its setup is:
stream : PLAYBACK
access : RW_INTERLEAVED
format : S24_LE
subformat : STD
channels : 6
rate : 48000
exact rate : 48000 (48000/1)
is acceptable.
Also looking at AC'97, I don't need to list the same parameter as a
dependent of the rule... something I'll try when I'm back from the
hospital later this afternoon...
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-05-08 13:27 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 9:20 [RFC v2 0/13] dw_hdmi cleanups, audio preparation, helpers and ahb audio support Russell King - ARM Linux
2015-04-02 9:20 ` Russell King - ARM Linux
2015-04-02 9:21 ` [PATCH RFC v2 01/13] drm: imx/dw_hdmi: move phy comments Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 02/13] drm: bridge/dw_hdmi: clean up phy configuration Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 03/13] drm: bridge/dw_hdmi: clean up hdmi_set_clk_regenerator() Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 04/13] drm: bridge/dw_hdmi: use drm_hdmi_avi_infoframe_from_display_mode() Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 05/13] drm: bridge/dw_hdmi: simplify hdmi_config_AVI() a little Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 06/13] drm: bridge/dw_hdmi: remove mhsyncpolarity/mvsyncpolarity/minterlaced Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 07/13] drm: bridge/dw_hdmi: introduce interface to setting sample rate Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 08/13] drm: bridge/dw_hdmi: introduce interfaces to enable and disable audio Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:22 ` [PATCH RFC v2 09/13] drm/edid: add function to help find SADs Russell King
2015-04-02 9:22 ` Russell King
2015-04-02 9:22 ` [PATCH RFC v2 10/13] sound/core: add DRM ELD helper Russell King
2015-04-02 9:22 ` Russell King
2015-04-05 15:57 ` Takashi Iwai
2015-04-05 15:57 ` Takashi Iwai
2015-04-05 16:20 ` Russell King - ARM Linux
2015-04-05 16:20 ` Russell King - ARM Linux
2015-04-05 16:46 ` Takashi Iwai
2015-04-05 16:46 ` Takashi Iwai
2015-04-05 17:26 ` Russell King - ARM Linux
2015-04-05 17:26 ` Russell King - ARM Linux
2015-05-06 17:02 ` Anssi Hannula
2015-05-06 17:02 ` Anssi Hannula
2015-05-07 10:41 ` Russell King - ARM Linux
2015-05-07 10:41 ` Russell King - ARM Linux
2015-05-07 11:11 ` Lars-Peter Clausen
2015-05-07 11:11 ` [alsa-devel] " Lars-Peter Clausen
2015-05-08 10:56 ` Jyri Sarha
2015-05-08 10:56 ` Jyri Sarha
2015-05-08 11:42 ` Russell King - ARM Linux
2015-05-08 11:42 ` Russell King - ARM Linux
2015-05-05 22:35 ` Mark Brown
2015-05-05 22:35 ` Mark Brown
2015-05-06 8:58 ` Liam Girdwood
2015-05-06 8:58 ` [alsa-devel] " Liam Girdwood
2015-05-08 13:16 ` Jyri Sarha
2015-05-08 13:16 ` Jyri Sarha
2015-05-08 13:27 ` Russell King - ARM Linux [this message]
2015-05-08 13:27 ` Russell King - ARM Linux
2015-05-08 13:37 ` Jyri Sarha
2015-05-08 13:37 ` [alsa-devel] " Jyri Sarha
2015-04-02 9:22 ` [PATCH RFC v2 11/13] sound/core: add IEC958 channel status helper Russell King
2015-04-02 9:22 ` Russell King
2015-04-02 9:22 ` [PATCH RFC v2 12/13] drm: bridge/dw_hdmi-ahb-audio: add audio driver Russell King
2015-04-02 9:22 ` Russell King
2015-04-02 9:22 ` [PATCH RFC v2 13/13] drm: bridge/dw_hdmi-ahb-audio: parse ELD from HDMI driver Russell King
2015-04-02 9:22 ` Russell King
2015-05-09 10:25 ` [PATCH v3 0/13] dw_hdmi cleanups, audio preparation, helpers and ahb audio support Russell King - ARM Linux
2015-05-09 10:25 ` Russell King - ARM Linux
2015-05-09 10:25 ` [PATCH 01/13] drm: imx/dw_hdmi: move phy comments Russell King
2015-05-09 10:25 ` Russell King
2015-05-09 10:26 ` [PATCH 02/13] drm: bridge/dw_hdmi: clean up phy configuration Russell King
2015-05-09 10:26 ` Russell King
2015-05-22 15:19 ` Yakir
2015-05-22 15:19 ` Yakir
2015-05-09 10:26 ` [PATCH 03/13] drm: bridge/dw_hdmi: clean up hdmi_set_clk_regenerator() Russell King
2015-05-09 10:26 ` Russell King
2015-05-22 15:22 ` Yakir
2015-05-22 15:22 ` Yakir
2015-05-09 10:26 ` [PATCH 04/13] drm: bridge/dw_hdmi: use drm_hdmi_avi_infoframe_from_display_mode() Russell King
2015-05-09 10:26 ` Russell King
2015-05-09 10:26 ` [PATCH 05/13] drm: bridge/dw_hdmi: simplify hdmi_config_AVI() a little Russell King
2015-05-09 10:26 ` Russell King
2015-05-09 10:26 ` [PATCH 06/13] drm: bridge/dw_hdmi: remove mhsyncpolarity/mvsyncpolarity/minterlaced Russell King
2015-05-09 10:26 ` Russell King
2015-05-09 10:26 ` [PATCH 07/13] drm: bridge/dw_hdmi: introduce interface to setting sample rate Russell King
2015-05-09 10:26 ` Russell King
2015-05-22 15:26 ` Yakir
2015-05-22 15:26 ` Yakir
2015-05-09 10:26 ` [PATCH 08/13] drm: bridge/dw_hdmi: introduce interfaces to enable and disable audio Russell King
2015-05-09 10:26 ` Russell King
2015-05-22 15:28 ` Yakir
2015-05-22 15:28 ` Yakir
2015-05-09 10:26 ` [PATCH 09/13] drm/edid: add function to help find SADs Russell King
2015-05-09 10:26 ` Russell King
2015-05-09 10:26 ` [PATCH 10/13] sound/core: add DRM ELD helper Russell King
2015-05-09 10:26 ` Russell King
2015-05-22 12:20 ` [alsa-devel] " Mark Brown
2015-05-22 12:20 ` Mark Brown
2015-05-22 13:15 ` Russell King - ARM Linux
2015-05-22 13:15 ` Russell King - ARM Linux
2015-05-22 13:30 ` Takashi Iwai
2015-05-22 13:30 ` Takashi Iwai
2015-05-22 13:53 ` Russell King - ARM Linux
2015-05-22 13:53 ` Russell King - ARM Linux
2015-05-22 13:54 ` Takashi Iwai
2015-05-22 13:54 ` Takashi Iwai
2015-05-22 14:00 ` Russell King - ARM Linux
2015-05-22 14:00 ` Russell King - ARM Linux
2015-05-22 14:02 ` Takashi Iwai
2015-05-22 14:02 ` Takashi Iwai
2015-05-22 14:05 ` Takashi Iwai
2015-05-22 14:05 ` Takashi Iwai
2015-05-22 16:12 ` Russell King - ARM Linux
2015-05-22 16:12 ` Russell King - ARM Linux
2015-05-09 10:26 ` [PATCH 11/13] sound/core: add IEC958 channel status helper Russell King
2015-05-09 10:26 ` Russell King
2015-05-22 12:40 ` Mark Brown
2015-05-22 12:40 ` Mark Brown
2015-05-09 10:26 ` [PATCH 12/13] drm: bridge/dw_hdmi-ahb-audio: add audio driver Russell King
2015-05-09 10:26 ` Russell King
2015-05-09 16:49 ` [alsa-devel] " Anssi Hannula
2015-05-09 16:49 ` Anssi Hannula
2015-05-09 16:55 ` Russell King - ARM Linux
2015-05-09 16:55 ` Russell King - ARM Linux
2015-05-09 17:07 ` Anssi Hannula
2015-05-09 17:07 ` Anssi Hannula
2015-05-09 17:40 ` Russell King - ARM Linux
2015-05-09 17:40 ` Russell King - ARM Linux
2015-05-09 17:53 ` Russell King - ARM Linux
2015-05-09 17:53 ` Russell King - ARM Linux
2015-05-09 17:55 ` Anssi Hannula
2015-05-09 17:55 ` Anssi Hannula
2015-05-09 18:11 ` Russell King - ARM Linux
2015-05-09 18:11 ` Russell King - ARM Linux
2015-05-10 18:59 ` Anssi Hannula
2015-05-10 18:59 ` Anssi Hannula
2015-05-10 19:33 ` Russell King - ARM Linux
2015-05-10 19:33 ` Russell King - ARM Linux
2015-05-10 20:47 ` Anssi Hannula
2015-05-10 20:47 ` Anssi Hannula
2015-05-11 15:58 ` Mark Brown
2015-05-11 15:58 ` [alsa-devel] " Mark Brown
2015-05-09 10:26 ` [PATCH 13/13] drm: bridge/dw_hdmi-ahb-audio: parse ELD from HDMI driver Russell King
2015-05-09 10:26 ` Russell King
2015-05-27 10:43 ` Daniel Vetter
2015-05-27 10:43 ` Daniel Vetter
2015-05-27 11:43 ` Mark Brown
2015-05-27 11:43 ` Mark Brown
2015-05-27 17:31 ` Russell King - ARM Linux
2015-05-27 17:31 ` Russell King - ARM Linux
2015-05-27 21:29 ` Daniel Vetter
2015-05-27 21:29 ` Daniel Vetter
2015-05-27 21:44 ` Russell King - ARM Linux
2015-05-27 21:44 ` Russell King - ARM Linux
2015-05-28 6:43 ` Daniel Vetter
2015-05-28 6:43 ` Daniel Vetter
2015-05-28 4:56 ` [alsa-devel] " Takashi Iwai
2015-05-28 4:56 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508132701.GJ2067@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=jsarha@ti.com \
--cc=jyri.sarha@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.