From: Daniel Vetter <daniel@ffwll.ch>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Jaroslav Kysela <perex@perex.cz>, Mark Brown <broonie@kernel.org>,
Yakir Yang <ykk@rock-chips.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 13/13] drm: bridge/dw_hdmi-ahb-audio: parse ELD from HDMI driver
Date: Thu, 28 May 2015 08:43:13 +0200 [thread overview]
Message-ID: <20150528064313.GR8341@phenom.ffwll.local> (raw)
In-Reply-To: <20150527214439.GW2067@n2100.arm.linux.org.uk>
On Wed, May 27, 2015 at 10:44:40PM +0100, Russell King - ARM Linux wrote:
> On Wed, May 27, 2015 at 11:29:52PM +0200, Daniel Vetter wrote:
> > The only issue that might be
> > there with your sw approach is that a concurrent probe/hotplug in drm
> > might free the edid and hence the eld, while the snd side is trying to
> > copy that.
>
> Talking only about the particular case of dw-hdmi-ahb-audio...
>
> The worst that may happen is that the ELD will be overwritten with an
> update on hotplug - it won't be freed unless the underlying connector
> is freed, as the eld is stored as an array inside struct drm_connector.
> Before the DRM connector is freed, we pull the audio driver's struct
> device, which will destroy the ALSA device.
Oh right I've forgotten that eld is stored as a full array and only the
edid floats around as a pointer in drm_connector.
> Hopefully ALSA already copes gracefully with the removal of an in-use
> device... it should do, it's no different from having a USB audio device
> and you pull it out of the USB socket while the device is in-use.
>
> (It's also worth noting as we're talking about this, that as the audio
> struct device is a child of the HDMI device, any PM activity will be
> correctly ordered: the child gets suspended before the parent... the
> audio device gets suspended before the video, and resume is of course
> the reverse order.)
Yeah, being able to control the nesting with DT seems so nice compared to
intel ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: daniel@ffwll.ch (Daniel Vetter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/13] drm: bridge/dw_hdmi-ahb-audio: parse ELD from HDMI driver
Date: Thu, 28 May 2015 08:43:13 +0200 [thread overview]
Message-ID: <20150528064313.GR8341@phenom.ffwll.local> (raw)
In-Reply-To: <20150527214439.GW2067@n2100.arm.linux.org.uk>
On Wed, May 27, 2015 at 10:44:40PM +0100, Russell King - ARM Linux wrote:
> On Wed, May 27, 2015 at 11:29:52PM +0200, Daniel Vetter wrote:
> > The only issue that might be
> > there with your sw approach is that a concurrent probe/hotplug in drm
> > might free the edid and hence the eld, while the snd side is trying to
> > copy that.
>
> Talking only about the particular case of dw-hdmi-ahb-audio...
>
> The worst that may happen is that the ELD will be overwritten with an
> update on hotplug - it won't be freed unless the underlying connector
> is freed, as the eld is stored as an array inside struct drm_connector.
> Before the DRM connector is freed, we pull the audio driver's struct
> device, which will destroy the ALSA device.
Oh right I've forgotten that eld is stored as a full array and only the
edid floats around as a pointer in drm_connector.
> Hopefully ALSA already copes gracefully with the removal of an in-use
> device... it should do, it's no different from having a USB audio device
> and you pull it out of the USB socket while the device is in-use.
>
> (It's also worth noting as we're talking about this, that as the audio
> struct device is a child of the HDMI device, any PM activity will be
> correctly ordered: the child gets suspended before the parent... the
> audio device gets suspended before the video, and resume is of course
> the reverse order.)
Yeah, being able to control the nesting with DT seems so nice compared to
intel ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2015-05-28 6:43 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 9:20 [RFC v2 0/13] dw_hdmi cleanups, audio preparation, helpers and ahb audio support Russell King - ARM Linux
2015-04-02 9:20 ` Russell King - ARM Linux
2015-04-02 9:21 ` [PATCH RFC v2 01/13] drm: imx/dw_hdmi: move phy comments Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 02/13] drm: bridge/dw_hdmi: clean up phy configuration Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 03/13] drm: bridge/dw_hdmi: clean up hdmi_set_clk_regenerator() Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 04/13] drm: bridge/dw_hdmi: use drm_hdmi_avi_infoframe_from_display_mode() Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 05/13] drm: bridge/dw_hdmi: simplify hdmi_config_AVI() a little Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 06/13] drm: bridge/dw_hdmi: remove mhsyncpolarity/mvsyncpolarity/minterlaced Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 07/13] drm: bridge/dw_hdmi: introduce interface to setting sample rate Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:21 ` [PATCH RFC v2 08/13] drm: bridge/dw_hdmi: introduce interfaces to enable and disable audio Russell King
2015-04-02 9:21 ` Russell King
2015-04-02 9:22 ` [PATCH RFC v2 09/13] drm/edid: add function to help find SADs Russell King
2015-04-02 9:22 ` Russell King
2015-04-02 9:22 ` [PATCH RFC v2 10/13] sound/core: add DRM ELD helper Russell King
2015-04-02 9:22 ` Russell King
2015-04-05 15:57 ` Takashi Iwai
2015-04-05 15:57 ` Takashi Iwai
2015-04-05 16:20 ` Russell King - ARM Linux
2015-04-05 16:20 ` Russell King - ARM Linux
2015-04-05 16:46 ` Takashi Iwai
2015-04-05 16:46 ` Takashi Iwai
2015-04-05 17:26 ` Russell King - ARM Linux
2015-04-05 17:26 ` Russell King - ARM Linux
2015-05-06 17:02 ` Anssi Hannula
2015-05-06 17:02 ` Anssi Hannula
2015-05-07 10:41 ` Russell King - ARM Linux
2015-05-07 10:41 ` Russell King - ARM Linux
2015-05-07 11:11 ` Lars-Peter Clausen
2015-05-07 11:11 ` [alsa-devel] " Lars-Peter Clausen
2015-05-08 10:56 ` Jyri Sarha
2015-05-08 10:56 ` Jyri Sarha
2015-05-08 11:42 ` Russell King - ARM Linux
2015-05-08 11:42 ` Russell King - ARM Linux
2015-05-05 22:35 ` Mark Brown
2015-05-05 22:35 ` Mark Brown
2015-05-06 8:58 ` Liam Girdwood
2015-05-06 8:58 ` [alsa-devel] " Liam Girdwood
2015-05-08 13:16 ` Jyri Sarha
2015-05-08 13:16 ` Jyri Sarha
2015-05-08 13:27 ` Russell King - ARM Linux
2015-05-08 13:27 ` Russell King - ARM Linux
2015-05-08 13:37 ` Jyri Sarha
2015-05-08 13:37 ` [alsa-devel] " Jyri Sarha
2015-04-02 9:22 ` [PATCH RFC v2 11/13] sound/core: add IEC958 channel status helper Russell King
2015-04-02 9:22 ` Russell King
2015-04-02 9:22 ` [PATCH RFC v2 12/13] drm: bridge/dw_hdmi-ahb-audio: add audio driver Russell King
2015-04-02 9:22 ` Russell King
2015-04-02 9:22 ` [PATCH RFC v2 13/13] drm: bridge/dw_hdmi-ahb-audio: parse ELD from HDMI driver Russell King
2015-04-02 9:22 ` Russell King
2015-05-09 10:25 ` [PATCH v3 0/13] dw_hdmi cleanups, audio preparation, helpers and ahb audio support Russell King - ARM Linux
2015-05-09 10:25 ` Russell King - ARM Linux
2015-05-09 10:25 ` [PATCH 01/13] drm: imx/dw_hdmi: move phy comments Russell King
2015-05-09 10:25 ` Russell King
2015-05-09 10:26 ` [PATCH 02/13] drm: bridge/dw_hdmi: clean up phy configuration Russell King
2015-05-09 10:26 ` Russell King
2015-05-22 15:19 ` Yakir
2015-05-22 15:19 ` Yakir
2015-05-09 10:26 ` [PATCH 03/13] drm: bridge/dw_hdmi: clean up hdmi_set_clk_regenerator() Russell King
2015-05-09 10:26 ` Russell King
2015-05-22 15:22 ` Yakir
2015-05-22 15:22 ` Yakir
2015-05-09 10:26 ` [PATCH 04/13] drm: bridge/dw_hdmi: use drm_hdmi_avi_infoframe_from_display_mode() Russell King
2015-05-09 10:26 ` Russell King
2015-05-09 10:26 ` [PATCH 05/13] drm: bridge/dw_hdmi: simplify hdmi_config_AVI() a little Russell King
2015-05-09 10:26 ` Russell King
2015-05-09 10:26 ` [PATCH 06/13] drm: bridge/dw_hdmi: remove mhsyncpolarity/mvsyncpolarity/minterlaced Russell King
2015-05-09 10:26 ` Russell King
2015-05-09 10:26 ` [PATCH 07/13] drm: bridge/dw_hdmi: introduce interface to setting sample rate Russell King
2015-05-09 10:26 ` Russell King
2015-05-22 15:26 ` Yakir
2015-05-22 15:26 ` Yakir
2015-05-09 10:26 ` [PATCH 08/13] drm: bridge/dw_hdmi: introduce interfaces to enable and disable audio Russell King
2015-05-09 10:26 ` Russell King
2015-05-22 15:28 ` Yakir
2015-05-22 15:28 ` Yakir
2015-05-09 10:26 ` [PATCH 09/13] drm/edid: add function to help find SADs Russell King
2015-05-09 10:26 ` Russell King
2015-05-09 10:26 ` [PATCH 10/13] sound/core: add DRM ELD helper Russell King
2015-05-09 10:26 ` Russell King
2015-05-22 12:20 ` [alsa-devel] " Mark Brown
2015-05-22 12:20 ` Mark Brown
2015-05-22 13:15 ` Russell King - ARM Linux
2015-05-22 13:15 ` Russell King - ARM Linux
2015-05-22 13:30 ` Takashi Iwai
2015-05-22 13:30 ` Takashi Iwai
2015-05-22 13:53 ` Russell King - ARM Linux
2015-05-22 13:53 ` Russell King - ARM Linux
2015-05-22 13:54 ` Takashi Iwai
2015-05-22 13:54 ` Takashi Iwai
2015-05-22 14:00 ` Russell King - ARM Linux
2015-05-22 14:00 ` Russell King - ARM Linux
2015-05-22 14:02 ` Takashi Iwai
2015-05-22 14:02 ` Takashi Iwai
2015-05-22 14:05 ` Takashi Iwai
2015-05-22 14:05 ` Takashi Iwai
2015-05-22 16:12 ` Russell King - ARM Linux
2015-05-22 16:12 ` Russell King - ARM Linux
2015-05-09 10:26 ` [PATCH 11/13] sound/core: add IEC958 channel status helper Russell King
2015-05-09 10:26 ` Russell King
2015-05-22 12:40 ` Mark Brown
2015-05-22 12:40 ` Mark Brown
2015-05-09 10:26 ` [PATCH 12/13] drm: bridge/dw_hdmi-ahb-audio: add audio driver Russell King
2015-05-09 10:26 ` Russell King
2015-05-09 16:49 ` [alsa-devel] " Anssi Hannula
2015-05-09 16:49 ` Anssi Hannula
2015-05-09 16:55 ` Russell King - ARM Linux
2015-05-09 16:55 ` Russell King - ARM Linux
2015-05-09 17:07 ` Anssi Hannula
2015-05-09 17:07 ` Anssi Hannula
2015-05-09 17:40 ` Russell King - ARM Linux
2015-05-09 17:40 ` Russell King - ARM Linux
2015-05-09 17:53 ` Russell King - ARM Linux
2015-05-09 17:53 ` Russell King - ARM Linux
2015-05-09 17:55 ` Anssi Hannula
2015-05-09 17:55 ` Anssi Hannula
2015-05-09 18:11 ` Russell King - ARM Linux
2015-05-09 18:11 ` Russell King - ARM Linux
2015-05-10 18:59 ` Anssi Hannula
2015-05-10 18:59 ` Anssi Hannula
2015-05-10 19:33 ` Russell King - ARM Linux
2015-05-10 19:33 ` Russell King - ARM Linux
2015-05-10 20:47 ` Anssi Hannula
2015-05-10 20:47 ` Anssi Hannula
2015-05-11 15:58 ` Mark Brown
2015-05-11 15:58 ` [alsa-devel] " Mark Brown
2015-05-09 10:26 ` [PATCH 13/13] drm: bridge/dw_hdmi-ahb-audio: parse ELD from HDMI driver Russell King
2015-05-09 10:26 ` Russell King
2015-05-27 10:43 ` Daniel Vetter
2015-05-27 10:43 ` Daniel Vetter
2015-05-27 11:43 ` Mark Brown
2015-05-27 11:43 ` Mark Brown
2015-05-27 17:31 ` Russell King - ARM Linux
2015-05-27 17:31 ` Russell King - ARM Linux
2015-05-27 21:29 ` Daniel Vetter
2015-05-27 21:29 ` Daniel Vetter
2015-05-27 21:44 ` Russell King - ARM Linux
2015-05-27 21:44 ` Russell King - ARM Linux
2015-05-28 6:43 ` Daniel Vetter [this message]
2015-05-28 6:43 ` Daniel Vetter
2015-05-28 4:56 ` [alsa-devel] " Takashi Iwai
2015-05-28 4:56 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528064313.GR8341@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=perex@perex.cz \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.