From: Viresh Kumar <viresh.kumar@linaro.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
mturquette@baylibre.com
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
rob.herring@linaro.org, nm@ti.com,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
arnd.bergmann@linaro.org, broonie@kernel.org,
sboyd@codeaurora.org, Sudeep.Holla@arm.com,
viswanath.puttagunta@linaro.org, l.stach@pengutronix.de,
thomas.petazzoni@free-electrons.com,
linux-arm-kernel@lists.infradead.org, ta.omasab@gmail.com,
kesavan.abhilash@gmail.com, khilman@linaro.org,
santosh.shilimkar@oracle.com
Subject: Re: [PATCH 05/10] opp: Add support to parse "operating-points-v2" bindings
Date: Mon, 27 Jul 2015 08:32:39 +0530 [thread overview]
Message-ID: <20150727030239.GG19944@linux> (raw)
In-Reply-To: <2910042.ys2zsBBKt2@amdc1976>
On 08-07-15, 15:41, Bartlomiej Zolnierkiewicz wrote:
> Isn't using u32 for storing frequency (in Hz) too small by today's
> standards?
>
> [ Please note that the old v1 binding uses kHz not Hz. ]
I have thought about this a bit more and I am somewhat confused. Yes I
agree that u32 isn't big enough for frequencies in Hz, i.e. Max value
of 4294967295 ~ 4.29 GHz.
But the bigger problem lies with the clk API that we have today. It
declares clk-rate as a unsigned-long which is 32 bits on a 32 bit
machine and 64 bits on a 64 bit machine. And every single piece of
code reading "clock-frequency" DT property, reads it as a 32 bit value
as we reserve only a single cell for it.
Now, if we wanna change that, we need to start changing from the
clk-API itself and that's not gonna be a small task and I would leave
it to Mike/Stephen for obvious reasons :)
So, I will keep this code in sync with rest of the kernel and lets see
what Mike has to say.
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/10] opp: Add support to parse "operating-points-v2" bindings
Date: Mon, 27 Jul 2015 08:32:39 +0530 [thread overview]
Message-ID: <20150727030239.GG19944@linux> (raw)
In-Reply-To: <2910042.ys2zsBBKt2@amdc1976>
On 08-07-15, 15:41, Bartlomiej Zolnierkiewicz wrote:
> Isn't using u32 for storing frequency (in Hz) too small by today's
> standards?
>
> [ Please note that the old v1 binding uses kHz not Hz. ]
I have thought about this a bit more and I am somewhat confused. Yes I
agree that u32 isn't big enough for frequencies in Hz, i.e. Max value
of 4294967295 ~ 4.29 GHz.
But the bigger problem lies with the clk API that we have today. It
declares clk-rate as a unsigned-long which is 32 bits on a 32 bit
machine and 64 bits on a 64 bit machine. And every single piece of
code reading "clock-frequency" DT property, reads it as a 32 bit value
as we reserve only a single cell for it.
Now, if we wanna change that, we need to start changing from the
clk-API itself and that's not gonna be a small task and I would leave
it to Mike/Stephen for obvious reasons :)
So, I will keep this code in sync with rest of the kernel and lets see
what Mike has to say.
--
viresh
next prev parent reply other threads:[~2015-07-27 3:02 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 11:57 [PATCH 00/10] OPP: Add code to support operating-points-v2 bindings Viresh Kumar
2015-06-15 11:57 ` Viresh Kumar
2015-06-15 11:57 ` [PATCH 01/10] opp: Relocate few routines Viresh Kumar
2015-06-15 11:57 ` Viresh Kumar
2015-07-02 1:25 ` Stephen Boyd
2015-07-02 1:25 ` Stephen Boyd
2015-07-24 17:08 ` Bartlomiej Zolnierkiewicz
2015-07-24 17:08 ` Bartlomiej Zolnierkiewicz
2015-06-15 11:57 ` [PATCH 02/10] OPP: Create _remove_device_opp() for freeing dev_opp Viresh Kumar
2015-06-15 11:57 ` Viresh Kumar
2015-07-02 1:25 ` Stephen Boyd
2015-07-02 1:25 ` Stephen Boyd
2015-07-24 17:13 ` Bartlomiej Zolnierkiewicz
2015-07-24 17:13 ` Bartlomiej Zolnierkiewicz
2015-06-15 11:57 ` [PATCH 03/10] OPP: Allocate dev_opp from _add_device_opp() Viresh Kumar
2015-06-15 11:57 ` Viresh Kumar
2015-07-02 1:02 ` Stephen Boyd
2015-07-02 1:02 ` Stephen Boyd
2015-07-02 6:24 ` Viresh Kumar
2015-07-02 6:24 ` Viresh Kumar
2015-07-02 23:46 ` Stephen Boyd
2015-07-02 23:46 ` Stephen Boyd
2015-07-03 6:45 ` Viresh Kumar
2015-07-03 6:45 ` Viresh Kumar
2015-07-06 22:31 ` Stephen Boyd
2015-07-06 22:31 ` Stephen Boyd
2015-07-24 17:25 ` Bartlomiej Zolnierkiewicz
2015-07-24 17:25 ` Bartlomiej Zolnierkiewicz
2015-06-15 11:57 ` [PATCH 04/10] OPP: Break _opp_add_dynamic() into smaller functions Viresh Kumar
2015-06-15 11:57 ` Viresh Kumar
2015-07-24 17:42 ` Bartlomiej Zolnierkiewicz
2015-07-24 17:42 ` Bartlomiej Zolnierkiewicz
2015-06-15 11:57 ` [PATCH 05/10] opp: Add support to parse "operating-points-v2" bindings Viresh Kumar
2015-06-15 11:57 ` Viresh Kumar
2015-07-02 1:13 ` Stephen Boyd
2015-07-02 1:13 ` Stephen Boyd
2015-07-02 6:38 ` Viresh Kumar
2015-07-02 6:38 ` Viresh Kumar
2015-07-02 16:07 ` Stephen Boyd
2015-07-02 16:07 ` Stephen Boyd
2015-07-03 6:08 ` Viresh Kumar
2015-07-03 6:08 ` Viresh Kumar
2015-07-08 13:41 ` Bartlomiej Zolnierkiewicz
2015-07-08 13:41 ` Bartlomiej Zolnierkiewicz
2015-07-09 5:18 ` Viresh Kumar
2015-07-09 5:18 ` Viresh Kumar
2015-07-24 18:02 ` Bartlomiej Zolnierkiewicz
2015-07-24 18:02 ` Bartlomiej Zolnierkiewicz
2015-07-27 3:14 ` Viresh Kumar
2015-07-27 3:14 ` Viresh Kumar
2015-07-27 3:02 ` Viresh Kumar [this message]
2015-07-27 3:02 ` Viresh Kumar
2015-07-28 23:03 ` Stephen Boyd
2015-07-28 23:03 ` Stephen Boyd
2015-07-29 6:53 ` Viresh Kumar
2015-07-29 6:53 ` Viresh Kumar
2015-07-30 10:17 ` Viresh Kumar
2015-07-30 10:17 ` Viresh Kumar
2015-06-15 11:57 ` [PATCH 06/10] OPP: Add clock-latency-ns support Viresh Kumar
2015-06-15 11:57 ` Viresh Kumar
2015-07-02 1:27 ` Stephen Boyd
2015-07-02 1:27 ` Stephen Boyd
2015-06-15 11:57 ` [PATCH 07/10] opp: Add OPP sharing information to OPP library Viresh Kumar
2015-06-15 11:57 ` Viresh Kumar
2015-07-17 22:51 ` Stephen Boyd
2015-07-17 22:51 ` Stephen Boyd
2015-07-18 6:33 ` Viresh Kumar
2015-07-18 6:33 ` Viresh Kumar
2015-07-20 17:46 ` Stephen Boyd
2015-07-20 17:46 ` Stephen Boyd
2015-07-21 2:18 ` Viresh Kumar
2015-07-21 2:18 ` Viresh Kumar
2015-07-27 3:20 ` Viresh Kumar
2015-07-27 3:20 ` Viresh Kumar
2015-06-15 11:57 ` [PATCH 08/10] OPP: Add support for opp-suspend Viresh Kumar
2015-06-15 11:57 ` Viresh Kumar
2015-07-17 19:22 ` Stephen Boyd
2015-07-17 19:22 ` Stephen Boyd
2015-07-18 6:32 ` Viresh Kumar
2015-07-18 6:32 ` Viresh Kumar
2015-06-15 11:57 ` [PATCH 09/10] opp: Add helpers for initializing CPU OPPs Viresh Kumar
2015-06-15 11:57 ` Viresh Kumar
2015-06-15 11:57 ` [PATCH 10/10] cpufreq-dt: Add support for operating-points-v2 bindings Viresh Kumar
2015-06-15 11:57 ` Viresh Kumar
2015-07-09 16:13 ` Bartlomiej Zolnierkiewicz
2015-07-09 16:13 ` Bartlomiej Zolnierkiewicz
2015-07-09 16:44 ` Bartlomiej Zolnierkiewicz
2015-07-09 16:44 ` Bartlomiej Zolnierkiewicz
2015-07-15 2:59 ` Viresh Kumar
2015-07-15 2:59 ` Viresh Kumar
2015-06-30 16:44 ` [PATCH 00/10] OPP: Add code to support " Viresh Kumar
2015-06-30 16:44 ` Viresh Kumar
2015-07-17 2:36 ` Viresh Kumar
2015-07-17 2:36 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150727030239.GG19944@linux \
--to=viresh.kumar@linaro.org \
--cc=Sudeep.Holla@arm.com \
--cc=arnd.bergmann@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=kesavan.abhilash@gmail.com \
--cc=khilman@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=rob.herring@linaro.org \
--cc=santosh.shilimkar@oracle.com \
--cc=sboyd@codeaurora.org \
--cc=ta.omasab@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=viswanath.puttagunta@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.