From: Sascha Hauer <s.hauer@pengutronix.de>
To: James Liao <jamesjj.liao@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Heiko Stubner <heiko@sntech.de>,
devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org, Daniel Kurtz <djkurtz@chromium.org>,
Ricky Liang <jcliang@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Sascha Hauer <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 5/9] clk: mediatek: Fix rate and dependency of MT8173 clocks
Date: Wed, 5 Aug 2015 08:53:41 +0200 [thread overview]
Message-ID: <20150805065341.GA18700@pengutronix.de> (raw)
In-Reply-To: <1438676218-11310-6-git-send-email-jamesjj.liao@mediatek.com>
On Tue, Aug 04, 2015 at 04:16:54PM +0800, James Liao wrote:
> Remove the dependency from clk_null, and give all root clocks a
> typical rate, include clkph_mck_o, usb_syspll_125m and hdmitx_dig_cts.
>
> dpi_ck was removed due to no clock reference to it.
>
> Replace parent clock of infra_cpum with cpum_ck, which is an external
> clock and can be defined in the device tree.
>
> Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
> ---
> drivers/clk/mediatek/clk-mt8173.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c
> index 361fe32..f37ace6 100644
> --- a/drivers/clk/mediatek/clk-mt8173.c
> +++ b/drivers/clk/mediatek/clk-mt8173.c
> @@ -22,10 +22,9 @@
>
> static DEFINE_SPINLOCK(mt8173_clk_lock);
>
> -static const struct mtk_fixed_factor root_clk_alias[] __initconst = {
> - FACTOR(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk_null", 1, 1),
> - FACTOR(CLK_TOP_USB_SYSPLL_125M, "usb_syspll_125m", "clk_null", 1, 1),
> - FACTOR(CLK_TOP_HDMITX_DIG_CTS, "hdmitx_dig_cts", "clk_null", 1, 1),
> +static const struct mtk_fixed_clk fixed_clks[] __initconst = {
> + FIXED_CLK(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk26m", 400 * MHZ),
> + FIXED_CLK(CLK_TOP_USB_SYSPLL_125M, "usb_syspll_125m", "clk26m", 125 * MHZ),
Hm, it seems you hide PLLs in fixed factor clock. Are you sure that
there is a PLL in the system generating 125MHz from 26MHz which is in no
way configurable? Or is this really some clock derived from the syspll
as the clock name suggests?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: James Liao <jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mike Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Heiko Stubner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Ricky Liang <jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v6 5/9] clk: mediatek: Fix rate and dependency of MT8173 clocks
Date: Wed, 5 Aug 2015 08:53:41 +0200 [thread overview]
Message-ID: <20150805065341.GA18700@pengutronix.de> (raw)
In-Reply-To: <1438676218-11310-6-git-send-email-jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On Tue, Aug 04, 2015 at 04:16:54PM +0800, James Liao wrote:
> Remove the dependency from clk_null, and give all root clocks a
> typical rate, include clkph_mck_o, usb_syspll_125m and hdmitx_dig_cts.
>
> dpi_ck was removed due to no clock reference to it.
>
> Replace parent clock of infra_cpum with cpum_ck, which is an external
> clock and can be defined in the device tree.
>
> Signed-off-by: James Liao <jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
> drivers/clk/mediatek/clk-mt8173.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c
> index 361fe32..f37ace6 100644
> --- a/drivers/clk/mediatek/clk-mt8173.c
> +++ b/drivers/clk/mediatek/clk-mt8173.c
> @@ -22,10 +22,9 @@
>
> static DEFINE_SPINLOCK(mt8173_clk_lock);
>
> -static const struct mtk_fixed_factor root_clk_alias[] __initconst = {
> - FACTOR(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk_null", 1, 1),
> - FACTOR(CLK_TOP_USB_SYSPLL_125M, "usb_syspll_125m", "clk_null", 1, 1),
> - FACTOR(CLK_TOP_HDMITX_DIG_CTS, "hdmitx_dig_cts", "clk_null", 1, 1),
> +static const struct mtk_fixed_clk fixed_clks[] __initconst = {
> + FIXED_CLK(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk26m", 400 * MHZ),
> + FIXED_CLK(CLK_TOP_USB_SYSPLL_125M, "usb_syspll_125m", "clk26m", 125 * MHZ),
Hm, it seems you hide PLLs in fixed factor clock. Are you sure that
there is a PLL in the system generating 125MHz from 26MHz which is in no
way configurable? Or is this really some clock derived from the syspll
as the clock name suggests?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 5/9] clk: mediatek: Fix rate and dependency of MT8173 clocks
Date: Wed, 5 Aug 2015 08:53:41 +0200 [thread overview]
Message-ID: <20150805065341.GA18700@pengutronix.de> (raw)
In-Reply-To: <1438676218-11310-6-git-send-email-jamesjj.liao@mediatek.com>
On Tue, Aug 04, 2015 at 04:16:54PM +0800, James Liao wrote:
> Remove the dependency from clk_null, and give all root clocks a
> typical rate, include clkph_mck_o, usb_syspll_125m and hdmitx_dig_cts.
>
> dpi_ck was removed due to no clock reference to it.
>
> Replace parent clock of infra_cpum with cpum_ck, which is an external
> clock and can be defined in the device tree.
>
> Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
> ---
> drivers/clk/mediatek/clk-mt8173.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c
> index 361fe32..f37ace6 100644
> --- a/drivers/clk/mediatek/clk-mt8173.c
> +++ b/drivers/clk/mediatek/clk-mt8173.c
> @@ -22,10 +22,9 @@
>
> static DEFINE_SPINLOCK(mt8173_clk_lock);
>
> -static const struct mtk_fixed_factor root_clk_alias[] __initconst = {
> - FACTOR(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk_null", 1, 1),
> - FACTOR(CLK_TOP_USB_SYSPLL_125M, "usb_syspll_125m", "clk_null", 1, 1),
> - FACTOR(CLK_TOP_HDMITX_DIG_CTS, "hdmitx_dig_cts", "clk_null", 1, 1),
> +static const struct mtk_fixed_clk fixed_clks[] __initconst = {
> + FIXED_CLK(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk26m", 400 * MHZ),
> + FIXED_CLK(CLK_TOP_USB_SYSPLL_125M, "usb_syspll_125m", "clk26m", 125 * MHZ),
Hm, it seems you hide PLLs in fixed factor clock. Are you sure that
there is a PLL in the system generating 125MHz from 26MHz which is in no
way configurable? Or is this really some clock derived from the syspll
as the clock name suggests?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2015-08-05 6:53 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 8:16 [PATCH v6 0/9] Fixes and new clocks support for Mediatek MT8173 James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` [PATCH v6 1/9] clk: mediatek: Removed unused dpi_ck clock from MT8173 James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` [PATCH v6 2/9] clk: mediatek: Remove unused code " James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` [PATCH v6 3/9] clk: mediatek: Add __initdata and __init for data and functions James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` [PATCH v6 4/9] clk: mediatek: Add fixed clocks support for Mediatek SoC James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` [PATCH v6 5/9] clk: mediatek: Fix rate and dependency of MT8173 clocks James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` James Liao
2015-08-05 6:53 ` Sascha Hauer [this message]
2015-08-05 6:53 ` Sascha Hauer
2015-08-05 6:53 ` Sascha Hauer
2015-08-06 8:35 ` James Liao
2015-08-06 8:35 ` James Liao
2015-08-06 8:35 ` James Liao
2015-08-06 8:59 ` Sascha Hauer
2015-08-06 8:59 ` Sascha Hauer
2015-08-06 8:59 ` Sascha Hauer
2015-08-04 8:16 ` [PATCH v6 6/9] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` [PATCH v6 7/9] clk: mediatek: Add subsystem clocks of MT8173 James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` James Liao
2015-08-05 6:46 ` Sascha Hauer
2015-08-05 6:46 ` Sascha Hauer
2015-08-05 6:46 ` Sascha Hauer
2015-08-05 7:26 ` Daniel Kurtz
2015-08-05 7:26 ` Daniel Kurtz
2015-08-05 7:26 ` Daniel Kurtz
2015-08-05 7:36 ` Sascha Hauer
2015-08-05 7:36 ` Sascha Hauer
2015-08-05 7:36 ` Sascha Hauer
2015-08-05 7:41 ` Daniel Kurtz
2015-08-05 7:41 ` Daniel Kurtz
2015-08-05 7:41 ` Daniel Kurtz
2015-08-05 7:50 ` Sascha Hauer
2015-08-05 7:50 ` Sascha Hauer
2015-08-05 7:50 ` Sascha Hauer
2015-08-05 7:58 ` Daniel Kurtz
2015-08-05 7:58 ` Daniel Kurtz
2015-08-05 7:58 ` Daniel Kurtz
2015-08-06 8:23 ` James Liao
2015-08-06 8:23 ` James Liao
2015-08-06 8:23 ` James Liao
2015-08-06 8:53 ` Sascha Hauer
2015-08-06 8:53 ` Sascha Hauer
2015-08-06 9:00 ` James Liao
2015-08-06 9:00 ` James Liao
2015-08-06 9:00 ` James Liao
2015-08-06 9:13 ` Daniel Kurtz
2015-08-06 9:13 ` Daniel Kurtz
2015-08-06 9:13 ` Daniel Kurtz
2015-08-06 10:20 ` Sascha Hauer
2015-08-06 10:20 ` Sascha Hauer
2015-08-06 10:20 ` Sascha Hauer
2015-08-07 2:20 ` James Liao
2015-08-07 2:20 ` James Liao
2015-08-07 2:20 ` James Liao
2015-08-07 8:05 ` Daniel Kurtz
2015-08-07 8:05 ` Daniel Kurtz
2015-08-07 8:05 ` Daniel Kurtz
2015-08-07 8:06 ` Daniel Kurtz
2015-08-07 8:06 ` Daniel Kurtz
2015-08-07 8:06 ` Daniel Kurtz
2015-08-04 8:16 ` [PATCH v6 8/9] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` [PATCH v6 9/9] arm64: dts: mt8173: Add subsystem clock controller device nodes James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 8:16 ` James Liao
2015-08-04 13:46 ` [PATCH v6 0/9] Fixes and new clocks support for Mediatek MT8173 Daniel Kurtz
2015-08-04 13:46 ` Daniel Kurtz
2015-08-04 13:46 ` Daniel Kurtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805065341.GA18700@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=heiko@sntech.de \
--cc=jamesjj.liao@mediatek.com \
--cc=jcliang@chromium.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.