From: Kenneth Westfield <kwestfie@codeaurora.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Patrick Lai <plai@codeaurora.org>,
alsa-devel@alsa-project.org,
Banajit Goswami <bgoswami@codeaurora.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: qcom: change PTR_ERR argument
Date: Thu, 3 Sep 2015 14:19:01 -0700 [thread overview]
Message-ID: <20150903211900.GA9014@kwestfie-linux.qualcomm.com> (raw)
In-Reply-To: <1440957911-7687-2-git-send-email-Julia.Lawall@lip6.fr>
On Sun, Aug 30, 2015 at 11:05:10AM -0700, Julia Lawall wrote:
> Apply PTR_ERR to the value that was recently assigned.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x,y;
> @@
>
> if (IS_ERR(x) || ...) {
> ... when any
> when != IS_ERR(...)
> (
> PTR_ERR(x)
> |
> * PTR_ERR(y)
> )
> ... when any
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
The patch itself looks good. Thanks.
Acked-by: Kenneth Westfield <kwestfie@codeaurora.org>
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Kenneth Westfield <kwestfie@codeaurora.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Patrick Lai <plai@codeaurora.org>,
alsa-devel@alsa-project.org,
Banajit Goswami <bgoswami@codeaurora.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: qcom: change PTR_ERR argument
Date: Thu, 03 Sep 2015 21:19:01 +0000 [thread overview]
Message-ID: <20150903211900.GA9014@kwestfie-linux.qualcomm.com> (raw)
In-Reply-To: <1440957911-7687-2-git-send-email-Julia.Lawall@lip6.fr>
On Sun, Aug 30, 2015 at 11:05:10AM -0700, Julia Lawall wrote:
> Apply PTR_ERR to the value that was recently assigned.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x,y;
> @@
>
> if (IS_ERR(x) || ...) {
> ... when any
> when != IS_ERR(...)
> (
> PTR_ERR(x)
> |
> * PTR_ERR(y)
> )
> ... when any
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
The patch itself looks good. Thanks.
Acked-by: Kenneth Westfield <kwestfie@codeaurora.org>
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-09-03 21:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-30 18:05 [PATCH 0/2] change PTR_ERR argument Julia Lawall
2015-08-30 18:05 ` Julia Lawall
2015-08-30 18:05 ` Julia Lawall
2015-08-30 18:05 ` [PATCH 1/2] ASoC: qcom: " Julia Lawall
2015-08-30 18:05 ` Julia Lawall
2015-08-30 18:54 ` walter harms
2015-08-30 18:54 ` walter harms
2015-08-30 19:54 ` Julia Lawall
2015-08-30 19:54 ` Julia Lawall
2015-09-03 21:36 ` [alsa-devel] " Kenneth Westfield
2015-09-03 21:36 ` Kenneth Westfield
2015-09-03 21:33 ` Kenneth Westfield
2015-09-03 21:33 ` Kenneth Westfield
2015-09-03 21:19 ` Kenneth Westfield [this message]
2015-09-03 21:19 ` Kenneth Westfield
2015-09-14 18:04 ` Mark Brown
2015-09-14 18:04 ` Mark Brown
2015-09-14 18:04 ` Mark Brown
2015-09-17 8:46 ` Julia Lawall
2015-09-17 8:46 ` Julia Lawall
2015-09-17 8:46 ` Julia Lawall
2015-09-17 9:21 ` Mark Brown
2015-09-17 9:21 ` Mark Brown
2015-09-17 9:21 ` Mark Brown
2015-09-17 8:47 ` Julia Lawall
2015-09-17 8:47 ` Julia Lawall
2015-09-17 17:36 ` Applied "ASoC: qcom: change PTR_ERR argument" to the asoc tree Mark Brown
2015-08-30 18:05 ` [PATCH 2/2] spi: spi-ep93xx: change PTR_ERR argument Julia Lawall
2015-08-30 18:05 ` Julia Lawall
2015-08-30 18:31 ` walter harms
2015-08-30 18:31 ` walter harms
2015-08-30 20:10 ` [PATCH 2/2 v2] spi: spi-ep93xx: fix PTR_ERR problem Julia Lawall
2015-08-30 20:10 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903211900.GA9014@kwestfie-linux.qualcomm.com \
--to=kwestfie@codeaurora.org \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.