From: walter harms <wharms@bfs.de> To: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Mark Brown <broonie@kernel.org>, kernel-janitors@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] spi: spi-ep93xx: change PTR_ERR argument Date: Sun, 30 Aug 2015 20:31:42 +0200 [thread overview] Message-ID: <55E34C0E.5000702@bfs.de> (raw) In-Reply-To: <1440957911-7687-3-git-send-email-Julia.Lawall@lip6.fr> Am 30.08.2015 20:05, schrieb Julia Lawall: > Apply PTR_ERR to the value that was recently assigned. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression x,y; > @@ > > if (IS_ERR(x) || ...) { > ... when any > when != IS_ERR(...) > ( > PTR_ERR(x) > | > * PTR_ERR(y) > ) > ... when any > } > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > drivers/spi/spi-ep93xx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c > index bb00be8..1a7696c 100644 > --- a/drivers/spi/spi-ep93xx.c > +++ b/drivers/spi/spi-ep93xx.c > @@ -567,7 +567,8 @@ static void ep93xx_spi_dma_transfer(struct ep93xx_spi *espi) > txd = ep93xx_spi_dma_prepare(espi, DMA_MEM_TO_DEV); > if (IS_ERR(txd)) { > ep93xx_spi_dma_finish(espi, DMA_DEV_TO_MEM); > - dev_err(&espi->pdev->dev, "DMA TX failed: %ld\n", PTR_ERR(rxd)); > + dev_err(&espi->pdev->dev, "DMA TX failed: %ld\n", > + PTR_ERR(txd)); > msg->status = PTR_ERR(txd); > return; > } > I improve readability i would suggest: ep93xx_spi_dma_finish(espi, DMA_DEV_TO_MEM); msg->status = PTR_ERR(txd); dev_err(&espi->pdev->dev, "DMA TX failed: %ld\n",msg->status): return; just my 2 cents, re, wh > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de> To: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Mark Brown <broonie@kernel.org>, kernel-janitors@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] spi: spi-ep93xx: change PTR_ERR argument Date: Sun, 30 Aug 2015 18:31:42 +0000 [thread overview] Message-ID: <55E34C0E.5000702@bfs.de> (raw) In-Reply-To: <1440957911-7687-3-git-send-email-Julia.Lawall@lip6.fr> Am 30.08.2015 20:05, schrieb Julia Lawall: > Apply PTR_ERR to the value that was recently assigned. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression x,y; > @@ > > if (IS_ERR(x) || ...) { > ... when any > when != IS_ERR(...) > ( > PTR_ERR(x) > | > * PTR_ERR(y) > ) > ... when any > } > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > drivers/spi/spi-ep93xx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c > index bb00be8..1a7696c 100644 > --- a/drivers/spi/spi-ep93xx.c > +++ b/drivers/spi/spi-ep93xx.c > @@ -567,7 +567,8 @@ static void ep93xx_spi_dma_transfer(struct ep93xx_spi *espi) > txd = ep93xx_spi_dma_prepare(espi, DMA_MEM_TO_DEV); > if (IS_ERR(txd)) { > ep93xx_spi_dma_finish(espi, DMA_DEV_TO_MEM); > - dev_err(&espi->pdev->dev, "DMA TX failed: %ld\n", PTR_ERR(rxd)); > + dev_err(&espi->pdev->dev, "DMA TX failed: %ld\n", > + PTR_ERR(txd)); > msg->status = PTR_ERR(txd); > return; > } > I improve readability i would suggest: ep93xx_spi_dma_finish(espi, DMA_DEV_TO_MEM); msg->status = PTR_ERR(txd); dev_err(&espi->pdev->dev, "DMA TX failed: %ld\n",msg->status): return; just my 2 cents, re, wh > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2015-08-30 18:31 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-30 18:05 [PATCH 0/2] change PTR_ERR argument Julia Lawall 2015-08-30 18:05 ` Julia Lawall 2015-08-30 18:05 ` Julia Lawall 2015-08-30 18:05 ` [PATCH 1/2] ASoC: qcom: " Julia Lawall 2015-08-30 18:05 ` Julia Lawall 2015-08-30 18:54 ` walter harms 2015-08-30 18:54 ` walter harms 2015-08-30 19:54 ` Julia Lawall 2015-08-30 19:54 ` Julia Lawall 2015-09-03 21:36 ` [alsa-devel] " Kenneth Westfield 2015-09-03 21:36 ` Kenneth Westfield 2015-09-03 21:33 ` Kenneth Westfield 2015-09-03 21:33 ` Kenneth Westfield 2015-09-03 21:19 ` Kenneth Westfield 2015-09-03 21:19 ` Kenneth Westfield 2015-09-14 18:04 ` Mark Brown 2015-09-14 18:04 ` Mark Brown 2015-09-14 18:04 ` Mark Brown 2015-09-17 8:46 ` Julia Lawall 2015-09-17 8:46 ` Julia Lawall 2015-09-17 8:46 ` Julia Lawall 2015-09-17 9:21 ` Mark Brown 2015-09-17 9:21 ` Mark Brown 2015-09-17 9:21 ` Mark Brown 2015-09-17 8:47 ` Julia Lawall 2015-09-17 8:47 ` Julia Lawall 2015-09-17 17:36 ` Applied "ASoC: qcom: change PTR_ERR argument" to the asoc tree Mark Brown 2015-08-30 18:05 ` [PATCH 2/2] spi: spi-ep93xx: change PTR_ERR argument Julia Lawall 2015-08-30 18:05 ` Julia Lawall 2015-08-30 18:31 ` walter harms [this message] 2015-08-30 18:31 ` walter harms 2015-08-30 20:10 ` [PATCH 2/2 v2] spi: spi-ep93xx: fix PTR_ERR problem Julia Lawall 2015-08-30 20:10 ` Julia Lawall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55E34C0E.5000702@bfs.de \ --to=wharms@bfs.de \ --cc=Julia.Lawall@lip6.fr \ --cc=broonie@kernel.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.