From: Thierry Reding <treding@nvidia.com>
To: Archit Taneja <architt@codeaurora.org>
Cc: dri-devel@lists.freedesktop.org, a.hajda@samsung.com,
jani.nikula@linux.intel.com, linux-kernel@vger.kernel.org,
airlied@linux.ie, daniel@ffwll.ch, l.stach@pengutronix.de,
robh@kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 5/6] drm/dsi: Add routine to unregister dsi device
Date: Thu, 21 Jan 2016 17:12:58 +0100 [thread overview]
Message-ID: <20160121161257.GE647@ulmo.nvidia.com> (raw)
In-Reply-To: <1449751300-2841-6-git-send-email-architt@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
On Thu, Dec 10, 2015 at 06:11:39PM +0530, Archit Taneja wrote:
> A driver calling mipi_dsi_device_new might want to unregister the device
> once it's done. It might also require it in an error handling path in
> case something didn't go right.
>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Archit Taneja <architt@codeaurora.org>
> ---
> include/drm/drm_mipi_dsi.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
> index cb084af..410d8b5 100644
> --- a/include/drm/drm_mipi_dsi.h
> +++ b/include/drm/drm_mipi_dsi.h
> @@ -195,6 +195,11 @@ ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *dsi, const void *params,
>
> struct mipi_dsi_device *mipi_dsi_device_new(struct mipi_dsi_host *host,
> struct mipi_dsi_device_info *info);
> +static inline void mipi_dsi_device_unregister(struct mipi_dsi_device *dsi)
> +{
> + device_unregister(&dsi->dev);
> +}
This is the same, essentially, as mipi_dsi_remove_device_fn(). I think
this should move into drm_mipi_dsi.c and mipi_dsi_remove_device_fn()
should call this new function so that both OF and !OF share the same
code for this.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <treding@nvidia.com>
To: Archit Taneja <architt@codeaurora.org>
Cc: <dri-devel@lists.freedesktop.org>, <a.hajda@samsung.com>,
<jani.nikula@linux.intel.com>, <linux-kernel@vger.kernel.org>,
<airlied@linux.ie>, <daniel@ffwll.ch>, <l.stach@pengutronix.de>,
<robh@kernel.org>, <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v4 5/6] drm/dsi: Add routine to unregister dsi device
Date: Thu, 21 Jan 2016 17:12:58 +0100 [thread overview]
Message-ID: <20160121161257.GE647@ulmo.nvidia.com> (raw)
In-Reply-To: <1449751300-2841-6-git-send-email-architt@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
On Thu, Dec 10, 2015 at 06:11:39PM +0530, Archit Taneja wrote:
> A driver calling mipi_dsi_device_new might want to unregister the device
> once it's done. It might also require it in an error handling path in
> case something didn't go right.
>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Archit Taneja <architt@codeaurora.org>
> ---
> include/drm/drm_mipi_dsi.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
> index cb084af..410d8b5 100644
> --- a/include/drm/drm_mipi_dsi.h
> +++ b/include/drm/drm_mipi_dsi.h
> @@ -195,6 +195,11 @@ ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *dsi, const void *params,
>
> struct mipi_dsi_device *mipi_dsi_device_new(struct mipi_dsi_host *host,
> struct mipi_dsi_device_info *info);
> +static inline void mipi_dsi_device_unregister(struct mipi_dsi_device *dsi)
> +{
> + device_unregister(&dsi->dev);
> +}
This is the same, essentially, as mipi_dsi_remove_device_fn(). I think
this should move into drm_mipi_dsi.c and mipi_dsi_remove_device_fn()
should call this new function so that both OF and !OF share the same
code for this.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-21 16:13 UTC|newest]
Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 5:24 [RFC 0/2] drm/dsi: DSI for devices with different control bus Archit Taneja
2015-06-30 5:24 ` [RFC 1/2] drm/dsi: Create dummy DSI devices Archit Taneja
2015-06-30 5:24 ` Archit Taneja
2015-08-19 8:10 ` Andrzej Hajda
2015-08-19 8:10 ` Andrzej Hajda
2015-08-19 9:30 ` Archit Taneja
2015-06-30 5:24 ` [RFC 2/2] drm/dsi: Get DSI host by DT device node Archit Taneja
2015-06-30 5:24 ` Archit Taneja
2015-08-19 8:46 ` Andrzej Hajda
2015-08-19 8:46 ` Andrzej Hajda
2015-08-19 5:07 ` [RFC 0/2] drm/dsi: DSI for devices with different control bus Archit Taneja
2015-08-19 13:13 ` Thierry Reding
2015-08-19 13:13 ` Thierry Reding
2015-08-19 14:17 ` Lucas Stach
2015-08-19 14:34 ` Thierry Reding
2015-08-19 14:34 ` Thierry Reding
2015-08-19 14:52 ` Lucas Stach
2015-08-19 14:52 ` Lucas Stach
2015-08-19 15:02 ` Thierry Reding
2015-08-19 15:02 ` Thierry Reding
2015-08-19 15:39 ` Jani Nikula
2015-08-20 4:16 ` Archit Taneja
2015-08-20 11:48 ` Thierry Reding
2015-08-20 11:48 ` Thierry Reding
2015-08-21 6:09 ` Archit Taneja
2015-08-21 6:09 ` Archit Taneja
2015-09-07 11:46 ` Archit Taneja
2015-09-07 11:46 ` Archit Taneja
2015-09-08 10:27 ` Andrzej Hajda
2015-09-10 6:15 ` Archit Taneja
2015-09-10 6:15 ` Archit Taneja
2015-09-10 7:32 ` Thierry Reding
2015-09-10 7:32 ` Thierry Reding
2015-09-15 10:32 ` Archit Taneja
2015-09-15 10:32 ` Archit Taneja
2015-09-15 15:43 ` Rob Herring
2015-09-17 8:56 ` Archit Taneja
2015-09-15 10:41 ` Archit Taneja
2015-09-15 10:41 ` Archit Taneja
2015-10-06 9:24 ` [RFC v2 0/5] " Archit Taneja
2015-10-06 9:24 ` [RFC v2 1/5] drm/dsi: Refactor device creation Archit Taneja
2015-10-06 9:24 ` Archit Taneja
2015-10-30 11:28 ` Andrzej Hajda
2015-10-30 11:28 ` Andrzej Hajda
2015-10-06 9:24 ` [RFC v2 2/5] drm/dsi: Try to match non-DT dsi devices Archit Taneja
2015-10-06 9:24 ` Archit Taneja
2015-10-30 12:42 ` Andrzej Hajda
2015-10-30 12:42 ` Andrzej Hajda
2015-11-02 5:26 ` Archit Taneja
2015-11-02 5:26 ` Archit Taneja
2015-10-06 9:24 ` [RFC v2 3/5] drm/dsi: Check for used channels Archit Taneja
2015-10-06 9:24 ` Archit Taneja
2015-10-30 12:52 ` Andrzej Hajda
2015-11-02 5:28 ` Archit Taneja
2015-11-02 5:28 ` Archit Taneja
2015-10-06 9:24 ` [RFC v2 4/5] drm/dsi: Add routine to unregister dsi device Archit Taneja
2015-10-06 9:24 ` Archit Taneja
2015-10-30 14:21 ` Andrzej Hajda
2015-10-30 14:21 ` Andrzej Hajda
2015-11-02 6:28 ` Archit Taneja
2015-11-02 10:42 ` Andrzej Hajda
2015-11-03 7:18 ` Archit Taneja
2015-10-06 9:24 ` [RFC v2 5/5] drm/dsi: Get DSI host by DT device node Archit Taneja
2015-10-06 9:24 ` Archit Taneja
2015-10-06 10:00 ` kbuild test robot
2015-10-06 10:00 ` kbuild test robot
2015-11-02 10:50 ` Andrzej Hajda
2015-11-02 10:50 ` Andrzej Hajda
2015-11-03 7:20 ` Archit Taneja
2015-11-03 7:20 ` Archit Taneja
2015-11-30 12:01 ` [PATCH v3 0/5] drm/dsi: DSI for devices with different control bus Archit Taneja
2015-11-30 12:01 ` [PATCH v3 1/5] drm/dsi: Refactor device creation Archit Taneja
2015-11-30 12:01 ` Archit Taneja
2015-11-30 12:01 ` [PATCH v3 2/5] drm/dsi: Try to match non-DT dsi devices Archit Taneja
2015-11-30 12:01 ` Archit Taneja
2015-11-30 12:45 ` kbuild test robot
2015-11-30 12:45 ` kbuild test robot
2015-12-07 5:29 ` Archit Taneja
2015-12-07 8:45 ` Jani Nikula
2015-12-07 8:59 ` Archit Taneja
2015-12-07 8:59 ` Archit Taneja
2015-12-07 9:10 ` Jani Nikula
2015-12-07 9:10 ` Jani Nikula
2015-12-07 9:18 ` Archit Taneja
2015-12-07 10:07 ` Jani Nikula
2015-12-07 16:55 ` Rob Clark
2015-11-30 12:01 ` [PATCH v3 3/5] drm/dsi: Check for used channels Archit Taneja
2015-11-30 12:01 ` Archit Taneja
2015-11-30 12:01 ` [PATCH v3 4/5] drm/dsi: Add routine to unregister dsi device Archit Taneja
2015-11-30 12:01 ` Archit Taneja
2015-11-30 12:34 ` Andrzej Hajda
2015-11-30 12:34 ` Andrzej Hajda
2015-11-30 12:01 ` [PATCH v3 5/5] drm/dsi: Get DSI host by DT device node Archit Taneja
2015-11-30 12:01 ` Archit Taneja
2015-12-10 12:41 ` [PATCH v4 0/6] drm/dsi: DSI for devices with different control bus Archit Taneja
2015-12-10 12:41 ` [PATCH v4 1/6] drm/dsi: check for CONFIG_OF when defining of_mipi_dsi_device_add Archit Taneja
2015-12-10 12:41 ` Archit Taneja
2016-01-21 15:31 ` Thierry Reding
2016-01-21 15:31 ` Thierry Reding
2016-01-26 14:59 ` Archit Taneja
2016-01-26 14:59 ` Archit Taneja
2015-12-10 12:41 ` [PATCH v4 2/6] drm/dsi: Refactor device creation Archit Taneja
2016-01-21 15:46 ` Thierry Reding
2016-01-21 15:46 ` Thierry Reding
2016-01-26 17:05 ` Archit Taneja
2016-01-26 17:05 ` Archit Taneja
2015-12-10 12:41 ` [PATCH v4 3/6] drm/dsi: Try to match non-DT dsi devices Archit Taneja
2015-12-10 12:41 ` Archit Taneja
2016-01-21 16:05 ` Thierry Reding
2016-01-21 16:05 ` Thierry Reding
2016-01-26 18:04 ` Archit Taneja
2016-01-26 18:04 ` Archit Taneja
2015-12-10 12:41 ` [PATCH v4 4/6] drm/dsi: Check for used channels Archit Taneja
2015-12-10 12:41 ` Archit Taneja
2016-01-21 16:11 ` Thierry Reding
2016-01-21 16:11 ` Thierry Reding
2016-01-27 5:16 ` Archit Taneja
2016-01-27 5:16 ` Archit Taneja
2015-12-10 12:41 ` [PATCH v4 5/6] drm/dsi: Add routine to unregister dsi device Archit Taneja
2015-12-10 12:41 ` Archit Taneja
2016-01-21 16:12 ` Thierry Reding [this message]
2016-01-21 16:12 ` Thierry Reding
2016-01-27 5:20 ` Archit Taneja
2015-12-10 12:41 ` [PATCH v4 6/6] drm/dsi: Get DSI host by DT device node Archit Taneja
2015-12-10 12:41 ` Archit Taneja
2016-01-21 16:16 ` Thierry Reding
2016-01-21 16:16 ` Thierry Reding
2016-01-27 5:21 ` Archit Taneja
2016-01-27 5:21 ` Archit Taneja
2016-01-05 5:29 ` [PATCH v4 0/6] drm/dsi: DSI for devices with different control bus Archit Taneja
2016-02-12 9:18 ` [PATCH v5 0/5] " Archit Taneja
2016-02-12 9:18 ` Archit Taneja
2016-02-12 9:18 ` [PATCH v5 1/5] drm/dsi: check for CONFIG_OF when defining of_mipi_dsi_device_add Archit Taneja
2016-02-12 9:18 ` Archit Taneja
2016-02-12 9:18 ` [PATCH v5 2/5] drm/dsi: Use mipi_dsi_device_register_full for DSI device creation Archit Taneja
2016-02-12 9:18 ` Archit Taneja
2016-02-12 9:18 ` [PATCH v5 3/5] drm/dsi: Try to match non-DT DSI devices Archit Taneja
2016-02-12 9:18 ` Archit Taneja
2016-02-12 9:18 ` [PATCH v5 4/5] drm/dsi: Add routine to unregister a DSI device Archit Taneja
2016-02-12 9:18 ` Archit Taneja
2016-02-12 9:18 ` [PATCH v5 5/5] drm/dsi: Get DSI host by DT device node Archit Taneja
2016-02-12 9:18 ` Archit Taneja
2016-03-02 16:05 ` [PATCH v5 0/5] drm/dsi: DSI for devices with different control bus Thierry Reding
2016-03-02 16:05 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121161257.GE647@ulmo.nvidia.com \
--to=treding@nvidia.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.