From: Andrzej Hajda <a.hajda@samsung.com> To: Archit Taneja <architt@codeaurora.org>, dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, treding@nvidia.com Subject: Re: [RFC 1/2] drm/dsi: Create dummy DSI devices Date: Wed, 19 Aug 2015 10:10:14 +0200 [thread overview] Message-ID: <55D439E6.3080604@samsung.com> (raw) In-Reply-To: <1435641851-27295-2-git-send-email-architt@codeaurora.org> On 06/30/2015 07:24 AM, Archit Taneja wrote: > We can have devices where the data bus is MIPI DSI, but the control bus > is something else (i2c, spi etc). A typical example is i2c controlled > encoder bridge chips. > > Such devices too require passing DSI specific parameters (number of data > lanes, DSI mode flags, color format etc) to their DSI host. For a device > that isn't 'mipi_dsi_device', there is no way of passing such parameters. > > Provide the option of creating a dummy DSI device. The main purpose of > this would be to attach to a DSI host by calling mipi_dsi_attach, and > pass DSI params. > > Create mipi_dsi_new_dummy for creating a dummy dsi device. The driver > calling this needs to be aware of the mipi_dsi_host it wants to attach > to, and also the DSI virtual channel the DSI device intends to use. > > Signed-off-by: Archit Taneja <architt@codeaurora.org> > --- > drivers/gpu/drm/drm_mipi_dsi.c | 78 ++++++++++++++++++++++++++++++++++++++++-- > include/drm/drm_mipi_dsi.h | 2 ++ > 2 files changed, 78 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index 2d5ca8ee..9bfe215 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -47,7 +47,14 @@ > > static int mipi_dsi_device_match(struct device *dev, struct device_driver *drv) > { > - return of_driver_match_device(dev, drv); > + if (of_driver_match_device(dev, drv)) > + return 1; > + > + if (!strcmp(drv->name, "mipi_dsi_dummy") && > + strstr(dev_name(dev), "dummy_dev")) > + return 1; Is this kind of fuzzy matching used in other dummy devs? It looks little bit scary. You can at least replace strstr(dev_name(dev), "dummy_dev")) with strstr(dev_name(dev), ".dummy_dev.")) Anyway, currently it should not break anything, am I right? > + > + return 0; > } > > static const struct dev_pm_ops mipi_dsi_device_pm_ops = { > @@ -171,6 +178,67 @@ of_mipi_dsi_device_add(struct mipi_dsi_host *host, struct device_node *node) > return dsi; > } > > +static int dummy_probe(struct mipi_dsi_device *dsi) > +{ > + return 0; > +} > + > +static int dummy_remove(struct mipi_dsi_device *dsi) > +{ > + return 0; > +} > + > +static void dummy_shutdown(struct mipi_dsi_device *dsi) > +{ > +} I suppose these callbacks are optional, so you can omit them. > + > +static struct mipi_dsi_driver dummy_dsi_driver = { > + .probe = dummy_probe, > + .remove = dummy_remove, > + .shutdown = dummy_shutdown, > + .driver.name = "mipi_dsi_dummy", > +}; > + > +static int mipi_dsi_device_add_dummy(struct mipi_dsi_device *dsi) > +{ > + struct mipi_dsi_host *host = dsi->host; > + > + dev_set_name(&dsi->dev, "%s.dummy_dev.%d", dev_name(host->dev), > + dsi->channel); > + > + return device_add(&dsi->dev); > +} > + > +struct mipi_dsi_device *mipi_dsi_new_dummy(struct mipi_dsi_host *host, u32 reg) > +{ > + struct mipi_dsi_device *dsi; > + struct device *dev = host->dev; > + int ret; > + > + if (reg > 3) { > + dev_err(dev, "invalid reg property %u\n", reg); > + return ERR_PTR(-EINVAL); > + } > + > + dsi = mipi_dsi_device_alloc(host); > + if (IS_ERR(dsi)) { > + dev_err(dev, "failed to allocate dummy DSI device %ld\n", > + PTR_ERR(dsi)); > + return dsi; > + } > + > + dsi->channel = reg; > + > + ret = mipi_dsi_device_add_dummy(dsi); > + if (ret) { > + dev_err(dev, "failed to add dummy DSI device %d\n", ret); > + kfree(dsi); > + return ERR_PTR(ret); > + } > + > + return dsi; > +} > + > int mipi_dsi_host_register(struct mipi_dsi_host *host) > { > struct device_node *node; > @@ -924,7 +992,13 @@ EXPORT_SYMBOL(mipi_dsi_driver_unregister); > > static int __init mipi_dsi_bus_init(void) > { > - return bus_register(&mipi_dsi_bus_type); > + int ret; > + > + ret = bus_register(&mipi_dsi_bus_type); > + if (ret < 0) > + return ret; > + > + return mipi_dsi_driver_register(&dummy_dsi_driver); > } > postcore_initcall(mipi_dsi_bus_init); > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index f1d8d0d..d06ba99 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -174,6 +174,8 @@ ssize_t mipi_dsi_generic_write(struct mipi_dsi_device *dsi, const void *payload, > ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *dsi, const void *params, > size_t num_params, void *data, size_t size); > > +struct mipi_dsi_device *mipi_dsi_new_dummy(struct mipi_dsi_host *host, u32 reg); > + > /** > * enum mipi_dsi_dcs_tear_mode - Tearing Effect Output Line mode > * @MIPI_DSI_DCS_TEAR_MODE_VBLANK: the TE output line consists of V-Blanking _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Hajda <a.hajda@samsung.com> To: Archit Taneja <architt@codeaurora.org>, dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, treding@nvidia.com, inki.dae@samsung.com, linux-kernel@vger.kernel.org, airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com Subject: Re: [RFC 1/2] drm/dsi: Create dummy DSI devices Date: Wed, 19 Aug 2015 10:10:14 +0200 [thread overview] Message-ID: <55D439E6.3080604@samsung.com> (raw) In-Reply-To: <1435641851-27295-2-git-send-email-architt@codeaurora.org> On 06/30/2015 07:24 AM, Archit Taneja wrote: > We can have devices where the data bus is MIPI DSI, but the control bus > is something else (i2c, spi etc). A typical example is i2c controlled > encoder bridge chips. > > Such devices too require passing DSI specific parameters (number of data > lanes, DSI mode flags, color format etc) to their DSI host. For a device > that isn't 'mipi_dsi_device', there is no way of passing such parameters. > > Provide the option of creating a dummy DSI device. The main purpose of > this would be to attach to a DSI host by calling mipi_dsi_attach, and > pass DSI params. > > Create mipi_dsi_new_dummy for creating a dummy dsi device. The driver > calling this needs to be aware of the mipi_dsi_host it wants to attach > to, and also the DSI virtual channel the DSI device intends to use. > > Signed-off-by: Archit Taneja <architt@codeaurora.org> > --- > drivers/gpu/drm/drm_mipi_dsi.c | 78 ++++++++++++++++++++++++++++++++++++++++-- > include/drm/drm_mipi_dsi.h | 2 ++ > 2 files changed, 78 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index 2d5ca8ee..9bfe215 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -47,7 +47,14 @@ > > static int mipi_dsi_device_match(struct device *dev, struct device_driver *drv) > { > - return of_driver_match_device(dev, drv); > + if (of_driver_match_device(dev, drv)) > + return 1; > + > + if (!strcmp(drv->name, "mipi_dsi_dummy") && > + strstr(dev_name(dev), "dummy_dev")) > + return 1; Is this kind of fuzzy matching used in other dummy devs? It looks little bit scary. You can at least replace strstr(dev_name(dev), "dummy_dev")) with strstr(dev_name(dev), ".dummy_dev.")) Anyway, currently it should not break anything, am I right? > + > + return 0; > } > > static const struct dev_pm_ops mipi_dsi_device_pm_ops = { > @@ -171,6 +178,67 @@ of_mipi_dsi_device_add(struct mipi_dsi_host *host, struct device_node *node) > return dsi; > } > > +static int dummy_probe(struct mipi_dsi_device *dsi) > +{ > + return 0; > +} > + > +static int dummy_remove(struct mipi_dsi_device *dsi) > +{ > + return 0; > +} > + > +static void dummy_shutdown(struct mipi_dsi_device *dsi) > +{ > +} I suppose these callbacks are optional, so you can omit them. > + > +static struct mipi_dsi_driver dummy_dsi_driver = { > + .probe = dummy_probe, > + .remove = dummy_remove, > + .shutdown = dummy_shutdown, > + .driver.name = "mipi_dsi_dummy", > +}; > + > +static int mipi_dsi_device_add_dummy(struct mipi_dsi_device *dsi) > +{ > + struct mipi_dsi_host *host = dsi->host; > + > + dev_set_name(&dsi->dev, "%s.dummy_dev.%d", dev_name(host->dev), > + dsi->channel); > + > + return device_add(&dsi->dev); > +} > + > +struct mipi_dsi_device *mipi_dsi_new_dummy(struct mipi_dsi_host *host, u32 reg) > +{ > + struct mipi_dsi_device *dsi; > + struct device *dev = host->dev; > + int ret; > + > + if (reg > 3) { > + dev_err(dev, "invalid reg property %u\n", reg); > + return ERR_PTR(-EINVAL); > + } > + > + dsi = mipi_dsi_device_alloc(host); > + if (IS_ERR(dsi)) { > + dev_err(dev, "failed to allocate dummy DSI device %ld\n", > + PTR_ERR(dsi)); > + return dsi; > + } > + > + dsi->channel = reg; > + > + ret = mipi_dsi_device_add_dummy(dsi); > + if (ret) { > + dev_err(dev, "failed to add dummy DSI device %d\n", ret); > + kfree(dsi); > + return ERR_PTR(ret); > + } > + > + return dsi; > +} > + > int mipi_dsi_host_register(struct mipi_dsi_host *host) > { > struct device_node *node; > @@ -924,7 +992,13 @@ EXPORT_SYMBOL(mipi_dsi_driver_unregister); > > static int __init mipi_dsi_bus_init(void) > { > - return bus_register(&mipi_dsi_bus_type); > + int ret; > + > + ret = bus_register(&mipi_dsi_bus_type); > + if (ret < 0) > + return ret; > + > + return mipi_dsi_driver_register(&dummy_dsi_driver); > } > postcore_initcall(mipi_dsi_bus_init); > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index f1d8d0d..d06ba99 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -174,6 +174,8 @@ ssize_t mipi_dsi_generic_write(struct mipi_dsi_device *dsi, const void *payload, > ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *dsi, const void *params, > size_t num_params, void *data, size_t size); > > +struct mipi_dsi_device *mipi_dsi_new_dummy(struct mipi_dsi_host *host, u32 reg); > + > /** > * enum mipi_dsi_dcs_tear_mode - Tearing Effect Output Line mode > * @MIPI_DSI_DCS_TEAR_MODE_VBLANK: the TE output line consists of V-Blanking
next prev parent reply other threads:[~2015-08-19 8:10 UTC|newest] Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-30 5:24 [RFC 0/2] drm/dsi: DSI for devices with different control bus Archit Taneja 2015-06-30 5:24 ` [RFC 1/2] drm/dsi: Create dummy DSI devices Archit Taneja 2015-06-30 5:24 ` Archit Taneja 2015-08-19 8:10 ` Andrzej Hajda [this message] 2015-08-19 8:10 ` Andrzej Hajda 2015-08-19 9:30 ` Archit Taneja 2015-06-30 5:24 ` [RFC 2/2] drm/dsi: Get DSI host by DT device node Archit Taneja 2015-06-30 5:24 ` Archit Taneja 2015-08-19 8:46 ` Andrzej Hajda 2015-08-19 8:46 ` Andrzej Hajda 2015-08-19 5:07 ` [RFC 0/2] drm/dsi: DSI for devices with different control bus Archit Taneja 2015-08-19 13:13 ` Thierry Reding 2015-08-19 13:13 ` Thierry Reding 2015-08-19 14:17 ` Lucas Stach 2015-08-19 14:34 ` Thierry Reding 2015-08-19 14:34 ` Thierry Reding 2015-08-19 14:52 ` Lucas Stach 2015-08-19 14:52 ` Lucas Stach 2015-08-19 15:02 ` Thierry Reding 2015-08-19 15:02 ` Thierry Reding 2015-08-19 15:39 ` Jani Nikula 2015-08-20 4:16 ` Archit Taneja 2015-08-20 11:48 ` Thierry Reding 2015-08-20 11:48 ` Thierry Reding 2015-08-21 6:09 ` Archit Taneja 2015-08-21 6:09 ` Archit Taneja 2015-09-07 11:46 ` Archit Taneja 2015-09-07 11:46 ` Archit Taneja 2015-09-08 10:27 ` Andrzej Hajda 2015-09-10 6:15 ` Archit Taneja 2015-09-10 6:15 ` Archit Taneja 2015-09-10 7:32 ` Thierry Reding 2015-09-10 7:32 ` Thierry Reding 2015-09-15 10:32 ` Archit Taneja 2015-09-15 10:32 ` Archit Taneja 2015-09-15 15:43 ` Rob Herring 2015-09-17 8:56 ` Archit Taneja 2015-09-15 10:41 ` Archit Taneja 2015-09-15 10:41 ` Archit Taneja 2015-10-06 9:24 ` [RFC v2 0/5] " Archit Taneja 2015-10-06 9:24 ` [RFC v2 1/5] drm/dsi: Refactor device creation Archit Taneja 2015-10-06 9:24 ` Archit Taneja 2015-10-30 11:28 ` Andrzej Hajda 2015-10-30 11:28 ` Andrzej Hajda 2015-10-06 9:24 ` [RFC v2 2/5] drm/dsi: Try to match non-DT dsi devices Archit Taneja 2015-10-06 9:24 ` Archit Taneja 2015-10-30 12:42 ` Andrzej Hajda 2015-10-30 12:42 ` Andrzej Hajda 2015-11-02 5:26 ` Archit Taneja 2015-11-02 5:26 ` Archit Taneja 2015-10-06 9:24 ` [RFC v2 3/5] drm/dsi: Check for used channels Archit Taneja 2015-10-06 9:24 ` Archit Taneja 2015-10-30 12:52 ` Andrzej Hajda 2015-11-02 5:28 ` Archit Taneja 2015-11-02 5:28 ` Archit Taneja 2015-10-06 9:24 ` [RFC v2 4/5] drm/dsi: Add routine to unregister dsi device Archit Taneja 2015-10-06 9:24 ` Archit Taneja 2015-10-30 14:21 ` Andrzej Hajda 2015-10-30 14:21 ` Andrzej Hajda 2015-11-02 6:28 ` Archit Taneja 2015-11-02 10:42 ` Andrzej Hajda 2015-11-03 7:18 ` Archit Taneja 2015-10-06 9:24 ` [RFC v2 5/5] drm/dsi: Get DSI host by DT device node Archit Taneja 2015-10-06 9:24 ` Archit Taneja 2015-10-06 10:00 ` kbuild test robot 2015-10-06 10:00 ` kbuild test robot 2015-11-02 10:50 ` Andrzej Hajda 2015-11-02 10:50 ` Andrzej Hajda 2015-11-03 7:20 ` Archit Taneja 2015-11-03 7:20 ` Archit Taneja 2015-11-30 12:01 ` [PATCH v3 0/5] drm/dsi: DSI for devices with different control bus Archit Taneja 2015-11-30 12:01 ` [PATCH v3 1/5] drm/dsi: Refactor device creation Archit Taneja 2015-11-30 12:01 ` Archit Taneja 2015-11-30 12:01 ` [PATCH v3 2/5] drm/dsi: Try to match non-DT dsi devices Archit Taneja 2015-11-30 12:01 ` Archit Taneja 2015-11-30 12:45 ` kbuild test robot 2015-11-30 12:45 ` kbuild test robot 2015-12-07 5:29 ` Archit Taneja 2015-12-07 8:45 ` Jani Nikula 2015-12-07 8:59 ` Archit Taneja 2015-12-07 8:59 ` Archit Taneja 2015-12-07 9:10 ` Jani Nikula 2015-12-07 9:10 ` Jani Nikula 2015-12-07 9:18 ` Archit Taneja 2015-12-07 10:07 ` Jani Nikula 2015-12-07 16:55 ` Rob Clark 2015-11-30 12:01 ` [PATCH v3 3/5] drm/dsi: Check for used channels Archit Taneja 2015-11-30 12:01 ` Archit Taneja 2015-11-30 12:01 ` [PATCH v3 4/5] drm/dsi: Add routine to unregister dsi device Archit Taneja 2015-11-30 12:01 ` Archit Taneja 2015-11-30 12:34 ` Andrzej Hajda 2015-11-30 12:34 ` Andrzej Hajda 2015-11-30 12:01 ` [PATCH v3 5/5] drm/dsi: Get DSI host by DT device node Archit Taneja 2015-11-30 12:01 ` Archit Taneja 2015-12-10 12:41 ` [PATCH v4 0/6] drm/dsi: DSI for devices with different control bus Archit Taneja 2015-12-10 12:41 ` [PATCH v4 1/6] drm/dsi: check for CONFIG_OF when defining of_mipi_dsi_device_add Archit Taneja 2015-12-10 12:41 ` Archit Taneja 2016-01-21 15:31 ` Thierry Reding 2016-01-21 15:31 ` Thierry Reding 2016-01-26 14:59 ` Archit Taneja 2016-01-26 14:59 ` Archit Taneja 2015-12-10 12:41 ` [PATCH v4 2/6] drm/dsi: Refactor device creation Archit Taneja 2016-01-21 15:46 ` Thierry Reding 2016-01-21 15:46 ` Thierry Reding 2016-01-26 17:05 ` Archit Taneja 2016-01-26 17:05 ` Archit Taneja 2015-12-10 12:41 ` [PATCH v4 3/6] drm/dsi: Try to match non-DT dsi devices Archit Taneja 2015-12-10 12:41 ` Archit Taneja 2016-01-21 16:05 ` Thierry Reding 2016-01-21 16:05 ` Thierry Reding 2016-01-26 18:04 ` Archit Taneja 2016-01-26 18:04 ` Archit Taneja 2015-12-10 12:41 ` [PATCH v4 4/6] drm/dsi: Check for used channels Archit Taneja 2015-12-10 12:41 ` Archit Taneja 2016-01-21 16:11 ` Thierry Reding 2016-01-21 16:11 ` Thierry Reding 2016-01-27 5:16 ` Archit Taneja 2016-01-27 5:16 ` Archit Taneja 2015-12-10 12:41 ` [PATCH v4 5/6] drm/dsi: Add routine to unregister dsi device Archit Taneja 2015-12-10 12:41 ` Archit Taneja 2016-01-21 16:12 ` Thierry Reding 2016-01-21 16:12 ` Thierry Reding 2016-01-27 5:20 ` Archit Taneja 2015-12-10 12:41 ` [PATCH v4 6/6] drm/dsi: Get DSI host by DT device node Archit Taneja 2015-12-10 12:41 ` Archit Taneja 2016-01-21 16:16 ` Thierry Reding 2016-01-21 16:16 ` Thierry Reding 2016-01-27 5:21 ` Archit Taneja 2016-01-27 5:21 ` Archit Taneja 2016-01-05 5:29 ` [PATCH v4 0/6] drm/dsi: DSI for devices with different control bus Archit Taneja 2016-02-12 9:18 ` [PATCH v5 0/5] " Archit Taneja 2016-02-12 9:18 ` Archit Taneja 2016-02-12 9:18 ` [PATCH v5 1/5] drm/dsi: check for CONFIG_OF when defining of_mipi_dsi_device_add Archit Taneja 2016-02-12 9:18 ` Archit Taneja 2016-02-12 9:18 ` [PATCH v5 2/5] drm/dsi: Use mipi_dsi_device_register_full for DSI device creation Archit Taneja 2016-02-12 9:18 ` Archit Taneja 2016-02-12 9:18 ` [PATCH v5 3/5] drm/dsi: Try to match non-DT DSI devices Archit Taneja 2016-02-12 9:18 ` Archit Taneja 2016-02-12 9:18 ` [PATCH v5 4/5] drm/dsi: Add routine to unregister a DSI device Archit Taneja 2016-02-12 9:18 ` Archit Taneja 2016-02-12 9:18 ` [PATCH v5 5/5] drm/dsi: Get DSI host by DT device node Archit Taneja 2016-02-12 9:18 ` Archit Taneja 2016-03-02 16:05 ` [PATCH v5 0/5] drm/dsi: DSI for devices with different control bus Thierry Reding 2016-03-02 16:05 ` Thierry Reding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55D439E6.3080604@samsung.com \ --to=a.hajda@samsung.com \ --cc=architt@codeaurora.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=treding@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.