From: Jean-Francois Moine <moinejf@free.fr> To: Maxime Ripard <maxime.ripard@free-electrons.com> Cc: Mike Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Chen-Yu Tsai <wens@csie.org>, Boris Brezillon <boris.brezillon@free-electrons.com>, Vishnu Patekar <vishnupatekar0510@gmail.com>, Andre Przywara <andre.przywara@arm.com>, Hans de Goede <hdegoede@redhat.com>, Rob Herring <robh+dt@kernel.org>, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 08/16] clk: sunxi-ng: Add M-factor clock support Date: Wed, 11 May 2016 08:46:33 +0200 [thread overview] Message-ID: <20160511084633.29b56effa514996ffafd56ef@free.fr> (raw) In-Reply-To: <1462737711-10017-9-git-send-email-maxime.ripard@free-electrons.com> On Sun, 8 May 2016 22:01:43 +0200 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Introduce support for clocks that divide by a linear factor. >=20 > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > drivers/clk/sunxi-ng/Makefile | 1 + > drivers/clk/sunxi-ng/ccu_m.c | 135 ++++++++++++++++++++++++++++++++++++= ++++++ > drivers/clk/sunxi-ng/ccu_m.h | 101 +++++++++++++++++++++++++++++++ > 3 files changed, 237 insertions(+) > create mode 100644 drivers/clk/sunxi-ng/ccu_m.c > create mode 100644 drivers/clk/sunxi-ng/ccu_m.h >=20 > diff --git a/drivers/clk/sunxi-ng/Makefile b/drivers/clk/sunxi-ng/Makefile > index a47a3bbdf285..f41de901c607 100644 > --- a/drivers/clk/sunxi-ng/Makefile > +++ b/drivers/clk/sunxi-ng/Makefile > @@ -4,5 +4,6 @@ obj-y +=3D ccu_reset.o > obj-y +=3D ccu_div_table.o > obj-y +=3D ccu_fixed_factor.o > obj-y +=3D ccu_gate.o > +obj-y +=3D ccu_m.o > obj-y +=3D ccu_mux.o > obj-y +=3D ccu_phase.o > diff --git a/drivers/clk/sunxi-ng/ccu_m.c b/drivers/clk/sunxi-ng/ccu_m.c > new file mode 100644 > index 000000000000..424eb6da0d5b > --- /dev/null > +++ b/drivers/clk/sunxi-ng/ccu_m.c > @@ -0,0 +1,135 @@ > +/* > + * Copyright (C) 2016 Maxime Ripard > + * Maxime Ripard <maxime.ripard@free-electrons.com> > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + */ [snip] > +static int ccu_m_set_rate(struct clk_hw *hw, unsigned long rate, > + unsigned long parent_rate) > +{ > + struct ccu_m *cm =3D hw_to_ccu_m(hw); > + unsigned long flags; > + unsigned int m; > + u32 reg; > + > + ccu_m_find_best(parent_rate, rate, 1 << cm->m.width, &m); > + > + spin_lock_irqsave(cm->common.lock, flags); > + > + reg =3D readl(cm->common.base + cm->common.reg); > + reg &=3D ((1 << cm->m.width) - 1) << cm->m.shift; Bug: reg &=3D ~GENMASK(cm->m.width + cm->m.shift, cm->m.shift); > + > + writel(reg | ((m - 1) << cm->m.shift), > + cm->common.base + cm->common.reg); > + > + spin_unlock_irqrestore(cm->common.lock, flags); > + > + return 0; > +} [snip] --=20 Ken ar c'henta=F1 | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/
WARNING: multiple messages have this Message-ID (diff)
From: moinejf@free.fr (Jean-Francois Moine) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 08/16] clk: sunxi-ng: Add M-factor clock support Date: Wed, 11 May 2016 08:46:33 +0200 [thread overview] Message-ID: <20160511084633.29b56effa514996ffafd56ef@free.fr> (raw) In-Reply-To: <1462737711-10017-9-git-send-email-maxime.ripard@free-electrons.com> On Sun, 8 May 2016 22:01:43 +0200 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Introduce support for clocks that divide by a linear factor. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > drivers/clk/sunxi-ng/Makefile | 1 + > drivers/clk/sunxi-ng/ccu_m.c | 135 ++++++++++++++++++++++++++++++++++++++++++ > drivers/clk/sunxi-ng/ccu_m.h | 101 +++++++++++++++++++++++++++++++ > 3 files changed, 237 insertions(+) > create mode 100644 drivers/clk/sunxi-ng/ccu_m.c > create mode 100644 drivers/clk/sunxi-ng/ccu_m.h > > diff --git a/drivers/clk/sunxi-ng/Makefile b/drivers/clk/sunxi-ng/Makefile > index a47a3bbdf285..f41de901c607 100644 > --- a/drivers/clk/sunxi-ng/Makefile > +++ b/drivers/clk/sunxi-ng/Makefile > @@ -4,5 +4,6 @@ obj-y += ccu_reset.o > obj-y += ccu_div_table.o > obj-y += ccu_fixed_factor.o > obj-y += ccu_gate.o > +obj-y += ccu_m.o > obj-y += ccu_mux.o > obj-y += ccu_phase.o > diff --git a/drivers/clk/sunxi-ng/ccu_m.c b/drivers/clk/sunxi-ng/ccu_m.c > new file mode 100644 > index 000000000000..424eb6da0d5b > --- /dev/null > +++ b/drivers/clk/sunxi-ng/ccu_m.c > @@ -0,0 +1,135 @@ > +/* > + * Copyright (C) 2016 Maxime Ripard > + * Maxime Ripard <maxime.ripard@free-electrons.com> > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + */ [snip] > +static int ccu_m_set_rate(struct clk_hw *hw, unsigned long rate, > + unsigned long parent_rate) > +{ > + struct ccu_m *cm = hw_to_ccu_m(hw); > + unsigned long flags; > + unsigned int m; > + u32 reg; > + > + ccu_m_find_best(parent_rate, rate, 1 << cm->m.width, &m); > + > + spin_lock_irqsave(cm->common.lock, flags); > + > + reg = readl(cm->common.base + cm->common.reg); > + reg &= ((1 << cm->m.width) - 1) << cm->m.shift; Bug: reg &= ~GENMASK(cm->m.width + cm->m.shift, cm->m.shift); > + > + writel(reg | ((m - 1) << cm->m.shift), > + cm->common.base + cm->common.reg); > + > + spin_unlock_irqrestore(cm->common.lock, flags); > + > + return 0; > +} [snip] -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2016-05-11 6:46 UTC|newest] Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-08 20:01 [PATCH 00/16] clk: sunxi: introduce "modern" clock support Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-08 20:01 ` [PATCH 01/16] clk: fix critical clock locking Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-09 22:11 ` Stephen Boyd 2016-05-09 22:11 ` Stephen Boyd 2016-05-13 7:50 ` Maxime Ripard 2016-05-13 7:50 ` Maxime Ripard 2016-05-08 20:01 ` [PATCH 02/16] clk: sunxi-ng: Add common infrastructure Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-09 10:01 ` Chen-Yu Tsai 2016-05-09 10:01 ` Chen-Yu Tsai 2016-05-15 18:31 ` Maxime Ripard 2016-05-15 18:31 ` Maxime Ripard 2016-05-16 7:02 ` Chen-Yu Tsai 2016-05-16 7:02 ` Chen-Yu Tsai 2016-05-16 8:02 ` Jean-Francois Moine 2016-05-16 8:02 ` Jean-Francois Moine 2016-05-16 20:15 ` Maxime Ripard 2016-05-16 20:15 ` Maxime Ripard 2016-05-17 6:54 ` Jean-Francois Moine 2016-05-17 6:54 ` Jean-Francois Moine 2016-05-18 19:59 ` Maxime Ripard 2016-05-18 19:59 ` Maxime Ripard 2016-05-08 20:01 ` [PATCH 03/16] clk: sunxi-ng: Add fixed factor clock support Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-09 10:05 ` Chen-Yu Tsai 2016-05-09 10:05 ` Chen-Yu Tsai 2016-05-16 13:15 ` Jean-Francois Moine 2016-05-16 13:15 ` Jean-Francois Moine 2016-05-16 21:08 ` Maxime Ripard 2016-05-16 21:08 ` Maxime Ripard 2016-05-08 20:01 ` [PATCH 04/16] clk: sunxi-ng: Add gate " Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-08 20:01 ` [PATCH 05/16] clk: sunxi-ng: Add mux " Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-21 16:18 ` Chen-Yu Tsai 2016-05-21 16:18 ` Chen-Yu Tsai 2016-05-22 19:20 ` Maxime Ripard 2016-05-22 19:20 ` Maxime Ripard 2016-05-08 20:01 ` [PATCH 06/16] clk: sunxi-ng: Add divider table clock Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-21 16:30 ` Chen-Yu Tsai 2016-05-21 16:30 ` Chen-Yu Tsai 2016-05-08 20:01 ` [PATCH 07/16] clk: sunxi-ng: Add phase clock support Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-21 16:43 ` Chen-Yu Tsai 2016-05-21 16:43 ` Chen-Yu Tsai 2016-05-23 17:01 ` Maxime Ripard 2016-05-23 17:01 ` Maxime Ripard 2016-05-24 9:01 ` Chen-Yu Tsai 2016-05-24 9:01 ` Chen-Yu Tsai 2016-05-08 20:01 ` [PATCH 08/16] clk: sunxi-ng: Add M-factor " Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-11 6:46 ` Jean-Francois Moine [this message] 2016-05-11 6:46 ` Jean-Francois Moine 2016-05-15 18:51 ` Maxime Ripard 2016-05-15 18:51 ` Maxime Ripard 2016-05-21 17:09 ` Chen-Yu Tsai 2016-05-21 17:09 ` Chen-Yu Tsai 2016-05-22 19:22 ` Maxime Ripard 2016-05-22 19:22 ` Maxime Ripard 2016-05-08 20:01 ` [PATCH 09/16] clk: sunxi-ng: Add P-factor " Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-08 20:01 ` [PATCH 10/16] clk: sunxi-ng: Add M-P factor " Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-23 13:45 ` Chen-Yu Tsai 2016-05-23 13:45 ` Chen-Yu Tsai 2016-05-23 17:18 ` Maxime Ripard 2016-05-23 17:18 ` Maxime Ripard 2016-05-24 4:14 ` Chen-Yu Tsai 2016-05-24 4:14 ` Chen-Yu Tsai 2016-05-24 21:07 ` Maxime Ripard 2016-05-24 21:07 ` Maxime Ripard 2016-05-08 20:01 ` [PATCH 11/16] clk: sunxi-ng: Add N-K-factor " Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-23 13:58 ` Chen-Yu Tsai 2016-05-23 13:58 ` Chen-Yu Tsai 2016-05-08 20:01 ` [PATCH 12/16] clk: sunxi-ng: Add N-M-factor " Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-09 7:24 ` Jean-Francois Moine 2016-05-09 7:24 ` Jean-Francois Moine 2016-05-15 19:04 ` Maxime Ripard 2016-05-15 19:04 ` Maxime Ripard 2016-05-08 20:01 ` [PATCH 13/16] clk: sunxi-ng: Add N-K-M Factor clock Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-11 8:45 ` Jean-Francois Moine 2016-05-11 8:45 ` Jean-Francois Moine 2016-05-15 19:08 ` Maxime Ripard 2016-05-15 19:08 ` Maxime Ripard 2016-05-23 14:10 ` Chen-Yu Tsai 2016-05-23 14:10 ` Chen-Yu Tsai 2016-05-08 20:01 ` [PATCH 14/16] clk: sunxi-ng: Add N-K-M-P factor clock Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-11 8:49 ` Jean-Francois Moine 2016-05-11 8:49 ` Jean-Francois Moine 2016-05-23 14:36 ` Chen-Yu Tsai 2016-05-23 14:36 ` Chen-Yu Tsai 2016-05-30 7:57 ` Maxime Ripard 2016-05-30 7:57 ` Maxime Ripard 2016-05-08 20:01 ` [PATCH 15/16] clk: sunxi-ng: Add H3 clocks Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard 2016-05-09 7:39 ` Jean-Francois Moine 2016-05-09 7:39 ` Jean-Francois Moine 2016-05-15 19:18 ` Maxime Ripard 2016-05-15 19:18 ` Maxime Ripard 2016-05-13 9:45 ` Jean-Francois Moine 2016-05-13 9:45 ` Jean-Francois Moine 2016-05-18 14:02 ` Maxime Ripard 2016-05-18 14:02 ` Maxime Ripard 2016-05-18 16:23 ` Jean-Francois Moine 2016-05-18 16:23 ` Jean-Francois Moine 2016-05-18 16:27 ` Jean-Francois Moine 2016-05-18 16:27 ` Jean-Francois Moine 2016-05-16 13:47 ` Jean-Francois Moine 2016-05-16 13:47 ` Jean-Francois Moine 2016-05-18 21:20 ` Maxime Ripard 2016-05-18 21:20 ` Maxime Ripard 2016-05-30 16:15 ` Chen-Yu Tsai 2016-05-30 16:15 ` Chen-Yu Tsai 2016-06-01 19:19 ` Maxime Ripard 2016-06-01 19:19 ` Maxime Ripard 2016-06-03 6:42 ` Chen-Yu Tsai 2016-06-03 6:42 ` Chen-Yu Tsai 2016-06-03 6:55 ` Chen-Yu Tsai 2016-06-03 6:55 ` Chen-Yu Tsai 2016-05-08 20:01 ` [PATCH 16/16] ARM: dt: sun8i: switch the H3 to the new CCU driver Maxime Ripard 2016-05-08 20:01 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160511084633.29b56effa514996ffafd56ef@free.fr \ --to=moinejf@free.fr \ --cc=andre.przywara@arm.com \ --cc=boris.brezillon@free-electrons.com \ --cc=hdegoede@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=maxime.ripard@free-electrons.com \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@codeaurora.org \ --cc=vishnupatekar0510@gmail.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.