From: Rob Herring <robh@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Heiko Stuebner <heiko@sntech.de>,
Shawn Lin <shawn.lin@rock-chips.com>,
Ziyuan Xu <xzy.xu@rock-chips.com>,
Brian Norris <briannorris@chromium.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/11] Documentation: mmc: sdhci-of-arasan: Add ability to export card clock
Date: Fri, 10 Jun 2016 08:10:52 -0500 [thread overview]
Message-ID: <20160610131052.GA9351@rob-hp-laptop> (raw)
In-Reply-To: <CAD=FV=WX_bu-dmALkSmPPrWeatfjJND3M59GJoVEr6bv0vLq9Q@mail.gmail.com>
On Wed, Jun 08, 2016 at 01:52:20PM -0700, Doug Anderson wrote:
> Rob,
>
> On Wed, Jun 8, 2016 at 1:19 PM, Rob Herring <robh@kernel.org> wrote:
> > On Tue, Jun 07, 2016 at 03:44:39PM -0700, Douglas Anderson wrote:
> >> Some SD/eMMC PHYs (like the PHY from Arasan that is designed to work
> >> with arasan,sdhci-5.1) need to know the card clock in order to function
> >> properly. Let's expose this clock using a standard device tree
> >> mechanism so that the PHY can get access to and query the card clock.
> >
> > Need to know the clock freq or need the clock? The former doesn't need
> > to be in DT.
>
> The PHY needs to know the card clock frequency. This clock clock
> frequency is known nowhere else in the system except the SDHCI driver
> since the SDHCI component takes its input clock and applies some
> dividers to get the card clock. In silicon, the SDHCI component and
> the PHY are separate and there is a physical clock signal going from
> the SDHCI component to the PHY component, so modeling this as a clock
> in in the device tree seems sane, doesn't it?
Yes, please just re-word it to make it clear there is a connection. With
that,
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2016-06-10 13:10 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 22:44 [PATCH 0/11] Changes to support 150 MHz eMMC on rk3399 Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` [PATCH 01/11] phy: rockchip-emmc: Increase lock time allowance Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-13 7:58 ` Shawn Lin
2016-06-13 7:58 ` Shawn Lin
2016-06-13 7:58 ` Shawn Lin
2016-06-13 23:07 ` Doug Anderson
2016-06-13 23:07 ` Doug Anderson
2016-06-13 23:07 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 02/11] mmc: sdhci-of-arasan: Always power the PHY off/on when clock changes Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-13 8:08 ` Shawn Lin
2016-06-13 8:08 ` Shawn Lin
2016-06-13 8:08 ` Shawn Lin
2016-06-13 23:06 ` Doug Anderson
2016-06-13 23:06 ` Doug Anderson
2016-06-13 23:06 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 03/11] Documentation: mmc: sdhci-of-arasan: Add soc-ctl-syscon for corecfg regs Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-08 20:17 ` Rob Herring
2016-06-13 8:18 ` Shawn Lin
2016-06-13 9:32 ` Heiko Stübner
2016-06-13 9:32 ` Heiko Stübner
2016-06-13 23:07 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 04/11] mmc: sdhci-of-arasan: Properly set corecfg_baseclkfreq on rk3399 Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-13 8:36 ` Shawn Lin
2016-06-13 8:36 ` Shawn Lin
2016-06-13 23:06 ` Doug Anderson
2016-06-13 23:06 ` Doug Anderson
2016-06-13 23:06 ` Doug Anderson
2016-06-14 0:14 ` Shawn Lin
2016-06-14 0:14 ` Shawn Lin
2016-06-14 0:14 ` Shawn Lin
2016-06-14 0:43 ` Doug Anderson
2016-06-14 0:43 ` Doug Anderson
2016-06-14 0:43 ` Doug Anderson
2016-06-14 0:59 ` Shawn Lin
2016-06-14 0:59 ` Shawn Lin
2016-06-14 0:59 ` Shawn Lin
2016-06-14 2:13 ` Doug Anderson
2016-06-14 2:13 ` Doug Anderson
2016-06-14 2:13 ` Doug Anderson
2016-06-16 1:06 ` Shawn Lin
2016-06-16 1:06 ` Shawn Lin
2016-06-16 1:06 ` Shawn Lin
2016-06-07 22:44 ` [PATCH 05/11] arm64: dts: rockchip: Add soc-ctl-syscon to sdhci for rk3399 Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` [PATCH 06/11] Documentation: mmc: sdhci-of-arasan: Add ability to export card clock Douglas Anderson
2016-06-08 20:19 ` Rob Herring
2016-06-08 20:52 ` Doug Anderson
2016-06-08 20:52 ` Doug Anderson
2016-06-10 13:10 ` Rob Herring [this message]
2016-06-13 23:05 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 07/11] " Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` [PATCH 08/11] Documentation: phy: Let the rockchip eMMC PHY get an exported " Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-10 13:36 ` Rob Herring
2016-06-10 13:36 ` Rob Herring
2016-06-13 23:05 ` Doug Anderson
2016-06-13 23:05 ` Doug Anderson
2016-06-13 23:05 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 09/11] phy: rockchip-emmc: Set phyctrl_frqsel based on " Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-13 8:54 ` Shawn Lin
2016-06-13 8:54 ` Shawn Lin
2016-06-13 8:54 ` Shawn Lin
2016-06-13 23:05 ` Doug Anderson
2016-06-13 23:05 ` Doug Anderson
2016-06-13 23:05 ` Doug Anderson
2016-06-13 23:05 ` Doug Anderson
2016-06-14 0:24 ` Shawn Lin
2016-06-14 0:24 ` Shawn Lin
2016-06-14 0:24 ` Shawn Lin
2016-06-14 0:45 ` Doug Anderson
2016-06-14 0:45 ` Doug Anderson
2016-06-14 0:45 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 10/11] phy: rockchip-emmc: Minor code cleanup in rockchip_emmc_phy_power_off() Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-13 8:56 ` Shawn Lin
2016-06-13 8:56 ` Shawn Lin
2016-06-13 23:05 ` Doug Anderson
2016-06-13 23:05 ` Doug Anderson
2016-06-13 23:05 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 11/11] arm64: dts: rockchip: Provide emmcclk to PHY for rk3399 Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610131052.GA9351@rob-hp-laptop \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=xzy.xu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.