From: Doug Anderson <dianders@chromium.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Ziyuan Xu <xzy.xu@rock-chips.com>,
Brian Norris <briannorris@chromium.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 10/11] phy: rockchip-emmc: Minor code cleanup in rockchip_emmc_phy_power_off()
Date: Mon, 13 Jun 2016 16:05:27 -0700 [thread overview]
Message-ID: <CAD=FV=U0XuOEBXsuf7cdp-mhe8=XJer9EoRJ99-2Mx_0=CFt-g@mail.gmail.com> (raw)
In-Reply-To: <f80ba471-95dd-5cda-00a2-9006cfe15167@rock-chips.com>
Hi,
On Mon, Jun 13, 2016 at 1:56 AM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> On 2016/6/8 6:44, Douglas Anderson wrote:
>>
>> There's no reason to store the return value of rockchip_emmc_phy_power()
>> in a variable nor to check it. Just return it.
>>
>> Signed-off-by: Douglas Anderson <dianders@chromium.org>
>> ---
>> drivers/phy/phy-rockchip-emmc.c | 8 +-------
>> 1 file changed, 1 insertion(+), 7 deletions(-)
>>
>> diff --git a/drivers/phy/phy-rockchip-emmc.c
>> b/drivers/phy/phy-rockchip-emmc.c
>> index 0fce7359d468..188e4c387ba8 100644
>> --- a/drivers/phy/phy-rockchip-emmc.c
>> +++ b/drivers/phy/phy-rockchip-emmc.c
>> @@ -227,8 +227,6 @@ static int rockchip_emmc_phy_power_off(struct phy
>> *phy)
>> static int rockchip_emmc_phy_power_on(struct phy *phy)
>> {
>
>
> I saw the cleanup for power_off is done on [patch 9/11]
>
> shouldn't be in this patch? :)
Yeah, I tried to, but then I realized that I couldn't split that out
too easily because the previous patch touched the same code.
...but actually, reordering things solves all the problems so I've done that.
-Doug
WARNING: multiple messages have this Message-ID (diff)
From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/11] phy: rockchip-emmc: Minor code cleanup in rockchip_emmc_phy_power_off()
Date: Mon, 13 Jun 2016 16:05:27 -0700 [thread overview]
Message-ID: <CAD=FV=U0XuOEBXsuf7cdp-mhe8=XJer9EoRJ99-2Mx_0=CFt-g@mail.gmail.com> (raw)
In-Reply-To: <f80ba471-95dd-5cda-00a2-9006cfe15167@rock-chips.com>
Hi,
On Mon, Jun 13, 2016 at 1:56 AM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> On 2016/6/8 6:44, Douglas Anderson wrote:
>>
>> There's no reason to store the return value of rockchip_emmc_phy_power()
>> in a variable nor to check it. Just return it.
>>
>> Signed-off-by: Douglas Anderson <dianders@chromium.org>
>> ---
>> drivers/phy/phy-rockchip-emmc.c | 8 +-------
>> 1 file changed, 1 insertion(+), 7 deletions(-)
>>
>> diff --git a/drivers/phy/phy-rockchip-emmc.c
>> b/drivers/phy/phy-rockchip-emmc.c
>> index 0fce7359d468..188e4c387ba8 100644
>> --- a/drivers/phy/phy-rockchip-emmc.c
>> +++ b/drivers/phy/phy-rockchip-emmc.c
>> @@ -227,8 +227,6 @@ static int rockchip_emmc_phy_power_off(struct phy
>> *phy)
>> static int rockchip_emmc_phy_power_on(struct phy *phy)
>> {
>
>
> I saw the cleanup for power_off is done on [patch 9/11]
>
> shouldn't be in this patch? :)
Yeah, I tried to, but then I realized that I couldn't split that out
too easily because the previous patch touched the same code.
...but actually, reordering things solves all the problems so I've done that.
-Doug
next prev parent reply other threads:[~2016-06-13 23:05 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 22:44 [PATCH 0/11] Changes to support 150 MHz eMMC on rk3399 Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` [PATCH 01/11] phy: rockchip-emmc: Increase lock time allowance Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-13 7:58 ` Shawn Lin
2016-06-13 7:58 ` Shawn Lin
2016-06-13 7:58 ` Shawn Lin
2016-06-13 23:07 ` Doug Anderson
2016-06-13 23:07 ` Doug Anderson
2016-06-13 23:07 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 02/11] mmc: sdhci-of-arasan: Always power the PHY off/on when clock changes Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-13 8:08 ` Shawn Lin
2016-06-13 8:08 ` Shawn Lin
2016-06-13 8:08 ` Shawn Lin
2016-06-13 23:06 ` Doug Anderson
2016-06-13 23:06 ` Doug Anderson
2016-06-13 23:06 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 03/11] Documentation: mmc: sdhci-of-arasan: Add soc-ctl-syscon for corecfg regs Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-08 20:17 ` Rob Herring
2016-06-13 8:18 ` Shawn Lin
2016-06-13 9:32 ` Heiko Stübner
2016-06-13 9:32 ` Heiko Stübner
2016-06-13 23:07 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 04/11] mmc: sdhci-of-arasan: Properly set corecfg_baseclkfreq on rk3399 Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-13 8:36 ` Shawn Lin
2016-06-13 8:36 ` Shawn Lin
2016-06-13 23:06 ` Doug Anderson
2016-06-13 23:06 ` Doug Anderson
2016-06-13 23:06 ` Doug Anderson
2016-06-14 0:14 ` Shawn Lin
2016-06-14 0:14 ` Shawn Lin
2016-06-14 0:14 ` Shawn Lin
2016-06-14 0:43 ` Doug Anderson
2016-06-14 0:43 ` Doug Anderson
2016-06-14 0:43 ` Doug Anderson
2016-06-14 0:59 ` Shawn Lin
2016-06-14 0:59 ` Shawn Lin
2016-06-14 0:59 ` Shawn Lin
2016-06-14 2:13 ` Doug Anderson
2016-06-14 2:13 ` Doug Anderson
2016-06-14 2:13 ` Doug Anderson
2016-06-16 1:06 ` Shawn Lin
2016-06-16 1:06 ` Shawn Lin
2016-06-16 1:06 ` Shawn Lin
2016-06-07 22:44 ` [PATCH 05/11] arm64: dts: rockchip: Add soc-ctl-syscon to sdhci for rk3399 Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` [PATCH 06/11] Documentation: mmc: sdhci-of-arasan: Add ability to export card clock Douglas Anderson
2016-06-08 20:19 ` Rob Herring
2016-06-08 20:52 ` Doug Anderson
2016-06-08 20:52 ` Doug Anderson
2016-06-10 13:10 ` Rob Herring
2016-06-13 23:05 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 07/11] " Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` [PATCH 08/11] Documentation: phy: Let the rockchip eMMC PHY get an exported " Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-10 13:36 ` Rob Herring
2016-06-10 13:36 ` Rob Herring
2016-06-13 23:05 ` Doug Anderson
2016-06-13 23:05 ` Doug Anderson
2016-06-13 23:05 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 09/11] phy: rockchip-emmc: Set phyctrl_frqsel based on " Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-13 8:54 ` Shawn Lin
2016-06-13 8:54 ` Shawn Lin
2016-06-13 8:54 ` Shawn Lin
2016-06-13 23:05 ` Doug Anderson
2016-06-13 23:05 ` Doug Anderson
2016-06-13 23:05 ` Doug Anderson
2016-06-13 23:05 ` Doug Anderson
2016-06-14 0:24 ` Shawn Lin
2016-06-14 0:24 ` Shawn Lin
2016-06-14 0:24 ` Shawn Lin
2016-06-14 0:45 ` Doug Anderson
2016-06-14 0:45 ` Doug Anderson
2016-06-14 0:45 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 10/11] phy: rockchip-emmc: Minor code cleanup in rockchip_emmc_phy_power_off() Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
2016-06-13 8:56 ` Shawn Lin
2016-06-13 8:56 ` Shawn Lin
2016-06-13 23:05 ` Doug Anderson [this message]
2016-06-13 23:05 ` Doug Anderson
2016-06-13 23:05 ` Doug Anderson
2016-06-07 22:44 ` [PATCH 11/11] arm64: dts: rockchip: Provide emmcclk to PHY for rk3399 Douglas Anderson
2016-06-07 22:44 ` Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=U0XuOEBXsuf7cdp-mhe8=XJer9EoRJ99-2Mx_0=CFt-g@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=adrian.hunter@intel.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=xzy.xu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.