From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, jarkko.nikula@bitmer.com, jsarha@ti.com
Subject: [PATCH 0/3] ASoC: tlv320aic3x: Pop noise reductions
Date: Fri, 23 Dec 2016 11:21:09 +0200 [thread overview]
Message-ID: <20161223092112.7992-1-peter.ujfalusi@ti.com> (raw)
Hi,
When we don't have any active component between the output of the codec and the
speaker/jack the codec emmits pop noise due to several factors:
- RESET register is toggled by regcache_sync (patch 1)
- After regcache_sync we need to wait a bit to allow the codec to settle down:
the codec will be soft reseted when it is powered down, so when we power it on
and run regcache_sync, we need to wait for the flushed settings to be valid.
(patch 2)
- The HP ouptut power-down mode can be changed to be driven weakly to VCM, this
can reduce the pop noise as well, with slight increase in powere consumption.
These factors were not taken care as in n810 and n900 we have external active
amplifiers and they will remove any artifacts coming from the codec, but on
boards w/o active external components they can reach the output.
Regards,
Peter
---
Peter Ujfalusi (3):
ASoC: tlv320aic3x: Mark the RESET register as volatile
ASoC: tlv320aic3x: Add delay after power on and register sync
ASoC: tlv320aic3x: Add controls for selecting HP power down modes
sound/soc/codecs/tlv320aic3x.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
--
2.11.0
next reply other threads:[~2016-12-23 9:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 9:21 Peter Ujfalusi [this message]
2016-12-23 9:21 ` [PATCH 1/3] ASoC: tlv320aic3x: Mark the RESET register as volatile Peter Ujfalusi
2016-12-23 18:27 ` Jarkko Nikula
2017-01-02 11:51 ` Peter Ujfalusi
2016-12-31 19:19 ` Applied "ASoC: tlv320aic3x: Mark the RESET register as volatile" to the asoc tree Mark Brown
2016-12-23 9:21 ` [PATCH 2/3] ASoC: tlv320aic3x: Add delay after power on and register sync Peter Ujfalusi
2016-12-31 19:19 ` Applied "ASoC: tlv320aic3x: Add delay after power on and register sync" to the asoc tree Mark Brown
2016-12-23 9:21 ` [PATCH 3/3] ASoC: tlv320aic3x: Add controls for selecting HP power down modes Peter Ujfalusi
2016-12-23 18:47 ` Jarkko Nikula
2016-12-31 18:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161223092112.7992-1-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.