All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	jsarha@ti.com, Liam Girdwood <lgirdwood@gmail.com>,
	jarkko.nikula@bitmer.com
Subject: Applied "ASoC: tlv320aic3x: Add delay after power on and register sync" to the asoc tree
Date: Sat, 31 Dec 2016 19:19:10 +0000	[thread overview]
Message-ID: <E1cNPBO-0003u1-Ha@debutante> (raw)
In-Reply-To: <20161223092112.7992-3-peter.ujfalusi@ti.com>

The patch

   ASoC: tlv320aic3x: Add delay after power on and register sync

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 03303da5243f394f5cc5e530a8bc9f26ad2c79cb Mon Sep 17 00:00:00 2001
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
Date: Fri, 23 Dec 2016 11:21:11 +0200
Subject: [PATCH] ASoC: tlv320aic3x: Add delay after power on and register sync

When the codec is powered on, it's registers are in reset state as the
power off will do a soft reset of the codec.

After the register sync we need to add delay to remove the pop-noise on
stream start.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/tlv320aic3x.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index bb94d50052d7..29bf8c81ae02 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -1393,6 +1393,12 @@ static int aic3x_set_power(struct snd_soc_codec *codec, int power)
 			snd_soc_write(codec, AIC3X_PLL_PROGC_REG, pll_c);
 			snd_soc_write(codec, AIC3X_PLL_PROGD_REG, pll_d);
 		}
+
+		/*
+		 * Delay is needed to reduce pop-noise after syncing back the
+		 * registers
+		 */
+		mdelay(50);
 	} else {
 		/*
 		 * Do soft reset to this codec instance in order to clear
-- 
2.11.0

  reply	other threads:[~2016-12-31 19:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-23  9:21 [PATCH 0/3] ASoC: tlv320aic3x: Pop noise reductions Peter Ujfalusi
2016-12-23  9:21 ` [PATCH 1/3] ASoC: tlv320aic3x: Mark the RESET register as volatile Peter Ujfalusi
2016-12-23 18:27   ` Jarkko Nikula
2017-01-02 11:51     ` Peter Ujfalusi
2016-12-31 19:19   ` Applied "ASoC: tlv320aic3x: Mark the RESET register as volatile" to the asoc tree Mark Brown
2016-12-23  9:21 ` [PATCH 2/3] ASoC: tlv320aic3x: Add delay after power on and register sync Peter Ujfalusi
2016-12-31 19:19   ` Mark Brown [this message]
2016-12-23  9:21 ` [PATCH 3/3] ASoC: tlv320aic3x: Add controls for selecting HP power down modes Peter Ujfalusi
2016-12-23 18:47   ` Jarkko Nikula
2016-12-31 18:49     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1cNPBO-0003u1-Ha@debutante \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=jsarha@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.