All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, jarkko.nikula@bitmer.com, jsarha@ti.com
Subject: [PATCH 1/3] ASoC: tlv320aic3x: Mark the RESET register as volatile
Date: Fri, 23 Dec 2016 11:21:10 +0200	[thread overview]
Message-ID: <20161223092112.7992-2-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20161223092112.7992-1-peter.ujfalusi@ti.com>

The RESET register only have one self clearing bit and it should not be
cached. If it is cached, when we sync the registers back to the chip we
will initiate a software reset as well, which is not desirable.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 sound/soc/codecs/tlv320aic3x.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index 216f74084c6a..7b6924e19021 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -126,6 +126,16 @@ static const struct reg_default aic3x_reg[] = {
 	{ 108, 0x00 }, { 109, 0x00 },
 };
 
+static bool aic3x_volatile_reg(struct device *dev, unsigned int reg)
+{
+	switch (reg) {
+	case AIC3X_RESET:
+		return true;
+	default:
+		return false;
+	}
+}
+
 static const struct regmap_config aic3x_regmap = {
 	.reg_bits = 8,
 	.val_bits = 8,
@@ -133,6 +143,9 @@ static const struct regmap_config aic3x_regmap = {
 	.max_register = DAC_ICC_ADJ,
 	.reg_defaults = aic3x_reg,
 	.num_reg_defaults = ARRAY_SIZE(aic3x_reg),
+
+	.volatile_reg = aic3x_volatile_reg,
+
 	.cache_type = REGCACHE_RBTREE,
 };
 
-- 
2.11.0

  reply	other threads:[~2016-12-23  9:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-23  9:21 [PATCH 0/3] ASoC: tlv320aic3x: Pop noise reductions Peter Ujfalusi
2016-12-23  9:21 ` Peter Ujfalusi [this message]
2016-12-23 18:27   ` [PATCH 1/3] ASoC: tlv320aic3x: Mark the RESET register as volatile Jarkko Nikula
2017-01-02 11:51     ` Peter Ujfalusi
2016-12-31 19:19   ` Applied "ASoC: tlv320aic3x: Mark the RESET register as volatile" to the asoc tree Mark Brown
2016-12-23  9:21 ` [PATCH 2/3] ASoC: tlv320aic3x: Add delay after power on and register sync Peter Ujfalusi
2016-12-31 19:19   ` Applied "ASoC: tlv320aic3x: Add delay after power on and register sync" to the asoc tree Mark Brown
2016-12-23  9:21 ` [PATCH 3/3] ASoC: tlv320aic3x: Add controls for selecting HP power down modes Peter Ujfalusi
2016-12-23 18:47   ` Jarkko Nikula
2016-12-31 18:49     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161223092112.7992-2-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=jsarha@ti.com \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.