All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Salvatore Mesoraca <s.mesoraca16@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	kernel-hardening@lists.openwall.com,
	Brad Spengler <spender@grsecurity.net>,
	PaX Team <pageexec@freemail.hu>,
	Casey Schaufler <casey@schaufler-ca.com>,
	Kees Cook <keescook@chromium.org>,
	James Morris <james.l.morris@oracle.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH 03/11] Creation of "usb_device_auth" LSM hook
Date: Mon, 12 Jun 2017 21:38:26 +0200	[thread overview]
Message-ID: <20170612193826.GA4235@kroah.com> (raw)
In-Reply-To: <1497286620-15027-4-git-send-email-s.mesoraca16@gmail.com>

On Mon, Jun 12, 2017 at 06:56:52PM +0200, Salvatore Mesoraca wrote:
> Creation of a new LSM hook that can be used to authorize or deauthorize
> new USB devices via the usb authorization interface.
> The same hook can also prevent the authorization of a USB device via
> "/sys/bus/usb/devices/DEVICE/authorized".
> Using this hook an LSM could provide an higher level of granularity
> than the current authorization interface.
> 
> Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com>
> Cc: linux-usb@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

No, like Krzysztof said, you can already do this today, just fine, from
userspace.  I think that support has been there for over a decade now,
why are you not taking advantage of this already?

No need to add extra stuff to the kernel at all to do this, sorry you
implemented all of this for no reason :(

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 03/11] Creation of "usb_device_auth" LSM hook
Date: Mon, 12 Jun 2017 21:38:26 +0200	[thread overview]
Message-ID: <20170612193826.GA4235@kroah.com> (raw)
In-Reply-To: <1497286620-15027-4-git-send-email-s.mesoraca16@gmail.com>

On Mon, Jun 12, 2017 at 06:56:52PM +0200, Salvatore Mesoraca wrote:
> Creation of a new LSM hook that can be used to authorize or deauthorize
> new USB devices via the usb authorization interface.
> The same hook can also prevent the authorization of a USB device via
> "/sys/bus/usb/devices/DEVICE/authorized".
> Using this hook an LSM could provide an higher level of granularity
> than the current authorization interface.
> 
> Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com>
> Cc: linux-usb at vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

No, like Krzysztof said, you can already do this today, just fine, from
userspace.  I think that support has been there for over a decade now,
why are you not taking advantage of this already?

No need to add extra stuff to the kernel at all to do this, sorry you
implemented all of this for no reason :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Salvatore Mesoraca <s.mesoraca16@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	kernel-hardening@lists.openwall.com,
	Brad Spengler <spender@grsecurity.net>,
	PaX Team <pageexec@freemail.hu>,
	Casey Schaufler <casey@schaufler-ca.com>,
	Kees Cook <keescook@chromium.org>,
	James Morris <james.l.morris@oracle.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	linux-usb@vger.kernel.org
Subject: [kernel-hardening] Re: [PATCH 03/11] Creation of "usb_device_auth" LSM hook
Date: Mon, 12 Jun 2017 21:38:26 +0200	[thread overview]
Message-ID: <20170612193826.GA4235@kroah.com> (raw)
In-Reply-To: <1497286620-15027-4-git-send-email-s.mesoraca16@gmail.com>

On Mon, Jun 12, 2017 at 06:56:52PM +0200, Salvatore Mesoraca wrote:
> Creation of a new LSM hook that can be used to authorize or deauthorize
> new USB devices via the usb authorization interface.
> The same hook can also prevent the authorization of a USB device via
> "/sys/bus/usb/devices/DEVICE/authorized".
> Using this hook an LSM could provide an higher level of granularity
> than the current authorization interface.
> 
> Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com>
> Cc: linux-usb@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

No, like Krzysztof said, you can already do this today, just fine, from
userspace.  I think that support has been there for over a decade now,
why are you not taking advantage of this already?

No need to add extra stuff to the kernel at all to do this, sorry you
implemented all of this for no reason :(

greg k-h

  parent reply	other threads:[~2017-06-12 19:38 UTC|newest]

Thread overview: 124+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12 16:56 [PATCH 00/11] S.A.R.A. a new stacked LSM Salvatore Mesoraca
2017-06-12 16:56 ` [kernel-hardening] " Salvatore Mesoraca
2017-06-12 16:56 ` Salvatore Mesoraca
2017-06-12 16:56 ` [PATCH 01/11] S.A.R.A. Documentation Salvatore Mesoraca
2017-06-12 16:56   ` [kernel-hardening] " Salvatore Mesoraca
2017-06-12 16:56   ` Salvatore Mesoraca
2017-06-12 17:49   ` [kernel-hardening] " Jann Horn
2017-06-12 17:49     ` Jann Horn
2017-06-13  7:43     ` Salvatore Mesoraca
2017-06-13  7:43       ` Salvatore Mesoraca
2017-06-27 22:51   ` Kees Cook
2017-06-27 22:51     ` [kernel-hardening] " Kees Cook
2017-06-27 22:51     ` Kees Cook
2017-06-27 22:54     ` Kees Cook
2017-06-27 22:54       ` [kernel-hardening] " Kees Cook
2017-06-27 22:54       ` Kees Cook
2017-07-04 10:12     ` Salvatore Mesoraca
2017-07-04 10:12       ` [kernel-hardening] " Salvatore Mesoraca
2017-07-04 10:12       ` Salvatore Mesoraca
2017-06-12 16:56 ` [PATCH 02/11] S.A.R.A. framework creation Salvatore Mesoraca
2017-06-12 16:56   ` [kernel-hardening] " Salvatore Mesoraca
2017-06-12 16:56   ` Salvatore Mesoraca
2017-06-12 16:56 ` [PATCH 03/11] Creation of "usb_device_auth" LSM hook Salvatore Mesoraca
2017-06-12 16:56   ` [kernel-hardening] " Salvatore Mesoraca
2017-06-12 16:56   ` Salvatore Mesoraca
2017-06-12 17:35   ` Krzysztof Opasiak
2017-06-12 17:35     ` [kernel-hardening] " Krzysztof Opasiak
2017-06-12 17:35     ` Krzysztof Opasiak
2017-06-13  7:47     ` Salvatore Mesoraca
2017-06-13  7:47       ` [kernel-hardening] " Salvatore Mesoraca
2017-06-13  7:47       ` Salvatore Mesoraca
2017-06-12 19:38   ` Greg Kroah-Hartman [this message]
2017-06-12 19:38     ` [kernel-hardening] " Greg Kroah-Hartman
2017-06-12 19:38     ` Greg Kroah-Hartman
2017-06-13  7:50     ` Salvatore Mesoraca
2017-06-13  7:50       ` [kernel-hardening] " Salvatore Mesoraca
2017-06-13  7:50       ` Salvatore Mesoraca
2017-06-12 21:31   ` Casey Schaufler
2017-06-12 21:31     ` [kernel-hardening] " Casey Schaufler
2017-06-12 21:31     ` Casey Schaufler
2017-06-13  7:51     ` Salvatore Mesoraca
2017-06-13  7:51       ` [kernel-hardening] " Salvatore Mesoraca
2017-06-13  7:51       ` Salvatore Mesoraca
2017-06-13  1:15   ` kbuild test robot
2017-06-13  1:15     ` [kernel-hardening] " kbuild test robot
2017-06-13  1:15     ` kbuild test robot
2017-06-13  3:11   ` kbuild test robot
2017-06-13  3:11     ` [kernel-hardening] " kbuild test robot
2017-06-13  3:11     ` kbuild test robot
2017-06-12 16:56 ` [PATCH 04/11] S.A.R.A. USB Filtering Salvatore Mesoraca
2017-06-12 16:56   ` [kernel-hardening] " Salvatore Mesoraca
2017-06-12 16:56   ` Salvatore Mesoraca
2017-06-20  7:07   ` Pavel Machek
2017-06-20  7:07     ` [kernel-hardening] " Pavel Machek
2017-06-20  7:53     ` Salvatore Mesoraca
2017-06-20  7:53       ` [kernel-hardening] " Salvatore Mesoraca
2017-06-20  7:53       ` Salvatore Mesoraca
2017-06-12 16:56 ` [PATCH 05/11] Creation of "check_vmflags" LSM hook Salvatore Mesoraca
2017-06-12 16:56   ` [kernel-hardening] " Salvatore Mesoraca
2017-06-12 16:56   ` Salvatore Mesoraca
2017-06-12 16:56   ` Salvatore Mesoraca
2017-06-12 21:31   ` Casey Schaufler
2017-06-12 21:31     ` [kernel-hardening] " Casey Schaufler
2017-06-12 21:31     ` Casey Schaufler
2017-06-12 21:31     ` Casey Schaufler
2017-06-13  7:55     ` Salvatore Mesoraca
2017-06-13  7:55       ` [kernel-hardening] " Salvatore Mesoraca
2017-06-13  7:55       ` Salvatore Mesoraca
2017-06-13  7:55       ` Salvatore Mesoraca
2017-06-13  6:34   ` Christoph Hellwig
2017-06-13  6:34     ` [kernel-hardening] " Christoph Hellwig
2017-06-13  6:34     ` Christoph Hellwig
2017-06-13  6:34     ` Christoph Hellwig
2017-06-13  7:52     ` Salvatore Mesoraca
2017-06-13  7:52       ` [kernel-hardening] " Salvatore Mesoraca
2017-06-13  7:52       ` Salvatore Mesoraca
2017-06-13  7:52       ` Salvatore Mesoraca
2017-06-12 16:56 ` [PATCH 06/11] S.A.R.A. cred blob management Salvatore Mesoraca
2017-06-12 16:56   ` [kernel-hardening] " Salvatore Mesoraca
2017-06-12 16:56   ` Salvatore Mesoraca
2017-06-12 16:56 ` [PATCH 07/11] S.A.R.A. WX Protection Salvatore Mesoraca
2017-06-12 16:56   ` [kernel-hardening] " Salvatore Mesoraca
2017-06-12 16:56   ` Salvatore Mesoraca
2017-06-12 16:56 ` [PATCH 08/11] Creation of "pagefault_handler_x86" LSM hook Salvatore Mesoraca
2017-06-12 16:56   ` [kernel-hardening] " Salvatore Mesoraca
2017-06-12 16:56   ` Salvatore Mesoraca
2017-06-12 17:32   ` Thomas Gleixner
2017-06-12 17:32     ` [kernel-hardening] " Thomas Gleixner
2017-06-12 17:32     ` Thomas Gleixner
2017-06-13  7:41     ` Salvatore Mesoraca
2017-06-13  7:41       ` [kernel-hardening] " Salvatore Mesoraca
2017-06-13  7:41       ` Salvatore Mesoraca
2017-06-12 16:56 ` [PATCH 09/11] Trampoline emulation Salvatore Mesoraca
2017-06-12 16:56   ` [kernel-hardening] " Salvatore Mesoraca
2017-06-12 16:56   ` Salvatore Mesoraca
2017-06-13  0:02   ` kbuild test robot
2017-06-13  0:02     ` [kernel-hardening] " kbuild test robot
2017-06-13  0:02     ` kbuild test robot
2017-06-12 16:56 ` [PATCH 10/11] Allowing for stacking procattr support in S.A.R.A Salvatore Mesoraca
2017-06-12 16:56   ` [kernel-hardening] " Salvatore Mesoraca
2017-06-12 16:56   ` Salvatore Mesoraca
2017-06-12 16:57 ` [PATCH 11/11] S.A.R.A. WX Protection procattr interface Salvatore Mesoraca
2017-06-12 16:57   ` [kernel-hardening] " Salvatore Mesoraca
2017-06-12 16:57   ` Salvatore Mesoraca
2017-07-09 19:35 ` [kernel-hardening] [PATCH 00/11] S.A.R.A. a new stacked LSM Mickaël Salaün
2017-07-10  7:59   ` Salvatore Mesoraca
2017-07-10  7:59     ` Salvatore Mesoraca
2017-07-10 23:40     ` Mickaël Salaün
2017-07-11 16:58       ` Salvatore Mesoraca
2017-07-11 16:58         ` Salvatore Mesoraca
2017-07-11 17:49         ` Matt Brown
2017-07-11 17:49           ` Matt Brown
2017-07-11 19:31           ` Mimi Zohar
2017-07-11 19:31             ` Mimi Zohar
2017-07-13 12:39             ` Matt Brown
2017-07-13 12:39               ` Matt Brown
2017-07-13 15:19               ` Mimi Zohar
2017-07-13 15:19                 ` Mimi Zohar
2017-07-13 19:51                 ` Serge E. Hallyn
2017-07-13 19:51                   ` Serge E. Hallyn
2017-07-13 22:33                   ` Matt Brown
2017-07-13 22:33                     ` Matt Brown
2017-07-24  0:58                   ` Casey Schaufler
2017-07-24  0:58                     ` Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170612193826.GA4235@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=casey@schaufler-ca.com \
    --cc=james.l.morris@oracle.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pageexec@freemail.hu \
    --cc=s.mesoraca16@gmail.com \
    --cc=serge@hallyn.com \
    --cc=spender@grsecurity.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.