All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Pavel Machek <pavel@ucw.cz>,
	pali.rohar@gmail.com, sre@kernel.org,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-omap@vger.kernel.org, khilman@kernel.org,
	aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
	patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Russell King <linux@armlinux.org.uk>
Subject: Re: n900 in next-20170901
Date: Wed, 6 Sep 2017 06:30:57 -0700	[thread overview]
Message-ID: <20170906133057.GH5024@atomide.com> (raw)
In-Reply-To: <20170905233241.GA19231@js1304-P5Q-DELUXE>

Hi,

* Joonsoo Kim <iamjoonsoo.kim@lge.com> [170905 16:32]:
> I think that I made a mistake for configuration CONFIG_HIGHMEM=y and
> CONFIG_HAVE_MEMBLOCK_NODE_MAP=y. In this case, the MOVABLE_ZONE can
> be *!highmem*. Could you check that your configuration have above
> options?

CONFIG_HIGHMEM is set yeah.

> And, could you check that following patch works for you?

Does not seem to help, tried against next with just 9caf25f996e8
revert and also with 9caf25f996e8.

Regards,

Tony


> ------------>8-----------------
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index 38f0fde..4c39c92 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -518,7 +518,7 @@ void __init dma_contiguous_remap(void)
>                  * considered as highmem even if it's physical address belong
>                  * to lowmem. Therefore, re-mapping isn't required.
>                  */
> -               if (!IS_ENABLED(CONFIG_HIGHMEM))
> +               if (!is_highmem_idx(ZONE_MOVABLE))
>                         iotable_init(&map, 1);
>         }
>  }
> 

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: n900 in next-20170901
Date: Wed, 6 Sep 2017 06:30:57 -0700	[thread overview]
Message-ID: <20170906133057.GH5024@atomide.com> (raw)
In-Reply-To: <20170905233241.GA19231@js1304-P5Q-DELUXE>

Hi,

* Joonsoo Kim <iamjoonsoo.kim@lge.com> [170905 16:32]:
> I think that I made a mistake for configuration CONFIG_HIGHMEM=y and
> CONFIG_HAVE_MEMBLOCK_NODE_MAP=y. In this case, the MOVABLE_ZONE can
> be *!highmem*. Could you check that your configuration have above
> options?

CONFIG_HIGHMEM is set yeah.

> And, could you check that following patch works for you?

Does not seem to help, tried against next with just 9caf25f996e8
revert and also with 9caf25f996e8.

Regards,

Tony


> ------------>8-----------------
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index 38f0fde..4c39c92 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -518,7 +518,7 @@ void __init dma_contiguous_remap(void)
>                  * considered as highmem even if it's physical address belong
>                  * to lowmem. Therefore, re-mapping isn't required.
>                  */
> -               if (!IS_ENABLED(CONFIG_HIGHMEM))
> +               if (!is_highmem_idx(ZONE_MOVABLE))
>                         iotable_init(&map, 1);
>         }
>  }
> 

  reply	other threads:[~2017-09-06 13:31 UTC|newest]

Thread overview: 121+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-03 20:37 n900 in next-20170901 Pavel Machek
2017-09-03 20:37 ` Pavel Machek
2017-09-05 20:13 ` Tony Lindgren
2017-09-05 20:13   ` Tony Lindgren
2017-09-05 20:27   ` Vlastimil Babka
2017-09-05 20:27     ` Vlastimil Babka
2017-09-05 20:32     ` Tony Lindgren
2017-09-05 20:32       ` Tony Lindgren
2017-09-05 23:32   ` Joonsoo Kim
2017-09-05 23:32     ` Joonsoo Kim
2017-09-06 13:30     ` Tony Lindgren [this message]
2017-09-06 13:30       ` Tony Lindgren
2017-09-07  7:30       ` Joonsoo Kim
2017-09-07  7:30         ` Joonsoo Kim
2017-09-07 16:16         ` Tony Lindgren
2017-09-07 16:16           ` Tony Lindgren
2017-09-13  7:55           ` Joonsoo Kim
2017-09-13  7:55             ` Joonsoo Kim
2017-09-13 16:31             ` Tony Lindgren
2017-09-13 16:31               ` Tony Lindgren
2017-09-15  6:56               ` Joonsoo Kim
2017-09-15  6:56                 ` Joonsoo Kim
2017-09-21 17:28                 ` Tony Lindgren
2017-09-21 17:28                   ` Tony Lindgren
2017-09-25  8:08                   ` Joonsoo Kim
2017-09-25  8:08                     ` Joonsoo Kim
2017-09-25 14:54                     ` Tony Lindgren
2017-09-25 14:54                       ` Tony Lindgren
2017-10-18  8:29                       ` Joonsoo Kim
2017-10-18  8:29                         ` Joonsoo Kim
2017-10-19 18:30                         ` Tony Lindgren
2017-10-19 18:30                           ` Tony Lindgren
2017-10-20  1:55                           ` Joonsoo Kim
2017-10-20  1:55                             ` Joonsoo Kim
2017-10-20 17:31                             ` Tony Lindgren
2017-10-20 17:31                               ` Tony Lindgren
2017-10-23  4:53                               ` Joonsoo Kim
2017-10-23  4:53                                 ` Joonsoo Kim
2017-10-25 17:31                                 ` Tony Lindgren
2017-10-25 17:31                                   ` Tony Lindgren
2017-10-26  4:48                                   ` Joonsoo Kim
2017-10-26  4:48                                     ` Joonsoo Kim
2017-10-26 14:16                                     ` Tony Lindgren
2017-10-26 14:16                                       ` Tony Lindgren
2017-11-07  5:33                                       ` Joonsoo Kim
2017-11-07  5:33                                         ` Joonsoo Kim
2017-11-07 15:48                                         ` Tony Lindgren
2017-11-07 15:48                                           ` Tony Lindgren
2017-11-08  7:46                                           ` Joonsoo Kim
2017-11-08  7:46                                             ` Joonsoo Kim
2017-11-08 16:34                                             ` Tony Lindgren
2017-11-08 16:34                                               ` Tony Lindgren
2017-11-09  0:08                                               ` Joonsoo Kim
2017-11-09  0:08                                                 ` Joonsoo Kim
2017-11-09  0:11                                                 ` Tony Lindgren
2017-11-09  0:11                                                   ` Tony Lindgren
2017-11-09  0:36                                                   ` Joonsoo Kim
2017-11-09  0:36                                                     ` Joonsoo Kim
2017-11-09  3:50                                                     ` Joonsoo Kim
2017-11-09  3:50                                                       ` Joonsoo Kim
2017-11-09 15:08                                                       ` Tony Lindgren
2017-11-09 15:08                                                         ` Tony Lindgren
2017-11-10  0:13                                                         ` Joonsoo Kim
2017-11-10  0:13                                                           ` Joonsoo Kim
2017-11-10  3:26                                                           ` Tony Lindgren
2017-11-10  3:26                                                             ` Tony Lindgren
2017-11-10  6:19                                                             ` Tony Lindgren
2017-11-10  6:19                                                               ` Tony Lindgren
2017-11-10  6:23                                                               ` Tony Lindgren
2017-11-10  6:23                                                                 ` Tony Lindgren
2017-11-10  6:46                                                                 ` Joonsoo Kim
2017-11-10  6:46                                                                   ` Joonsoo Kim
2017-11-10 15:37                                                                   ` Tony Lindgren
2017-11-10 15:37                                                                     ` Tony Lindgren
2017-11-10  6:37                                                             ` Joonsoo Kim
2017-11-10  6:37                                                               ` Joonsoo Kim
2017-11-10 15:36                                                               ` Tony Lindgren
2017-11-10 15:36                                                                 ` Tony Lindgren
2017-11-13 21:15                                                                 ` Tony Lindgren
2017-11-13 21:15                                                                   ` Tony Lindgren
2017-11-14  6:40                                                                   ` Joonsoo Kim
2017-11-14  6:40                                                                     ` Joonsoo Kim
2017-11-14  6:37                                                                 ` Joonsoo Kim
2017-11-14  6:37                                                                   ` Joonsoo Kim
2017-11-14 17:37                                                                   ` Tony Lindgren
2017-11-14 17:37                                                                     ` Tony Lindgren
2017-11-14 19:31                                                                     ` Tero Kristo
2017-11-14 19:31                                                                       ` Tero Kristo
2017-11-14 19:31                                                                       ` Tero Kristo
2017-11-14 19:44                                                                       ` Tony Lindgren
2017-11-14 19:44                                                                         ` Tony Lindgren
2017-11-14 20:01                                                                         ` Tero Kristo
2017-11-14 20:01                                                                           ` Tero Kristo
2017-11-14 20:01                                                                           ` Tero Kristo
2017-11-14 20:54                                                                           ` Tony Lindgren
2017-11-14 20:54                                                                             ` Tony Lindgren
2017-11-15  0:51                                                                     ` Joonsoo Kim
2017-11-15  0:51                                                                       ` Joonsoo Kim
2017-11-15  2:04                                                                       ` Tony Lindgren
2017-11-15  2:04                                                                         ` Tony Lindgren
2017-11-15  2:48                                                                         ` Joonsoo Kim
2017-11-15  2:48                                                                           ` Joonsoo Kim
2017-11-15  2:53                                                                           ` Tony Lindgren
2017-11-15  2:53                                                                             ` Tony Lindgren
2017-11-15  2:53                                                                             ` Tony Lindgren
2017-09-15 13:18           ` Pavel Machek
2017-09-15 13:18             ` Pavel Machek
2017-09-18  2:01             ` Joonsoo Kim
2017-09-18  2:01               ` Joonsoo Kim
2017-09-18  8:11               ` Linux-next broken for 2 weeks was " Pavel Machek
2017-09-18  8:11                 ` Pavel Machek
2017-09-18 22:00                 ` Stephen Rothwell
2017-09-18 22:00                   ` Stephen Rothwell
2017-09-18 22:16                   ` Pavel Machek
2017-09-18 22:16                     ` Pavel Machek
2017-09-15 13:28         ` Pali Rohár
2017-09-15 13:28           ` Pali Rohár
2017-09-18  2:07           ` Joonsoo Kim
2017-09-18  2:07             ` Joonsoo Kim
2017-09-08  9:31   ` Pavel Machek
2017-09-08  9:31     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170906133057.GH5024@atomide.com \
    --to=tony@atomide.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=abcloriens@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=pali.rohar@gmail.com \
    --cc=patrikbachan@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=serge@hallyn.com \
    --cc=sfr@canb.auug.org.au \
    --cc=sre@kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.