From: Sebastian Reichel <sre@kernel.org> To: Ladislav Michl <ladis@linux-mips.org> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>, Tony Lindgren <tony@atomide.com>, Peter Ujfalusi <peter.ujfalusi@ti.com>, Kyungmin Park <kyungmin.park@samsung.com>, linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, Roger Quadros <rogerq@ti.com> Subject: Re: [PATCH v4 07/16] mtd: onenand: omap2: Account waiting time as waiting on IO Date: Wed, 15 Nov 2017 16:00:04 +0100 [thread overview] Message-ID: <20171115150004.v2i47cjutt3bpaml@earth> (raw) In-Reply-To: <20171111212058.3xkqfw42ik6pre47@lenoch> [-- Attachment #1.1: Type: text/plain, Size: 1378 bytes --] Hi, On Sat, Nov 11, 2017 at 10:20:58PM +0100, Ladislav Michl wrote: > Use wait_for_completion_io_timeout, which has an impact on how the > task is accounted in scheduling stats. > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > --- Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> -- Sebastian > Changes: > -v4: new patch > > drivers/mtd/onenand/omap2.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c > index 883993bbe40b..0e7772e16d75 100644 > --- a/drivers/mtd/onenand/omap2.c > +++ b/drivers/mtd/onenand/omap2.c > @@ -170,9 +170,8 @@ static int omap2_onenand_wait(struct mtd_info *mtd, int state) > if (result == 0) { > int retry_cnt = 0; > retry: > - result = wait_for_completion_timeout(&c->irq_done, > - msecs_to_jiffies(20)); > - if (result == 0) { > + if (!wait_for_completion_io_timeout(&c->irq_done, > + msecs_to_jiffies(20))) { > /* Timeout after 20ms */ > ctrl = read_reg(c, ONENAND_REG_CTRL_STATUS); > if (ctrl & ONENAND_CTRL_ONGO && > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 144 bytes --] ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sre@kernel.org> To: Ladislav Michl <ladis@linux-mips.org> Cc: linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>, Peter Ujfalusi <peter.ujfalusi@ti.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, Kyungmin Park <kyungmin.park@samsung.com> Subject: Re: [PATCH v4 07/16] mtd: onenand: omap2: Account waiting time as waiting on IO Date: Wed, 15 Nov 2017 16:00:04 +0100 [thread overview] Message-ID: <20171115150004.v2i47cjutt3bpaml@earth> (raw) In-Reply-To: <20171111212058.3xkqfw42ik6pre47@lenoch> [-- Attachment #1: Type: text/plain, Size: 1378 bytes --] Hi, On Sat, Nov 11, 2017 at 10:20:58PM +0100, Ladislav Michl wrote: > Use wait_for_completion_io_timeout, which has an impact on how the > task is accounted in scheduling stats. > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > --- Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> -- Sebastian > Changes: > -v4: new patch > > drivers/mtd/onenand/omap2.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c > index 883993bbe40b..0e7772e16d75 100644 > --- a/drivers/mtd/onenand/omap2.c > +++ b/drivers/mtd/onenand/omap2.c > @@ -170,9 +170,8 @@ static int omap2_onenand_wait(struct mtd_info *mtd, int state) > if (result == 0) { > int retry_cnt = 0; > retry: > - result = wait_for_completion_timeout(&c->irq_done, > - msecs_to_jiffies(20)); > - if (result == 0) { > + if (!wait_for_completion_io_timeout(&c->irq_done, > + msecs_to_jiffies(20))) { > /* Timeout after 20ms */ > ctrl = read_reg(c, ONENAND_REG_CTRL_STATUS); > if (ctrl & ONENAND_CTRL_ONGO && > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-15 15:00 UTC|newest] Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-11 21:12 [PATCH v4 00/16] OMAP2+ OneNAND driver update Ladislav Michl 2017-11-11 21:12 ` Ladislav Michl 2017-11-11 21:17 ` [PATCH v4 02/16] ARM: dts: OMAP2+: Add compatible property to onenand node Ladislav Michl 2017-11-11 21:17 ` Ladislav Michl 2017-11-14 15:11 ` Roger Quadros 2017-11-14 15:11 ` Roger Quadros 2017-11-14 23:01 ` Ladislav Michl 2017-11-14 23:01 ` Ladislav Michl 2017-11-14 21:39 ` Tony Lindgren 2017-11-14 21:39 ` Tony Lindgren 2017-11-11 21:18 ` [PATCH v4 03/16] ARM: dts: omap3-igep: Update onenand node timings Ladislav Michl 2017-11-11 21:18 ` Ladislav Michl 2017-11-14 15:12 ` Roger Quadros 2017-11-14 15:12 ` Roger Quadros 2017-11-14 21:39 ` Tony Lindgren 2017-11-14 21:39 ` Tony Lindgren 2017-11-11 21:19 ` [PATCH v4 04/16] mtd: onenand: omap2: Remove regulator support Ladislav Michl 2017-11-11 21:19 ` Ladislav Michl 2017-11-14 15:13 ` Roger Quadros 2017-11-14 15:13 ` Roger Quadros 2017-11-15 14:15 ` Sebastian Reichel 2017-11-15 14:15 ` Sebastian Reichel 2017-11-11 21:19 ` [PATCH v4 05/16] mtd: onenand: omap2: Remove skip initial unlocking support Ladislav Michl 2017-11-11 21:19 ` Ladislav Michl 2017-11-14 15:14 ` Roger Quadros 2017-11-14 15:14 ` Roger Quadros 2017-11-15 14:16 ` Sebastian Reichel 2017-11-15 14:16 ` Sebastian Reichel 2017-11-11 21:20 ` [PATCH v4 06/16] mtd: onenand: omap2: Remove partitioning support from platform data Ladislav Michl 2017-11-11 21:20 ` Ladislav Michl 2017-11-14 15:14 ` Roger Quadros 2017-11-14 15:14 ` Roger Quadros 2017-11-15 14:57 ` Sebastian Reichel 2017-11-15 14:57 ` Sebastian Reichel 2017-11-11 21:20 ` [PATCH v4 07/16] mtd: onenand: omap2: Account waiting time as waiting on IO Ladislav Michl 2017-11-11 21:20 ` Ladislav Michl 2017-11-14 15:18 ` Roger Quadros 2017-11-14 15:18 ` Roger Quadros 2017-11-15 15:00 ` Sebastian Reichel [this message] 2017-11-15 15:00 ` Sebastian Reichel 2017-11-11 21:21 ` [PATCH v4 08/16] mtd: onenand: omap2: Simplify the DMA setup for various paths Ladislav Michl 2017-11-11 21:21 ` Ladislav Michl 2017-11-15 8:35 ` Roger Quadros 2017-11-15 8:35 ` Roger Quadros 2017-11-15 15:05 ` Sebastian Reichel 2017-11-15 15:05 ` Sebastian Reichel 2017-11-11 21:22 ` [PATCH v4 09/16] mtd: onenand: omap2: Unify OMAP2 and OMAP3 DMA implementation Ladislav Michl 2017-11-11 21:22 ` Ladislav Michl 2017-11-15 8:38 ` Roger Quadros 2017-11-15 8:38 ` Roger Quadros 2017-11-15 15:07 ` Sebastian Reichel 2017-11-15 15:07 ` Sebastian Reichel 2017-11-11 21:23 ` [PATCH v4 10/16] mtd: onenand: omap2: Convert to use dmaengine for memcpy Ladislav Michl 2017-11-11 21:23 ` Ladislav Michl 2017-11-15 8:57 ` Roger Quadros 2017-11-15 8:57 ` Roger Quadros 2017-11-15 9:32 ` Ladislav Michl 2017-11-15 9:32 ` Ladislav Michl 2017-11-15 15:19 ` Sebastian Reichel 2017-11-15 15:19 ` Sebastian Reichel 2017-11-11 21:24 ` [PATCH v4 11/16] mtd: onenand: omap2: Do not make delay for GPIO OMAP3 specific Ladislav Michl 2017-11-11 21:24 ` Ladislav Michl 2017-11-15 9:31 ` Roger Quadros 2017-11-15 9:31 ` Roger Quadros 2017-11-15 15:20 ` Sebastian Reichel 2017-11-15 15:20 ` Sebastian Reichel 2017-11-11 21:24 ` [PATCH v4 12/16] mtd: onenand: omap2: Enable DMA by default Ladislav Michl 2017-11-11 21:24 ` Ladislav Michl 2017-11-15 10:08 ` Roger Quadros 2017-11-15 10:08 ` Roger Quadros 2017-11-15 10:32 ` Ladislav Michl 2017-11-15 10:32 ` Ladislav Michl 2017-11-15 10:43 ` Roger Quadros 2017-11-15 10:43 ` Roger Quadros 2017-11-27 18:21 ` Ladislav Michl 2017-11-27 18:21 ` Ladislav Michl 2017-11-15 10:44 ` Roger Quadros 2017-11-15 10:44 ` Roger Quadros 2017-11-11 21:26 ` [PATCH v4 13/16] memory: omap-gpmc: Refactor OneNAND support Ladislav Michl 2017-11-11 21:26 ` Ladislav Michl 2017-11-15 10:13 ` Roger Quadros 2017-11-15 10:13 ` Roger Quadros 2017-11-15 10:37 ` Ladislav Michl 2017-11-15 10:37 ` Ladislav Michl 2017-11-11 21:27 ` [PATCH v4 14/16] mtd: onenand: omap2: Configure driver from DT Ladislav Michl 2017-11-11 21:27 ` Ladislav Michl 2017-11-15 10:40 ` Roger Quadros 2017-11-15 10:40 ` Roger Quadros 2017-11-15 10:53 ` Ladislav Michl 2017-11-15 10:53 ` Ladislav Michl 2017-11-15 11:04 ` Roger Quadros 2017-11-15 11:04 ` Roger Quadros 2017-11-15 11:20 ` Ladislav Michl 2017-11-15 11:20 ` Ladislav Michl 2017-11-15 14:41 ` Roger Quadros 2017-11-15 14:41 ` Roger Quadros 2017-11-11 21:29 ` [PATCH v4 15/16] ARM: OMAP2+: Remove gpmc-onenand Ladislav Michl 2017-11-11 21:29 ` Ladislav Michl 2017-11-14 21:41 ` Tony Lindgren 2017-11-14 21:41 ` Tony Lindgren 2017-11-15 10:46 ` Roger Quadros 2017-11-15 10:46 ` Roger Quadros 2017-11-11 21:29 ` [PATCH v4 16/16] ARM: dts: Nokia: Use R/B pin Ladislav Michl 2017-11-11 21:29 ` Ladislav Michl 2017-11-14 21:42 ` Tony Lindgren 2017-11-14 21:42 ` Tony Lindgren 2017-11-14 22:46 ` Ladislav Michl 2017-11-14 22:46 ` Ladislav Michl 2017-11-14 21:48 ` [PATCH v4 00/16] OMAP2+ OneNAND driver update Tony Lindgren 2017-11-14 21:48 ` Tony Lindgren 2017-11-14 22:53 ` Ladislav Michl 2017-11-14 22:53 ` Ladislav Michl 2017-11-15 8:10 ` Peter Ujfalusi 2017-11-15 8:10 ` Peter Ujfalusi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171115150004.v2i47cjutt3bpaml@earth \ --to=sre@kernel.org \ --cc=boris.brezillon@free-electrons.com \ --cc=kyungmin.park@samsung.com \ --cc=ladis@linux-mips.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=peter.ujfalusi@ti.com \ --cc=rogerq@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.