From: Mike Snitzer <snitzer@redhat.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v5] blk-mq: introduce BLK_STS_DEV_RESOURCE
Date: Tue, 30 Jan 2018 15:12:12 -0500 [thread overview]
Message-ID: <20180130201212.GA16284@redhat.com> (raw)
In-Reply-To: <1517341349.2589.35.camel@wdc.com>
On Tue, Jan 30 2018 at 2:42pm -0500,
Bart Van Assche <Bart.VanAssche@wdc.com> wrote:
> On Tue, 2018-01-30 at 14:33 -0500, Mike Snitzer wrote:
> > On Tue, Jan 30 2018 at 12:52pm -0500,
> > Bart Van Assche <bart.vanassche@wdc.com> wrote:
> >
> > > - This patch does not fix any bugs nor makes block drivers easier to
> > > read or to implement. So why is this patch considered useful?
> >
> > It enables blk-mq core to own the problem that individual drivers should
> > have no business needing to worry about. Period.
>
> Thanks for having confirmed that this patch is an API-change only and does
> not fix any bugs.
No, it is an API change that enables blk-mq drivers to make forward
progress without compromising the potential benefits associated with
blk-mq's SCHED_RESTART functionality.
(If we're going to beat this horse to death it might as well be with
precision)
WARNING: multiple messages have this Message-ID (diff)
From: snitzer@redhat.com (Mike Snitzer)
Subject: [PATCH v5] blk-mq: introduce BLK_STS_DEV_RESOURCE
Date: Tue, 30 Jan 2018 15:12:12 -0500 [thread overview]
Message-ID: <20180130201212.GA16284@redhat.com> (raw)
In-Reply-To: <1517341349.2589.35.camel@wdc.com>
On Tue, Jan 30 2018 at 2:42pm -0500,
Bart Van Assche <Bart.VanAssche@wdc.com> wrote:
> On Tue, 2018-01-30@14:33 -0500, Mike Snitzer wrote:
> > On Tue, Jan 30 2018 at 12:52pm -0500,
> > Bart Van Assche <bart.vanassche@wdc.com> wrote:
> >
> > > - This patch does not fix any bugs nor makes block drivers easier to
> > > read or to implement. So why is this patch considered useful?
> >
> > It enables blk-mq core to own the problem that individual drivers should
> > have no business needing to worry about. Period.
>
> Thanks for having confirmed that this patch is an API-change only and does
> not fix any bugs.
No, it is an API change that enables blk-mq drivers to make forward
progress without compromising the potential benefits associated with
blk-mq's SCHED_RESTART functionality.
(If we're going to beat this horse to death it might as well be with
precision)
next prev parent reply other threads:[~2018-01-30 20:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 14:24 [PATCH v5] blk-mq: introduce BLK_STS_DEV_RESOURCE Mike Snitzer
2018-01-30 14:24 ` Mike Snitzer
2018-01-30 17:52 ` [dm-devel] " Bart Van Assche
2018-01-30 17:52 ` Bart Van Assche
2018-01-30 18:38 ` Laurence Oberman
2018-01-30 18:38 ` Laurence Oberman
2018-01-30 18:38 ` Laurence Oberman
2018-01-30 19:33 ` Mike Snitzer
2018-01-30 19:33 ` Mike Snitzer
2018-01-30 19:42 ` Bart Van Assche
2018-01-30 19:42 ` Bart Van Assche
2018-01-30 19:42 ` Bart Van Assche
2018-01-30 20:12 ` Mike Snitzer [this message]
2018-01-30 20:12 ` Mike Snitzer
2018-01-31 2:14 ` [dm-devel] " Ming Lei
2018-01-31 2:14 ` Ming Lei
2018-01-31 3:17 ` Jens Axboe
2018-01-31 3:17 ` Jens Axboe
2018-01-31 3:21 ` Bart Van Assche
2018-01-31 3:21 ` Bart Van Assche
2018-01-31 3:21 ` Bart Van Assche
2018-01-31 3:22 ` Jens Axboe
2018-01-31 3:22 ` Jens Axboe
2018-01-31 3:27 ` Bart Van Assche
2018-01-31 3:27 ` Bart Van Assche
2018-01-31 3:27 ` Bart Van Assche
2018-01-31 3:31 ` Jens Axboe
2018-01-31 3:31 ` Jens Axboe
2018-01-31 3:33 ` Ming Lei
2018-01-31 3:33 ` Ming Lei
2018-01-31 3:33 ` Ming Lei
2018-01-31 2:44 ` Jens Axboe
2018-01-31 2:44 ` Jens Axboe
2018-01-31 3:04 ` [PATCH v6] " Mike Snitzer
2018-01-31 3:04 ` Mike Snitzer
2018-01-31 3:18 ` Jens Axboe
2018-01-31 3:18 ` Jens Axboe
2018-01-31 3:07 ` [PATCH v5] " Mike Snitzer
2018-01-31 3:07 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130201212.GA16284@redhat.com \
--to=snitzer@redhat.com \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.