From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <Bart.VanAssche@wdc.com>,
"snitzer@redhat.com" <snitzer@redhat.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [dm-devel] [PATCH v5] blk-mq: introduce BLK_STS_DEV_RESOURCE
Date: Tue, 30 Jan 2018 20:22:27 -0700 [thread overview]
Message-ID: <d563628f-687d-c463-7e7e-d85a52cdf25b@kernel.dk> (raw)
In-Reply-To: <1517368861.4421.2.camel@wdc.com>
On 1/30/18 8:21 PM, Bart Van Assche wrote:
> On Tue, 2018-01-30 at 20:17 -0700, Jens Axboe wrote:
>> BLK_STS_RESOURCE should always be safe to return, and it should work
>> the same as STS_DEV_RESOURCE, except it may cause an extra queue
>> run.
>>
>> Well written drivers should use STS_DEV_RESOURCE where it makes
>> sense.
>
> Hello Jens,
>
> I would appreciate it if other names would be chosen than BLK_STS_RESOURCE
> and BLK_STS_DEV_RESOURCE, e.g. names that directly refer to the fact that
> one of the two status codes causes the queue to be rerun and the other not.
> I'm afraid that the currently chosen names will cause confusion.
DEV_RESOURCE is pretty clear I think, but I agree that STS_RESOURCE
could perhaps be better. STS_SYSTEM_RESOURCE? It makes the distinction
a bit clearer.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: axboe@kernel.dk (Jens Axboe)
Subject: [dm-devel] [PATCH v5] blk-mq: introduce BLK_STS_DEV_RESOURCE
Date: Tue, 30 Jan 2018 20:22:27 -0700 [thread overview]
Message-ID: <d563628f-687d-c463-7e7e-d85a52cdf25b@kernel.dk> (raw)
In-Reply-To: <1517368861.4421.2.camel@wdc.com>
On 1/30/18 8:21 PM, Bart Van Assche wrote:
> On Tue, 2018-01-30@20:17 -0700, Jens Axboe wrote:
>> BLK_STS_RESOURCE should always be safe to return, and it should work
>> the same as STS_DEV_RESOURCE, except it may cause an extra queue
>> run.
>>
>> Well written drivers should use STS_DEV_RESOURCE where it makes
>> sense.
>
> Hello Jens,
>
> I would appreciate it if other names would be chosen than BLK_STS_RESOURCE
> and BLK_STS_DEV_RESOURCE, e.g. names that directly refer to the fact that
> one of the two status codes causes the queue to be rerun and the other not.
> I'm afraid that the currently chosen names will cause confusion.
DEV_RESOURCE is pretty clear I think, but I agree that STS_RESOURCE
could perhaps be better. STS_SYSTEM_RESOURCE? It makes the distinction
a bit clearer.
--
Jens Axboe
next prev parent reply other threads:[~2018-01-31 3:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 14:24 [PATCH v5] blk-mq: introduce BLK_STS_DEV_RESOURCE Mike Snitzer
2018-01-30 14:24 ` Mike Snitzer
2018-01-30 17:52 ` [dm-devel] " Bart Van Assche
2018-01-30 17:52 ` Bart Van Assche
2018-01-30 18:38 ` Laurence Oberman
2018-01-30 18:38 ` Laurence Oberman
2018-01-30 18:38 ` Laurence Oberman
2018-01-30 19:33 ` Mike Snitzer
2018-01-30 19:33 ` Mike Snitzer
2018-01-30 19:42 ` Bart Van Assche
2018-01-30 19:42 ` Bart Van Assche
2018-01-30 19:42 ` Bart Van Assche
2018-01-30 20:12 ` Mike Snitzer
2018-01-30 20:12 ` Mike Snitzer
2018-01-31 2:14 ` [dm-devel] " Ming Lei
2018-01-31 2:14 ` Ming Lei
2018-01-31 3:17 ` Jens Axboe
2018-01-31 3:17 ` Jens Axboe
2018-01-31 3:21 ` Bart Van Assche
2018-01-31 3:21 ` Bart Van Assche
2018-01-31 3:21 ` Bart Van Assche
2018-01-31 3:22 ` Jens Axboe [this message]
2018-01-31 3:22 ` Jens Axboe
2018-01-31 3:27 ` Bart Van Assche
2018-01-31 3:27 ` Bart Van Assche
2018-01-31 3:27 ` Bart Van Assche
2018-01-31 3:31 ` Jens Axboe
2018-01-31 3:31 ` Jens Axboe
2018-01-31 3:33 ` Ming Lei
2018-01-31 3:33 ` Ming Lei
2018-01-31 3:33 ` Ming Lei
2018-01-31 2:44 ` Jens Axboe
2018-01-31 2:44 ` Jens Axboe
2018-01-31 3:04 ` [PATCH v6] " Mike Snitzer
2018-01-31 3:04 ` Mike Snitzer
2018-01-31 3:18 ` Jens Axboe
2018-01-31 3:18 ` Jens Axboe
2018-01-31 3:07 ` [PATCH v5] " Mike Snitzer
2018-01-31 3:07 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d563628f-687d-c463-7e7e-d85a52cdf25b@kernel.dk \
--to=axboe@kernel.dk \
--cc=Bart.VanAssche@wdc.com \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.