From: Rob Herring <robh@kernel.org> To: Benjamin Gaignard <benjamin.gaignard@linaro.org> Cc: William Breathitt Gray <vilhelm.gray@gmail.com>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Benjamin Gaignard <benjamin.gaignard@st.com>, linux-iio@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, Fabrice Gasnier <fabrice.gasnier@st.com>, Jonathan Cameron <jic23@kernel.org> Subject: Re: [PATCH v6 6/9] dt-bindings: counter: Document stm32 quadrature encoder Date: Fri, 18 May 2018 11:28:15 -0500 [thread overview] Message-ID: <20180518162815.GA24966@rob-hp-laptop> (raw) In-Reply-To: <CA+M3ks4vjE5JMmLjjPnf6ffD9QYSUmSyrpO+yxADT_8WqAA3Tg@mail.gmail.com> On Thu, May 17, 2018 at 08:59:40PM +0200, Benjamin Gaignard wrote: > 2018-05-17 18:23 GMT+02:00 Rob Herring <robh+dt@kernel.org>: > > On Wed, May 16, 2018 at 12:51 PM, William Breathitt Gray > > <vilhelm.gray@gmail.com> wrote: > >> From: Benjamin Gaignard <benjamin.gaignard@st.com> > > > > v6? Where's v1-v5? > > > >> Add bindings for STM32 Timer quadrature encoder. > >> It is a sub-node of STM32 Timer which implement the > >> counter part of the hardware. > >> > >> Cc: Rob Herring <robh+dt@kernel.org> > >> Cc: Mark Rutland <mark.rutland@arm.com> > >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > >> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > >> --- > >> .../bindings/counter/stm32-timer-cnt.txt | 26 +++++++++++++++++++ > >> .../devicetree/bindings/mfd/stm32-timers.txt | 7 +++++ > >> 2 files changed, 33 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt > >> > >> diff --git a/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt b/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt > >> new file mode 100644 > >> index 000000000000..377728128bef > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt > >> @@ -0,0 +1,26 @@ > >> +STMicroelectronics STM32 Timer quadrature encoder > >> + > >> +STM32 Timer provides quadrature encoder counter mode to detect > > > > 'mode' does not sound like a sub-block of the timers block. > > quadrature encoding is one of the counting modes of this hardware > block which is enable to count on other signals/triggers You don't need a child node and compatible to set a mode. > >> +angular position and direction of rotary elements, > >> +from IN1 and IN2 input signals. > >> + > >> +Must be a sub-node of an STM32 Timer device tree node. > >> +See ../mfd/stm32-timers.txt for details about the parent node. > >> + > >> +Required properties: > >> +- compatible: Must be "st,stm32-timer-counter". > >> +- pinctrl-names: Set to "default". > >> +- pinctrl-0: List of phandles pointing to pin configuration nodes, > >> + to set IN1/IN2 pins in mode of operation for Low-Power > >> + Timer input on external pin. > >> + > >> +Example: > >> + timers@40010000 { > >> + compatible = "st,stm32-timers"; > >> + ... > >> + counter { > >> + compatible = "st,stm32-timer-counter"; > > > > Is there only 1? How is the counter addressed? > > Yes there is only one counter per hardware block. > Counter is addressed like the two others sub-nodes and the details > about parent mode are describe in stm32-timers.txt > Should I add them here too ? so example will be like that: No, you should drop the child node and add pinctrl to the parent. Any other functions this block has that you plan on adding? Please make bindings as complete as possible, not what you currently have drivers for. > timers@40010000 { > #address-cells = <1>; > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x40010000 0x400>; > clocks = <&rcc 0 160>; > clock-names = "int"; > counter { > compatible = "st,stm32-timer-counter"; > pinctrl-names = "default"; > pinctrl-0 = <&tim1_in_pins>; > }; > }; > > Benjamin > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 6/9] dt-bindings: counter: Document stm32 quadrature encoder Date: Fri, 18 May 2018 11:28:15 -0500 [thread overview] Message-ID: <20180518162815.GA24966@rob-hp-laptop> (raw) In-Reply-To: <CA+M3ks4vjE5JMmLjjPnf6ffD9QYSUmSyrpO+yxADT_8WqAA3Tg@mail.gmail.com> On Thu, May 17, 2018 at 08:59:40PM +0200, Benjamin Gaignard wrote: > 2018-05-17 18:23 GMT+02:00 Rob Herring <robh+dt@kernel.org>: > > On Wed, May 16, 2018 at 12:51 PM, William Breathitt Gray > > <vilhelm.gray@gmail.com> wrote: > >> From: Benjamin Gaignard <benjamin.gaignard@st.com> > > > > v6? Where's v1-v5? > > > >> Add bindings for STM32 Timer quadrature encoder. > >> It is a sub-node of STM32 Timer which implement the > >> counter part of the hardware. > >> > >> Cc: Rob Herring <robh+dt@kernel.org> > >> Cc: Mark Rutland <mark.rutland@arm.com> > >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > >> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > >> --- > >> .../bindings/counter/stm32-timer-cnt.txt | 26 +++++++++++++++++++ > >> .../devicetree/bindings/mfd/stm32-timers.txt | 7 +++++ > >> 2 files changed, 33 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt > >> > >> diff --git a/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt b/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt > >> new file mode 100644 > >> index 000000000000..377728128bef > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt > >> @@ -0,0 +1,26 @@ > >> +STMicroelectronics STM32 Timer quadrature encoder > >> + > >> +STM32 Timer provides quadrature encoder counter mode to detect > > > > 'mode' does not sound like a sub-block of the timers block. > > quadrature encoding is one of the counting modes of this hardware > block which is enable to count on other signals/triggers You don't need a child node and compatible to set a mode. > >> +angular position and direction of rotary elements, > >> +from IN1 and IN2 input signals. > >> + > >> +Must be a sub-node of an STM32 Timer device tree node. > >> +See ../mfd/stm32-timers.txt for details about the parent node. > >> + > >> +Required properties: > >> +- compatible: Must be "st,stm32-timer-counter". > >> +- pinctrl-names: Set to "default". > >> +- pinctrl-0: List of phandles pointing to pin configuration nodes, > >> + to set IN1/IN2 pins in mode of operation for Low-Power > >> + Timer input on external pin. > >> + > >> +Example: > >> + timers at 40010000 { > >> + compatible = "st,stm32-timers"; > >> + ... > >> + counter { > >> + compatible = "st,stm32-timer-counter"; > > > > Is there only 1? How is the counter addressed? > > Yes there is only one counter per hardware block. > Counter is addressed like the two others sub-nodes and the details > about parent mode are describe in stm32-timers.txt > Should I add them here too ? so example will be like that: No, you should drop the child node and add pinctrl to the parent. Any other functions this block has that you plan on adding? Please make bindings as complete as possible, not what you currently have drivers for. > timers at 40010000 { > #address-cells = <1>; > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x40010000 0x400>; > clocks = <&rcc 0 160>; > clock-names = "int"; > counter { > compatible = "st,stm32-timer-counter"; > pinctrl-names = "default"; > pinctrl-0 = <&tim1_in_pins>; > }; > }; > > Benjamin > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel at lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-05-18 16:28 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-16 17:50 [PATCH v6 0/9] Introduce the Counter subsystem William Breathitt Gray 2018-05-16 17:50 ` William Breathitt Gray 2018-05-16 17:50 ` [PATCH v6 1/9] counter: Introduce the Generic Counter interface William Breathitt Gray 2018-05-16 17:50 ` William Breathitt Gray 2018-05-20 15:06 ` Jonathan Cameron 2018-05-20 15:06 ` Jonathan Cameron 2018-05-21 13:06 ` William Breathitt Gray 2018-05-21 13:06 ` William Breathitt Gray 2018-05-16 17:50 ` [PATCH v6 2/9] counter: Documentation: Add Generic Counter sysfs documentation William Breathitt Gray 2018-05-16 17:50 ` William Breathitt Gray 2018-05-20 15:12 ` Jonathan Cameron 2018-05-20 15:12 ` Jonathan Cameron 2018-05-16 17:51 ` [PATCH v6 3/9] docs: Add Generic Counter interface documentation William Breathitt Gray 2018-05-16 17:51 ` William Breathitt Gray 2018-05-19 15:30 ` kbuild test robot 2018-05-19 15:30 ` kbuild test robot 2018-05-19 15:30 ` kbuild test robot 2018-05-20 15:31 ` Jonathan Cameron 2018-05-20 15:31 ` Jonathan Cameron 2018-05-20 15:31 ` Jonathan Cameron 2018-05-21 13:47 ` William Breathitt Gray 2018-05-21 13:47 ` William Breathitt Gray 2018-05-22 17:08 ` Jonathan Cameron 2018-05-22 17:08 ` Jonathan Cameron 2018-05-25 9:26 ` Fabrice Gasnier 2018-05-25 9:26 ` Fabrice Gasnier 2018-05-25 9:26 ` Fabrice Gasnier 2018-05-25 13:00 ` William Breathitt Gray 2018-05-25 13:00 ` William Breathitt Gray 2018-05-16 17:51 ` [PATCH v6 4/9] counter: 104-quad-8: Add Generic Counter interface support William Breathitt Gray 2018-05-16 17:51 ` William Breathitt Gray 2018-05-19 13:16 ` kbuild test robot 2018-05-19 13:16 ` kbuild test robot 2018-05-19 13:16 ` kbuild test robot 2018-05-19 13:55 ` William Breathitt Gray 2018-05-19 13:55 ` William Breathitt Gray 2018-05-19 13:55 ` William Breathitt Gray 2018-05-19 13:16 ` [RFC PATCH] counter: 104-quad-8: quad8_ops can be static kbuild test robot 2018-05-19 13:16 ` kbuild test robot 2018-05-19 13:16 ` kbuild test robot 2018-05-20 15:42 ` [PATCH v6 4/9] counter: 104-quad-8: Add Generic Counter interface support Jonathan Cameron 2018-05-20 15:42 ` Jonathan Cameron 2018-05-21 13:51 ` William Breathitt Gray 2018-05-21 13:51 ` William Breathitt Gray 2018-05-16 17:51 ` [PATCH v6 5/9] counter: 104-quad-8: Documentation: Add Generic Counter sysfs documentation William Breathitt Gray 2018-05-16 17:51 ` William Breathitt Gray 2018-05-16 17:51 ` [PATCH v6 6/9] dt-bindings: counter: Document stm32 quadrature encoder William Breathitt Gray 2018-05-16 17:51 ` William Breathitt Gray 2018-05-17 16:23 ` Rob Herring 2018-05-17 16:23 ` Rob Herring 2018-05-17 18:07 ` William Breathitt Gray 2018-05-17 18:07 ` William Breathitt Gray 2018-05-17 18:59 ` Benjamin Gaignard 2018-05-17 18:59 ` Benjamin Gaignard 2018-05-18 16:28 ` Rob Herring [this message] 2018-05-18 16:28 ` Rob Herring 2018-05-20 15:47 ` Jonathan Cameron 2018-05-20 15:47 ` Jonathan Cameron 2018-06-04 13:03 ` Benjamin Gaignard 2018-06-04 13:03 ` Benjamin Gaignard 2018-06-04 13:03 ` Benjamin Gaignard 2018-05-16 17:52 ` [PATCH v6 7/9] counter: Add STM32 Timer " William Breathitt Gray 2018-05-16 17:52 ` William Breathitt Gray 2018-05-16 17:52 ` [PATCH v6 8/9] counter: stm32-lptimer: add counter device William Breathitt Gray 2018-05-16 17:52 ` William Breathitt Gray 2018-05-18 16:34 ` Rob Herring 2018-05-18 16:34 ` Rob Herring 2018-05-16 17:52 ` [PATCH v6 9/9] iio: counter: Remove IIO counter subdirectory William Breathitt Gray 2018-05-16 17:52 ` William Breathitt Gray 2018-05-20 15:53 ` Jonathan Cameron 2018-05-20 15:53 ` Jonathan Cameron 2018-05-21 13:58 ` William Breathitt Gray 2018-05-21 13:58 ` William Breathitt Gray 2018-05-22 10:44 ` Jonathan Cameron 2018-05-22 10:44 ` Jonathan Cameron 2018-05-22 10:44 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180518162815.GA24966@rob-hp-laptop \ --to=robh@kernel.org \ --cc=benjamin.gaignard@linaro.org \ --cc=benjamin.gaignard@st.com \ --cc=devicetree@vger.kernel.org \ --cc=fabrice.gasnier@st.com \ --cc=jic23@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=vilhelm.gray@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.