From: Jonathan Cameron <jic23@kernel.org> To: Maxime Ripard <maxime.ripard@bootlin.com> Cc: Philipp Rossak <embed3d@gmail.com>, lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, eugen.hristev@microchip.com, rdunlap@infradead.org, vilhelm.gray@gmail.com, clabbe.montjoie@gmail.com, quentin.schulz@bootlin.com, geert+renesas@glider.be, lukas@wunner.de, icenowy@aosc.io, arnd@arndb.de, broonie@kernel.org, arnaud.pouliquen@st.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 01/30] mfd: Makefile: Remove build option for MFD:sun4i-gpadc Date: Sun, 2 Sep 2018 20:58:46 +0100 [thread overview] Message-ID: <20180902205846.7a08846c@archlinux> (raw) In-Reply-To: <20180831082545.z6oilsmizliin3li@flea> On Fri, 31 Aug 2018 10:25:45 +0200 Maxime Ripard <maxime.ripard@bootlin.com> wrote: > Hi Philipp, > > First, thanks for doing that rework. It was needed, and it's very much > appreciated :) > > As you can imagine though, I have a bunch of comments. > > On Thu, Aug 30, 2018 at 05:44:49PM +0200, Philipp Rossak wrote: > > Since we are merging the mfd driver into the sun4i-gpadc driver we need > > to remove the build options for the sun4i-gpadc driver. > > > > Signed-off-by: Philipp Rossak <embed3d@gmail.com> > > --- > > drivers/mfd/Makefile | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > index e9fd20dba18d..c680994db988 100644 > > --- a/drivers/mfd/Makefile > > +++ b/drivers/mfd/Makefile > > @@ -220,7 +220,6 @@ obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) += intel_soc_pmic_chtdc_ti.o > > obj-$(CONFIG_MFD_MT6397) += mt6397-core.o > > > > obj-$(CONFIG_MFD_ALTERA_A10SR) += altera-a10sr.o > > -obj-$(CONFIG_MFD_SUN4I_GPADC) += sun4i-gpadc.o > > One of the things we should strive for is bisectability, which means > being able to have a working driver at every point in time while > introducing the features. > > In this particular case, this isn't really a problem since you're > removing part of code that were never really enabled, but you should > at least document why in your commit log. > Agreed. I for one don't know / can't remember why this would make sense! Jonathan > Thanks! > Maxime >
WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 01/30] mfd: Makefile: Remove build option for MFD:sun4i-gpadc Date: Sun, 2 Sep 2018 20:58:46 +0100 [thread overview] Message-ID: <20180902205846.7a08846c@archlinux> (raw) In-Reply-To: <20180831082545.z6oilsmizliin3li@flea> On Fri, 31 Aug 2018 10:25:45 +0200 Maxime Ripard <maxime.ripard@bootlin.com> wrote: > Hi Philipp, > > First, thanks for doing that rework. It was needed, and it's very much > appreciated :) > > As you can imagine though, I have a bunch of comments. > > On Thu, Aug 30, 2018 at 05:44:49PM +0200, Philipp Rossak wrote: > > Since we are merging the mfd driver into the sun4i-gpadc driver we need > > to remove the build options for the sun4i-gpadc driver. > > > > Signed-off-by: Philipp Rossak <embed3d@gmail.com> > > --- > > drivers/mfd/Makefile | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > index e9fd20dba18d..c680994db988 100644 > > --- a/drivers/mfd/Makefile > > +++ b/drivers/mfd/Makefile > > @@ -220,7 +220,6 @@ obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) += intel_soc_pmic_chtdc_ti.o > > obj-$(CONFIG_MFD_MT6397) += mt6397-core.o > > > > obj-$(CONFIG_MFD_ALTERA_A10SR) += altera-a10sr.o > > -obj-$(CONFIG_MFD_SUN4I_GPADC) += sun4i-gpadc.o > > One of the things we should strive for is bisectability, which means > being able to have a working driver at every point in time while > introducing the features. > > In this particular case, this isn't really a problem since you're > removing part of code that were never really enabled, but you should > at least document why in your commit log. > Agreed. I for one don't know / can't remember why this would make sense! Jonathan > Thanks! > Maxime >
next prev parent reply other threads:[~2018-09-02 19:58 UTC|newest] Thread overview: 244+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-30 15:44 [PATCH v3 00/30] IIO-based thermal sensor driver for Allwinner H3 and A83T SoC Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` [PATCH v3 01/30] mfd: Makefile: Remove build option for MFD:sun4i-gpadc Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-31 8:25 ` Maxime Ripard 2018-08-31 8:25 ` Maxime Ripard 2018-08-31 8:25 ` Maxime Ripard 2018-09-02 19:58 ` Jonathan Cameron [this message] 2018-09-02 19:58 ` Jonathan Cameron 2018-08-30 15:44 ` [PATCH v3 02/30] mfd: Kconfig: Remove MFD_SUN4I_GPADC config option Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-09-02 19:58 ` Jonathan Cameron 2018-09-02 19:58 ` Jonathan Cameron 2018-08-30 15:44 ` [PATCH v3 03/30] iio: adc: Remove ID table Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` [PATCH v3 04/30] iio: adc: Kconfig: Update Kconfig to new build options Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-31 8:32 ` Maxime Ripard 2018-08-31 8:32 ` Maxime Ripard 2018-08-31 8:32 ` Maxime Ripard 2018-08-30 15:44 ` [PATCH v3 05/30] iio: adc: move SUN4I_GPADC_CHANNEL define to header file Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-09-02 20:01 ` Jonathan Cameron 2018-09-02 20:01 ` Jonathan Cameron 2018-09-03 14:24 ` Philipp Rossak 2018-09-03 14:24 ` Philipp Rossak 2018-09-03 14:24 ` Philipp Rossak 2018-09-03 17:28 ` Jonathan Cameron 2018-09-03 17:28 ` Jonathan Cameron 2018-08-30 15:44 ` [PATCH v3 06/30] iio: adc: remove ofnode options Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` [PATCH v3 07/30] iio: adc: remove mfd_probe & sunwi_irq_init function Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-31 8:34 ` Maxime Ripard 2018-08-31 8:34 ` Maxime Ripard 2018-08-31 8:34 ` Maxime Ripard 2018-08-30 15:44 ` [PATCH v3 08/30] iio: adc: remove hwmon structure Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-31 8:34 ` Maxime Ripard 2018-08-31 8:34 ` Maxime Ripard 2018-08-31 8:34 ` Maxime Ripard 2018-08-30 15:44 ` [PATCH v3 09/30] iio: adc: Threat A33 as thermal sensor and remove non thermal sun4i channel Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 16:40 ` [linux-sunxi] " Ondřej Jirman 2018-08-30 16:40 ` Ondřej Jirman 2018-08-30 16:40 ` 'Ondřej Jirman' via linux-sunxi 2018-08-31 8:35 ` Maxime Ripard 2018-08-31 8:35 ` Maxime Ripard 2018-08-31 8:35 ` Maxime Ripard 2018-08-30 15:44 ` [PATCH v3 10/30] iio: adc: rework irq and adc_channel handling Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-31 8:44 ` Maxime Ripard 2018-08-31 8:44 ` Maxime Ripard 2018-08-31 8:44 ` Maxime Ripard 2018-08-30 15:44 ` [PATCH v3 11/30] iio: adc: add new compatibles Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-30 15:44 ` Philipp Rossak 2018-08-31 8:46 ` Maxime Ripard 2018-08-31 8:46 ` Maxime Ripard 2018-08-31 8:46 ` Maxime Ripard 2018-08-30 15:45 ` [PATCH v3 12/30] mfd: Remove old mfd driver & Move sun4i-gpadc.h to iio/adc/ Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` [PATCH v3 13/30] arm: config: Enable SUN4I_GPADC in defconfig Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` [PATCH v3 14/30] dt-bindings: update the Allwinner GPADC device tree binding for H3 & A83T Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-31 8:48 ` Maxime Ripard 2018-08-31 8:48 ` Maxime Ripard 2018-08-31 8:48 ` Maxime Ripard 2018-09-10 19:44 ` Rob Herring 2018-09-10 19:44 ` Rob Herring 2018-09-10 19:44 ` Rob Herring 2018-09-11 9:12 ` Maxime Ripard 2018-09-11 9:12 ` Maxime Ripard 2018-09-11 9:12 ` Maxime Ripard 2018-08-30 15:45 ` [PATCH v3 15/30] iio: adc: sun4i-gpadc-iio: rename A33-specified registers to contain A33 Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` [PATCH v3 16/30] iio: adc: sun4i-gpadc-iio: rework: readout temp_data Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-31 8:50 ` Maxime Ripard 2018-08-31 8:50 ` Maxime Ripard 2018-08-31 8:50 ` Maxime Ripard 2018-08-30 15:45 ` [PATCH v3 17/30] iio: adc: sun4i-gpadc-iio: rework: support clocks and reset Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-31 9:03 ` Maxime Ripard 2018-08-31 9:03 ` Maxime Ripard 2018-08-31 9:03 ` Maxime Ripard 2018-08-30 15:45 ` [PATCH v3 18/30] iio: adc: sun4i-gpadc-iio: rework: support multiple sensors Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-31 9:05 ` Maxime Ripard 2018-08-31 9:05 ` Maxime Ripard 2018-08-31 9:05 ` Maxime Ripard 2018-09-02 20:11 ` Jonathan Cameron 2018-09-02 20:11 ` Jonathan Cameron 2018-09-03 13:58 ` Philipp Rossak 2018-09-03 13:58 ` Philipp Rossak 2018-09-03 13:58 ` Philipp Rossak 2018-09-03 17:29 ` Jonathan Cameron 2018-09-03 17:29 ` Jonathan Cameron 2018-08-30 15:45 ` [PATCH v3 19/30] iio: adc: sun4i-gpadc-iio: rework: support nvmem calibration data Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-31 9:07 ` Maxime Ripard 2018-08-31 9:07 ` Maxime Ripard 2018-08-31 9:07 ` Maxime Ripard 2018-08-30 15:45 ` [PATCH v3 20/30] iio: adc: sun4i-gpadc-iio: rework: device specific suspend & resume Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-31 9:09 ` Maxime Ripard 2018-08-31 9:09 ` Maxime Ripard 2018-08-31 9:09 ` Maxime Ripard 2018-08-31 12:05 ` Philipp Rossak 2018-08-31 12:05 ` Philipp Rossak 2018-08-31 12:05 ` Philipp Rossak 2018-09-03 9:44 ` Maxime Ripard 2018-09-03 9:44 ` Maxime Ripard 2018-09-03 9:44 ` Maxime Ripard 2018-08-30 15:45 ` [PATCH v3 21/30] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 16:27 ` [linux-sunxi] " Ondřej Jirman 2018-08-30 16:27 ` Ondřej Jirman 2018-08-30 16:27 ` 'Ondřej Jirman' via linux-sunxi 2018-08-30 20:00 ` [linux-sunxi] " Philipp Rossak 2018-08-30 20:00 ` Philipp Rossak 2018-08-30 20:00 ` Philipp Rossak 2018-08-30 20:46 ` [linux-sunxi] " Philipp Rossak 2018-08-30 20:46 ` Philipp Rossak 2018-08-30 20:46 ` Philipp Rossak 2018-08-31 9:11 ` Maxime Ripard 2018-08-31 9:11 ` Maxime Ripard 2018-08-31 9:11 ` Maxime Ripard 2018-08-31 9:51 ` Icenowy Zheng 2018-08-31 9:51 ` Icenowy Zheng 2018-08-31 11:58 ` [linux-sunxi] " Philipp Rossak 2018-08-31 11:58 ` Philipp Rossak 2018-08-31 11:58 ` Philipp Rossak 2018-09-03 10:20 ` Maxime Ripard 2018-09-03 10:20 ` Maxime Ripard 2018-09-03 10:20 ` Maxime Ripard 2018-09-03 11:01 ` [linux-sunxi] " Icenowy Zheng 2018-09-03 11:01 ` Icenowy Zheng 2018-09-03 11:01 ` Icenowy Zheng 2018-09-03 11:01 ` Icenowy Zheng 2018-09-05 14:58 ` Maxime Ripard 2018-09-05 14:58 ` Maxime Ripard 2018-09-05 14:58 ` Maxime Ripard 2018-08-31 12:01 ` Philipp Rossak 2018-08-31 12:01 ` Philipp Rossak 2018-08-31 12:01 ` Philipp Rossak 2018-08-30 15:45 ` [PATCH v3 22/30] iio: adc: sun4i-gpadc-iio: add support for A83T " Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` [PATCH v3 23/30] ARM: dts: sunxi-h3-h5: add support for the thermal sensor in H3 and H5 Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` [PATCH v3 24/30] ARM: dts: sun8i: h3: add support for the thermal sensor in H3 Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` [PATCH v3 25/30] ARM: dts: sun8i: h3: add thermal zone to H3 Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-31 9:14 ` Maxime Ripard 2018-08-31 9:14 ` Maxime Ripard 2018-08-31 9:14 ` Maxime Ripard 2018-08-30 15:45 ` [PATCH v3 26/30] ARM: dts: sun8i: h3: enable H3 sid controller Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` [PATCH v3 27/30] ARM: dts: sun8i: h3: use calibration for ths Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-09-04 16:46 ` Emmanuel Vadot 2018-09-04 16:46 ` Emmanuel Vadot 2018-09-06 11:47 ` Philipp Rossak 2018-09-06 11:47 ` Philipp Rossak 2018-09-06 11:47 ` Philipp Rossak 2018-09-06 11:51 ` Maxime Ripard 2018-09-06 11:51 ` Maxime Ripard 2018-09-06 11:51 ` Maxime Ripard 2018-09-06 12:04 ` [linux-sunxi] " Icenowy Zheng 2018-09-06 12:04 ` Icenowy Zheng 2018-09-06 12:04 ` Icenowy Zheng 2018-09-06 12:18 ` Philipp Rossak 2018-09-06 12:18 ` Philipp Rossak 2019-02-19 7:54 ` Allwinner SID THS calibration data cell representation? Chen-Yu Tsai 2019-02-20 14:55 ` Maxime Ripard 2019-02-20 14:55 ` Maxime Ripard 2019-02-21 10:10 ` Emmanuel Vadot 2019-02-21 10:10 ` Emmanuel Vadot 2019-02-21 10:10 ` Emmanuel Vadot 2019-02-25 20:37 ` Philipp Rossak 2019-02-25 20:37 ` Philipp Rossak 2019-02-25 20:37 ` Philipp Rossak 2018-08-30 15:45 ` [PATCH v3 28/30] ARM: dts: sun8i: a83t: add support for the thermal sensor in A83T Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` [PATCH v3 29/30] ARM: dts: sun8i: a83t: add thermal zone to A83T Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 15:45 ` [PATCH v3 30/30] ARM: sun8i: a83t: full range OPP tables and CPUfreq Philipp Rossak 2018-08-30 15:45 ` Philipp Rossak 2018-08-30 16:38 ` [linux-sunxi] " Ondřej Jirman 2018-08-30 16:38 ` Ondřej Jirman 2018-08-30 16:38 ` 'Ondřej Jirman' via linux-sunxi 2018-08-30 20:29 ` [linux-sunxi] " Philipp Rossak 2018-08-30 20:29 ` Philipp Rossak 2018-08-30 20:29 ` Philipp Rossak 2018-09-06 7:24 ` Quentin Schulz 2018-09-06 7:24 ` Quentin Schulz 2018-09-06 7:24 ` Quentin Schulz 2018-09-06 11:39 ` Philipp Rossak 2018-09-06 11:39 ` Philipp Rossak 2018-09-06 11:39 ` Philipp Rossak 2018-09-06 11:42 ` Maxime Ripard 2018-09-06 11:42 ` Maxime Ripard 2018-09-06 11:42 ` Maxime Ripard 2018-09-06 12:06 ` Quentin Schulz 2018-09-06 12:06 ` Quentin Schulz 2018-09-06 12:06 ` Quentin Schulz 2019-03-19 12:30 ` [PATCH v3 00/30] IIO-based thermal sensor driver for Allwinner H3 and A83T SoC Måns Rullgård 2019-03-19 12:30 ` Måns Rullgård 2019-03-19 12:37 ` Maxime Ripard 2019-03-19 12:37 ` Maxime Ripard 2019-03-19 12:37 ` Maxime Ripard 2019-03-19 13:04 ` [linux-sunxi] " Chen-Yu Tsai 2019-03-19 13:04 ` Chen-Yu Tsai 2019-03-19 13:04 ` Chen-Yu Tsai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180902205846.7a08846c@archlinux \ --to=jic23@kernel.org \ --cc=arnaud.pouliquen@st.com \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=clabbe.montjoie@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=embed3d@gmail.com \ --cc=eugen.hristev@microchip.com \ --cc=geert+renesas@glider.be \ --cc=icenowy@aosc.io \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=linux@armlinux.org.uk \ --cc=lukas@wunner.de \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@bootlin.com \ --cc=pmeerw@pmeerw.net \ --cc=quentin.schulz@bootlin.com \ --cc=rdunlap@infradead.org \ --cc=robh+dt@kernel.org \ --cc=vilhelm.gray@gmail.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.