From: Christoph Hellwig <hch@infradead.org>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] nvme: add quirk to not call disable function when suspending
Date: Mon, 5 Nov 2018 23:10:57 -0800 [thread overview]
Message-ID: <20181106071057.GB23935@infradead.org> (raw)
In-Reply-To: <20181106020402.21120-2-acelan.kao@canonical.com>
On Tue, Nov 06, 2018 at 10:04:02AM +0800, AceLan Kao wrote:
> Call nvme_dev_disable() function leads to the power consumption goes
> up to 2.2 Watt during suspend-to-idle, and from SK hynix FE, they
> suggest us to use its own APST feature to do the power management during
> s2idle.
> After D3 is diabled and nvme_dev_disable() is not called while
> suspending, the power consumption drops to 0.77 Watt during s2idle.
Same comment as previous one. Get the firmware fixed please - this
doesn't prevent the drive from working, but it is a grave implementation
bug in it that needs to get fixed.
WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 2/2] nvme: add quirk to not call disable function when suspending
Date: Mon, 5 Nov 2018 23:10:57 -0800 [thread overview]
Message-ID: <20181106071057.GB23935@infradead.org> (raw)
In-Reply-To: <20181106020402.21120-2-acelan.kao@canonical.com>
On Tue, Nov 06, 2018@10:04:02AM +0800, AceLan Kao wrote:
> Call nvme_dev_disable() function leads to the power consumption goes
> up to 2.2 Watt during suspend-to-idle, and from SK hynix FE, they
> suggest us to use its own APST feature to do the power management during
> s2idle.
> After D3 is diabled and nvme_dev_disable() is not called while
> suspending, the power consumption drops to 0.77 Watt during s2idle.
Same comment as previous one. Get the firmware fixed please - this
doesn't prevent the drive from working, but it is a grave implementation
bug in it that needs to get fixed.
next prev parent reply other threads:[~2018-11-06 7:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 2:04 [PATCH 1/2] pci: prevent sk hynix nvme from entering D3 AceLan Kao
2018-11-06 2:04 ` AceLan Kao
2018-11-06 2:04 ` [PATCH 2/2] nvme: add quirk to not call disable function when suspending AceLan Kao
2018-11-06 2:04 ` AceLan Kao
2018-11-06 2:24 ` Sinan Kaya
2018-11-06 2:24 ` Sinan Kaya
2018-11-06 2:54 ` AceLan Kao
2018-11-06 2:54 ` AceLan Kao
2018-11-06 7:10 ` Christoph Hellwig [this message]
2018-11-06 7:10 ` Christoph Hellwig
2018-11-06 7:10 ` [PATCH 1/2] pci: prevent sk hynix nvme from entering D3 Christoph Hellwig
2018-11-06 7:10 ` Christoph Hellwig
2018-11-06 10:11 ` AceLan Kao
2018-11-06 10:11 ` AceLan Kao
2018-11-07 8:19 ` Christoph Hellwig
2018-11-07 8:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106071057.GB23935@infradead.org \
--to=hch@infradead.org \
--cc=acelan.kao@canonical.com \
--cc=axboe@fb.com \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.