From: AceLan Kao <acelan.kao@canonical.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: keith.busch@intel.com, axboe@fb.com, hch@lst.de,
sagi@grimberg.me, Bjorn Helgaas <bhelgaas@google.com>,
linux-nvme@lists.infradead.org,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, victor.chang@sk.com,
james.chen@sk.com, Chih-Hsyuan Ho <chih.ho@canonical.com>
Subject: Re: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3
Date: Tue, 6 Nov 2018 18:11:31 +0800 [thread overview]
Message-ID: <CAFv23QmK-BPNLcy9UTuYjF=Jv_xOUFj5dTTem9r-dfijb4WQ8Q@mail.gmail.com> (raw)
In-Reply-To: <20181106071011.GA23935@infradead.org>
Christoph Hellwig <hch@infradead.org> 於 2018年11月6日 週二 下午3:10寫道：
>
> On Tue, Nov 06, 2018 at 10:04:01AM +0800, AceLan Kao wrote:
> > It leads to the power consumption raises to 2.2W during s2idle, while
> > it consumes less than 1W during long idle if put SK hynix nvme to D3
> > and then enter s2idle.
> > >From SK hynix FE, MS Windows doesn't put nvme to D3, and uses its own
> > APST feature to do the power management.
> > To leverage its APST feature during s2idle, we can't disable nvme
> > device while suspending, too.
> >
> > BTW, prevent it from entering D3 will increase the power consumtion around
> > 0.13W ~ 0.15W during short/long idle, and the power consumption during
> > s2idle becomes 0.77W.
>
> Please get this fixed in firmware. And yes, depending on which Windows
> driver you use Windows might be doing very agressive runtime D3, which
> is parted of Windows modern standby, so it'll trip up there eventually
> as well.
Agree, this is not a good fix for Sk hynix nvme, so Dell is still pushing
Sk hynix to fix it from firmware.
But before the firmware is ready, this is still a issue that need to be fixed in
kernel side, and the new firmware may not be applied on the old nvme
modules.
This list won't keep growing, and we'll keep an eye on the new firmware and
co-work with engineers from Sky hynix to make sure this issue won't happen
again.
WARNING: multiple messages have this Message-ID (diff)
From: acelan.kao@canonical.com (AceLan Kao)
Subject: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3
Date: Tue, 6 Nov 2018 18:11:31 +0800 [thread overview]
Message-ID: <CAFv23QmK-BPNLcy9UTuYjF=Jv_xOUFj5dTTem9r-dfijb4WQ8Q@mail.gmail.com> (raw)
In-Reply-To: <20181106071011.GA23935@infradead.org>
Christoph Hellwig <hch at infradead.org> ? 2018?11?6? ?? ??3:10???
>
> On Tue, Nov 06, 2018@10:04:01AM +0800, AceLan Kao wrote:
> > It leads to the power consumption raises to 2.2W during s2idle, while
> > it consumes less than 1W during long idle if put SK hynix nvme to D3
> > and then enter s2idle.
> > >From SK hynix FE, MS Windows doesn't put nvme to D3, and uses its own
> > APST feature to do the power management.
> > To leverage its APST feature during s2idle, we can't disable nvme
> > device while suspending, too.
> >
> > BTW, prevent it from entering D3 will increase the power consumtion around
> > 0.13W ~ 0.15W during short/long idle, and the power consumption during
> > s2idle becomes 0.77W.
>
> Please get this fixed in firmware. And yes, depending on which Windows
> driver you use Windows might be doing very agressive runtime D3, which
> is parted of Windows modern standby, so it'll trip up there eventually
> as well.
Agree, this is not a good fix for Sk hynix nvme, so Dell is still pushing
Sk hynix to fix it from firmware.
But before the firmware is ready, this is still a issue that need to be fixed in
kernel side, and the new firmware may not be applied on the old nvme
modules.
This list won't keep growing, and we'll keep an eye on the new firmware and
co-work with engineers from Sky hynix to make sure this issue won't happen
again.
next prev parent reply other threads:[~2018-11-06 10:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 2:04 [PATCH 1/2] pci: prevent sk hynix nvme from entering D3 AceLan Kao
2018-11-06 2:04 ` AceLan Kao
2018-11-06 2:04 ` [PATCH 2/2] nvme: add quirk to not call disable function when suspending AceLan Kao
2018-11-06 2:04 ` AceLan Kao
2018-11-06 2:24 ` Sinan Kaya
2018-11-06 2:24 ` Sinan Kaya
2018-11-06 2:54 ` AceLan Kao
2018-11-06 2:54 ` AceLan Kao
2018-11-06 7:10 ` Christoph Hellwig
2018-11-06 7:10 ` Christoph Hellwig
2018-11-06 7:10 ` [PATCH 1/2] pci: prevent sk hynix nvme from entering D3 Christoph Hellwig
2018-11-06 7:10 ` Christoph Hellwig
2018-11-06 10:11 ` AceLan Kao [this message]
2018-11-06 10:11 ` AceLan Kao
2018-11-07 8:19 ` Christoph Hellwig
2018-11-07 8:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFv23QmK-BPNLcy9UTuYjF=Jv_xOUFj5dTTem9r-dfijb4WQ8Q@mail.gmail.com' \
--to=acelan.kao@canonical.com \
--cc=axboe@fb.com \
--cc=bhelgaas@google.com \
--cc=chih.ho@canonical.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=james.chen@sk.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=victor.chang@sk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.