From: Christoph Hellwig <hch@lst.de>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: keith.busch@intel.com, axboe@fb.com, hch@lst.de,
sagi@grimberg.me, Bjorn Helgaas <bhelgaas@google.com>,
linux-nvme@lists.infradead.org,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, victor.chang@sk.com,
james.chen@sk.com, Chih-Hsyuan Ho <chih.ho@canonical.com>
Subject: Re: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3
Date: Wed, 7 Nov 2018 09:19:15 +0100 [thread overview]
Message-ID: <20181107081915.GA24841@lst.de> (raw)
In-Reply-To: <CAFv23QmK-BPNLcy9UTuYjF=Jv_xOUFj5dTTem9r-dfijb4WQ8Q@mail.gmail.com>
On Tue, Nov 06, 2018 at 06:11:31PM +0800, AceLan Kao wrote:
> Agree, this is not a good fix for Sk hynix nvme, so Dell is still pushing
> Sk hynix to fix it from firmware.
> But before the firmware is ready, this is still a issue that need to be fixed in
> kernel side, and the new firmware may not be applied on the old nvme
> modules.
> This list won't keep growing, and we'll keep an eye on the new firmware and
> co-work with engineers from Sky hynix to make sure this issue won't happen
> again.
We generally quirk for grave issues that make devices unusable.
To me working around a D3 mode that consumers more power than D0
does not quite fit that bill.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3
Date: Wed, 7 Nov 2018 09:19:15 +0100 [thread overview]
Message-ID: <20181107081915.GA24841@lst.de> (raw)
In-Reply-To: <CAFv23QmK-BPNLcy9UTuYjF=Jv_xOUFj5dTTem9r-dfijb4WQ8Q@mail.gmail.com>
On Tue, Nov 06, 2018@06:11:31PM +0800, AceLan Kao wrote:
> Agree, this is not a good fix for Sk hynix nvme, so Dell is still pushing
> Sk hynix to fix it from firmware.
> But before the firmware is ready, this is still a issue that need to be fixed in
> kernel side, and the new firmware may not be applied on the old nvme
> modules.
> This list won't keep growing, and we'll keep an eye on the new firmware and
> co-work with engineers from Sky hynix to make sure this issue won't happen
> again.
We generally quirk for grave issues that make devices unusable.
To me working around a D3 mode that consumers more power than D0
does not quite fit that bill.
next prev parent reply other threads:[~2018-11-07 8:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 2:04 [PATCH 1/2] pci: prevent sk hynix nvme from entering D3 AceLan Kao
2018-11-06 2:04 ` AceLan Kao
2018-11-06 2:04 ` [PATCH 2/2] nvme: add quirk to not call disable function when suspending AceLan Kao
2018-11-06 2:04 ` AceLan Kao
2018-11-06 2:24 ` Sinan Kaya
2018-11-06 2:24 ` Sinan Kaya
2018-11-06 2:54 ` AceLan Kao
2018-11-06 2:54 ` AceLan Kao
2018-11-06 7:10 ` Christoph Hellwig
2018-11-06 7:10 ` Christoph Hellwig
2018-11-06 7:10 ` [PATCH 1/2] pci: prevent sk hynix nvme from entering D3 Christoph Hellwig
2018-11-06 7:10 ` Christoph Hellwig
2018-11-06 10:11 ` AceLan Kao
2018-11-06 10:11 ` AceLan Kao
2018-11-07 8:19 ` Christoph Hellwig [this message]
2018-11-07 8:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107081915.GA24841@lst.de \
--to=hch@lst.de \
--cc=acelan.kao@canonical.com \
--cc=axboe@fb.com \
--cc=bhelgaas@google.com \
--cc=chih.ho@canonical.com \
--cc=james.chen@sk.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=victor.chang@sk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.