From: Rob Herring <robh@kernel.org>
To: Yu Chen <chenyu56@huawei.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, john.stultz@linaro.org,
suzhuangluan@hisilicon.com, kongfei@hisilicon.com,
liuyu712@hisilicon.com, wanghu17@hisilicon.com,
butao@hisilicon.com, chenyao11@huawei.com,
fangshengzhou@hisilicon.com, lipengcheng8@huawei.com,
songxiaowei@hisilicon.com, xuyiping@hisilicon.com,
xuyoujun4@huawei.com, yudongbin@hisilicon.com,
zangleigang@hisilicon.com, Mark Rutland <mark.rutland@arm.com>,
Binghui Wang <wangbinghui@hisilicon.com>
Subject: Re: [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY
Date: Mon, 18 Feb 2019 14:18:24 -0600 [thread overview]
Message-ID: <20190218201824.GA23724@bogus> (raw)
In-Reply-To: <20190218112310.17860-2-chenyu56@huawei.com>
On Mon, Feb 18, 2019 at 07:23:01PM +0800, Yu Chen wrote:
> This patch adds binding documentation for supporting the hi3660 usb
> phy on boards like the HiKey960.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Binghui Wang <wangbinghui@hisilicon.com>
> Signed-off-by: Yu Chen <chenyu56@huawei.com>
> ---
> v1:
> * Fix some format error as suggested by Rob.
> v2:
> * Change hi3660 usb PHY to hi3660 USB PHY
> ---
> ---
> .../devicetree/bindings/phy/phy-hi3660-usb3.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
> new file mode 100644
> index 000000000000..f9a3d56cfdd2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
> @@ -0,0 +1,21 @@
> +Hisilicon hi3660 USB PHY
> +-----------------------
> +
> +Required properties:
> +- compatible: should be "hisilicon,hi3660-usb-phy"
> +- #phy-cells: must be 0
> +- hisilicon,pericrg-syscon: phandle of syscon used to control phy.
> +- hisilicon,pctrl-syscon: phandle of syscon used to control phy.
> +- hisilicon,usb3-otg-bc-syscon: phandle of syscon used to control phy.
> +- hisilicon,eye-diagram-param: parameter set for phy
> +Refer to phy/phy-bindings.txt for the generic PHY binding properties
> +
> +Example:
> + usb-phy {
> + compatible = "hisilicon,hi3660-usb-phy";
> + #phy-cells = <0>;
> + hisilicon,pericrg-syscon = <&crg_ctrl>;
> + hisilicon,pctrl-syscon = <&pctrl>;
> + hisilicon,usb3-otg-bc-syscon = <&usb3_otg_bc>;
Are most of the registers within one of these blocks? If so, make this
node a child of that node.
> + hisilicon,eye-diagram-param = <0x22466e4>;
> + };
> --
> 2.15.0-rc2
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Yu Chen <chenyu56@huawei.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, john.stultz@linaro.org,
suzhuangluan@hisilicon.com, kongfei@hisilicon.com,
liuyu712@hisilicon.com, wanghu17@hisilicon.com,
butao@hisilicon.com, chenyao11@huawei.com,
fangshengzhou@hisilicon.com, lipengcheng8@huawei.com,
songxiaowei@hisilicon.com, xuyiping@hisilicon.com,
xuyoujun4@huawei.com, yudongbin@hisilicon.com,
zangleigang@hisilicon.com, Mark Rutland <mark.rutland@arm.com>,
Binghui Wang <wangbinghui@hisilicon.com>
Subject: [v2,01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY
Date: Mon, 18 Feb 2019 14:18:24 -0600 [thread overview]
Message-ID: <20190218201824.GA23724@bogus> (raw)
On Mon, Feb 18, 2019 at 07:23:01PM +0800, Yu Chen wrote:
> This patch adds binding documentation for supporting the hi3660 usb
> phy on boards like the HiKey960.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Binghui Wang <wangbinghui@hisilicon.com>
> Signed-off-by: Yu Chen <chenyu56@huawei.com>
> ---
> v1:
> * Fix some format error as suggested by Rob.
> v2:
> * Change hi3660 usb PHY to hi3660 USB PHY
> ---
> ---
> .../devicetree/bindings/phy/phy-hi3660-usb3.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
> new file mode 100644
> index 000000000000..f9a3d56cfdd2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt
> @@ -0,0 +1,21 @@
> +Hisilicon hi3660 USB PHY
> +-----------------------
> +
> +Required properties:
> +- compatible: should be "hisilicon,hi3660-usb-phy"
> +- #phy-cells: must be 0
> +- hisilicon,pericrg-syscon: phandle of syscon used to control phy.
> +- hisilicon,pctrl-syscon: phandle of syscon used to control phy.
> +- hisilicon,usb3-otg-bc-syscon: phandle of syscon used to control phy.
> +- hisilicon,eye-diagram-param: parameter set for phy
> +Refer to phy/phy-bindings.txt for the generic PHY binding properties
> +
> +Example:
> + usb-phy {
> + compatible = "hisilicon,hi3660-usb-phy";
> + #phy-cells = <0>;
> + hisilicon,pericrg-syscon = <&crg_ctrl>;
> + hisilicon,pctrl-syscon = <&pctrl>;
> + hisilicon,usb3-otg-bc-syscon = <&usb3_otg_bc>;
Are most of the registers within one of these blocks? If so, make this
node a child of that node.
> + hisilicon,eye-diagram-param = <0x22466e4>;
> + };
> --
> 2.15.0-rc2
>
next prev parent reply other threads:[~2019-02-18 20:18 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 11:23 [PATCH v2 00/10] Add support for usb on Hikey960 Yu Chen
2019-02-18 11:23 ` Yu Chen
2019-02-18 11:23 ` [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen
2019-02-18 11:23 ` [v2,01/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 01/10] " Yu Chen
2019-02-18 20:18 ` Rob Herring [this message]
2019-02-18 20:18 ` [v2,01/10] " Rob Herring
2019-02-19 1:50 ` [PATCH v2 01/10] " Chen Yu
2019-02-19 1:50 ` [v2,01/10] " Yu Chen
2019-02-19 1:50 ` [PATCH v2 01/10] " Chen Yu
2019-02-19 3:03 ` Chunfeng Yun
2019-02-19 3:03 ` [v2,01/10] " Chunfeng Yun
2019-02-19 3:03 ` [PATCH v2 01/10] " Chunfeng Yun
2019-02-19 3:55 ` Chen Yu
2019-02-19 3:55 ` [v2,01/10] " Yu Chen
2019-02-19 3:55 ` [PATCH v2 01/10] " Chen Yu
2019-02-19 14:22 ` Rob Herring
2019-02-19 14:22 ` [v2,01/10] " Rob Herring
2019-02-18 11:23 ` [PATCH v2 02/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen
2019-02-18 11:23 ` [v2,02/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 02/10] " Yu Chen
2019-02-19 8:25 ` Sergei Shtylyov
2019-02-19 8:25 ` [v2,02/10] " Sergei Shtylyov
2019-02-20 2:34 ` [PATCH v2 02/10] " Chen Yu
2019-02-20 2:34 ` [v2,02/10] " Yu Chen
2019-02-20 2:34 ` [PATCH v2 02/10] " Chen Yu
2019-02-18 11:23 ` [PATCH v2 03/10] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform Yu Chen
2019-02-18 11:23 ` [v2,03/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 03/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 04/10] usb: dwc3: Add two quirks for Hisilicon Kirin " Yu Chen
2019-02-18 11:23 ` [v2,04/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 04/10] " Yu Chen
2019-02-18 12:21 ` Andy Shevchenko
2019-02-18 12:21 ` [v2,04/10] " Andy Shevchenko
2019-02-18 12:31 ` [PATCH v2 04/10] " Chen Yu
2019-02-18 12:31 ` [v2,04/10] " Yu Chen
2019-02-18 12:31 ` [PATCH v2 04/10] " Chen Yu
2019-02-18 11:23 ` [PATCH v2 05/10] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2019-02-18 11:23 ` [v2,05/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 05/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 06/10] usb: roles: Add usb role switch notifier Yu Chen
2019-02-18 11:23 ` [v2,06/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 06/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 07/10] usb: dwc3: Registering a role switch in the DRD code Yu Chen
2019-02-18 11:23 ` [v2,07/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 07/10] " Yu Chen
2019-02-18 17:30 ` Valentin Schneider
2019-02-18 17:30 ` [v2,07/10] " Valentin Schneider
2019-02-19 1:40 ` [PATCH v2 07/10] " Chen Yu
2019-02-19 1:40 ` [v2,07/10] " Yu Chen
2019-02-19 1:40 ` [PATCH v2 07/10] " Chen Yu
2019-02-19 2:57 ` Jun Li
2019-02-19 2:57 ` [v2,07/10] " Jun Li
2019-02-19 3:37 ` [PATCH v2 07/10] " Chen Yu
2019-02-19 3:37 ` [v2,07/10] " Yu Chen
2019-02-19 3:37 ` [PATCH v2 07/10] " Chen Yu
2019-02-18 11:23 ` [PATCH v2 08/10] hikey960: Support usb functionality of Hikey960 Yu Chen
2019-02-18 11:23 ` [v2,08/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 08/10] " Yu Chen
2019-02-19 2:50 ` Chunfeng Yun
2019-02-19 2:50 ` [v2,08/10] " Chunfeng Yun
2019-02-19 2:50 ` [PATCH v2 08/10] " Chunfeng Yun
2019-02-19 3:20 ` Chen Yu
2019-02-19 3:20 ` [v2,08/10] " Yu Chen
2019-02-19 3:20 ` [PATCH v2 08/10] " Chen Yu
2019-02-22 7:32 ` Chunfeng Yun
2019-02-22 7:32 ` [v2,08/10] " Chunfeng Yun
2019-02-22 7:32 ` [PATCH v2 08/10] " Chunfeng Yun
2019-03-02 1:02 ` Chen Yu
2019-03-02 1:02 ` [v2,08/10] " Yu Chen
2019-03-02 1:02 ` [PATCH v2 08/10] " Chen Yu
2019-02-18 11:23 ` [PATCH v2 09/10] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen
2019-02-18 11:23 ` [v2,09/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 09/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 10/10] dts: hi3660: Add support for usb on Hikey960 Yu Chen
2019-02-18 11:23 ` Yu Chen
2019-02-18 11:23 ` [v2,10/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 10/10] " Yu Chen
2019-02-18 17:30 ` [PATCH v2 00/10] " Valentin Schneider
2019-02-19 1:34 ` Chen Yu
2019-02-19 1:34 ` Chen Yu
2019-02-19 11:31 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218201824.GA23724@bogus \
--to=robh@kernel.org \
--cc=butao@hisilicon.com \
--cc=chenyao11@huawei.com \
--cc=chenyu56@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=fangshengzhou@hisilicon.com \
--cc=john.stultz@linaro.org \
--cc=kongfei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lipengcheng8@huawei.com \
--cc=liuyu712@hisilicon.com \
--cc=mark.rutland@arm.com \
--cc=songxiaowei@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=wangbinghui@hisilicon.com \
--cc=wanghu17@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=xuyoujun4@huawei.com \
--cc=yudongbin@hisilicon.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.