From: Chen Yu <chenyu56@huawei.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: <liuyu712@hisilicon.com>, <linux-usb@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<john.stultz@linaro.org>, <suzhuangluan@hisilicon.com>,
<kongfei@hisilicon.com>, <wanghu17@hisilicon.com>,
<butao@hisilicon.com>, <chenyao11@huawei.com>,
<fangshengzhou@hisilicon.com>, <lipengcheng8@huawei.com>,
<songxiaowei@hisilicon.com>, <xuyiping@hisilicon.com>,
<xuyoujun4@huawei.com>, <yudongbin@hisilicon.com>,
<zangleigang@hisilicon.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Binghui Wang <wangbinghui@hisilicon.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v2 08/10] hikey960: Support usb functionality of Hikey960
Date: Tue, 19 Feb 2019 11:20:07 +0800 [thread overview]
Message-ID: <c02407b4-1825-83f5-2aff-dd41ae16e2ab@huawei.com> (raw)
In-Reply-To: <1550544615.2210.27.camel@mhfsdcap03>
Hi,
On 2019/2/19 10:50, Chunfeng Yun wrote:
>> + if (ret)
>> + hisi_hikey_usb->typec_vbus_enable_val = 1;
>> +
>> + hisi_hikey_usb->typec_vbus = devm_gpiod_get(dev, "typec-vbus",
>> + hisi_hikey_usb->typec_vbus_enable_val ?
>> + GPIOD_OUT_LOW : GPIOD_OUT_HIGH);
>> + if (!hisi_hikey_usb->typec_vbus)
>> + return -ENOENT;
>> + else if (IS_ERR(hisi_hikey_usb->typec_vbus))
>> + return PTR_ERR(hisi_hikey_usb->typec_vbus);
>> +
>> + gpiod_direction_output(hisi_hikey_usb->typec_vbus,
>> + !hisi_hikey_usb->typec_vbus_enable_val);
> maybe a simple way if use fixed regulator?
>
The hardware of the Hikey960 board has been fixed, and the type-c
port can act as UFP. So it is better to close the vbus when Hikey960
connect to host(e.g PC).
>> +
>> + hisi_hikey_usb->otg_switch = devm_gpiod_get(dev, "otg-switch", GPIOD_IN);
>> + if (!hisi_hikey_usb->otg_switch)
>> + return -ENOENT;
>> + else if (IS_ERR(hisi_hikey_usb->otg_switch))
>> + return PTR_ERR(hisi_hikey_usb->otg_switch);
>> +
>> + gpiod_direction_output(hisi_hikey_usb->otg_switch, USB_SWITCH_TO_HUB);
>> +
>> + /* hub-vdd33-en is optional */
>> + hisi_hikey_usb->hub_vbus = devm_gpiod_get(dev, "hub-vdd33-en",
>> + GPIOD_OUT_LOW);
>> + if (IS_ERR(hisi_hikey_usb->hub_vbus))
>> + return PTR_ERR(hisi_hikey_usb->hub_vbus);
>> +
>> + gpiod_direction_output(hisi_hikey_usb->hub_vbus, HUB_VBUS_POWER_ON);
> ditto
>> +
>> + hisi_hikey_usb->role_sw = usb_role_switch_get(dev);
>> + if (!hisi_hikey_usb->role_sw)
>> + return -EPROBE_DEFER;
>> + else if (IS_ERR(hisi_hikey_usb->role_sw))
>> + return PTR_ERR(hisi_hikey_usb->role_sw);
>> +
Thanks
Yu Chen
WARNING: multiple messages have this Message-ID (diff)
From: Chen Yu <chenyu56@huawei.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: liuyu712@hisilicon.com, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
john.stultz@linaro.org, suzhuangluan@hisilicon.com,
kongfei@hisilicon.com, wanghu17@hisilicon.com,
butao@hisilicon.com, chenyao11@huawei.com,
fangshengzhou@hisilicon.com, lipengcheng8@huawei.com,
songxiaowei@hisilicon.com, xuyiping@hisilicon.com,
xuyoujun4@huawei.com, yudongbin@hisilicon.com,
zangleigang@hisilicon.com,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Binghui Wang <wangbinghui@hisilicon.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v2 08/10] hikey960: Support usb functionality of Hikey960
Date: Tue, 19 Feb 2019 11:20:07 +0800 [thread overview]
Message-ID: <c02407b4-1825-83f5-2aff-dd41ae16e2ab@huawei.com> (raw)
In-Reply-To: <1550544615.2210.27.camel@mhfsdcap03>
Hi,
On 2019/2/19 10:50, Chunfeng Yun wrote:
>> + if (ret)
>> + hisi_hikey_usb->typec_vbus_enable_val = 1;
>> +
>> + hisi_hikey_usb->typec_vbus = devm_gpiod_get(dev, "typec-vbus",
>> + hisi_hikey_usb->typec_vbus_enable_val ?
>> + GPIOD_OUT_LOW : GPIOD_OUT_HIGH);
>> + if (!hisi_hikey_usb->typec_vbus)
>> + return -ENOENT;
>> + else if (IS_ERR(hisi_hikey_usb->typec_vbus))
>> + return PTR_ERR(hisi_hikey_usb->typec_vbus);
>> +
>> + gpiod_direction_output(hisi_hikey_usb->typec_vbus,
>> + !hisi_hikey_usb->typec_vbus_enable_val);
> maybe a simple way if use fixed regulator?
>
The hardware of the Hikey960 board has been fixed, and the type-c
port can act as UFP. So it is better to close the vbus when Hikey960
connect to host(e.g PC).
>> +
>> + hisi_hikey_usb->otg_switch = devm_gpiod_get(dev, "otg-switch", GPIOD_IN);
>> + if (!hisi_hikey_usb->otg_switch)
>> + return -ENOENT;
>> + else if (IS_ERR(hisi_hikey_usb->otg_switch))
>> + return PTR_ERR(hisi_hikey_usb->otg_switch);
>> +
>> + gpiod_direction_output(hisi_hikey_usb->otg_switch, USB_SWITCH_TO_HUB);
>> +
>> + /* hub-vdd33-en is optional */
>> + hisi_hikey_usb->hub_vbus = devm_gpiod_get(dev, "hub-vdd33-en",
>> + GPIOD_OUT_LOW);
>> + if (IS_ERR(hisi_hikey_usb->hub_vbus))
>> + return PTR_ERR(hisi_hikey_usb->hub_vbus);
>> +
>> + gpiod_direction_output(hisi_hikey_usb->hub_vbus, HUB_VBUS_POWER_ON);
> ditto
>> +
>> + hisi_hikey_usb->role_sw = usb_role_switch_get(dev);
>> + if (!hisi_hikey_usb->role_sw)
>> + return -EPROBE_DEFER;
>> + else if (IS_ERR(hisi_hikey_usb->role_sw))
>> + return PTR_ERR(hisi_hikey_usb->role_sw);
>> +
Thanks
Yu Chen
WARNING: multiple messages have this Message-ID (diff)
From: Yu Chen <chenyu56@huawei.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: liuyu712@hisilicon.com, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
john.stultz@linaro.org, suzhuangluan@hisilicon.com,
kongfei@hisilicon.com, wanghu17@hisilicon.com,
butao@hisilicon.com, chenyao11@huawei.com,
fangshengzhou@hisilicon.com, lipengcheng8@huawei.com,
songxiaowei@hisilicon.com, xuyiping@hisilicon.com,
xuyoujun4@huawei.com, yudongbin@hisilicon.com,
zangleigang@hisilicon.com,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Binghui Wang <wangbinghui@hisilicon.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: [v2,08/10] hikey960: Support usb functionality of Hikey960
Date: Tue, 19 Feb 2019 11:20:07 +0800 [thread overview]
Message-ID: <c02407b4-1825-83f5-2aff-dd41ae16e2ab@huawei.com> (raw)
Hi,
On 2019/2/19 10:50, Chunfeng Yun wrote:
>> + if (ret)
>> + hisi_hikey_usb->typec_vbus_enable_val = 1;
>> +
>> + hisi_hikey_usb->typec_vbus = devm_gpiod_get(dev, "typec-vbus",
>> + hisi_hikey_usb->typec_vbus_enable_val ?
>> + GPIOD_OUT_LOW : GPIOD_OUT_HIGH);
>> + if (!hisi_hikey_usb->typec_vbus)
>> + return -ENOENT;
>> + else if (IS_ERR(hisi_hikey_usb->typec_vbus))
>> + return PTR_ERR(hisi_hikey_usb->typec_vbus);
>> +
>> + gpiod_direction_output(hisi_hikey_usb->typec_vbus,
>> + !hisi_hikey_usb->typec_vbus_enable_val);
> maybe a simple way if use fixed regulator?
>
The hardware of the Hikey960 board has been fixed, and the type-c
port can act as UFP. So it is better to close the vbus when Hikey960
connect to host(e.g PC).
>> +
>> + hisi_hikey_usb->otg_switch = devm_gpiod_get(dev, "otg-switch", GPIOD_IN);
>> + if (!hisi_hikey_usb->otg_switch)
>> + return -ENOENT;
>> + else if (IS_ERR(hisi_hikey_usb->otg_switch))
>> + return PTR_ERR(hisi_hikey_usb->otg_switch);
>> +
>> + gpiod_direction_output(hisi_hikey_usb->otg_switch, USB_SWITCH_TO_HUB);
>> +
>> + /* hub-vdd33-en is optional */
>> + hisi_hikey_usb->hub_vbus = devm_gpiod_get(dev, "hub-vdd33-en",
>> + GPIOD_OUT_LOW);
>> + if (IS_ERR(hisi_hikey_usb->hub_vbus))
>> + return PTR_ERR(hisi_hikey_usb->hub_vbus);
>> +
>> + gpiod_direction_output(hisi_hikey_usb->hub_vbus, HUB_VBUS_POWER_ON);
> ditto
>> +
>> + hisi_hikey_usb->role_sw = usb_role_switch_get(dev);
>> + if (!hisi_hikey_usb->role_sw)
>> + return -EPROBE_DEFER;
>> + else if (IS_ERR(hisi_hikey_usb->role_sw))
>> + return PTR_ERR(hisi_hikey_usb->role_sw);
>> +
Thanks
Yu Chen
next prev parent reply other threads:[~2019-02-19 3:20 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 11:23 [PATCH v2 00/10] Add support for usb on Hikey960 Yu Chen
2019-02-18 11:23 ` Yu Chen
2019-02-18 11:23 ` [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen
2019-02-18 11:23 ` [v2,01/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 01/10] " Yu Chen
2019-02-18 20:18 ` Rob Herring
2019-02-18 20:18 ` [v2,01/10] " Rob Herring
2019-02-19 1:50 ` [PATCH v2 01/10] " Chen Yu
2019-02-19 1:50 ` [v2,01/10] " Yu Chen
2019-02-19 1:50 ` [PATCH v2 01/10] " Chen Yu
2019-02-19 3:03 ` Chunfeng Yun
2019-02-19 3:03 ` [v2,01/10] " Chunfeng Yun
2019-02-19 3:03 ` [PATCH v2 01/10] " Chunfeng Yun
2019-02-19 3:55 ` Chen Yu
2019-02-19 3:55 ` [v2,01/10] " Yu Chen
2019-02-19 3:55 ` [PATCH v2 01/10] " Chen Yu
2019-02-19 14:22 ` Rob Herring
2019-02-19 14:22 ` [v2,01/10] " Rob Herring
2019-02-18 11:23 ` [PATCH v2 02/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen
2019-02-18 11:23 ` [v2,02/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 02/10] " Yu Chen
2019-02-19 8:25 ` Sergei Shtylyov
2019-02-19 8:25 ` [v2,02/10] " Sergei Shtylyov
2019-02-20 2:34 ` [PATCH v2 02/10] " Chen Yu
2019-02-20 2:34 ` [v2,02/10] " Yu Chen
2019-02-20 2:34 ` [PATCH v2 02/10] " Chen Yu
2019-02-18 11:23 ` [PATCH v2 03/10] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform Yu Chen
2019-02-18 11:23 ` [v2,03/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 03/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 04/10] usb: dwc3: Add two quirks for Hisilicon Kirin " Yu Chen
2019-02-18 11:23 ` [v2,04/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 04/10] " Yu Chen
2019-02-18 12:21 ` Andy Shevchenko
2019-02-18 12:21 ` [v2,04/10] " Andy Shevchenko
2019-02-18 12:31 ` [PATCH v2 04/10] " Chen Yu
2019-02-18 12:31 ` [v2,04/10] " Yu Chen
2019-02-18 12:31 ` [PATCH v2 04/10] " Chen Yu
2019-02-18 11:23 ` [PATCH v2 05/10] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2019-02-18 11:23 ` [v2,05/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 05/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 06/10] usb: roles: Add usb role switch notifier Yu Chen
2019-02-18 11:23 ` [v2,06/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 06/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 07/10] usb: dwc3: Registering a role switch in the DRD code Yu Chen
2019-02-18 11:23 ` [v2,07/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 07/10] " Yu Chen
2019-02-18 17:30 ` Valentin Schneider
2019-02-18 17:30 ` [v2,07/10] " Valentin Schneider
2019-02-19 1:40 ` [PATCH v2 07/10] " Chen Yu
2019-02-19 1:40 ` [v2,07/10] " Yu Chen
2019-02-19 1:40 ` [PATCH v2 07/10] " Chen Yu
2019-02-19 2:57 ` Jun Li
2019-02-19 2:57 ` [v2,07/10] " Jun Li
2019-02-19 3:37 ` [PATCH v2 07/10] " Chen Yu
2019-02-19 3:37 ` [v2,07/10] " Yu Chen
2019-02-19 3:37 ` [PATCH v2 07/10] " Chen Yu
2019-02-18 11:23 ` [PATCH v2 08/10] hikey960: Support usb functionality of Hikey960 Yu Chen
2019-02-18 11:23 ` [v2,08/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 08/10] " Yu Chen
2019-02-19 2:50 ` Chunfeng Yun
2019-02-19 2:50 ` [v2,08/10] " Chunfeng Yun
2019-02-19 2:50 ` [PATCH v2 08/10] " Chunfeng Yun
2019-02-19 3:20 ` Chen Yu [this message]
2019-02-19 3:20 ` [v2,08/10] " Yu Chen
2019-02-19 3:20 ` [PATCH v2 08/10] " Chen Yu
2019-02-22 7:32 ` Chunfeng Yun
2019-02-22 7:32 ` [v2,08/10] " Chunfeng Yun
2019-02-22 7:32 ` [PATCH v2 08/10] " Chunfeng Yun
2019-03-02 1:02 ` Chen Yu
2019-03-02 1:02 ` [v2,08/10] " Yu Chen
2019-03-02 1:02 ` [PATCH v2 08/10] " Chen Yu
2019-02-18 11:23 ` [PATCH v2 09/10] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen
2019-02-18 11:23 ` [v2,09/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 09/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 10/10] dts: hi3660: Add support for usb on Hikey960 Yu Chen
2019-02-18 11:23 ` Yu Chen
2019-02-18 11:23 ` [v2,10/10] " Yu Chen
2019-02-18 11:23 ` [PATCH v2 10/10] " Yu Chen
2019-02-18 17:30 ` [PATCH v2 00/10] " Valentin Schneider
2019-02-19 1:34 ` Chen Yu
2019-02-19 1:34 ` Chen Yu
2019-02-19 11:31 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c02407b4-1825-83f5-2aff-dd41ae16e2ab@huawei.com \
--to=chenyu56@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=butao@hisilicon.com \
--cc=chenyao11@huawei.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fangshengzhou@hisilicon.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=kongfei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lipengcheng8@huawei.com \
--cc=liuyu712@hisilicon.com \
--cc=songxiaowei@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=wangbinghui@hisilicon.com \
--cc=wanghu17@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=xuyoujun4@huawei.com \
--cc=yudongbin@hisilicon.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.