From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Yu Chen <chenyu56@huawei.com> Cc: USB <linux-usb@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, John Stultz <john.stultz@linaro.org>, Suzhuangluan <suzhuangluan@hisilicon.com>, Kongfei <kongfei@hisilicon.com>, liuyu712@hisilicon.com, wanghu17@hisilicon.com, butao@hisilicon.com, Yao Chen <chenyao11@huawei.com>, fangshengzhou@hisilicon.com, lipengcheng8@huawei.com, songxiaowei <songxiaowei@hisilicon.com>, xu yiping <xuyiping@hisilicon.com>, xuyoujun4@huawei.com, yudongbin@hisilicon.com, zangleigang@hisilicon.com, Felipe Balbi <balbi@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Binghui Wang <wangbinghui@hisilicon.com> Subject: Re: [PATCH v2 04/10] usb: dwc3: Add two quirks for Hisilicon Kirin Soc Platform Date: Mon, 18 Feb 2019 14:21:34 +0200 [thread overview] Message-ID: <CAHp75VdrSyORjd0OXS11poCL-3PofgsiejzgZ=m56sZegfGyMw@mail.gmail.com> (raw) In-Reply-To: <20190218112310.17860-5-chenyu56@huawei.com> On Mon, Feb 18, 2019 at 1:23 PM Yu Chen <chenyu56@huawei.com> wrote: > > There are tow quirks for DesignWare USB3 DRD Core of Hisilicon Kirin Soc. > 1)SPLIT_BOUNDARY_DISABLE should be set for Host mode > 2)A GCTL soft reset should be executed when switch mode Thus, it must be two patches, no? > +static void dwc3_gctl_core_soft_reset(struct dwc3 *dwc) > +{ > + u32 reg; > + > + reg = dwc3_readl(dwc->regs, DWC3_GCTL); > + reg |= (DWC3_GCTL_CORESOFTRESET); Redundant parens. > + dwc3_writel(dwc->regs, DWC3_GCTL, reg); > + > + reg = dwc3_readl(dwc->regs, DWC3_GCTL); > + reg &= ~(DWC3_GCTL_CORESOFTRESET); Ditto. > + dwc3_writel(dwc->regs, DWC3_GCTL, reg); > +} > +static void dwc3_complete(struct device *dev) > +{ > + struct dwc3 *dwc = dev_get_drvdata(dev); > + u32 reg; Indentation style is different to the other functions in the same patch. Use simple space here. > + if (dwc->current_dr_role == DWC3_GCTL_PRTCAP_HOST && > + dwc->dis_split_quirk) { > + dev_dbg(dwc->dev, "set DWC3_GUCTL3_SPLITDISABLE\n"); > + reg = dwc3_readl(dwc->regs, DWC3_GUCTL3); > + reg |= DWC3_GUCTL3_SPLITDISABLE; > + dwc3_writel(dwc->regs, DWC3_GUCTL3, reg); > + } > +} > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -269,7 +269,7 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned cmd, > { > const struct usb_endpoint_descriptor *desc = dep->endpoint.desc; > struct dwc3 *dwc = dep->dwc; > - u32 timeout = 1000; > + u32 timeout = 5000; I don't see anything about this change in commit message. Moreoever, it looks like it must be a separate logical change with its own description. > u32 saved_config = 0; > u32 reg; -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Yu Chen <chenyu56@huawei.com> Cc: USB <linux-usb@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, John Stultz <john.stultz@linaro.org>, Suzhuangluan <suzhuangluan@hisilicon.com>, Kongfei <kongfei@hisilicon.com>, liuyu712@hisilicon.com, wanghu17@hisilicon.com, butao@hisilicon.com, Yao Chen <chenyao11@huawei.com>, fangshengzhou@hisilicon.com, lipengcheng8@huawei.com, songxiaowei <songxiaowei@hisilicon.com>, xu yiping <xuyiping@hisilicon.com>, xuyoujun4@huawei.com, yudongbin@hisilicon.com, zangleigang@hisilicon.com, Felipe Balbi <balbi@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Binghui Wang <wangbinghui@hisilicon.com> Subject: [v2,04/10] usb: dwc3: Add two quirks for Hisilicon Kirin Soc Platform Date: Mon, 18 Feb 2019 14:21:34 +0200 [thread overview] Message-ID: <CAHp75VdrSyORjd0OXS11poCL-3PofgsiejzgZ=m56sZegfGyMw@mail.gmail.com> (raw) On Mon, Feb 18, 2019 at 1:23 PM Yu Chen <chenyu56@huawei.com> wrote: > > There are tow quirks for DesignWare USB3 DRD Core of Hisilicon Kirin Soc. > 1)SPLIT_BOUNDARY_DISABLE should be set for Host mode > 2)A GCTL soft reset should be executed when switch mode Thus, it must be two patches, no? > +static void dwc3_gctl_core_soft_reset(struct dwc3 *dwc) > +{ > + u32 reg; > + > + reg = dwc3_readl(dwc->regs, DWC3_GCTL); > + reg |= (DWC3_GCTL_CORESOFTRESET); Redundant parens. > + dwc3_writel(dwc->regs, DWC3_GCTL, reg); > + > + reg = dwc3_readl(dwc->regs, DWC3_GCTL); > + reg &= ~(DWC3_GCTL_CORESOFTRESET); Ditto. > + dwc3_writel(dwc->regs, DWC3_GCTL, reg); > +} > +static void dwc3_complete(struct device *dev) > +{ > + struct dwc3 *dwc = dev_get_drvdata(dev); > + u32 reg; Indentation style is different to the other functions in the same patch. Use simple space here. > + if (dwc->current_dr_role == DWC3_GCTL_PRTCAP_HOST && > + dwc->dis_split_quirk) { > + dev_dbg(dwc->dev, "set DWC3_GUCTL3_SPLITDISABLE\n"); > + reg = dwc3_readl(dwc->regs, DWC3_GUCTL3); > + reg |= DWC3_GUCTL3_SPLITDISABLE; > + dwc3_writel(dwc->regs, DWC3_GUCTL3, reg); > + } > +} > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -269,7 +269,7 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned cmd, > { > const struct usb_endpoint_descriptor *desc = dep->endpoint.desc; > struct dwc3 *dwc = dep->dwc; > - u32 timeout = 1000; > + u32 timeout = 5000; I don't see anything about this change in commit message. Moreoever, it looks like it must be a separate logical change with its own description. > u32 saved_config = 0; > u32 reg;
next prev parent reply other threads:[~2019-02-18 12:21 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-18 11:23 [PATCH v2 00/10] Add support for usb on Hikey960 Yu Chen 2019-02-18 11:23 ` Yu Chen 2019-02-18 11:23 ` [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen 2019-02-18 11:23 ` [v2,01/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 01/10] " Yu Chen 2019-02-18 20:18 ` Rob Herring 2019-02-18 20:18 ` [v2,01/10] " Rob Herring 2019-02-19 1:50 ` [PATCH v2 01/10] " Chen Yu 2019-02-19 1:50 ` [v2,01/10] " Yu Chen 2019-02-19 1:50 ` [PATCH v2 01/10] " Chen Yu 2019-02-19 3:03 ` Chunfeng Yun 2019-02-19 3:03 ` [v2,01/10] " Chunfeng Yun 2019-02-19 3:03 ` [PATCH v2 01/10] " Chunfeng Yun 2019-02-19 3:55 ` Chen Yu 2019-02-19 3:55 ` [v2,01/10] " Yu Chen 2019-02-19 3:55 ` [PATCH v2 01/10] " Chen Yu 2019-02-19 14:22 ` Rob Herring 2019-02-19 14:22 ` [v2,01/10] " Rob Herring 2019-02-18 11:23 ` [PATCH v2 02/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen 2019-02-18 11:23 ` [v2,02/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 02/10] " Yu Chen 2019-02-19 8:25 ` Sergei Shtylyov 2019-02-19 8:25 ` [v2,02/10] " Sergei Shtylyov 2019-02-20 2:34 ` [PATCH v2 02/10] " Chen Yu 2019-02-20 2:34 ` [v2,02/10] " Yu Chen 2019-02-20 2:34 ` [PATCH v2 02/10] " Chen Yu 2019-02-18 11:23 ` [PATCH v2 03/10] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform Yu Chen 2019-02-18 11:23 ` [v2,03/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 03/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 04/10] usb: dwc3: Add two quirks for Hisilicon Kirin " Yu Chen 2019-02-18 11:23 ` [v2,04/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 04/10] " Yu Chen 2019-02-18 12:21 ` Andy Shevchenko [this message] 2019-02-18 12:21 ` [v2,04/10] " Andy Shevchenko 2019-02-18 12:31 ` [PATCH v2 04/10] " Chen Yu 2019-02-18 12:31 ` [v2,04/10] " Yu Chen 2019-02-18 12:31 ` [PATCH v2 04/10] " Chen Yu 2019-02-18 11:23 ` [PATCH v2 05/10] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen 2019-02-18 11:23 ` [v2,05/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 05/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 06/10] usb: roles: Add usb role switch notifier Yu Chen 2019-02-18 11:23 ` [v2,06/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 06/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 07/10] usb: dwc3: Registering a role switch in the DRD code Yu Chen 2019-02-18 11:23 ` [v2,07/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 07/10] " Yu Chen 2019-02-18 17:30 ` Valentin Schneider 2019-02-18 17:30 ` [v2,07/10] " Valentin Schneider 2019-02-19 1:40 ` [PATCH v2 07/10] " Chen Yu 2019-02-19 1:40 ` [v2,07/10] " Yu Chen 2019-02-19 1:40 ` [PATCH v2 07/10] " Chen Yu 2019-02-19 2:57 ` Jun Li 2019-02-19 2:57 ` [v2,07/10] " Jun Li 2019-02-19 3:37 ` [PATCH v2 07/10] " Chen Yu 2019-02-19 3:37 ` [v2,07/10] " Yu Chen 2019-02-19 3:37 ` [PATCH v2 07/10] " Chen Yu 2019-02-18 11:23 ` [PATCH v2 08/10] hikey960: Support usb functionality of Hikey960 Yu Chen 2019-02-18 11:23 ` [v2,08/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 08/10] " Yu Chen 2019-02-19 2:50 ` Chunfeng Yun 2019-02-19 2:50 ` [v2,08/10] " Chunfeng Yun 2019-02-19 2:50 ` [PATCH v2 08/10] " Chunfeng Yun 2019-02-19 3:20 ` Chen Yu 2019-02-19 3:20 ` [v2,08/10] " Yu Chen 2019-02-19 3:20 ` [PATCH v2 08/10] " Chen Yu 2019-02-22 7:32 ` Chunfeng Yun 2019-02-22 7:32 ` [v2,08/10] " Chunfeng Yun 2019-02-22 7:32 ` [PATCH v2 08/10] " Chunfeng Yun 2019-03-02 1:02 ` Chen Yu 2019-03-02 1:02 ` [v2,08/10] " Yu Chen 2019-03-02 1:02 ` [PATCH v2 08/10] " Chen Yu 2019-02-18 11:23 ` [PATCH v2 09/10] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen 2019-02-18 11:23 ` [v2,09/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 09/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 10/10] dts: hi3660: Add support for usb on Hikey960 Yu Chen 2019-02-18 11:23 ` Yu Chen 2019-02-18 11:23 ` [v2,10/10] " Yu Chen 2019-02-18 11:23 ` [PATCH v2 10/10] " Yu Chen 2019-02-18 17:30 ` [PATCH v2 00/10] " Valentin Schneider 2019-02-19 1:34 ` Chen Yu 2019-02-19 1:34 ` Chen Yu 2019-02-19 11:31 ` Valentin Schneider
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHp75VdrSyORjd0OXS11poCL-3PofgsiejzgZ=m56sZegfGyMw@mail.gmail.com' \ --to=andy.shevchenko@gmail.com \ --cc=balbi@kernel.org \ --cc=butao@hisilicon.com \ --cc=chenyao11@huawei.com \ --cc=chenyu56@huawei.com \ --cc=devicetree@vger.kernel.org \ --cc=fangshengzhou@hisilicon.com \ --cc=gregkh@linuxfoundation.org \ --cc=john.stultz@linaro.org \ --cc=kongfei@hisilicon.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=lipengcheng8@huawei.com \ --cc=liuyu712@hisilicon.com \ --cc=songxiaowei@hisilicon.com \ --cc=suzhuangluan@hisilicon.com \ --cc=wangbinghui@hisilicon.com \ --cc=wanghu17@hisilicon.com \ --cc=xuyiping@hisilicon.com \ --cc=xuyoujun4@huawei.com \ --cc=yudongbin@hisilicon.com \ --cc=zangleigang@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.