From: Maxime Ripard <maxime.ripard@bootlin.com> To: "Noralf Trønnes" <noralf@tronnes.org> Cc: eben@raspberrypi.org, David Airlie <airlied@linux.ie>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, dri-devel@lists.freedesktop.org, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Eric Anholt <eric@anholt.net>, Sean Paul <seanpaul@chromium.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Daniel Vetter <daniel.vetter@intel.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline Date: Tue, 11 Jun 2019 14:49:33 +0200 [thread overview] Message-ID: <20190611124933.2g6l3d7nx6lqft6k@flea> (raw) In-Reply-To: <9ccb7573-d46e-4b90-7caa-7b8cd7b8e7a2@tronnes.org> [-- Attachment #1.1: Type: text/plain, Size: 1228 bytes --] Hi Noralf, On Thu, Apr 18, 2019 at 06:40:42PM +0200, Noralf Trønnes wrote: > Den 18.04.2019 14.41, skrev Maxime Ripard: > > + /** > > + * We want the rotation on the command line to overwrite > > + * whatever comes from the panel. > > + */ > > + cmdline = &connector->cmdline_mode; > > + if (cmdline->specified && > > + cmdline->rotation != DRM_MODE_ROTATE_0) > > I believe you need to drop that second check, otherwise rotate=0 will > not overwrite panel rotation. Good catch :) > > + } else if (!strncmp(option, "reflect_x", delim - option)) { > > + rotation |= DRM_MODE_REFLECT_X; > > + sep = delim; > > + } else if (!strncmp(option, "reflect_y", delim - option)) { > > I think you should drop reflect_x and _y for now since they're not > supported. People like me that only reads code and not documentation > (ahem..) will get the impression that this should work. I'm not sure what you mean here, this is definitely supposed to work. Is there a limitation you're thinking of? > Documentation/fb/modedb.txt needs to be updated with this new video= option. Will do, thanks! maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com> To: "Noralf Trønnes" <noralf@tronnes.org> Cc: eben@raspberrypi.org, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Sean Paul <seanpaul@chromium.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Daniel Vetter <daniel.vetter@intel.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline Date: Tue, 11 Jun 2019 14:49:33 +0200 [thread overview] Message-ID: <20190611124933.2g6l3d7nx6lqft6k@flea> (raw) In-Reply-To: <9ccb7573-d46e-4b90-7caa-7b8cd7b8e7a2@tronnes.org> [-- Attachment #1.1: Type: text/plain, Size: 1228 bytes --] Hi Noralf, On Thu, Apr 18, 2019 at 06:40:42PM +0200, Noralf Trønnes wrote: > Den 18.04.2019 14.41, skrev Maxime Ripard: > > + /** > > + * We want the rotation on the command line to overwrite > > + * whatever comes from the panel. > > + */ > > + cmdline = &connector->cmdline_mode; > > + if (cmdline->specified && > > + cmdline->rotation != DRM_MODE_ROTATE_0) > > I believe you need to drop that second check, otherwise rotate=0 will > not overwrite panel rotation. Good catch :) > > + } else if (!strncmp(option, "reflect_x", delim - option)) { > > + rotation |= DRM_MODE_REFLECT_X; > > + sep = delim; > > + } else if (!strncmp(option, "reflect_y", delim - option)) { > > I think you should drop reflect_x and _y for now since they're not > supported. People like me that only reads code and not documentation > (ahem..) will get the impression that this should work. I'm not sure what you mean here, this is definitely supposed to work. Is there a limitation you're thinking of? > Documentation/fb/modedb.txt needs to be updated with this new video= option. Will do, thanks! maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-11 12:49 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-18 12:41 [PATCH v3 0/6] drm/vc4: Allow for more boot-time configuration Maxime Ripard 2019-04-18 12:41 ` Maxime Ripard 2019-04-18 12:41 ` [PATCH v3 1/6] drm/modes: Rewrite the command line parser Maxime Ripard 2019-04-18 12:41 ` Maxime Ripard 2019-04-18 16:11 ` Noralf Trønnes 2019-04-18 16:11 ` Noralf Trønnes 2019-04-18 12:41 ` [PATCH v3 2/6] drm/modes: Support modes names on the command line Maxime Ripard 2019-04-18 12:41 ` Maxime Ripard 2019-04-18 16:22 ` Noralf Trønnes 2019-04-18 16:22 ` Noralf Trønnes 2019-04-18 12:41 ` [PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline Maxime Ripard 2019-04-18 12:41 ` Maxime Ripard 2019-04-18 16:40 ` Noralf Trønnes 2019-04-18 16:40 ` Noralf Trønnes 2019-04-19 8:53 ` Noralf Trønnes 2019-04-19 8:53 ` Noralf Trønnes 2019-06-11 13:20 ` Maxime Ripard 2019-06-11 13:20 ` Maxime Ripard 2019-06-12 8:11 ` Jani Nikula 2019-06-12 8:11 ` Jani Nikula 2019-06-12 13:21 ` Noralf Trønnes 2019-06-12 13:21 ` Noralf Trønnes 2019-06-13 12:50 ` Maxime Ripard 2019-06-13 12:50 ` Maxime Ripard 2019-06-13 14:12 ` Noralf Trønnes 2019-06-13 14:12 ` Noralf Trønnes 2019-06-11 12:49 ` Maxime Ripard [this message] 2019-06-11 12:49 ` Maxime Ripard 2019-06-12 12:43 ` Noralf Trønnes 2019-06-12 12:43 ` Noralf Trønnes 2019-06-12 15:54 ` Maxime Ripard 2019-06-12 15:54 ` Maxime Ripard 2019-04-18 12:41 ` [PATCH v3 4/6] drm/modes: Parse overscan properties Maxime Ripard 2019-04-18 12:41 ` Maxime Ripard 2019-04-18 16:50 ` Noralf Trønnes 2019-04-18 16:50 ` Noralf Trønnes 2019-04-19 9:05 ` Noralf Trønnes 2019-04-19 9:05 ` Noralf Trønnes 2019-04-18 12:41 ` [PATCH v3 5/6] drm/selftests: Add command line parser selftests Maxime Ripard 2019-04-18 12:41 ` Maxime Ripard 2019-04-18 16:51 ` Noralf Trønnes 2019-04-18 16:51 ` Noralf Trønnes 2019-04-18 12:41 ` [PATCH v3 6/6] drm/vc4: hdmi: Set default state margin at reset Maxime Ripard 2019-04-18 12:41 ` Maxime Ripard 2019-04-18 16:59 ` Noralf Trønnes 2019-04-19 18:50 ` Noralf Trønnes 2019-04-19 18:50 ` Noralf Trønnes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190611124933.2g6l3d7nx6lqft6k@flea \ --to=maxime.ripard@bootlin.com \ --cc=airlied@linux.ie \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=eben@raspberrypi.org \ --cc=eric@anholt.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=noralf@tronnes.org \ --cc=paul.kocialkowski@bootlin.com \ --cc=seanpaul@chromium.org \ --cc=thomas.petazzoni@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.