Re: [PATCH v3 6/6] drm/vc4: hdmi: Set default state margin at reset

From: "Noralf Trønnes" <noralf@tronnes.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Sean Paul <seanpaul@chromium.org>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	linux-arm-kernel@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	dri-devel@lists.freedesktop.org, eben@raspberrypi.org
Subject: Re: [PATCH v3 6/6] drm/vc4: hdmi: Set default state margin at reset
Date: Fri, 19 Apr 2019 20:50:49 +0200	[thread overview]
Message-ID: <4134b0f8-243b-3d16-e544-27316885feb4@tronnes.org> (raw)
In-Reply-To: <b925966c-1ad2-f685-d7e2-222495988bb6@tronnes.org>

Den 18.04.2019 18.59, skrev Noralf Trønnes:
> 
> 
> Den 18.04.2019 14.41, skrev Maxime Ripard:
>> Now that the TV margins are properly parsed and filled into
>> drm_cmdline_mode, we just need to initialise the first state at reset to
>> get those values and start using them.
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>> ---
>>  drivers/gpu/drm/vc4/vc4_hdmi.c | 16 +++++++++++++++-
>>  1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
>> index 99fc8569e0f5..d86f154138f5 100644
>> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
>> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
>> @@ -255,11 +255,25 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)
>>  	return ret;
>>  }
>>  
>> +static void vc4_hdmi_connector_reset(struct drm_connector *connector)

You could turn this function into a helper
drm_atomic_helper_connector_tv_reset() or something.

>> +{
>> +	struct drm_cmdline_mode *cmdline = &connector->cmdline_mode;
>> +	struct drm_connector_state *state;
>> +
>> +	drm_atomic_helper_connector_reset(connector);
> 
> Initially I wondered why not do this in the helper, but ofc that would
> apply the values to all the connectors. I know too little about this
> subject to argue for having it in the helper, and it can be changed
> later if deemed convinient, so:
> 
> Acked-by: Noralf Trønnes <noralf@tronnes.org>
> 
>> +
>> +	state = connector->state;
>> +	state->tv.margins.left = cmdline->tv_margins.left;
>> +	state->tv.margins.right = cmdline->tv_margins.right;
>> +	state->tv.margins.top = cmdline->tv_margins.top;
>> +	state->tv.margins.bottom = cmdline->tv_margins.bottom;
>> +}
>> +
>>  static const struct drm_connector_funcs vc4_hdmi_connector_funcs = {
>>  	.detect = vc4_hdmi_connector_detect,
>>  	.fill_modes = drm_helper_probe_single_connector_modes,
>>  	.destroy = vc4_hdmi_connector_destroy,
>> -	.reset = drm_atomic_helper_connector_reset,
>> +	.reset = vc4_hdmi_connector_reset,
>>  	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
>>  	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
>>  };
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel