From: Mark Brown <broonie@kernel.org> To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, "baolin.wang@linaro.org" <baolin.wang@linaro.org>, "bcm-kernel-feedback-list@broadcom.com" <bcm-kernel-feedback-list@broadcom.com>, "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>, "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>, "linus.walleij@linaro.org" <linus.walleij@linaro.org>, "jic23@kernel.org" <jic23@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "f.fainelli@gmail.com" <f.fainelli@gmail.com>, "orsonzhai@gmail.com" <orsonzhai@gmail.com>, "zhang.lyra@gmail.com" <zhang.lyra@gmail.com> Subject: Re: [RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic Date: Mon, 16 Sep 2019 14:43:09 +0100 [thread overview] Message-ID: <20190916134309.GH4352@sirena.co.uk> (raw) In-Reply-To: <458cbb212fbd04c157c9861501f51c03ea958302.camel@analog.com> [-- Attachment #1: Type: text/plain, Size: 1044 bytes --] On Mon, Sep 16, 2019 at 01:04:42PM +0000, Ardelean, Alexandru wrote: > On Mon, 2019-09-16 at 13:47 +0100, Mark Brown wrote: > > That v3 seems to be a small subset of this series? > Ack. > V3 is the first 4 patches from this series. > Well, patches 3 & 4 are squashed. > I am 100% convinced that the entire series is a good idea. > In the sense that a `struct spi_delay` may be a good idea, but at the same time, it may be un-needed. > All I wanted to do, was to add another delay somewhere, and got lost in the rework of current delays. > I thought about proposing just the first 4 patches [on their own], but I thought that showing the current series as-is > now, may be a good idea as well [to gather some feedback]. I think it makes more sense to review as a whole series rather than only a part of the conversion, it doesn't really help to only do part of it. Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> Cc: "f.fainelli@gmail.com" <f.fainelli@gmail.com>, "baolin.wang@linaro.org" <baolin.wang@linaro.org>, "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>, "zhang.lyra@gmail.com" <zhang.lyra@gmail.com>, "linus.walleij@linaro.org" <linus.walleij@linaro.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, "bcm-kernel-feedback-list@broadcom.com" <bcm-kernel-feedback-list@broadcom.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>, "orsonzhai@gmail.com" <orsonzhai@gmail.com>, "jic23@kernel.org" <jic23@kernel.org> Subject: Re: [RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic Date: Mon, 16 Sep 2019 14:43:09 +0100 [thread overview] Message-ID: <20190916134309.GH4352@sirena.co.uk> (raw) In-Reply-To: <458cbb212fbd04c157c9861501f51c03ea958302.camel@analog.com> [-- Attachment #1.1: Type: text/plain, Size: 1044 bytes --] On Mon, Sep 16, 2019 at 01:04:42PM +0000, Ardelean, Alexandru wrote: > On Mon, 2019-09-16 at 13:47 +0100, Mark Brown wrote: > > That v3 seems to be a small subset of this series? > Ack. > V3 is the first 4 patches from this series. > Well, patches 3 & 4 are squashed. > I am 100% convinced that the entire series is a good idea. > In the sense that a `struct spi_delay` may be a good idea, but at the same time, it may be un-needed. > All I wanted to do, was to add another delay somewhere, and got lost in the rework of current delays. > I thought about proposing just the first 4 patches [on their own], but I thought that showing the current series as-is > now, may be a good idea as well [to gather some feedback]. I think it makes more sense to review as a whole series rather than only a part of the conversion, it doesn't really help to only do part of it. Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-16 13:43 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-13 11:45 [RFC PATCH 00/15] Unify SPI delays into an `struct spi_delay` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 01/15] spi: move `cs_change_delay` backwards compat logic outside switch Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 02/15] spi: introduce spi_delay struct as "value + unit" & spi_delay_exec() Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-16 12:25 ` Mark Brown 2019-09-16 12:25 ` Mark Brown 2019-09-16 12:37 ` Ardelean, Alexandru 2019-09-16 12:37 ` Ardelean, Alexandru 2019-09-16 12:37 ` Ardelean, Alexandru 2019-09-16 12:47 ` Mark Brown 2019-09-16 12:47 ` Mark Brown 2019-09-16 12:47 ` Mark Brown 2019-09-16 13:04 ` Ardelean, Alexandru 2019-09-16 13:04 ` Ardelean, Alexandru 2019-09-16 13:04 ` Ardelean, Alexandru 2019-09-16 13:43 ` Mark Brown [this message] 2019-09-16 13:43 ` Mark Brown 2019-09-16 13:43 ` Mark Brown 2019-09-17 6:05 ` Ardelean, Alexandru 2019-09-17 6:05 ` Ardelean, Alexandru 2019-09-17 6:05 ` Ardelean, Alexandru 2019-09-13 11:45 ` [RFC PATCH 04/15] iio: imu: adis: convert cs_change_delay to spi_delay struct Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 05/15] spi: sprd: convert transfer word delay " Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 06/15] spi: orion: use new `word_delay` field for SPI transfers Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 07/15] spi: spidev: use new `word_delay` field for spi transfers Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 08/15] spi: core,atmel: convert `word_delay_usecs` -> `word_delay` for spi_device Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 08/15] spi: core, atmel: " Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 08/15] spi: core,atmel: " Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 09/15] spi: introduce `delay` field for `spi_transfer` + spi_transfer_exec() Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 10/15] spi: use new `spi_transfer_delay` helper where straightforward Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 11/15] spi: tegra114: use `spi_transfer_delay` helper Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 12/15] spi: spi-loopback-test: use new `delay` field Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 13/15] spi: spidev: use new `delay` field for spi transfers Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 14/15] spi: tegra114: change format for `spi_set_cs_timing()` function Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` [RFC PATCH 15/15] spi: implement SW control for CS times Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-13 11:45 ` Alexandru Ardelean 2019-09-15 10:22 ` [RFC PATCH 00/15] Unify SPI delays into an `struct spi_delay` Jonathan Cameron 2019-09-15 10:22 ` Jonathan Cameron 2019-09-15 10:22 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190916134309.GH4352@sirena.co.uk \ --to=broonie@kernel.org \ --cc=alexandru.Ardelean@analog.com \ --cc=baolin.wang@linaro.org \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=f.fainelli@gmail.com \ --cc=jic23@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=orsonzhai@gmail.com \ --cc=zhang.lyra@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.