From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"baolin.wang@linaro.org" <baolin.wang@linaro.org>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"jic23@kernel.org" <jic23@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"orsonzhai@gmail.com" <orsonzhai@gmail.com>,
"zhang.lyra@gmail.com" <zhang.lyra@gmail.com>
Subject: Re: [RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic
Date: Mon, 16 Sep 2019 12:37:12 +0000 [thread overview]
Message-ID: <ae469c65828443524f9ff0409f1c7a81bf64cf6b.camel@analog.com> (raw)
In-Reply-To: <20190916122505.GC4352@sirena.co.uk>
On Mon, 2019-09-16 at 13:25 +0100, Mark Brown wrote:
> [External]
>
> On Fri, Sep 13, 2019 at 02:45:38PM +0300, Alexandru Ardelean wrote:
>
> > - u16 cs_change_delay;
> > - u8 cs_change_delay_unit;
> > + struct spi_delay cs_change_delay;
>
> This breaks the build as there is a user of this interface.
Ack.
Jonathan pointed this out.
There's a V3 that changes both this and it's user (in IIO).
V3:
https://lore.kernel.org/linux-iio/20190916071024.21447-1-alexandru.ardelean@analog.com/T/#t
V2:
https://lore.kernel.org/linux-iio/20190913115549.3823-1-alexandru.ardelean@analog.com/T/#t
[ archive is from the IIO list ]
Well, I'm hoping you are referring to the same user.
On a general note: I apologise for the amount of noise/spam I am doing here. Still adjusting to how to do things/changes
that touch 2 subsystems, especially when trees are not quite in-sync.
WARNING: multiple messages have this Message-ID (diff)
From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"baolin.wang@linaro.org" <baolin.wang@linaro.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"orsonzhai@gmail.com" <orsonzhai@gmail.com>,
"jic23@kernel.org" <jic23@kernel.org>
Subject: Re: [RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic
Date: Mon, 16 Sep 2019 12:37:12 +0000 [thread overview]
Message-ID: <ae469c65828443524f9ff0409f1c7a81bf64cf6b.camel@analog.com> (raw)
In-Reply-To: <20190916122505.GC4352@sirena.co.uk>
On Mon, 2019-09-16 at 13:25 +0100, Mark Brown wrote:
> [External]
>
> On Fri, Sep 13, 2019 at 02:45:38PM +0300, Alexandru Ardelean wrote:
>
> > - u16 cs_change_delay;
> > - u8 cs_change_delay_unit;
> > + struct spi_delay cs_change_delay;
>
> This breaks the build as there is a user of this interface.
Ack.
Jonathan pointed this out.
There's a V3 that changes both this and it's user (in IIO).
V3:
https://lore.kernel.org/linux-iio/20190916071024.21447-1-alexandru.ardelean@analog.com/T/#t
V2:
https://lore.kernel.org/linux-iio/20190913115549.3823-1-alexandru.ardelean@analog.com/T/#t
[ archive is from the IIO list ]
Well, I'm hoping you are referring to the same user.
On a general note: I apologise for the amount of noise/spam I am doing here. Still adjusting to how to do things/changes
that touch 2 subsystems, especially when trees are not quite in-sync.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-16 12:37 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 11:45 [RFC PATCH 00/15] Unify SPI delays into an `struct spi_delay` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 01/15] spi: move `cs_change_delay` backwards compat logic outside switch Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 02/15] spi: introduce spi_delay struct as "value + unit" & spi_delay_exec() Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-16 12:25 ` Mark Brown
2019-09-16 12:25 ` Mark Brown
2019-09-16 12:37 ` Ardelean, Alexandru [this message]
2019-09-16 12:37 ` Ardelean, Alexandru
2019-09-16 12:37 ` Ardelean, Alexandru
2019-09-16 12:47 ` Mark Brown
2019-09-16 12:47 ` Mark Brown
2019-09-16 12:47 ` Mark Brown
2019-09-16 13:04 ` Ardelean, Alexandru
2019-09-16 13:04 ` Ardelean, Alexandru
2019-09-16 13:04 ` Ardelean, Alexandru
2019-09-16 13:43 ` Mark Brown
2019-09-16 13:43 ` Mark Brown
2019-09-16 13:43 ` Mark Brown
2019-09-17 6:05 ` Ardelean, Alexandru
2019-09-17 6:05 ` Ardelean, Alexandru
2019-09-17 6:05 ` Ardelean, Alexandru
2019-09-13 11:45 ` [RFC PATCH 04/15] iio: imu: adis: convert cs_change_delay to spi_delay struct Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 05/15] spi: sprd: convert transfer word delay " Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 06/15] spi: orion: use new `word_delay` field for SPI transfers Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 07/15] spi: spidev: use new `word_delay` field for spi transfers Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 08/15] spi: core,atmel: convert `word_delay_usecs` -> `word_delay` for spi_device Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 08/15] spi: core, atmel: " Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 08/15] spi: core,atmel: " Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 09/15] spi: introduce `delay` field for `spi_transfer` + spi_transfer_exec() Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 10/15] spi: use new `spi_transfer_delay` helper where straightforward Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 11/15] spi: tegra114: use `spi_transfer_delay` helper Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 12/15] spi: spi-loopback-test: use new `delay` field Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 13/15] spi: spidev: use new `delay` field for spi transfers Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 14/15] spi: tegra114: change format for `spi_set_cs_timing()` function Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` [RFC PATCH 15/15] spi: implement SW control for CS times Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-13 11:45 ` Alexandru Ardelean
2019-09-15 10:22 ` [RFC PATCH 00/15] Unify SPI delays into an `struct spi_delay` Jonathan Cameron
2019-09-15 10:22 ` Jonathan Cameron
2019-09-15 10:22 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae469c65828443524f9ff0409f1c7a81bf64cf6b.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=baolin.wang@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jic23@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.