From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>, <lenb@kernel.org>
Cc: <linux-pci@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-acpi@vger.kernel.org>, <devicetree@vger.kernel.org>,
<iommu@lists.linux-foundation.org>, <joro@8bytes.org>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<lorenzo.pieralisi@arm.com>, <guohanjun@huawei.com>,
<sudeep.holla@arm.com>, <rjw@rjwysocki.net>, <will@kernel.org>,
<robin.murphy@arm.com>, <bhelgaas@google.com>,
<eric.auger@redhat.com>, <zhangfei.gao@linaro.org>
Subject: Re: [PATCH v3 00/13] iommu: Add PASID support to Arm SMMUv3
Date: Fri, 13 Dec 2019 17:10:06 +0000 [thread overview]
Message-ID: <20191213171006.00003e99@Huawei.com> (raw)
In-Reply-To: <20191209180514.272727-1-jean-philippe@linaro.org>
On Mon, 9 Dec 2019 19:05:01 +0100
Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:
> Add support for Substream ID and PASIDs to the SMMUv3 driver.
> Changes since v2 [1]:
>
> * Split preparatory work into patches 5, 6, 8 and 9.
>
> * Added patch 1. Not strictly relevant, but since we're moving the DMA
> allocations and adding a new one, we might as well clean the flags
> first.
>
> * Fixed a double free reported by Jonathan, and other small
> issues.
>
> * Added patch 12. Upstream commit c6e9aefbf9db ("PCI/ATS: Remove unused
> PRI and PASID stubs") removed the unused PASID stubs. Since the SMMU
> driver can be built without PCI, the stubs are now needed.
>
> [1] https://lore.kernel.org/linux-iommu/20191108152508.4039168-1-jean-philippe@linaro.org/
Hi Jean-Philippe,
Series looks great to me. FWIW
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
for the patches I didn't comment on in this version as I couldn't find anything
to comment about ;)
Thanks
Jonathan
>
> Jean-Philippe Brucker (13):
> iommu/arm-smmu-v3: Drop __GFP_ZERO flag from DMA allocation
> dt-bindings: document PASID property for IOMMU masters
> iommu/arm-smmu-v3: Support platform SSID
> ACPI/IORT: Support PASID for platform devices
> iommu/arm-smmu-v3: Prepare arm_smmu_s1_cfg for SSID support
> iommu/arm-smmu-v3: Add context descriptor tables allocators
> iommu/arm-smmu-v3: Add support for Substream IDs
> iommu/arm-smmu-v3: Propate ssid_bits
> iommu/arm-smmu-v3: Handle failure of arm_smmu_write_ctx_desc()
> iommu/arm-smmu-v3: Add second level of context descriptor table
> iommu/arm-smmu-v3: Improve add_device() error handling
> PCI/ATS: Add PASID stubs
> iommu/arm-smmu-v3: Add support for PCI PASID
>
> .../devicetree/bindings/iommu/iommu.txt | 6 +
> drivers/acpi/arm64/iort.c | 18 +
> drivers/iommu/arm-smmu-v3.c | 462 +++++++++++++++---
> drivers/iommu/of_iommu.c | 6 +-
> include/linux/iommu.h | 2 +
> include/linux/pci-ats.h | 3 +
> 6 files changed, 437 insertions(+), 60 deletions(-)
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>, <lenb@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, sudeep.holla@arm.com,
rjw@rjwysocki.net, robin.murphy@arm.com,
linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org,
robh+dt@kernel.org, guohanjun@huawei.com, bhelgaas@google.com,
zhangfei.gao@linaro.org, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 00/13] iommu: Add PASID support to Arm SMMUv3
Date: Fri, 13 Dec 2019 17:10:06 +0000 [thread overview]
Message-ID: <20191213171006.00003e99@Huawei.com> (raw)
In-Reply-To: <20191209180514.272727-1-jean-philippe@linaro.org>
On Mon, 9 Dec 2019 19:05:01 +0100
Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:
> Add support for Substream ID and PASIDs to the SMMUv3 driver.
> Changes since v2 [1]:
>
> * Split preparatory work into patches 5, 6, 8 and 9.
>
> * Added patch 1. Not strictly relevant, but since we're moving the DMA
> allocations and adding a new one, we might as well clean the flags
> first.
>
> * Fixed a double free reported by Jonathan, and other small
> issues.
>
> * Added patch 12. Upstream commit c6e9aefbf9db ("PCI/ATS: Remove unused
> PRI and PASID stubs") removed the unused PASID stubs. Since the SMMU
> driver can be built without PCI, the stubs are now needed.
>
> [1] https://lore.kernel.org/linux-iommu/20191108152508.4039168-1-jean-philippe@linaro.org/
Hi Jean-Philippe,
Series looks great to me. FWIW
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
for the patches I didn't comment on in this version as I couldn't find anything
to comment about ;)
Thanks
Jonathan
>
> Jean-Philippe Brucker (13):
> iommu/arm-smmu-v3: Drop __GFP_ZERO flag from DMA allocation
> dt-bindings: document PASID property for IOMMU masters
> iommu/arm-smmu-v3: Support platform SSID
> ACPI/IORT: Support PASID for platform devices
> iommu/arm-smmu-v3: Prepare arm_smmu_s1_cfg for SSID support
> iommu/arm-smmu-v3: Add context descriptor tables allocators
> iommu/arm-smmu-v3: Add support for Substream IDs
> iommu/arm-smmu-v3: Propate ssid_bits
> iommu/arm-smmu-v3: Handle failure of arm_smmu_write_ctx_desc()
> iommu/arm-smmu-v3: Add second level of context descriptor table
> iommu/arm-smmu-v3: Improve add_device() error handling
> PCI/ATS: Add PASID stubs
> iommu/arm-smmu-v3: Add support for PCI PASID
>
> .../devicetree/bindings/iommu/iommu.txt | 6 +
> drivers/acpi/arm64/iort.c | 18 +
> drivers/iommu/arm-smmu-v3.c | 462 +++++++++++++++---
> drivers/iommu/of_iommu.c | 6 +-
> include/linux/iommu.h | 2 +
> include/linux/pci-ats.h | 3 +
> 6 files changed, 437 insertions(+), 60 deletions(-)
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>, <lenb@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
lorenzo.pieralisi@arm.com, eric.auger@redhat.com,
linux-pci@vger.kernel.org, joro@8bytes.org, sudeep.holla@arm.com,
rjw@rjwysocki.net, robin.murphy@arm.com,
linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org,
robh+dt@kernel.org, guohanjun@huawei.com, bhelgaas@google.com,
zhangfei.gao@linaro.org, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 00/13] iommu: Add PASID support to Arm SMMUv3
Date: Fri, 13 Dec 2019 17:10:06 +0000 [thread overview]
Message-ID: <20191213171006.00003e99@Huawei.com> (raw)
In-Reply-To: <20191209180514.272727-1-jean-philippe@linaro.org>
On Mon, 9 Dec 2019 19:05:01 +0100
Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:
> Add support for Substream ID and PASIDs to the SMMUv3 driver.
> Changes since v2 [1]:
>
> * Split preparatory work into patches 5, 6, 8 and 9.
>
> * Added patch 1. Not strictly relevant, but since we're moving the DMA
> allocations and adding a new one, we might as well clean the flags
> first.
>
> * Fixed a double free reported by Jonathan, and other small
> issues.
>
> * Added patch 12. Upstream commit c6e9aefbf9db ("PCI/ATS: Remove unused
> PRI and PASID stubs") removed the unused PASID stubs. Since the SMMU
> driver can be built without PCI, the stubs are now needed.
>
> [1] https://lore.kernel.org/linux-iommu/20191108152508.4039168-1-jean-philippe@linaro.org/
Hi Jean-Philippe,
Series looks great to me. FWIW
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
for the patches I didn't comment on in this version as I couldn't find anything
to comment about ;)
Thanks
Jonathan
>
> Jean-Philippe Brucker (13):
> iommu/arm-smmu-v3: Drop __GFP_ZERO flag from DMA allocation
> dt-bindings: document PASID property for IOMMU masters
> iommu/arm-smmu-v3: Support platform SSID
> ACPI/IORT: Support PASID for platform devices
> iommu/arm-smmu-v3: Prepare arm_smmu_s1_cfg for SSID support
> iommu/arm-smmu-v3: Add context descriptor tables allocators
> iommu/arm-smmu-v3: Add support for Substream IDs
> iommu/arm-smmu-v3: Propate ssid_bits
> iommu/arm-smmu-v3: Handle failure of arm_smmu_write_ctx_desc()
> iommu/arm-smmu-v3: Add second level of context descriptor table
> iommu/arm-smmu-v3: Improve add_device() error handling
> PCI/ATS: Add PASID stubs
> iommu/arm-smmu-v3: Add support for PCI PASID
>
> .../devicetree/bindings/iommu/iommu.txt | 6 +
> drivers/acpi/arm64/iort.c | 18 +
> drivers/iommu/arm-smmu-v3.c | 462 +++++++++++++++---
> drivers/iommu/of_iommu.c | 6 +-
> include/linux/iommu.h | 2 +
> include/linux/pci-ats.h | 3 +
> 6 files changed, 437 insertions(+), 60 deletions(-)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-13 20:39 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 18:05 [PATCH v3 00/13] iommu: Add PASID support to Arm SMMUv3 Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` [PATCH v3 01/13] iommu/arm-smmu-v3: Drop __GFP_ZERO flag from DMA allocation Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-13 16:45 ` Jonathan Cameron
2019-12-13 16:45 ` Jonathan Cameron
2019-12-13 16:45 ` Jonathan Cameron
2019-12-17 10:59 ` Auger Eric
2019-12-17 10:59 ` Auger Eric
2019-12-17 10:59 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 02/13] dt-bindings: document PASID property for IOMMU masters Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` [PATCH v3 03/13] iommu/arm-smmu-v3: Support platform SSID Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 11:05 ` Auger Eric
2019-12-17 11:05 ` Auger Eric
2019-12-17 11:05 ` Auger Eric
2019-12-17 15:21 ` Jean-Philippe Brucker
2019-12-17 15:21 ` Jean-Philippe Brucker
2019-12-17 15:21 ` Jean-Philippe Brucker
2019-12-17 16:46 ` Auger Eric
2019-12-17 16:46 ` Auger Eric
2019-12-17 16:46 ` Auger Eric
2019-12-18 10:17 ` Auger Eric
2019-12-18 10:17 ` Auger Eric
2019-12-18 10:17 ` Auger Eric
2019-12-18 16:06 ` Jean-Philippe Brucker
2019-12-18 16:06 ` Jean-Philippe Brucker
2019-12-18 16:06 ` Jean-Philippe Brucker
2019-12-09 18:05 ` [PATCH v3 04/13] ACPI/IORT: Support PASID for platform devices Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 13:27 ` Auger Eric
2019-12-17 13:27 ` Auger Eric
2019-12-17 13:27 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 05/13] iommu/arm-smmu-v3: Prepare arm_smmu_s1_cfg for SSID support Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 13:27 ` Auger Eric
2019-12-17 13:27 ` Auger Eric
2019-12-17 13:27 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 06/13] iommu/arm-smmu-v3: Add context descriptor tables allocators Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 13:36 ` Auger Eric
2019-12-17 13:36 ` Auger Eric
2019-12-17 13:36 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 07/13] iommu/arm-smmu-v3: Add support for Substream IDs Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 16:43 ` Auger Eric
2019-12-17 16:43 ` Auger Eric
2019-12-17 16:43 ` Auger Eric
2019-12-18 16:07 ` Jean-Philippe Brucker
2019-12-18 16:07 ` Jean-Philippe Brucker
2019-12-18 16:07 ` Jean-Philippe Brucker
2019-12-18 16:59 ` Auger Eric
2019-12-18 16:59 ` Auger Eric
2019-12-18 16:59 ` Auger Eric
2019-12-18 17:03 ` Auger Eric
2019-12-18 17:03 ` Auger Eric
2019-12-18 17:03 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 08/13] iommu/arm-smmu-v3: Propate ssid_bits Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 17:07 ` Auger Eric
2019-12-17 17:07 ` Auger Eric
2019-12-17 17:07 ` Auger Eric
2019-12-18 16:08 ` Jean-Philippe Brucker
2019-12-18 16:08 ` Jean-Philippe Brucker
2019-12-18 16:08 ` Jean-Philippe Brucker
2019-12-18 17:00 ` Auger Eric
2019-12-18 17:00 ` Auger Eric
2019-12-18 17:00 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 09/13] iommu/arm-smmu-v3: Handle failure of arm_smmu_write_ctx_desc() Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 17:24 ` Auger Eric
2019-12-17 17:24 ` Auger Eric
2019-12-17 17:24 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 10/13] iommu/arm-smmu-v3: Add second level of context descriptor table Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-13 17:07 ` Jonathan Cameron
2019-12-13 17:07 ` Jonathan Cameron
2019-12-13 17:07 ` Jonathan Cameron
2019-12-18 9:59 ` Auger Eric
2019-12-18 9:59 ` Auger Eric
2019-12-18 9:59 ` Auger Eric
2019-12-18 16:10 ` Jean-Philippe Brucker
2019-12-18 16:10 ` Jean-Philippe Brucker
2019-12-18 16:10 ` Jean-Philippe Brucker
2019-12-09 18:05 ` [PATCH v3 11/13] iommu/arm-smmu-v3: Improve add_device() error handling Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` [PATCH v3 12/13] PCI/ATS: Add PASID stubs Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-10 21:07 ` Bjorn Helgaas
2019-12-10 21:07 ` Bjorn Helgaas
2019-12-10 21:07 ` Bjorn Helgaas
2019-12-18 10:02 ` Auger Eric
2019-12-18 10:02 ` Auger Eric
2019-12-18 10:02 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 13/13] iommu/arm-smmu-v3: Add support for PCI PASID Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-18 10:17 ` Auger Eric
2019-12-18 10:17 ` Auger Eric
2019-12-18 10:17 ` Auger Eric
2019-12-18 16:13 ` Jean-Philippe Brucker
2019-12-18 16:13 ` Jean-Philippe Brucker
2019-12-18 16:13 ` Jean-Philippe Brucker
2019-12-10 5:52 ` [PATCH v3 00/13] iommu: Add PASID support to Arm SMMUv3 zhangfei.gao
2019-12-10 5:52 ` zhangfei.gao
2019-12-13 17:10 ` Jonathan Cameron [this message]
2019-12-13 17:10 ` Jonathan Cameron
2019-12-13 17:10 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213171006.00003e99@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=eric.auger@redhat.com \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.