From: Auger Eric <eric.auger@redhat.com>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org,
joro@8bytes.org, sudeep.holla@arm.com, rjw@rjwysocki.net,
robin.murphy@arm.com, linux-acpi@vger.kernel.org,
iommu@lists.linux-foundation.org, robh+dt@kernel.org,
jonathan.cameron@huawei.com, guohanjun@huawei.com,
bhelgaas@google.com, zhangfei.gao@linaro.org, will@kernel.org,
linux-arm-kernel@lists.infradead.org, lenb@kernel.org
Subject: Re: [PATCH v3 03/13] iommu/arm-smmu-v3: Support platform SSID
Date: Tue, 17 Dec 2019 17:46:13 +0100 [thread overview]
Message-ID: <d3ef7adf-4e9e-6b7f-c4eb-52a8f1eaa16c@redhat.com> (raw)
In-Reply-To: <20191217152108.GB2305883@myrica>
Hi Jean,
On 12/17/19 4:21 PM, Jean-Philippe Brucker wrote:
> Hi Eric,
>
> On Tue, Dec 17, 2019 at 12:05:18PM +0100, Auger Eric wrote:
>>> + fwspec = dev_iommu_fwspec_get(dev);
>>> + if (!err && fwspec)
>>> + of_property_read_u32(master_np, "pasid-num-bits",
>>> + &fwspec->num_pasid_bits);
>>> + }
>> This patch dedicates to platform devices however I fail to understand,
>> at that stage, how/when do you retrieve/store the same max capability
>> for PCI devices?
>
> For PCI devices, the max capability is only described by the PCIe PASID
> capability, not by firmware. Patch 13 deals with PCI by setting
> masted->ssid_bits from the PASID capability directly, ignoring
> fwspec->num_pasid_bits.
Get it now. thank you for the explanation.
Eric
>
>> Besides,
>>
>> Reviewed-by: Eric Auger <eric.auger@redhat.com>
>
> Thanks!
> Jean
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
WARNING: multiple messages have this Message-ID (diff)
From: Auger Eric <eric.auger@redhat.com>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
guohanjun@huawei.com, will@kernel.org, linux-pci@vger.kernel.org,
rjw@rjwysocki.net, linux-acpi@vger.kernel.org,
iommu@lists.linux-foundation.org, robh+dt@kernel.org,
sudeep.holla@arm.com, bhelgaas@google.com,
zhangfei.gao@linaro.org, robin.murphy@arm.com,
linux-arm-kernel@lists.infradead.org, lenb@kernel.org
Subject: Re: [PATCH v3 03/13] iommu/arm-smmu-v3: Support platform SSID
Date: Tue, 17 Dec 2019 17:46:13 +0100 [thread overview]
Message-ID: <d3ef7adf-4e9e-6b7f-c4eb-52a8f1eaa16c@redhat.com> (raw)
In-Reply-To: <20191217152108.GB2305883@myrica>
Hi Jean,
On 12/17/19 4:21 PM, Jean-Philippe Brucker wrote:
> Hi Eric,
>
> On Tue, Dec 17, 2019 at 12:05:18PM +0100, Auger Eric wrote:
>>> + fwspec = dev_iommu_fwspec_get(dev);
>>> + if (!err && fwspec)
>>> + of_property_read_u32(master_np, "pasid-num-bits",
>>> + &fwspec->num_pasid_bits);
>>> + }
>> This patch dedicates to platform devices however I fail to understand,
>> at that stage, how/when do you retrieve/store the same max capability
>> for PCI devices?
>
> For PCI devices, the max capability is only described by the PCIe PASID
> capability, not by firmware. Patch 13 deals with PCI by setting
> masted->ssid_bits from the PASID capability directly, ignoring
> fwspec->num_pasid_bits.
Get it now. thank you for the explanation.
Eric
>
>> Besides,
>>
>> Reviewed-by: Eric Auger <eric.auger@redhat.com>
>
> Thanks!
> Jean
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Auger Eric <eric.auger@redhat.com>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
guohanjun@huawei.com, lorenzo.pieralisi@arm.com, will@kernel.org,
linux-pci@vger.kernel.org, joro@8bytes.org,
jonathan.cameron@huawei.com, rjw@rjwysocki.net,
linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org,
robh+dt@kernel.org, sudeep.holla@arm.com, bhelgaas@google.com,
zhangfei.gao@linaro.org, robin.murphy@arm.com,
linux-arm-kernel@lists.infradead.org, lenb@kernel.org
Subject: Re: [PATCH v3 03/13] iommu/arm-smmu-v3: Support platform SSID
Date: Tue, 17 Dec 2019 17:46:13 +0100 [thread overview]
Message-ID: <d3ef7adf-4e9e-6b7f-c4eb-52a8f1eaa16c@redhat.com> (raw)
In-Reply-To: <20191217152108.GB2305883@myrica>
Hi Jean,
On 12/17/19 4:21 PM, Jean-Philippe Brucker wrote:
> Hi Eric,
>
> On Tue, Dec 17, 2019 at 12:05:18PM +0100, Auger Eric wrote:
>>> + fwspec = dev_iommu_fwspec_get(dev);
>>> + if (!err && fwspec)
>>> + of_property_read_u32(master_np, "pasid-num-bits",
>>> + &fwspec->num_pasid_bits);
>>> + }
>> This patch dedicates to platform devices however I fail to understand,
>> at that stage, how/when do you retrieve/store the same max capability
>> for PCI devices?
>
> For PCI devices, the max capability is only described by the PCIe PASID
> capability, not by firmware. Patch 13 deals with PCI by setting
> masted->ssid_bits from the PASID capability directly, ignoring
> fwspec->num_pasid_bits.
Get it now. thank you for the explanation.
Eric
>
>> Besides,
>>
>> Reviewed-by: Eric Auger <eric.auger@redhat.com>
>
> Thanks!
> Jean
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-17 16:46 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 18:05 [PATCH v3 00/13] iommu: Add PASID support to Arm SMMUv3 Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` [PATCH v3 01/13] iommu/arm-smmu-v3: Drop __GFP_ZERO flag from DMA allocation Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-13 16:45 ` Jonathan Cameron
2019-12-13 16:45 ` Jonathan Cameron
2019-12-13 16:45 ` Jonathan Cameron
2019-12-17 10:59 ` Auger Eric
2019-12-17 10:59 ` Auger Eric
2019-12-17 10:59 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 02/13] dt-bindings: document PASID property for IOMMU masters Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` [PATCH v3 03/13] iommu/arm-smmu-v3: Support platform SSID Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 11:05 ` Auger Eric
2019-12-17 11:05 ` Auger Eric
2019-12-17 11:05 ` Auger Eric
2019-12-17 15:21 ` Jean-Philippe Brucker
2019-12-17 15:21 ` Jean-Philippe Brucker
2019-12-17 15:21 ` Jean-Philippe Brucker
2019-12-17 16:46 ` Auger Eric [this message]
2019-12-17 16:46 ` Auger Eric
2019-12-17 16:46 ` Auger Eric
2019-12-18 10:17 ` Auger Eric
2019-12-18 10:17 ` Auger Eric
2019-12-18 10:17 ` Auger Eric
2019-12-18 16:06 ` Jean-Philippe Brucker
2019-12-18 16:06 ` Jean-Philippe Brucker
2019-12-18 16:06 ` Jean-Philippe Brucker
2019-12-09 18:05 ` [PATCH v3 04/13] ACPI/IORT: Support PASID for platform devices Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 13:27 ` Auger Eric
2019-12-17 13:27 ` Auger Eric
2019-12-17 13:27 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 05/13] iommu/arm-smmu-v3: Prepare arm_smmu_s1_cfg for SSID support Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 13:27 ` Auger Eric
2019-12-17 13:27 ` Auger Eric
2019-12-17 13:27 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 06/13] iommu/arm-smmu-v3: Add context descriptor tables allocators Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 13:36 ` Auger Eric
2019-12-17 13:36 ` Auger Eric
2019-12-17 13:36 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 07/13] iommu/arm-smmu-v3: Add support for Substream IDs Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 16:43 ` Auger Eric
2019-12-17 16:43 ` Auger Eric
2019-12-17 16:43 ` Auger Eric
2019-12-18 16:07 ` Jean-Philippe Brucker
2019-12-18 16:07 ` Jean-Philippe Brucker
2019-12-18 16:07 ` Jean-Philippe Brucker
2019-12-18 16:59 ` Auger Eric
2019-12-18 16:59 ` Auger Eric
2019-12-18 16:59 ` Auger Eric
2019-12-18 17:03 ` Auger Eric
2019-12-18 17:03 ` Auger Eric
2019-12-18 17:03 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 08/13] iommu/arm-smmu-v3: Propate ssid_bits Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 17:07 ` Auger Eric
2019-12-17 17:07 ` Auger Eric
2019-12-17 17:07 ` Auger Eric
2019-12-18 16:08 ` Jean-Philippe Brucker
2019-12-18 16:08 ` Jean-Philippe Brucker
2019-12-18 16:08 ` Jean-Philippe Brucker
2019-12-18 17:00 ` Auger Eric
2019-12-18 17:00 ` Auger Eric
2019-12-18 17:00 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 09/13] iommu/arm-smmu-v3: Handle failure of arm_smmu_write_ctx_desc() Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-17 17:24 ` Auger Eric
2019-12-17 17:24 ` Auger Eric
2019-12-17 17:24 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 10/13] iommu/arm-smmu-v3: Add second level of context descriptor table Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-13 17:07 ` Jonathan Cameron
2019-12-13 17:07 ` Jonathan Cameron
2019-12-13 17:07 ` Jonathan Cameron
2019-12-18 9:59 ` Auger Eric
2019-12-18 9:59 ` Auger Eric
2019-12-18 9:59 ` Auger Eric
2019-12-18 16:10 ` Jean-Philippe Brucker
2019-12-18 16:10 ` Jean-Philippe Brucker
2019-12-18 16:10 ` Jean-Philippe Brucker
2019-12-09 18:05 ` [PATCH v3 11/13] iommu/arm-smmu-v3: Improve add_device() error handling Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` [PATCH v3 12/13] PCI/ATS: Add PASID stubs Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-10 21:07 ` Bjorn Helgaas
2019-12-10 21:07 ` Bjorn Helgaas
2019-12-10 21:07 ` Bjorn Helgaas
2019-12-18 10:02 ` Auger Eric
2019-12-18 10:02 ` Auger Eric
2019-12-18 10:02 ` Auger Eric
2019-12-09 18:05 ` [PATCH v3 13/13] iommu/arm-smmu-v3: Add support for PCI PASID Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-09 18:05 ` Jean-Philippe Brucker
2019-12-18 10:17 ` Auger Eric
2019-12-18 10:17 ` Auger Eric
2019-12-18 10:17 ` Auger Eric
2019-12-18 16:13 ` Jean-Philippe Brucker
2019-12-18 16:13 ` Jean-Philippe Brucker
2019-12-18 16:13 ` Jean-Philippe Brucker
2019-12-10 5:52 ` [PATCH v3 00/13] iommu: Add PASID support to Arm SMMUv3 zhangfei.gao
2019-12-10 5:52 ` zhangfei.gao
2019-12-13 17:10 ` Jonathan Cameron
2019-12-13 17:10 ` Jonathan Cameron
2019-12-13 17:10 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3ef7adf-4e9e-6b7f-c4eb-52a8f1eaa16c@redhat.com \
--to=eric.auger@redhat.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=jonathan.cameron@huawei.com \
--cc=joro@8bytes.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.